René's URL Explorer Experiment


Title: Fix for relating covered discriminants in unions by rbuckton · Pull Request #39393 · microsoft/TypeScript · GitHub

Open Graph Title: Fix for relating covered discriminants in unions by rbuckton · Pull Request #39393 · microsoft/TypeScript

X Title: Fix for relating covered discriminants in unions by rbuckton · Pull Request #39393 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Fix for relating covered discriminants in unions by rbuckton · Pull Request #39393 · microsoft/TypeScript

Open Graph Description: In #30779 we added the ability to relate a source type to a target when the target is a discriminated union and the source is covered by the target. This did not work when the target was a union of...

X Description: In #30779 we added the ability to relate a source type to a target when the target is a discriminated union and the source is covered by the target. This did not work when the target was a union of...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/39393

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2a57b09e-674e-dad9-1665-148e2c7797a2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id999C:26CE3B:1012D1B:163CDA4:6AFBFBB0
html-safe-nonce9f6f0a7691a2c63a289183d401b68d05699a4d0238ac69bb11931e571b0f66d4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OTlDOjI2Q0UzQjoxMDEyRDFCOjE2M0NEQTQ6NkFGQkZCQjAiLCJ2aXNpdG9yX2lkIjoiODgxMzM0ODkzMDI2MjEyNzg0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace801e2ea174e4ec4b266445a0950180038a24cc2c2cd523b498d0a5667a9ebbc
hovercard-subject-tagpull_request:443679820
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/39393/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/be7fae24fcd69837beb65b6268472ac074cff68717d5ac59dad4e0478884b95c/microsoft/TypeScript/pull/39393
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/be7fae24fcd69837beb65b6268472ac074cff68717d5ac59dad4e0478884b95c/microsoft/TypeScript/pull/39393
og:image:altIn #30779 we added the ability to relate a source type to a target when the target is a discriminated union and the source is covered by the target. This did not work when the target was a union of...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerbuckton
hostnamegithub.com
expected-hostnamegithub.com
Nonefa74413a1d84dac536fcca0740780bcbd3207bafec0e51873b73ff8e8cca032f
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb3b5633a74535d9c23385512d534c66c8fde1907
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/39393#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F39393
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F39393
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/39393
Reloadhttps://github.com/microsoft/TypeScript/pull/39393
Reloadhttps://github.com/microsoft/TypeScript/pull/39393
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests335 (335)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/pulse
https://github.com/microsoft/TypeScript
Ron Buckton (rbuckton)https://github.com/rbuckton
masterhttps://github.com/microsoft/TypeScript/tree/master
fix39357https://github.com/microsoft/TypeScript/tree/fix39357
Conversationhttps://github.com/microsoft/TypeScript/pull/39393
Commits1 (1)https://github.com/microsoft/TypeScript/pull/39393/commits
Checkshttps://github.com/microsoft/TypeScript/pull/39393/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/39393/files
Fix for relating covered discriminants in unionshttps://github.com/microsoft/TypeScript/pull/39393#top
Ron Buckton (rbuckton)https://github.com/rbuckton
masterhttps://github.com/microsoft/TypeScript/tree/master
fix39357https://github.com/microsoft/TypeScript/tree/fix39357
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Jul 2, 2020https://github.com/microsoft/TypeScript/pull/39393#issue-650128331
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39393
#30779https://github.com/microsoft/TypeScript/pull/30779
#39357https://github.com/microsoft/TypeScript/issues/39357
#34967https://github.com/microsoft/TypeScript/issues/34967
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39393
https://github.com/rbuckton
Fix for relating covered discriminants in unionshttps://github.com/microsoft/TypeScript/pull/39393/commits/8eba362a01b4626b4d657166e268b24d1ee4115f
8eba362https://github.com/microsoft/TypeScript/pull/39393/commits/8eba362a01b4626b4d657166e268b24d1ee4115f
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Wesley Wigham (weswigham)https://github.com/weswigham
July 2, 2020 18:30https://github.com/microsoft/TypeScript/pull/39393#event-3508297302
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Ron Buckton (rbuckton)https://github.com/rbuckton
Jul 2, 2020https://github.com/microsoft/TypeScript/pull/39393#event-3508297816
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
Jul 2, 2020https://github.com/microsoft/TypeScript/pull/39393#event-3508297851
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Jul 2, 2020https://github.com/microsoft/TypeScript/pull/39393#issuecomment-653162651
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39393
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jul 2, 2020https://github.com/microsoft/TypeScript/pull/39393#issuecomment-653162670
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39393
Ron Buckton (@rbuckton)https://github.com/rbuckton
8eba362https://github.com/microsoft/TypeScript/commit/8eba362a01b4626b4d657166e268b24d1ee4115f
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=78526
The results are in!https://github.com/microsoft/TypeScript/pull/39393#issuecomment-653177842
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39393
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jul 2, 2020https://github.com/microsoft/TypeScript/pull/39393#issuecomment-653162671
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39393
Ron Buckton (@rbuckton)https://github.com/rbuckton
8eba362https://github.com/microsoft/TypeScript/commit/8eba362a01b4626b4d657166e268b24d1ee4115f
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=78525
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39393
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jul 2, 2020https://github.com/microsoft/TypeScript/pull/39393#issuecomment-653162672
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39393
Ron Buckton (@rbuckton)https://github.com/rbuckton
8eba362https://github.com/microsoft/TypeScript/commit/8eba362a01b4626b4d657166e268b24d1ee4115f
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=78528
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39393
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jul 2, 2020https://github.com/microsoft/TypeScript/pull/39393#issuecomment-653162673
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39393
Ron Buckton (@rbuckton)https://github.com/rbuckton
8eba362https://github.com/microsoft/TypeScript/commit/8eba362a01b4626b4d657166e268b24d1ee4115f
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=78527
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39393
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jul 2, 2020 https://github.com/microsoft/TypeScript/pull/39393#ref-pullrequest-650147432
🤖 User test baselines have changed for fix39357 typescript-bot/TypeScript#55 https://github.com/typescript-bot/TypeScript/pull/55
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jul 2, 2020https://github.com/microsoft/TypeScript/pull/39393#issuecomment-653175491
PR with the baseline diff from masterhttps://github.com/typescript-bot/TypeScript/pull/55
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39393
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jul 2, 2020https://github.com/microsoft/TypeScript/pull/39393#issuecomment-653177842
Ron Buckton (@rbuckton)https://github.com/rbuckton
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39393
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Jul 3, 2020 https://github.com/microsoft/TypeScript/pull/39393#pullrequestreview-442125468
View reviewed changes https://github.com/microsoft/TypeScript/pull/39393/files/8eba362a01b4626b4d657166e268b24d1ee4115f
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Jul 7, 2020https://github.com/microsoft/TypeScript/pull/39393#issuecomment-655047591
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39393
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Jul 7, 2020https://github.com/microsoft/TypeScript/pull/39393#issuecomment-655102306
'eventsource' DOM augmentations are incompatible with TypeScript 4.0 DefinitelyTyped/DefinitelyTyped#45935https://github.com/DefinitelyTyped/DefinitelyTyped/issues/45935
'testing-library__vue' tests are failing for 'getByRole' DefinitelyTyped/DefinitelyTyped#45937https://github.com/DefinitelyTyped/DefinitelyTyped/issues/45937
'knockout' tests are failing due to overload resolution with 'null' on 'ko.observable' DefinitelyTyped/DefinitelyTyped#45938https://github.com/DefinitelyTyped/DefinitelyTyped/issues/45938
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39393
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
b100680https://github.com/microsoft/TypeScript/commit/b100680a3eebf85dfdf2de04f1d096e454866dd0
Jul 7, 2020https://github.com/microsoft/TypeScript/pull/39393#event-3522106263
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
July 7, 2020 20:12https://github.com/microsoft/TypeScript/pull/39393#event-3522106634
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Dec 16, 2020 https://github.com/microsoft/TypeScript/pull/39393#ref-issue-519092266
Not assignable Type #34967 https://github.com/microsoft/TypeScript/issues/34967
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/39393#event-20416991784
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F39393
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
https://github.com/microsoft/TypeScript/pull/39393/files/8eba362a01b4626b4d657166e268b24d1ee4115f
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg) https://github.com/ahejlsberg
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39393
https://github.com/rbuckton
Ron Buckton (rbuckton) https://github.com/rbuckton
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
Equivalence between tuple containing union type and union type of tuples https://github.com/microsoft/TypeScript/issues/39357
Not assignable Type https://github.com/microsoft/TypeScript/issues/34967
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/39393
https://github.com/rbuckton
https://github.com/typescript-bot
https://github.com/weswigham
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.