René's URL Explorer Experiment


Title: fix(25155): insertSpaceBeforeTypeAnnotation doesn't work with optional parameters / properties by a-tarasyuk · Pull Request #38798 · microsoft/TypeScript · GitHub

Open Graph Title: fix(25155): insertSpaceBeforeTypeAnnotation doesn't work with optional parameters / properties by a-tarasyuk · Pull Request #38798 · microsoft/TypeScript

X Title: fix(25155): insertSpaceBeforeTypeAnnotation doesn't work with optional parameters / properties by a-tarasyuk · Pull Request #38798 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - fix(25155): insertSpaceBeforeTypeAnnotation doesn't work with optional parameters / properties by a-tarasyuk · Pull Request #38798 · microsoft/TypeScript

Open Graph Description: Fixes #25155

X Description: Fixes #25155

Opengraph URL: https://github.com/microsoft/TypeScript/pull/38798

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5dfbb3a4-7be0-bc41-67d8-8424a71b229c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8A08:3F8AB1:F68DE9:13C2AEE:6B00FB95
html-safe-nonce18bd71dbc426e6d24280ffe149322de5da7c868f2cbf679ffb53baa6d12ad873
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTA4OjNGOEFCMTpGNjhERTk6MTNDMkFFRTo2QjAwRkI5NSIsInZpc2l0b3JfaWQiOiI3NjQ2NDU5Nzg4Mjg1MDM5NTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc51ebcf8daba0319ab51b715fabbe410d53b8fdd8595255edf38fa7bb3401bc0
hovercard-subject-tagpull_request:423615475
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/38798/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9f45ff1f9103097ce3cc89805bbf9c1760a18be3ba8eebddedd4682fa3977da1/microsoft/TypeScript/pull/38798
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9f45ff1f9103097ce3cc89805bbf9c1760a18be3ba8eebddedd4682fa3977da1/microsoft/TypeScript/pull/38798
og:image:altFixes #25155
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamea-tarasyuk
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/38798#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F38798
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F38798
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/38798
Reloadhttps://github.com/microsoft/TypeScript/pull/38798
Reloadhttps://github.com/microsoft/TypeScript/pull/38798
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Andrew Branch (andrewbranch)https://github.com/andrewbranch
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
a-tarasyuk:bug/25155https://github.com/a-tarasyuk/TypeScript/tree/bug/25155
Conversationhttps://github.com/microsoft/TypeScript/pull/38798
Commits1 (1)https://github.com/microsoft/TypeScript/pull/38798/commits
Checkshttps://github.com/microsoft/TypeScript/pull/38798/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/38798/files
fix(25155): insertSpaceBeforeTypeAnnotation doesn't work with optional parameters / propertieshttps://github.com/microsoft/TypeScript/pull/38798#top
Andrew Branch (andrewbranch)https://github.com/andrewbranch
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
a-tarasyuk:bug/25155https://github.com/a-tarasyuk/TypeScript/tree/bug/25155
https://github.com/a-tarasyuk
Oleksandr Tarasiuk (a-tarasyuk)https://github.com/a-tarasyuk
May 27, 2020https://github.com/microsoft/TypeScript/pull/38798#issue-625387789
#25155https://github.com/microsoft/TypeScript/issues/25155
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38798
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
May 29, 2020 https://github.com/microsoft/TypeScript/pull/38798#pullrequestreview-420576567
View reviewed changes https://github.com/microsoft/TypeScript/pull/38798/files
tests/cases/fourslash/formatTypeAnnotation1.tshttps://github.com/microsoft/TypeScript/pull/38798/files#diff-805562d6fd353cf878fab47e374b9085e7421055a59e4d95d6fec87921830e95
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38798
https://github.com/a-tarasyuk
Oleksandr Tarasiuk (a-tarasyuk)https://github.com/a-tarasyuk
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
May 29, 2020 06:16https://github.com/microsoft/TypeScript/pull/38798#event-3385780451
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Jun 2, 2020 https://github.com/microsoft/TypeScript/pull/38798#pullrequestreview-423102247
View reviewed changes https://github.com/microsoft/TypeScript/pull/38798/files
tests/cases/fourslash/formatTypeAnnotation2.tshttps://github.com/microsoft/TypeScript/pull/38798/files#diff-c0b3ae4e993ebb12b69b4a65aae811f6b21779da3778bb67978157b367c38266
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38798
tests/cases/fourslash/formatTypeAnnotation1.tshttps://github.com/microsoft/TypeScript/pull/38798/files#diff-805562d6fd353cf878fab47e374b9085e7421055a59e4d95d6fec87921830e95
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38798
https://github.com/a-tarasyuk
fix(25155): add space before optional parameters/propertieshttps://github.com/microsoft/TypeScript/pull/38798/commits/e9add2e2dd0dd5cacb79fe8f4d32343036cb69b5
e9add2ehttps://github.com/microsoft/TypeScript/pull/38798/commits/e9add2e2dd0dd5cacb79fe8f4d32343036cb69b5
https://github.com/a-tarasyuk
Oleksandr Tarasiuk (a-tarasyuk)https://github.com/a-tarasyuk
force-pushedhttps://github.com/microsoft/TypeScript/compare/34e4992f1007d2410d684be482866d8ad2f3f8b3..e9add2e2dd0dd5cacb79fe8f4d32343036cb69b5
34e4992https://github.com/microsoft/TypeScript/commit/34e4992f1007d2410d684be482866d8ad2f3f8b3
e9add2ehttps://github.com/microsoft/TypeScript/commit/e9add2e2dd0dd5cacb79fe8f4d32343036cb69b5
Compare https://github.com/microsoft/TypeScript/compare/34e4992f1007d2410d684be482866d8ad2f3f8b3..e9add2e2dd0dd5cacb79fe8f4d32343036cb69b5
June 3, 2020 08:37https://github.com/microsoft/TypeScript/pull/38798#event-3401067578
https://github.com/a-tarasyuk
Oleksandr Tarasiuk (a-tarasyuk)https://github.com/a-tarasyuk
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
June 3, 2020 08:49https://github.com/microsoft/TypeScript/pull/38798#event-3401117264
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Andrew Branch (andrewbranch)https://github.com/andrewbranch
June 29, 2020 21:07https://github.com/microsoft/TypeScript/pull/38798#event-3494563505
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Jul 8, 2020 https://github.com/microsoft/TypeScript/pull/38798#pullrequestreview-445105990
View reviewed changes https://github.com/microsoft/TypeScript/pull/38798/files/e9add2e2dd0dd5cacb79fe8f4d32343036cb69b5
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
48c19eehttps://github.com/microsoft/TypeScript/commit/48c19eebaf7422bd47ce6752b20f0b223667c723
Jul 8, 2020https://github.com/microsoft/TypeScript/pull/38798#event-3526937880
AllenLee (cangSDARM)https://github.com/cangSDARM
Jul 9, 2020 https://github.com/microsoft/TypeScript/pull/38798#ref-commit-84b6358
https://github.com/cangSDARM
Merge remote-tracking branch 'upstream/master'https://github.com/cangSDARM/TypeScript/commit/84b6358dc94c9f6acf65f478887e6f1ec0802397
84b6358https://github.com/cangSDARM/TypeScript/commit/84b6358dc94c9f6acf65f478887e6f1ec0802397
microsoft#39394https://github.com/microsoft/TypeScript/pull/39394
@Propertyhttps://github.com/Property
microsoft#39487https://github.com/microsoft/TypeScript/pull/39487
microsoft#38798https://github.com/microsoft/TypeScript/pull/38798
microsoft#38834https://github.com/microsoft/TypeScript/issues/38834
microsoft#39479https://github.com/microsoft/TypeScript/pull/39479
microsoft#39507https://github.com/microsoft/TypeScript/pull/39507
microsoft#39433https://github.com/microsoft/TypeScript/pull/39433
microsoft#39465https://github.com/microsoft/TypeScript/pull/39465
microsoft#39483https://github.com/microsoft/TypeScript/pull/39483
microsoft#39220https://github.com/microsoft/TypeScript/pull/39220
microsoft#39447https://github.com/microsoft/TypeScript/pull/39447
@typehttps://github.com/type
microsoft#39473https://github.com/microsoft/TypeScript/pull/39473
microsoft#38920https://github.com/microsoft/TypeScript/pull/38920
microsoft#39363https://github.com/microsoft/TypeScript/pull/39363
microsoft#39485https://github.com/microsoft/TypeScript/pull/39485
microsoft#39481https://github.com/microsoft/TypeScript/pull/39481
microsoft#39348https://github.com/microsoft/TypeScript/pull/39348
microsoft#39130https://github.com/microsoft/TypeScript/pull/39130
microsoft#39478https://github.com/microsoft/TypeScript/pull/39478
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/38798#event-20416971879
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F38798
https://github.com/andrewbranch
Andrew Branch (andrewbranch) https://github.com/andrewbranch
https://github.com/microsoft/TypeScript/pull/38798/files/e9add2e2dd0dd5cacb79fe8f4d32343036cb69b5
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) https://github.com/DanielRosenwasser
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38798
insertSpaceBeforeTypeAnnotation doesn't work with optional parameters / properties https://github.com/microsoft/TypeScript/issues/25155
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38798
https://github.com/a-tarasyuk
https://github.com/DanielRosenwasser
https://github.com/andrewbranch
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.