René's URL Explorer Experiment


Title: Ensure formatter can always get a newline character by andrewbranch · Pull Request #38579 · microsoft/TypeScript · GitHub

Open Graph Title: Ensure formatter can always get a newline character by andrewbranch · Pull Request #38579 · microsoft/TypeScript

X Title: Ensure formatter can always get a newline character by andrewbranch · Pull Request #38579 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Ensure formatter can always get a newline character by andrewbranch · Pull Request #38579 · microsoft/TypeScript

Open Graph Description: Fixes #38548 It looks like this was always a problem, but didn’t surface itself (at least not where anyone noticed) until we started preserving source newlines in refactors and codefixes. Also, I d...

X Description: Fixes #38548 It looks like this was always a problem, but didn’t surface itself (at least not where anyone noticed) until we started preserving source newlines in refactors and codefixes. Also, I d...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/38579

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:cae048af-7362-b6ab-1571-ea61bbd0090e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD072:38C5CF:D4437D:1112CD8:6B00F02B
html-safe-nonce3acacef4a54f95c7e1218496989778c68c4e8b6097af4988d86eceb2571fdd31
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDcyOjM4QzVDRjpENDQzN0Q6MTExMkNEODo2QjAwRjAyQiIsInZpc2l0b3JfaWQiOiI2OTY3NjkwNDY3ODgyMzY0OTcyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1a129908db213c13b499d1017bb412cbde070a215fb7bee1b7f97566278a126f
hovercard-subject-tagpull_request:418205832
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/38579/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6c9627d2d3a5ee15066c8d9d4d4d24407aef63d42868df046d41454035ee0f64/microsoft/TypeScript/pull/38579
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6c9627d2d3a5ee15066c8d9d4d4d24407aef63d42868df046d41454035ee0f64/microsoft/TypeScript/pull/38579
og:image:altFixes #38548 It looks like this was always a problem, but didn’t surface itself (at least not where anyone noticed) until we started preserving source newlines in refactors and codefixes. Also, I d...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameandrewbranch
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/38579#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F38579
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F38579
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/38579
Reloadhttps://github.com/microsoft/TypeScript/pull/38579
Reloadhttps://github.com/microsoft/TypeScript/pull/38579
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests308 (308)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Andrew Branch (andrewbranch)https://github.com/andrewbranch
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
andrewbranch:bug/38548https://github.com/andrewbranch/TypeScript/tree/bug/38548
Conversationhttps://github.com/microsoft/TypeScript/pull/38579
Commits3 (3)https://github.com/microsoft/TypeScript/pull/38579/commits
Checkshttps://github.com/microsoft/TypeScript/pull/38579/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/38579/files
Ensure formatter can always get a newline characterhttps://github.com/microsoft/TypeScript/pull/38579#top
Andrew Branch (andrewbranch)https://github.com/andrewbranch
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
andrewbranch:bug/38548https://github.com/andrewbranch/TypeScript/tree/bug/38548
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
May 14, 2020https://github.com/microsoft/TypeScript/pull/38579#issue-618486016
#38548https://github.com/microsoft/TypeScript/issues/38548
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38579
Andrew Branch (andrewbranch)https://github.com/andrewbranch
May 14, 2020 12:17https://github.com/microsoft/TypeScript/pull/38579#commits-pushed-0a696c9
https://github.com/andrewbranch
Ensure formatter can always get a newline characterhttps://github.com/microsoft/TypeScript/pull/38579/commits/0a696c902dc0f9534c2eb4ae723b46fe870cc2dc
0a696c9https://github.com/microsoft/TypeScript/pull/38579/commits/0a696c902dc0f9534c2eb4ae723b46fe870cc2dc
https://github.com/andrewbranch
Make FormatContext.host optional since it’s not necessary if format o…https://github.com/microsoft/TypeScript/pull/38579/commits/ab09d67b49cd0298fb5ea94ba21fb7af430cf4b6
ab09d67https://github.com/microsoft/TypeScript/pull/38579/commits/ab09d67b49cd0298fb5ea94ba21fb7af430cf4b6
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Andrew Branch (andrewbranch)https://github.com/andrewbranch
May 14, 2020https://github.com/microsoft/TypeScript/pull/38579#event-3338125474
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
May 14, 2020https://github.com/microsoft/TypeScript/pull/38579#event-3338125541
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Andrew Casey (amcasey)https://github.com/amcasey
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
May 14, 2020 19:36https://github.com/microsoft/TypeScript/pull/38579#event-3338125730
https://github.com/sheetalkamat
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
May 14, 2020 https://github.com/microsoft/TypeScript/pull/38579#pullrequestreview-412152912
View reviewed changes https://github.com/microsoft/TypeScript/pull/38579/files/ab09d67b49cd0298fb5ea94ba21fb7af430cf4b6
src/services/formatting/formatting.tshttps://github.com/microsoft/TypeScript/pull/38579/files/ab09d67b49cd0298fb5ea94ba21fb7af430cf4b6#diff-853328a69fa29e01eda0b7b5e4ef672c45640a0bacae48a031159ea916761834
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38579
https://github.com/andrewbranch
Make FormattingHost required againhttps://github.com/microsoft/TypeScript/pull/38579/commits/90923e2050172c922c8b6be57ab69786c2a77922
90923e2https://github.com/microsoft/TypeScript/pull/38579/commits/90923e2050172c922c8b6be57ab69786c2a77922
https://github.com/sheetalkamat
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
May 14, 2020 https://github.com/microsoft/TypeScript/pull/38579#pullrequestreview-412216983
View reviewed changes https://github.com/microsoft/TypeScript/pull/38579/files/90923e2050172c922c8b6be57ab69786c2a77922
https://github.com/amcasey
Andrew Casey (amcasey)https://github.com/amcasey
May 14, 2020 https://github.com/microsoft/TypeScript/pull/38579#pullrequestreview-412239580
View reviewed changes https://github.com/microsoft/TypeScript/pull/38579/files/90923e2050172c922c8b6be57ab69786c2a77922
Andrew Casey (amcasey)https://github.com/amcasey
https://github.com/microsoft/TypeScript/pull/38579#pullrequestreview-412239580
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38579
https://github.com/amcasey
Andrew Casey (amcasey)https://github.com/amcasey
May 14, 2020https://github.com/microsoft/TypeScript/pull/38579#issuecomment-628927261
Jesse Trinity (@jessetrinity)https://github.com/jessetrinity
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38579
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
707e977https://github.com/microsoft/TypeScript/commit/707e9770564865d10168e3722eec4eb9e20d32db
May 19, 2020https://github.com/microsoft/TypeScript/pull/38579#event-3353544189
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
May 19, 2020https://github.com/microsoft/TypeScript/pull/38579#issuecomment-631057418
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38579
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
May 19, 2020https://github.com/microsoft/TypeScript/pull/38579#issuecomment-631057741
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38579
Andrew Branch (@andrewbranch)https://github.com/andrewbranch
90923e2https://github.com/microsoft/TypeScript/commit/90923e2050172c922c8b6be57ab69786c2a77922
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=74289
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38579
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
May 19, 2020 https://github.com/microsoft/TypeScript/pull/38579#ref-pullrequest-621259101
🤖 Pick PR #38579 (Ensure formatter can always get a n...) into release-3.9 #38666 https://github.com/microsoft/TypeScript/pull/38666
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
May 19, 2020https://github.com/microsoft/TypeScript/pull/38579#issuecomment-631060186
Andrew Branch (@andrewbranch)https://github.com/andrewbranch
#38666https://github.com/microsoft/TypeScript/pull/38666
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38579
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
May 19, 2020 https://github.com/microsoft/TypeScript/pull/38579#ref-commit-dbe9092
https://github.com/andrewbranch
https://github.com/typescript-bot
Cherry-pick PRhttps://github.com/typescript-bot/TypeScript/commit/dbe90926a2f65e132e9fc77e9f1fd509d85d4dd3
microsoft#38579https://github.com/microsoft/TypeScript/pull/38579
into release-3.9https://github.com/typescript-bot/TypeScript/commit/dbe90926a2f65e132e9fc77e9f1fd509d85d4dd3
dbe9092https://github.com/typescript-bot/TypeScript/commit/dbe90926a2f65e132e9fc77e9f1fd509d85d4dd3
0a696c9https://github.com/typescript-bot/TypeScript/commit/0a696c902dc0f9534c2eb4ae723b46fe870cc2dc
ab09d67https://github.com/typescript-bot/TypeScript/commit/ab09d67b49cd0298fb5ea94ba21fb7af430cf4b6
90923e2https://github.com/typescript-bot/TypeScript/commit/90923e2050172c922c8b6be57ab69786c2a77922
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
May 19, 2020 20:20https://github.com/microsoft/TypeScript/pull/38579#event-3353565468
Andrew Branch (andrewbranch)https://github.com/andrewbranch
May 19, 2020 https://github.com/microsoft/TypeScript/pull/38579#ref-commit-5b29b14
https://github.com/andrewbranch
Cherry-pick PRhttps://github.com/microsoft/TypeScript/commit/5b29b141fa0dc12f16592803ccd926526a45f409
#38579https://github.com/microsoft/TypeScript/pull/38579
into release-3.9 (https://github.com/microsoft/TypeScript/commit/5b29b141fa0dc12f16592803ccd926526a45f409
#38666https://github.com/microsoft/TypeScript/pull/38666
)https://github.com/microsoft/TypeScript/commit/5b29b141fa0dc12f16592803ccd926526a45f409
5b29b14https://github.com/microsoft/TypeScript/commit/5b29b141fa0dc12f16592803ccd926526a45f409
0a696c9https://github.com/microsoft/TypeScript/commit/0a696c902dc0f9534c2eb4ae723b46fe870cc2dc
ab09d67https://github.com/microsoft/TypeScript/commit/ab09d67b49cd0298fb5ea94ba21fb7af430cf4b6
90923e2https://github.com/microsoft/TypeScript/commit/90923e2050172c922c8b6be57ab69786c2a77922
AllenLee (cangSDARM)https://github.com/cangSDARM
May 20, 2020 https://github.com/microsoft/TypeScript/pull/38579#ref-commit-60ee5e8
https://github.com/cangSDARM
Merge remote-tracking branch 'upstream/master'https://github.com/cangSDARM/TypeScript/commit/60ee5e825c566e0a8e4797d41eeed18f9a0550a5
60ee5e8https://github.com/cangSDARM/TypeScript/commit/60ee5e825c566e0a8e4797d41eeed18f9a0550a5
microsoft#38234https://github.com/microsoft/TypeScript/pull/38234
microsoft#37912https://github.com/microsoft/TypeScript/pull/37912
microsoft#38653https://github.com/microsoft/TypeScript/pull/38653
microsoft#38579https://github.com/microsoft/TypeScript/pull/38579
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/38579#event-20416963914
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F38579
https://github.com/sheetalkamat
Sheetal Nandi (sheetalkamat) https://github.com/sheetalkamat
https://github.com/microsoft/TypeScript/pull/38579/files/90923e2050172c922c8b6be57ab69786c2a77922
https://github.com/amcasey
Andrew Casey (amcasey) https://github.com/amcasey
https://github.com/microsoft/TypeScript/pull/38579/files/90923e2050172c922c8b6be57ab69786c2a77922
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38579
https://github.com/andrewbranch
Andrew Branch (andrewbranch) https://github.com/andrewbranch
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
PR Backlog https://github.com/orgs/microsoft/projects/1252
3.9 Regression: organizeImports prepends/appends "undefined" when there are 2+ named imports https://github.com/microsoft/TypeScript/issues/38548
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38579
https://github.com/andrewbranch
https://github.com/amcasey
https://github.com/typescript-bot
https://github.com/sheetalkamat
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.