René's URL Explorer Experiment


Title: Fix for jsdoc modifiers on constructor params by rbuckton · Pull Request #38403 · microsoft/TypeScript · GitHub

Open Graph Title: Fix for jsdoc modifiers on constructor params by rbuckton · Pull Request #38403 · microsoft/TypeScript

X Title: Fix for jsdoc modifiers on constructor params by rbuckton · Pull Request #38403 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Fix for jsdoc modifiers on constructor params by rbuckton · Pull Request #38403 · microsoft/TypeScript

Open Graph Description: When we added support for @public, @private, @protected, @readonly JSDoc-style modifiers, we inadvertently treated such modifiers on constructor properties as if they were TypeScript "paramete...

X Description: When we added support for @public, @private, @protected, @readonly JSDoc-style modifiers, we inadvertently treated such modifiers on constructor properties as if they were TypeScript "para...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/38403

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:cfc0347a-9b52-35f8-1a1c-f1c8deba0572
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA140:269AD9:658499:89C099:6B00D6DE
html-safe-noncef198432d03a2cc3ede56ff5a28e5d6f4331ddda53fca5aec3631c850b6c6c995
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTQwOjI2OUFEOTo2NTg0OTk6ODlDMDk5OjZCMDBENkRFIiwidmlzaXRvcl9pZCI6IjY5OTM0NjIyMzQ0NTg0MTI3NjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac77b09af7111513073b5939a4a0e55152b0c90b84785a41bad425006af7a8bc15
hovercard-subject-tagpull_request:414933136
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/38403/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5e0aeab5edd5d0278d35be022c28c68d713809d06d3448951d9a4e6827829016/microsoft/TypeScript/pull/38403
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5e0aeab5edd5d0278d35be022c28c68d713809d06d3448951d9a4e6827829016/microsoft/TypeScript/pull/38403
og:image:altWhen we added support for @public, @private, @protected, @readonly JSDoc-style modifiers, we inadvertently treated such modifiers on constructor properties as if they were TypeScript "paramete...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerbuckton
hostnamegithub.com
expected-hostnamegithub.com
Nonea481f62a1e04c9b9bdcb5628230682c66d59006f5b13b080f79cba84a176905b
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release84c8c5cc25e2fb7f2308428458538436baecc6d2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/38403#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F38403
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F38403
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/38403
Reloadhttps://github.com/microsoft/TypeScript/pull/38403
Reloadhttps://github.com/microsoft/TypeScript/pull/38403
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests307 (307)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Ron Buckton (rbuckton)https://github.com/rbuckton
masterhttps://github.com/microsoft/TypeScript/tree/master
fix38401https://github.com/microsoft/TypeScript/tree/fix38401
Conversationhttps://github.com/microsoft/TypeScript/pull/38403
Commits2 (2)https://github.com/microsoft/TypeScript/pull/38403/commits
Checkshttps://github.com/microsoft/TypeScript/pull/38403/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/38403/files
Fix for jsdoc modifiers on constructor paramshttps://github.com/microsoft/TypeScript/pull/38403#top
Ron Buckton (rbuckton)https://github.com/rbuckton
masterhttps://github.com/microsoft/TypeScript/tree/master
fix38401https://github.com/microsoft/TypeScript/tree/fix38401
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
May 7, 2020https://github.com/microsoft/TypeScript/pull/38403#issue-614360581
#38401https://github.com/microsoft/TypeScript/issues/38401
Daniel Rosenwasser (@DanielRosenwasser)https://github.com/DanielRosenwasser
Ryan Cavanaugh (@RyanCavanaugh)https://github.com/RyanCavanaugh
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38403
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 7, 2020 21:36https://github.com/microsoft/TypeScript/pull/38403#event-3314751589
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Ron Buckton (rbuckton)https://github.com/rbuckton
May 7, 2020https://github.com/microsoft/TypeScript/pull/38403#event-3314751709
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
May 7, 2020https://github.com/microsoft/TypeScript/pull/38403#event-3314751732
https://github.com/rbuckton
Fix for jsdoc modifiers on constructor paramshttps://github.com/microsoft/TypeScript/pull/38403/commits/f238dc18559b226805cdb7dbc951751f431c9b62
f238dc1https://github.com/microsoft/TypeScript/pull/38403/commits/f238dc18559b226805cdb7dbc951751f431c9b62
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
force-pushedhttps://github.com/microsoft/TypeScript/compare/d14685db77fc3926856993d9213c81c43f65573d..f238dc18559b226805cdb7dbc951751f431c9b62
d14685dhttps://github.com/microsoft/TypeScript/commit/d14685db77fc3926856993d9213c81c43f65573d
f238dc1https://github.com/microsoft/TypeScript/commit/f238dc18559b226805cdb7dbc951751f431c9b62
Compare https://github.com/microsoft/TypeScript/compare/d14685db77fc3926856993d9213c81c43f65573d..f238dc18559b226805cdb7dbc951751f431c9b62
May 7, 2020 21:50https://github.com/microsoft/TypeScript/pull/38403#event-3314788544
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 7, 2020 https://github.com/microsoft/TypeScript/pull/38403#pullrequestreview-407901859
View reviewed changes https://github.com/microsoft/TypeScript/pull/38403/files/f238dc18559b226805cdb7dbc951751f431c9b62
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
https://github.com/microsoft/TypeScript/pull/38403#pullrequestreview-407901859
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38403
src/compiler/transformers/declarations.tshttps://github.com/microsoft/TypeScript/pull/38403/files/f238dc18559b226805cdb7dbc951751f431c9b62#diff-ec32a99747e4349604cbc0cdcfd80b391a4fc2bf2cadaa28553d8b919d63b424
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38403
src/compiler/transformers/declarations/diagnostics.tshttps://github.com/microsoft/TypeScript/pull/38403/files/f238dc18559b226805cdb7dbc951751f431c9b62#diff-ce7fde22e30ddc3b1cb35060e1446599b5a1142d405661dd7896da57de913296
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38403
src/compiler/transformers/declarations/diagnostics.tshttps://github.com/microsoft/TypeScript/pull/38403/files/f238dc18559b226805cdb7dbc951751f431c9b62#diff-ce7fde22e30ddc3b1cb35060e1446599b5a1142d405661dd7896da57de913296
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38403
src/compiler/types.tshttps://github.com/microsoft/TypeScript/pull/38403/files/f238dc18559b226805cdb7dbc951751f431c9b62#diff-e9fd483341eea176a38fbd370590e1dc65ce2d9bf70bfd317c5407f04dba9560
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38403
src/services/codefixes/helpers.tshttps://github.com/microsoft/TypeScript/pull/38403/files/f238dc18559b226805cdb7dbc951751f431c9b62#diff-880eafae481c815c3af893123092cc0d93305284d8e6d2200638e7d546123b6c
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38403
src/services/codefixes/fixClassIncorrectlyImplementsInterface.tshttps://github.com/microsoft/TypeScript/pull/38403/files/f238dc18559b226805cdb7dbc951751f431c9b62#diff-f0d3f6347f30cd6226c259f0eea05097b8e0a0b643181bb633b05cde4fc8b58f
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38403
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/38403/files/f238dc18559b226805cdb7dbc951751f431c9b62#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38403
https://github.com/rbuckton
Update Public API baseline and fix unique symbol grammar check for jshttps://github.com/microsoft/TypeScript/pull/38403/commits/39d9d22c073149291c1d9d1ffe7172a01c803e40
39d9d22https://github.com/microsoft/TypeScript/pull/38403/commits/39d9d22c073149291c1d9d1ffe7172a01c803e40
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
May 8, 2020https://github.com/microsoft/TypeScript/pull/38403#issuecomment-625568016
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38403
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
May 8, 2020https://github.com/microsoft/TypeScript/pull/38403#issuecomment-626029459
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38403
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 11, 2020 https://github.com/microsoft/TypeScript/pull/38403#pullrequestreview-409522349
View reviewed changes https://github.com/microsoft/TypeScript/pull/38403/files/39d9d22c073149291c1d9d1ffe7172a01c803e40
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
d07e866https://github.com/microsoft/TypeScript/commit/d07e866a28879f38d8cf7aea2a1b030de26613cc
May 11, 2020https://github.com/microsoft/TypeScript/pull/38403#event-3324969853
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
May 11, 2020 22:07https://github.com/microsoft/TypeScript/pull/38403#event-3324970044
AllenLee (cangSDARM)https://github.com/cangSDARM
May 12, 2020 https://github.com/microsoft/TypeScript/pull/38403#ref-commit-2e7319b
https://github.com/cangSDARM
Merge remote-tracking branch 'upstream/master'https://github.com/cangSDARM/TypeScript/commit/2e7319bd9a6f0eb1c700cdfb4de947c750ade2dc
2e7319bhttps://github.com/cangSDARM/TypeScript/commit/2e7319bd9a6f0eb1c700cdfb4de947c750ade2dc
microsoft#38403https://github.com/microsoft/TypeScript/pull/38403
microsoft#38270https://github.com/microsoft/TypeScript/pull/38270
microsoft#37546https://github.com/microsoft/TypeScript/pull/37546
@typehttps://github.com/type
microsoft#38340https://github.com/microsoft/TypeScript/pull/38340
microsoft#38107https://github.com/microsoft/TypeScript/pull/38107
microsoft#38472https://github.com/microsoft/TypeScript/pull/38472
microsoft#38405https://github.com/microsoft/TypeScript/pull/38405
microsoft#38430https://github.com/microsoft/TypeScript/issues/38430
microsoft#38368https://github.com/microsoft/TypeScript/pull/38368
microsoft#38269https://github.com/microsoft/TypeScript/pull/38269
microsoft#38395https://github.com/microsoft/TypeScript/pull/38395
microsoft#38398https://github.com/microsoft/TypeScript/pull/38398
microsoft#38128https://github.com/microsoft/TypeScript/pull/38128
https://github.com/ajafff
Klaus Meinhardt (ajafff)https://github.com/ajafff
Jan 3, 2021 https://github.com/microsoft/TypeScript/pull/38403#ref-issue-777687452
getSyntacticModifierFlags return value affected by getEffectiveModifierFlags #42189 https://github.com/microsoft/TypeScript/issues/42189
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/38403#event-20416957631
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F38403
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
https://github.com/microsoft/TypeScript/pull/38403/files/39d9d22c073149291c1d9d1ffe7172a01c803e40
https://github.com/andrewbranch
Andrew Branch (andrewbranch) https://github.com/andrewbranch
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38403
https://github.com/rbuckton
Ron Buckton (rbuckton) https://github.com/rbuckton
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
Regression: JSDoc '@public' comment on constructor parameter affects JS emit https://github.com/microsoft/TypeScript/issues/38401
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38403
https://github.com/rbuckton
https://github.com/sandersn
https://github.com/typescript-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.