| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:cfc0347a-9b52-35f8-1a1c-f1c8deba0572 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A140:269AD9:658499:89C099:6B00D6DE |
| html-safe-nonce | f198432d03a2cc3ede56ff5a28e5d6f4331ddda53fca5aec3631c850b6c6c995 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTQwOjI2OUFEOTo2NTg0OTk6ODlDMDk5OjZCMDBENkRFIiwidmlzaXRvcl9pZCI6IjY5OTM0NjIyMzQ0NTg0MTI3NjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 77b09af7111513073b5939a4a0e55152b0c90b84785a41bad425006af7a8bc15 |
| hovercard-subject-tag | pull_request:414933136 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/38403/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5e0aeab5edd5d0278d35be022c28c68d713809d06d3448951d9a4e6827829016/microsoft/TypeScript/pull/38403 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5e0aeab5edd5d0278d35be022c28c68d713809d06d3448951d9a4e6827829016/microsoft/TypeScript/pull/38403 |
| og:image:alt | When we added support for @public, @private, @protected, @readonly JSDoc-style modifiers, we inadvertently treated such modifiers on constructor properties as if they were TypeScript "paramete... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | rbuckton |
| hostname | github.com |
| expected-hostname | github.com |
| None | a481f62a1e04c9b9bdcb5628230682c66d59006f5b13b080f79cba84a176905b |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 84c8c5cc25e2fb7f2308428458538436baecc6d2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/38403#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F38403 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F38403 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/38403 |
| Reload | https://github.com/microsoft/TypeScript/pull/38403 |
| Reload | https://github.com/microsoft/TypeScript/pull/38403 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests307 (307) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| master | https://github.com/microsoft/TypeScript/tree/master |
| fix38401 | https://github.com/microsoft/TypeScript/tree/fix38401 |
| Conversation | https://github.com/microsoft/TypeScript/pull/38403 |
| Commits2 (2) | https://github.com/microsoft/TypeScript/pull/38403/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/38403/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/38403/files |
| Fix for jsdoc modifiers on constructor params | https://github.com/microsoft/TypeScript/pull/38403#top |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| master | https://github.com/microsoft/TypeScript/tree/master |
| fix38401 | https://github.com/microsoft/TypeScript/tree/fix38401 |
|
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| May 7, 2020 | https://github.com/microsoft/TypeScript/pull/38403#issue-614360581 |
| #38401 | https://github.com/microsoft/TypeScript/issues/38401 |
| Daniel Rosenwasser (@DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Ryan Cavanaugh (@RyanCavanaugh) | https://github.com/RyanCavanaugh |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/38403 |
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| May 7, 2020 21:36 | https://github.com/microsoft/TypeScript/pull/38403#event-3314751589 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| May 7, 2020 | https://github.com/microsoft/TypeScript/pull/38403#event-3314751709 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
|
Author: Team
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22 |
| May 7, 2020 | https://github.com/microsoft/TypeScript/pull/38403#event-3314751732 |
|
| https://github.com/rbuckton |
| Fix for jsdoc modifiers on constructor params | https://github.com/microsoft/TypeScript/pull/38403/commits/f238dc18559b226805cdb7dbc951751f431c9b62 |
| f238dc1 | https://github.com/microsoft/TypeScript/pull/38403/commits/f238dc18559b226805cdb7dbc951751f431c9b62 |
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| force-pushed | https://github.com/microsoft/TypeScript/compare/d14685db77fc3926856993d9213c81c43f65573d..f238dc18559b226805cdb7dbc951751f431c9b62 |
| d14685d | https://github.com/microsoft/TypeScript/commit/d14685db77fc3926856993d9213c81c43f65573d |
| f238dc1 | https://github.com/microsoft/TypeScript/commit/f238dc18559b226805cdb7dbc951751f431c9b62 |
|
Compare
| https://github.com/microsoft/TypeScript/compare/d14685db77fc3926856993d9213c81c43f65573d..f238dc18559b226805cdb7dbc951751f431c9b62 |
| May 7, 2020 21:50 | https://github.com/microsoft/TypeScript/pull/38403#event-3314788544 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
|
May 7, 2020
| https://github.com/microsoft/TypeScript/pull/38403#pullrequestreview-407901859 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/38403/files/f238dc18559b226805cdb7dbc951751f431c9b62 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| https://github.com/microsoft/TypeScript/pull/38403#pullrequestreview-407901859 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/38403 |
| src/compiler/transformers/declarations.ts | https://github.com/microsoft/TypeScript/pull/38403/files/f238dc18559b226805cdb7dbc951751f431c9b62#diff-ec32a99747e4349604cbc0cdcfd80b391a4fc2bf2cadaa28553d8b919d63b424 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/38403 |
| src/compiler/transformers/declarations/diagnostics.ts | https://github.com/microsoft/TypeScript/pull/38403/files/f238dc18559b226805cdb7dbc951751f431c9b62#diff-ce7fde22e30ddc3b1cb35060e1446599b5a1142d405661dd7896da57de913296 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/38403 |
| src/compiler/transformers/declarations/diagnostics.ts | https://github.com/microsoft/TypeScript/pull/38403/files/f238dc18559b226805cdb7dbc951751f431c9b62#diff-ce7fde22e30ddc3b1cb35060e1446599b5a1142d405661dd7896da57de913296 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/38403 |
| src/compiler/types.ts | https://github.com/microsoft/TypeScript/pull/38403/files/f238dc18559b226805cdb7dbc951751f431c9b62#diff-e9fd483341eea176a38fbd370590e1dc65ce2d9bf70bfd317c5407f04dba9560 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/38403 |
| src/services/codefixes/helpers.ts | https://github.com/microsoft/TypeScript/pull/38403/files/f238dc18559b226805cdb7dbc951751f431c9b62#diff-880eafae481c815c3af893123092cc0d93305284d8e6d2200638e7d546123b6c |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/38403 |
| src/services/codefixes/fixClassIncorrectlyImplementsInterface.ts | https://github.com/microsoft/TypeScript/pull/38403/files/f238dc18559b226805cdb7dbc951751f431c9b62#diff-f0d3f6347f30cd6226c259f0eea05097b8e0a0b643181bb633b05cde4fc8b58f |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/38403 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/38403/files/f238dc18559b226805cdb7dbc951751f431c9b62#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/38403 |
|
| https://github.com/rbuckton |
| Update Public API baseline and fix unique symbol grammar check for js | https://github.com/microsoft/TypeScript/pull/38403/commits/39d9d22c073149291c1d9d1ffe7172a01c803e40 |
| 39d9d22 | https://github.com/microsoft/TypeScript/pull/38403/commits/39d9d22c073149291c1d9d1ffe7172a01c803e40 |
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| May 8, 2020 | https://github.com/microsoft/TypeScript/pull/38403#issuecomment-625568016 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/38403 |
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| May 8, 2020 | https://github.com/microsoft/TypeScript/pull/38403#issuecomment-626029459 |
| Nathan Shively-Sanders (@sandersn) | https://github.com/sandersn |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/38403 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
|
May 11, 2020
| https://github.com/microsoft/TypeScript/pull/38403#pullrequestreview-409522349 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/38403/files/39d9d22c073149291c1d9d1ffe7172a01c803e40 |
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| d07e866 | https://github.com/microsoft/TypeScript/commit/d07e866a28879f38d8cf7aea2a1b030de26613cc |
| May 11, 2020 | https://github.com/microsoft/TypeScript/pull/38403#event-3324969853 |
| https://github.com/rbuckton |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| May 11, 2020 22:07 | https://github.com/microsoft/TypeScript/pull/38403#event-3324970044 |
| AllenLee (cangSDARM) | https://github.com/cangSDARM |
|
May 12, 2020
| https://github.com/microsoft/TypeScript/pull/38403#ref-commit-2e7319b |
|
| https://github.com/cangSDARM |
| Merge remote-tracking branch 'upstream/master' | https://github.com/cangSDARM/TypeScript/commit/2e7319bd9a6f0eb1c700cdfb4de947c750ade2dc |
| 2e7319b | https://github.com/cangSDARM/TypeScript/commit/2e7319bd9a6f0eb1c700cdfb4de947c750ade2dc |
| microsoft#38403 | https://github.com/microsoft/TypeScript/pull/38403 |
| microsoft#38270 | https://github.com/microsoft/TypeScript/pull/38270 |
| microsoft#37546 | https://github.com/microsoft/TypeScript/pull/37546 |
| @type | https://github.com/type |
| microsoft#38340 | https://github.com/microsoft/TypeScript/pull/38340 |
| microsoft#38107 | https://github.com/microsoft/TypeScript/pull/38107 |
| microsoft#38472 | https://github.com/microsoft/TypeScript/pull/38472 |
| microsoft#38405 | https://github.com/microsoft/TypeScript/pull/38405 |
| microsoft#38430 | https://github.com/microsoft/TypeScript/issues/38430 |
| microsoft#38368 | https://github.com/microsoft/TypeScript/pull/38368 |
| microsoft#38269 | https://github.com/microsoft/TypeScript/pull/38269 |
| microsoft#38395 | https://github.com/microsoft/TypeScript/pull/38395 |
| microsoft#38398 | https://github.com/microsoft/TypeScript/pull/38398 |
| microsoft#38128 | https://github.com/microsoft/TypeScript/pull/38128 |
| https://github.com/ajafff |
| Klaus Meinhardt (ajafff) | https://github.com/ajafff |
|
Jan 3, 2021
| https://github.com/microsoft/TypeScript/pull/38403#ref-issue-777687452 |
|
getSyntacticModifierFlags return value affected by getEffectiveModifierFlags
#42189
| https://github.com/microsoft/TypeScript/issues/42189 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Oct 21, 2025 | https://github.com/microsoft/TypeScript/pull/38403#event-20416957631 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F38403 |
|
| https://github.com/sandersn |
|
Nathan Shively-Sanders (sandersn)
| https://github.com/sandersn |
|
| https://github.com/microsoft/TypeScript/pull/38403/files/39d9d22c073149291c1d9d1ffe7172a01c803e40 |
|
| https://github.com/andrewbranch |
|
Andrew Branch (andrewbranch)
| https://github.com/andrewbranch |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/38403 |
|
| https://github.com/rbuckton |
|
Ron Buckton (rbuckton)
| https://github.com/rbuckton |
|
Author: Team
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22 |
|
Regression: JSDoc '@public' comment on constructor parameter affects JS emit
| https://github.com/microsoft/TypeScript/issues/38401 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/38403 |
|
| https://github.com/rbuckton |
|
| https://github.com/sandersn |
|
| https://github.com/typescript-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |