René's URL Explorer Experiment


Title: Consistent narrowing by discriminant by ahejlsberg · Pull Request #38311 · microsoft/TypeScript · GitHub

Open Graph Title: Consistent narrowing by discriminant by ahejlsberg · Pull Request #38311 · microsoft/TypeScript

X Title: Consistent narrowing by discriminant by ahejlsberg · Pull Request #38311 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Consistent narrowing by discriminant by ahejlsberg · Pull Request #38311 · microsoft/TypeScript

Open Graph Description: With this PR we fix inconsistencies in our narrowing logic for discriminated unions. Previously we required the declared type of a reference to be a union type before we'd narrow by discriminan...

X Description: With this PR we fix inconsistencies in our narrowing logic for discriminated unions. Previously we required the declared type of a reference to be a union type before we'd narrow by discrim...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/38311

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fc005156-598d-92e9-cbc5-895e7817328b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCA90:1EC9BC:DE2A93:11C1BED:6B010855
html-safe-nonceb2bbd1891816addd83699aba9bf44ea592e0bdd8a60da7ca08b20aaaec2872f5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTkwOjFFQzlCQzpERTJBOTM6MTFDMUJFRDo2QjAxMDg1NSIsInZpc2l0b3JfaWQiOiIxNjYyODgxNzIwOTg4NDAzNzk3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9b7c886bebbf369e197aa0f3ba2890ed9a2104b99652b3abcf51ec9857947d93
hovercard-subject-tagpull_request:412660975
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/38311/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1ecdf86f05d534efe83b9b647827e2d0ab51d49d6e0c499667ad82706b0ffe1e/microsoft/TypeScript/pull/38311
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1ecdf86f05d534efe83b9b647827e2d0ab51d49d6e0c499667ad82706b0ffe1e/microsoft/TypeScript/pull/38311
og:image:altWith this PR we fix inconsistencies in our narrowing logic for discriminated unions. Previously we required the declared type of a reference to be a union type before we'd narrow by discriminan...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameahejlsberg
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/38311#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F38311
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F38311
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/38311
Reloadhttps://github.com/microsoft/TypeScript/pull/38311
Reloadhttps://github.com/microsoft/TypeScript/pull/38311
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
masterhttps://github.com/microsoft/TypeScript/tree/master
fix36777https://github.com/microsoft/TypeScript/tree/fix36777
Conversationhttps://github.com/microsoft/TypeScript/pull/38311
Commits2 (2)https://github.com/microsoft/TypeScript/pull/38311/commits
Checkshttps://github.com/microsoft/TypeScript/pull/38311/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/38311/files
Consistent narrowing by discriminanthttps://github.com/microsoft/TypeScript/pull/38311#top
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
masterhttps://github.com/microsoft/TypeScript/tree/master
fix36777https://github.com/microsoft/TypeScript/tree/fix36777
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
May 3, 2020https://github.com/microsoft/TypeScript/pull/38311#issue-611499126
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38311
#30557https://github.com/microsoft/TypeScript/issues/30557
#36777https://github.com/microsoft/TypeScript/issues/36777
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38311
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
May 3, 2020 12:23https://github.com/microsoft/TypeScript/pull/38311#commits-pushed-e8f1c58
https://github.com/ahejlsberg
Consistent requirements for narrowing by discriminanthttps://github.com/microsoft/TypeScript/pull/38311/commits/e8f1c5864e6ecb23847267f4951cfd68bd1d5a5d
e8f1c58https://github.com/microsoft/TypeScript/pull/38311/commits/e8f1c5864e6ecb23847267f4951cfd68bd1d5a5d
https://github.com/ahejlsberg
Add testshttps://github.com/microsoft/TypeScript/pull/38311/commits/88025e60bc0620876e45bed744a338d110db54f4
88025e6https://github.com/microsoft/TypeScript/pull/38311/commits/88025e60bc0620876e45bed744a338d110db54f4
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
May 3, 2020 20:24https://github.com/microsoft/TypeScript/pull/38311#event-3297801426
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
May 3, 2020https://github.com/microsoft/TypeScript/pull/38311#issuecomment-623175862
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38311
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
May 3, 2020https://github.com/microsoft/TypeScript/pull/38311#issuecomment-623175880
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38311
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
88025e6https://github.com/microsoft/TypeScript/commit/88025e60bc0620876e45bed744a338d110db54f4
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=72726
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38311
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
May 3, 2020https://github.com/microsoft/TypeScript/pull/38311#issuecomment-623175881
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38311
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
88025e6https://github.com/microsoft/TypeScript/commit/88025e60bc0620876e45bed744a338d110db54f4
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=72727
The results are in!https://github.com/microsoft/TypeScript/pull/38311#issuecomment-623181574
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38311
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
May 3, 2020https://github.com/microsoft/TypeScript/pull/38311#issuecomment-623175882
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38311
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
88025e6https://github.com/microsoft/TypeScript/commit/88025e60bc0620876e45bed744a338d110db54f4
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=72725
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38311
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
May 3, 2020https://github.com/microsoft/TypeScript/pull/38311#issuecomment-623175883
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38311
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
88025e6https://github.com/microsoft/TypeScript/commit/88025e60bc0620876e45bed744a338d110db54f4
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=72728
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38311
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
May 3, 2020https://github.com/microsoft/TypeScript/pull/38311#issuecomment-623179764
PR with the baseline diff from masterhttps://github.com/typescript-bot/TypeScript/pull/30
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38311
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
May 3, 2020 https://github.com/microsoft/TypeScript/pull/38311#ref-pullrequest-611504443
🤖 User test baselines have changed for fix36777 typescript-bot/TypeScript#30 https://github.com/typescript-bot/TypeScript/pull/30
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
May 3, 2020https://github.com/microsoft/TypeScript/pull/38311#issuecomment-623181574
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38311
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
May 4, 2020https://github.com/microsoft/TypeScript/pull/38311#issuecomment-623240906
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38311
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
May 4, 2020https://github.com/microsoft/TypeScript/pull/38311#issuecomment-623724259
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38311
#33434https://github.com/microsoft/TypeScript/pull/33434
#30593https://github.com/microsoft/TypeScript/pull/30593
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38311
https://github.com/jack-williams
Jack Williams (jack-williams)https://github.com/jack-williams
May 4, 2020https://github.com/microsoft/TypeScript/pull/38311#issuecomment-623761910
Wesley Wigham (@weswigham)https://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38311
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
May 5, 2020 https://github.com/microsoft/TypeScript/pull/38311#pullrequestreview-406150777
View reviewed changes https://github.com/microsoft/TypeScript/pull/38311/files/88025e60bc0620876e45bed744a338d110db54f4
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
2524fb1https://github.com/microsoft/TypeScript/commit/2524fb164ac3d6f508b876f248a9994500c82076
May 6, 2020https://github.com/microsoft/TypeScript/pull/38311#event-3306727685
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
May 6, 2020 03:06https://github.com/microsoft/TypeScript/pull/38311#event-3306727821
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 6, 2020 https://github.com/microsoft/TypeScript/pull/38311#ref-pullrequest-493610966
Unify logic in typeof narrowing #33434 https://github.com/microsoft/TypeScript/pull/33434
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
May 15, 2020 https://github.com/microsoft/TypeScript/pull/38311#ref-issue-619147345
Design Meeting Notes, 5/8/2020 #38598 https://github.com/microsoft/TypeScript/issues/38598
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/38311#event-20416951929
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F38311
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh) https://github.com/RyanCavanaugh
https://github.com/microsoft/TypeScript/pull/38311/files/88025e60bc0620876e45bed744a338d110db54f4
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38311
Discriminate union inference inconsistent behavior with if/else checks https://github.com/microsoft/TypeScript/issues/36777
Unknown types narrowed to a union won't narrow further https://github.com/microsoft/TypeScript/issues/30557
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/38311
https://github.com/ahejlsberg
https://github.com/typescript-bot
https://github.com/weswigham
https://github.com/jack-williams
https://github.com/RyanCavanaugh
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.