| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:fc005156-598d-92e9-cbc5-895e7817328b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CA90:1EC9BC:DE2A93:11C1BED:6B010855 |
| html-safe-nonce | b2bbd1891816addd83699aba9bf44ea592e0bdd8a60da7ca08b20aaaec2872f5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTkwOjFFQzlCQzpERTJBOTM6MTFDMUJFRDo2QjAxMDg1NSIsInZpc2l0b3JfaWQiOiIxNjYyODgxNzIwOTg4NDAzNzk3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 9b7c886bebbf369e197aa0f3ba2890ed9a2104b99652b3abcf51ec9857947d93 |
| hovercard-subject-tag | pull_request:412660975 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/38311/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/1ecdf86f05d534efe83b9b647827e2d0ab51d49d6e0c499667ad82706b0ffe1e/microsoft/TypeScript/pull/38311 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1ecdf86f05d534efe83b9b647827e2d0ab51d49d6e0c499667ad82706b0ffe1e/microsoft/TypeScript/pull/38311 |
| og:image:alt | With this PR we fix inconsistencies in our narrowing logic for discriminated unions. Previously we required the declared type of a reference to be a union type before we'd narrow by discriminan... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ahejlsberg |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/38311#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F38311 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F38311 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/38311 |
| Reload | https://github.com/microsoft/TypeScript/pull/38311 |
| Reload | https://github.com/microsoft/TypeScript/pull/38311 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests309 (309) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| master | https://github.com/microsoft/TypeScript/tree/master |
| fix36777 | https://github.com/microsoft/TypeScript/tree/fix36777 |
| Conversation | https://github.com/microsoft/TypeScript/pull/38311 |
| Commits2 (2) | https://github.com/microsoft/TypeScript/pull/38311/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/38311/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/38311/files |
| Consistent narrowing by discriminant | https://github.com/microsoft/TypeScript/pull/38311#top |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| master | https://github.com/microsoft/TypeScript/tree/master |
| fix36777 | https://github.com/microsoft/TypeScript/tree/fix36777 |
|
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| May 3, 2020 | https://github.com/microsoft/TypeScript/pull/38311#issue-611499126 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/38311 |
| #30557 | https://github.com/microsoft/TypeScript/issues/30557 |
| #36777 | https://github.com/microsoft/TypeScript/issues/36777 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/38311 |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| May 3, 2020 12:23 | https://github.com/microsoft/TypeScript/pull/38311#commits-pushed-e8f1c58 |
|
| https://github.com/ahejlsberg |
| Consistent requirements for narrowing by discriminant | https://github.com/microsoft/TypeScript/pull/38311/commits/e8f1c5864e6ecb23847267f4951cfd68bd1d5a5d |
| e8f1c58 | https://github.com/microsoft/TypeScript/pull/38311/commits/e8f1c5864e6ecb23847267f4951cfd68bd1d5a5d |
|
| https://github.com/ahejlsberg |
| Add tests | https://github.com/microsoft/TypeScript/pull/38311/commits/88025e60bc0620876e45bed744a338d110db54f4 |
| 88025e6 | https://github.com/microsoft/TypeScript/pull/38311/commits/88025e60bc0620876e45bed744a338d110db54f4 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| Ryan Cavanaugh (RyanCavanaugh) | https://github.com/RyanCavanaugh |
| May 3, 2020 20:24 | https://github.com/microsoft/TypeScript/pull/38311#event-3297801426 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| May 3, 2020 | https://github.com/microsoft/TypeScript/pull/38311#issuecomment-623175862 |
| TypeScript Bot (@typescript-bot) | https://github.com/typescript-bot |
| TypeScript Bot (@typescript-bot) | https://github.com/typescript-bot |
| TypeScript Bot (@typescript-bot) | https://github.com/typescript-bot |
| TypeScript Bot (@typescript-bot) | https://github.com/typescript-bot |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/38311 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| May 3, 2020 | https://github.com/microsoft/TypeScript/pull/38311#issuecomment-623175880 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/38311 |
| Anders Hejlsberg (@ahejlsberg) | https://github.com/ahejlsberg |
| 88025e6 | https://github.com/microsoft/TypeScript/commit/88025e60bc0620876e45bed744a338d110db54f4 |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=72726 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/38311 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| May 3, 2020 | https://github.com/microsoft/TypeScript/pull/38311#issuecomment-623175881 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/38311 |
| Anders Hejlsberg (@ahejlsberg) | https://github.com/ahejlsberg |
| 88025e6 | https://github.com/microsoft/TypeScript/commit/88025e60bc0620876e45bed744a338d110db54f4 |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=72727 |
| The results are in! | https://github.com/microsoft/TypeScript/pull/38311#issuecomment-623181574 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/38311 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| May 3, 2020 | https://github.com/microsoft/TypeScript/pull/38311#issuecomment-623175882 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/38311 |
| Anders Hejlsberg (@ahejlsberg) | https://github.com/ahejlsberg |
| 88025e6 | https://github.com/microsoft/TypeScript/commit/88025e60bc0620876e45bed744a338d110db54f4 |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=72725 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/38311 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| May 3, 2020 | https://github.com/microsoft/TypeScript/pull/38311#issuecomment-623175883 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/38311 |
| Anders Hejlsberg (@ahejlsberg) | https://github.com/ahejlsberg |
| 88025e6 | https://github.com/microsoft/TypeScript/commit/88025e60bc0620876e45bed744a338d110db54f4 |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=72728 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/38311 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| May 3, 2020 | https://github.com/microsoft/TypeScript/pull/38311#issuecomment-623179764 |
| PR with the baseline diff from master | https://github.com/typescript-bot/TypeScript/pull/30 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/38311 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
|
May 3, 2020
| https://github.com/microsoft/TypeScript/pull/38311#ref-pullrequest-611504443 |
|
🤖 User test baselines have changed for fix36777
typescript-bot/TypeScript#30
| https://github.com/typescript-bot/TypeScript/pull/30 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| May 3, 2020 | https://github.com/microsoft/TypeScript/pull/38311#issuecomment-623181574 |
| Anders Hejlsberg (@ahejlsberg) | https://github.com/ahejlsberg |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/38311 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| May 4, 2020 | https://github.com/microsoft/TypeScript/pull/38311#issuecomment-623240906 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/38311 |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| May 4, 2020 | https://github.com/microsoft/TypeScript/pull/38311#issuecomment-623724259 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/38311 |
| #33434 | https://github.com/microsoft/TypeScript/pull/33434 |
| #30593 | https://github.com/microsoft/TypeScript/pull/30593 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/38311 |
| https://github.com/jack-williams |
| Jack Williams (jack-williams) | https://github.com/jack-williams |
| May 4, 2020 | https://github.com/microsoft/TypeScript/pull/38311#issuecomment-623761910 |
| Wesley Wigham (@weswigham) | https://github.com/weswigham |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/38311 |
| https://github.com/RyanCavanaugh |
| Ryan Cavanaugh (RyanCavanaugh) | https://github.com/RyanCavanaugh |
|
May 5, 2020
| https://github.com/microsoft/TypeScript/pull/38311#pullrequestreview-406150777 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/38311/files/88025e60bc0620876e45bed744a338d110db54f4 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| 2524fb1 | https://github.com/microsoft/TypeScript/commit/2524fb164ac3d6f508b876f248a9994500c82076 |
| May 6, 2020 | https://github.com/microsoft/TypeScript/pull/38311#event-3306727685 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| May 6, 2020 03:06 | https://github.com/microsoft/TypeScript/pull/38311#event-3306727821 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
|
May 6, 2020
| https://github.com/microsoft/TypeScript/pull/38311#ref-pullrequest-493610966 |
|
Unify logic in typeof narrowing
#33434
| https://github.com/microsoft/TypeScript/pull/33434 |
| https://github.com/RyanCavanaugh |
| Ryan Cavanaugh (RyanCavanaugh) | https://github.com/RyanCavanaugh |
|
May 15, 2020
| https://github.com/microsoft/TypeScript/pull/38311#ref-issue-619147345 |
|
Design Meeting Notes, 5/8/2020
#38598
| https://github.com/microsoft/TypeScript/issues/38598 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Oct 21, 2025 | https://github.com/microsoft/TypeScript/pull/38311#event-20416951929 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F38311 |
|
| https://github.com/RyanCavanaugh |
|
Ryan Cavanaugh (RyanCavanaugh)
| https://github.com/RyanCavanaugh |
|
| https://github.com/microsoft/TypeScript/pull/38311/files/88025e60bc0620876e45bed744a338d110db54f4 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/38311 |
|
Discriminate union inference inconsistent behavior with if/else checks
| https://github.com/microsoft/TypeScript/issues/36777 |
|
Unknown types narrowed to a union won't narrow further
| https://github.com/microsoft/TypeScript/issues/30557 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/38311 |
|
| https://github.com/ahejlsberg |
|
| https://github.com/typescript-bot |
|
| https://github.com/weswigham |
|
| https://github.com/jack-williams |
|
| https://github.com/RyanCavanaugh |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |