René's URL Explorer Experiment


Title: Disallow partial matches for discriminant properties when generating error messages by weswigham · Pull Request #37589 · microsoft/TypeScript · GitHub

Open Graph Title: Disallow partial matches for discriminant properties when generating error messages by weswigham · Pull Request #37589 · microsoft/TypeScript

X Title: Disallow partial matches for discriminant properties when generating error messages by weswigham · Pull Request #37589 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Disallow partial matches for discriminant properties when generating error messages by weswigham · Pull Request #37589 · microsoft/TypeScript

Open Graph Description: Fixes #37506 In the example given, data is marked as a discriminable property, because for the members it exists on, it can discriminate between them; so, taken with another (potentially partial) d...

X Description: Fixes #37506 In the example given, data is marked as a discriminable property, because for the members it exists on, it can discriminate between them; so, taken with another (potentially partial) d...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/37589

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a1d113e3-5b50-4ecb-d4f8-4444af1ceafe
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA3D0:3F4253:E49A17:13112B0:6B010824
html-safe-noncecc8c4c6b94e7b5c62b2eadc4eed25c0d7129e9cc28aef019323fc1c09d65d03b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBM0QwOjNGNDI1MzpFNDlBMTc6MTMxMTJCMDo2QjAxMDgyNCIsInZpc2l0b3JfaWQiOiI1NDM2MDI4NzE0MDcwNjQwNjc3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf08f7b44d67b0d1d62c3afaaa2551fcb1518974d07f34a54736271c0199fa9fc
hovercard-subject-tagpull_request:393736898
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/37589/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b6454c5faef69a2f830e87fb5815757b8d761efceeae32493139352ea42e42d3/microsoft/TypeScript/pull/37589
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b6454c5faef69a2f830e87fb5815757b8d761efceeae32493139352ea42e42d3/microsoft/TypeScript/pull/37589
og:image:altFixes #37506 In the example given, data is marked as a discriminable property, because for the members it exists on, it can discriminate between them; so, taken with another (potentially partial) d...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameweswigham
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/37589#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F37589
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F37589
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/37589
Reloadhttps://github.com/microsoft/TypeScript/pull/37589
Reloadhttps://github.com/microsoft/TypeScript/pull/37589
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
weswigham:sometimes-disable-partial-discriminantshttps://github.com/weswigham/TypeScript/tree/sometimes-disable-partial-discriminants
Conversationhttps://github.com/microsoft/TypeScript/pull/37589
Commits1 (1)https://github.com/microsoft/TypeScript/pull/37589/commits
Checkshttps://github.com/microsoft/TypeScript/pull/37589/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/37589/files
Disallow partial matches for discriminant properties when generating error messageshttps://github.com/microsoft/TypeScript/pull/37589#top
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
weswigham:sometimes-disable-partial-discriminantshttps://github.com/weswigham/TypeScript/tree/sometimes-disable-partial-discriminants
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Mar 25, 2020https://github.com/microsoft/TypeScript/pull/37589#issue-587880182
#37506https://github.com/microsoft/TypeScript/issues/37506
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37589
https://github.com/weswigham
Disallow partial matches for discriminant properties when generating …https://github.com/microsoft/TypeScript/pull/37589/commits/3a4f171a23a093b5ba48efe6bb43cca8821e9e13
3a4f171https://github.com/microsoft/TypeScript/pull/37589/commits/3a4f171a23a093b5ba48efe6bb43cca8821e9e13
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Wesley Wigham (weswigham)https://github.com/weswigham
Mar 25, 2020https://github.com/microsoft/TypeScript/pull/37589#event-3165103356
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
Mar 25, 2020https://github.com/microsoft/TypeScript/pull/37589#event-3165103418
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
March 25, 2020 17:53https://github.com/microsoft/TypeScript/pull/37589#event-3165104381
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Mar 26, 2020 https://github.com/microsoft/TypeScript/pull/37589#pullrequestreview-382479846
View reviewed changes https://github.com/microsoft/TypeScript/pull/37589/files/3a4f171a23a093b5ba48efe6bb43cca8821e9e13
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/37589/files/3a4f171a23a093b5ba48efe6bb43cca8821e9e13#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Mar 26, 2020https://github.com/microsoft/TypeScript/pull/37589#discussion_r398943546
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37589
Wesley Wigham (weswigham)https://github.com/weswigham
Mar 27, 2020https://github.com/microsoft/TypeScript/pull/37589#discussion_r398996119
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37589
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37589
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Apr 1, 2020 https://github.com/microsoft/TypeScript/pull/37589#pullrequestreview-385955858
View reviewed changes https://github.com/microsoft/TypeScript/pull/37589/files/3a4f171a23a093b5ba48efe6bb43cca8821e9e13
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
https://github.com/microsoft/TypeScript/pull/37589#pullrequestreview-385955858
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37589
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
326e1c9https://github.com/microsoft/TypeScript/commit/326e1c9ff8cb8b4b74574ba1f49b312e88434476
Apr 1, 2020https://github.com/microsoft/TypeScript/pull/37589#event-3189928499
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
April 1, 2020 22:39https://github.com/microsoft/TypeScript/pull/37589#event-3189928659
https://github.com/orta
Orta Therox (orta)https://github.com/orta
Apr 14, 2020 https://github.com/microsoft/TypeScript/pull/37589#ref-issue-494526154
[tsc] Regression causing 'Maximum call stack size exceeded' #33460 https://github.com/microsoft/TypeScript/issues/33460
https://github.com/jcalz
Joe Calzaretta (jcalz)https://github.com/jcalz
Feb 7, 2023 https://github.com/microsoft/TypeScript/pull/37589#ref-issue-1027000144
Unexpected error message when using tagged union in an nested object. #46374 https://github.com/microsoft/TypeScript/issues/46374
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/37589#event-20416914258
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F37589
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) https://github.com/DanielRosenwasser
https://github.com/microsoft/TypeScript/pull/37589/files/3a4f171a23a093b5ba48efe6bb43cca8821e9e13
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
https://github.com/microsoft/TypeScript/pull/37589/files/3a4f171a23a093b5ba48efe6bb43cca8821e9e13
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh) https://github.com/RyanCavanaugh
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37589
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
Error message indicates incorrect union discriminant https://github.com/microsoft/TypeScript/issues/37506
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37589
https://github.com/weswigham
https://github.com/sandersn
https://github.com/DanielRosenwasser
https://github.com/typescript-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.