René's URL Explorer Experiment


Title: Make substitution types even if the substitution base isnt a type variable by weswigham · Pull Request #37348 · microsoft/TypeScript · GitHub

Open Graph Title: Make substitution types even if the substitution base isnt a type variable by weswigham · Pull Request #37348 · microsoft/TypeScript

X Title: Make substitution types even if the substitution base isnt a type variable by weswigham · Pull Request #37348 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Make substitution types even if the substitution base isnt a type variable by weswigham · Pull Request #37348 · microsoft/TypeScript

Open Graph Description: Fixes #36135

X Description: Fixes #36135

Opengraph URL: https://github.com/microsoft/TypeScript/pull/37348

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:841091b5-e4fc-5c92-5dd0-d47b6eb06389
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB55C:31E99C:2CBF25F:3BBED9C:6B01D054
html-safe-nonce2958cb46cb3ca86042ab584253d1b547db311a0a0edb134e200ec813430f38bf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNTVDOjMxRTk5QzoyQ0JGMjVGOjNCQkVEOUM6NkIwMUQwNTQiLCJ2aXNpdG9yX2lkIjoiODI3NTAwNzY1MDExOTQwNTY1MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc3a98429344985decb60854878f702566f7570a8ca9b96ffc04eaf0d9b682d9f
hovercard-subject-tagpull_request:386879520
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/37348/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9371ae6a098775a8b4f9db5b64c2090bc704452589a31e23c7b2799a939b3838/microsoft/TypeScript/pull/37348
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9371ae6a098775a8b4f9db5b64c2090bc704452589a31e23c7b2799a939b3838/microsoft/TypeScript/pull/37348
og:image:altFixes #36135
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameweswigham
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/37348#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F37348
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F37348
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/37348
Reloadhttps://github.com/microsoft/TypeScript/pull/37348
Reloadhttps://github.com/microsoft/TypeScript/pull/37348
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
weswigham:conditional-bugfixhttps://github.com/weswigham/TypeScript/tree/conditional-bugfix
Conversationhttps://github.com/microsoft/TypeScript/pull/37348
Commits3 (3)https://github.com/microsoft/TypeScript/pull/37348/commits
Checkshttps://github.com/microsoft/TypeScript/pull/37348/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/37348/files
Make substitution types even if the substitution base isnt a type variablehttps://github.com/microsoft/TypeScript/pull/37348#top
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
weswigham:conditional-bugfixhttps://github.com/weswigham/TypeScript/tree/conditional-bugfix
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Mar 11, 2020https://github.com/microsoft/TypeScript/pull/37348#issue-579495487
#36135https://github.com/microsoft/TypeScript/issues/36135
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37348
https://github.com/weswigham
Make substitution types even if the substitution base isnt a type var…https://github.com/microsoft/TypeScript/pull/37348/commits/7772caf13a004e519d3bf211012462b92bc6e9aa
7772cafhttps://github.com/microsoft/TypeScript/pull/37348/commits/7772caf13a004e519d3bf211012462b92bc6e9aa
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Wesley Wigham (weswigham)https://github.com/weswigham
Mar 11, 2020https://github.com/microsoft/TypeScript/pull/37348#event-3120227684
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
Mar 11, 2020https://github.com/microsoft/TypeScript/pull/37348#event-3120227740
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Mar 11, 2020https://github.com/microsoft/TypeScript/pull/37348#issuecomment-597827764
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37348
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Mar 11, 2020https://github.com/microsoft/TypeScript/pull/37348#issuecomment-597827808
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37348
Wesley Wigham (@weswigham)https://github.com/weswigham
7772cafhttps://github.com/microsoft/TypeScript/commit/7772caf13a004e519d3bf211012462b92bc6e9aa
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=67728
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37348
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Mar 11, 2020https://github.com/microsoft/TypeScript/pull/37348#issuecomment-597827809
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37348
Wesley Wigham (@weswigham)https://github.com/weswigham
7772cafhttps://github.com/microsoft/TypeScript/commit/7772caf13a004e519d3bf211012462b92bc6e9aa
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=67726
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37348
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Mar 11, 2020https://github.com/microsoft/TypeScript/pull/37348#issuecomment-597827810
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37348
Wesley Wigham (@weswigham)https://github.com/weswigham
7772cafhttps://github.com/microsoft/TypeScript/commit/7772caf13a004e519d3bf211012462b92bc6e9aa
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=67725
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37348
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Mar 11, 2020https://github.com/microsoft/TypeScript/pull/37348#issuecomment-597827813
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37348
Wesley Wigham (@weswigham)https://github.com/weswigham
7772cafhttps://github.com/microsoft/TypeScript/commit/7772caf13a004e519d3bf211012462b92bc6e9aa
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=67727
The results are in!https://github.com/microsoft/TypeScript/pull/37348#issuecomment-597843613
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37348
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Mar 11, 2020 https://github.com/microsoft/TypeScript/pull/37348#ref-pullrequest-579516110
🤖 User test baselines have changed for conditional-bugfix weswigham/TypeScript#66 https://github.com/weswigham/TypeScript/pull/66
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Mar 11, 2020https://github.com/microsoft/TypeScript/pull/37348#issuecomment-597841214
PR with the baseline diff from masterhttps://github.com/weswigham/TypeScript/pull/66
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37348
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Mar 11, 2020https://github.com/microsoft/TypeScript/pull/37348#issuecomment-597843613
Wesley Wigham (@weswigham)https://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37348
https://github.com/weswigham
Broaden usage of getConditionalFlowTypeOfType to _all_ type lookupshttps://github.com/microsoft/TypeScript/pull/37348/commits/c7f54d594b4e24913e552e16c6e0e8485fdf2cca
c7f54d5https://github.com/microsoft/TypeScript/pull/37348/commits/c7f54d594b4e24913e552e16c6e0e8485fdf2cca
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Mar 11, 2020https://github.com/microsoft/TypeScript/pull/37348#issuecomment-597846016
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37348
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Mar 11, 2020https://github.com/microsoft/TypeScript/pull/37348#issuecomment-597846050
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37348
Wesley Wigham (@weswigham)https://github.com/weswigham
c7f54d5https://github.com/microsoft/TypeScript/commit/c7f54d594b4e24913e552e16c6e0e8485fdf2cca
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=67746
The results are in!https://github.com/microsoft/TypeScript/pull/37348#issuecomment-597887639
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37348
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Mar 11, 2020https://github.com/microsoft/TypeScript/pull/37348#issuecomment-597846053
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37348
Wesley Wigham (@weswigham)https://github.com/weswigham
c7f54d5https://github.com/microsoft/TypeScript/commit/c7f54d594b4e24913e552e16c6e0e8485fdf2cca
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=67749
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37348
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Mar 11, 2020https://github.com/microsoft/TypeScript/pull/37348#issuecomment-597846054
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37348
Wesley Wigham (@weswigham)https://github.com/weswigham
c7f54d5https://github.com/microsoft/TypeScript/commit/c7f54d594b4e24913e552e16c6e0e8485fdf2cca
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=67747
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37348
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Mar 11, 2020https://github.com/microsoft/TypeScript/pull/37348#issuecomment-597846056
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37348
Wesley Wigham (@weswigham)https://github.com/weswigham
c7f54d5https://github.com/microsoft/TypeScript/commit/c7f54d594b4e24913e552e16c6e0e8485fdf2cca
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=67748
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37348
https://github.com/weswigham
Align commentshttps://github.com/microsoft/TypeScript/pull/37348/commits/5ba49ef8012c38ed23c26fd9d79a8776e308175b
5ba49efhttps://github.com/microsoft/TypeScript/pull/37348/commits/5ba49ef8012c38ed23c26fd9d79a8776e308175b
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Andrew Branch (andrewbranch)https://github.com/andrewbranch
March 11, 2020 20:30https://github.com/microsoft/TypeScript/pull/37348#event-3120405258
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Mar 11, 2020https://github.com/microsoft/TypeScript/pull/37348#issuecomment-597887639
Wesley Wigham (@weswigham)https://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37348
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Mar 11, 2020https://github.com/microsoft/TypeScript/pull/37348#issuecomment-597890716
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37348
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Mar 13, 2020 https://github.com/microsoft/TypeScript/pull/37348#pullrequestreview-374500415
View reviewed changes https://github.com/microsoft/TypeScript/pull/37348/files/5ba49ef8012c38ed23c26fd9d79a8776e308175b
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
47b60echttps://github.com/microsoft/TypeScript/commit/47b60ece0baddaa7e354881cd537a61335b200d6
Mar 13, 2020https://github.com/microsoft/TypeScript/pull/37348#event-3127705949
https://github.com/jcalz
Joe Calzaretta (jcalz)https://github.com/jcalz
Jul 26, 2024 https://github.com/microsoft/TypeScript/pull/37348#ref-issue-2432466428
A strange behavior when checking extends ReadonlyArray #59430 https://github.com/microsoft/TypeScript/issues/59430
https://github.com/jcalz
Joe Calzaretta (jcalz)https://github.com/jcalz
Aug 14, 2024 https://github.com/microsoft/TypeScript/pull/37348#ref-issue-2465492405
Unexpected any when using conditional type #59630 https://github.com/microsoft/TypeScript/issues/59630
https://github.com/LukeAbby
LukeAbbyhttps://github.com/LukeAbby
Nov 23, 2024 https://github.com/microsoft/TypeScript/pull/37348#ref-issue-2685114037
Type Instantiation is Excessively Deep Error Regression in #37348 #60567 https://github.com/microsoft/TypeScript/issues/60567
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/37348#event-20416905431
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F37348
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg) https://github.com/ahejlsberg
https://github.com/microsoft/TypeScript/pull/37348/files/5ba49ef8012c38ed23c26fd9d79a8776e308175b
https://github.com/andrewbranch
Andrew Branch (andrewbranch) https://github.com/andrewbranch
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37348
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
Conditional type *without union* behaves differently when inlined https://github.com/microsoft/TypeScript/issues/36135
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37348
https://github.com/weswigham
https://github.com/typescript-bot
https://github.com/ahejlsberg
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.