René's URL Explorer Experiment


Title: Allow nested conditionals to be related via constraints by weswigham · Pull Request #37208 · microsoft/TypeScript · GitHub

Open Graph Title: Allow nested conditionals to be related via constraints by weswigham · Pull Request #37208 · microsoft/TypeScript

X Title: Allow nested conditionals to be related via constraints by weswigham · Pull Request #37208 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Allow nested conditionals to be related via constraints by weswigham · Pull Request #37208 · microsoft/TypeScript

Open Graph Description: Fixes #30706 This allows a conditional to be related to another conditional via constraint. This means, notably, that conditionals which resolve to ? X : never should now be assignable to X, where ...

X Description: Fixes #30706 This allows a conditional to be related to another conditional via constraint. This means, notably, that conditionals which resolve to ? X : never should now be assignable to X, where ...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/37208

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6c99cfdb-0635-fcaa-0a92-45e10f947c32
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8282:19AA62:11BAAC4:168F6AB:6B011B5A
html-safe-nonceba29f1102b406d7a6a7b692c520b39e1c83827b4d2d2218fd4df911184c03927
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjgyOjE5QUE2MjoxMUJBQUM0OjE2OEY2QUI6NkIwMTFCNUEiLCJ2aXNpdG9yX2lkIjoiMTgyNzY2MjU2NTExNTc2MzU0NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2b7ad365a57add7e721f56750d1f0a77435128cc24bd38738c2aa7b79f115423
hovercard-subject-tagpull_request:383502674
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/37208/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d893623744b5d269c0ef8ffbf21adedab45cda0635e6cba5229e1ceaf158de2a/microsoft/TypeScript/pull/37208
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d893623744b5d269c0ef8ffbf21adedab45cda0635e6cba5229e1ceaf158de2a/microsoft/TypeScript/pull/37208
og:image:altFixes #30706 This allows a conditional to be related to another conditional via constraint. This means, notably, that conditionals which resolve to ? X : never should now be assignable to X, where ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameweswigham
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/37208#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F37208
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F37208
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/37208
Reloadhttps://github.com/microsoft/TypeScript/pull/37208
Reloadhttps://github.com/microsoft/TypeScript/pull/37208
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests310 (310)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
weswigham:loosen-conditional-assignabilityhttps://github.com/weswigham/TypeScript/tree/loosen-conditional-assignability
Conversationhttps://github.com/microsoft/TypeScript/pull/37208
Commits3 (3)https://github.com/microsoft/TypeScript/pull/37208/commits
Checkshttps://github.com/microsoft/TypeScript/pull/37208/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/37208/files
Allow nested conditionals to be related via constraintshttps://github.com/microsoft/TypeScript/pull/37208#top
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
weswigham:loosen-conditional-assignabilityhttps://github.com/weswigham/TypeScript/tree/loosen-conditional-assignability
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Mar 4, 2020https://github.com/microsoft/TypeScript/pull/37208#issue-575337161
#30706https://github.com/microsoft/TypeScript/issues/30706
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37208
https://github.com/weswigham
Allow nested conditionals to be related via constraintshttps://github.com/microsoft/TypeScript/pull/37208/commits/b554a2f4a9ee24bd3de81710e1719cd830b7ac97
b554a2fhttps://github.com/microsoft/TypeScript/pull/37208/commits/b554a2f4a9ee24bd3de81710e1719cd830b7ac97
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
March 4, 2020 11:44https://github.com/microsoft/TypeScript/pull/37208#event-3096132752
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Wesley Wigham (weswigham)https://github.com/weswigham
Mar 4, 2020https://github.com/microsoft/TypeScript/pull/37208#event-3096132908
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
Mar 4, 2020https://github.com/microsoft/TypeScript/pull/37208#event-3096133012
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Mar 4, 2020https://github.com/microsoft/TypeScript/pull/37208#issuecomment-594474287
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37208
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Mar 4, 2020https://github.com/microsoft/TypeScript/pull/37208#issuecomment-594474315
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37208
Wesley Wigham (@weswigham)https://github.com/weswigham
b554a2fhttps://github.com/microsoft/TypeScript/commit/b554a2f4a9ee24bd3de81710e1719cd830b7ac97
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=67077
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37208
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Mar 4, 2020https://github.com/microsoft/TypeScript/pull/37208#issuecomment-594474316
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37208
Wesley Wigham (@weswigham)https://github.com/weswigham
b554a2fhttps://github.com/microsoft/TypeScript/commit/b554a2f4a9ee24bd3de81710e1719cd830b7ac97
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=67075
The results are in!https://github.com/microsoft/TypeScript/pull/37208#issuecomment-594489318
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37208
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Mar 4, 2020https://github.com/microsoft/TypeScript/pull/37208#issuecomment-594474318
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37208
Wesley Wigham (@weswigham)https://github.com/weswigham
b554a2fhttps://github.com/microsoft/TypeScript/commit/b554a2f4a9ee24bd3de81710e1719cd830b7ac97
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=67074
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37208
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Mar 4, 2020https://github.com/microsoft/TypeScript/pull/37208#issuecomment-594474320
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37208
Wesley Wigham (@weswigham)https://github.com/weswigham
b554a2fhttps://github.com/microsoft/TypeScript/commit/b554a2f4a9ee24bd3de81710e1719cd830b7ac97
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=67076
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37208
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Mar 4, 2020 https://github.com/microsoft/TypeScript/pull/37208#ref-issue-428314198
NonNullable> can't be assigned to ConditionalType with --strictNullChecks #30706 https://github.com/microsoft/TypeScript/issues/30706
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Mar 4, 2020 https://github.com/microsoft/TypeScript/pull/37208#ref-pullrequest-575355428
🤖 User test baselines have changed for loosen-conditional-assignability weswigham/TypeScript#63 https://github.com/weswigham/TypeScript/pull/63
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Mar 4, 2020https://github.com/microsoft/TypeScript/pull/37208#issuecomment-594486870
PR with the baseline diff from masterhttps://github.com/weswigham/TypeScript/pull/63
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37208
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Mar 4, 2020https://github.com/microsoft/TypeScript/pull/37208#issuecomment-594489318
Wesley Wigham (@weswigham)https://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37208
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Mar 4, 2020https://github.com/microsoft/TypeScript/pull/37208#issuecomment-594519739
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37208
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Mar 10, 2020 https://github.com/microsoft/TypeScript/pull/37208#ref-pullrequest-539382702
Type comparison when conditional type is target #35741 https://github.com/microsoft/TypeScript/pull/35741
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Mar 19, 2020 https://github.com/microsoft/TypeScript/pull/37208#pullrequestreview-377928908
View reviewed changes https://github.com/microsoft/TypeScript/pull/37208/files/b554a2f4a9ee24bd3de81710e1719cd830b7ac97
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/37208/files/b554a2f4a9ee24bd3de81710e1719cd830b7ac97#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Mar 19, 2020https://github.com/microsoft/TypeScript/pull/37208#discussion_r395189042
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37208
Wesley Wigham (weswigham)https://github.com/weswigham
Mar 19, 2020https://github.com/microsoft/TypeScript/pull/37208#discussion_r395210957
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37208
Wesley Wigham (weswigham)https://github.com/weswigham
March 19, 2020 11:42https://github.com/microsoft/TypeScript/pull/37208#commits-pushed-31f4c93
https://github.com/weswigham
Delete word in commenthttps://github.com/microsoft/TypeScript/pull/37208/commits/31f4c93e3361f7b93421c583276f96e68ba3ad6a
31f4c93https://github.com/microsoft/TypeScript/pull/37208/commits/31f4c93e3361f7b93421c583276f96e68ba3ad6a
https://github.com/weswigham
Merge branch 'master' into loosen-conditional-assignabilityhttps://github.com/microsoft/TypeScript/pull/37208/commits/8327b894261f207ce9ea28197eed31a6de5b8c49
8327b89https://github.com/microsoft/TypeScript/pull/37208/commits/8327b894261f207ce9ea28197eed31a6de5b8c49
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
c513a4ahttps://github.com/microsoft/TypeScript/commit/c513a4adeac46858f81cf62a7afb30f105fbc8ca
Mar 19, 2020https://github.com/microsoft/TypeScript/pull/37208#event-3146893298
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Sep 1, 2021 https://github.com/microsoft/TypeScript/pull/37208#ref-issue-984602060
Recursive types error: Type instantiation is excessively deep #45672 https://github.com/microsoft/TypeScript/issues/45672
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/37208#event-20416900704
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F37208
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg) https://github.com/ahejlsberg
https://github.com/microsoft/TypeScript/pull/37208/files/b554a2f4a9ee24bd3de81710e1719cd830b7ac97
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37208
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
NonNullable> can't be assigned to ConditionalType with --strictNullChecks https://github.com/microsoft/TypeScript/issues/30706
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/37208
https://github.com/weswigham
https://github.com/typescript-bot
https://github.com/ahejlsberg
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.