René's URL Explorer Experiment


Title: Avoid expensive relationship checking in mapped type member resolution by ahejlsberg · Pull Request #36754 · microsoft/TypeScript · GitHub

Open Graph Title: Avoid expensive relationship checking in mapped type member resolution by ahejlsberg · Pull Request #36754 · microsoft/TypeScript

X Title: Avoid expensive relationship checking in mapped type member resolution by ahejlsberg · Pull Request #36754 · microsoft/TypeScript

Description: This PR removes an expensive isTypeAssignableTo check from mapped type member resolution and replaces it with a shallower maybeTypeOfKind. The full relationship check can generate a lot of work exp...

Open Graph Description: This PR removes an expensive isTypeAssignableTo check from mapped type member resolution and replaces it with a shallower maybeTypeOfKind. The full relationship check can generate a lot of work exp...

X Description: This PR removes an expensive isTypeAssignableTo check from mapped type member resolution and replaces it with a shallower maybeTypeOfKind. The full relationship check can generate a lot of work exp...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/36754

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fe41d2e9-c56d-e957-606c-6f901f7ab17b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD258:16F07B:224CEFF:2F51335:6964CD68
html-safe-nonce46ade33e10218994cf77580eb850e3fd1336905d077c3ca0d06b39822c985e9a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjU4OjE2RjA3QjoyMjRDRUZGOjJGNTEzMzU6Njk2NENENjgiLCJ2aXNpdG9yX2lkIjoiMjQxNjcxMTI4NjcxNjE1NzI4OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb291c97940fca144e354566a72a67b246e7ce24d842e4e28b9442c5c2b349836
hovercard-subject-tagpull_request:374426926
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/36754/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0c5596c435a394a6f6000cdae4e3237868e5bb807aea1fd306f9765498991646/microsoft/TypeScript/pull/36754
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0c5596c435a394a6f6000cdae4e3237868e5bb807aea1fd306f9765498991646/microsoft/TypeScript/pull/36754
og:image:altThis PR removes an expensive isTypeAssignableTo check from mapped type member resolution and replaces it with a shallower maybeTypeOfKind. The full relationship check can generate a lot of work exp...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameahejlsberg
hostnamegithub.com
expected-hostnamegithub.com
None5838582163a1256e5ebd5086b7e1dc5cea93d82086c9c8b1395fb50f6ddab28d
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8f997e7f84bd1db9537ba403fa68be0da3423594
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/36754#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F36754
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F36754
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/36754
Reloadhttps://github.com/microsoft/TypeScript/pull/36754
Reloadhttps://github.com/microsoft/TypeScript/pull/36754
microsoft https://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Notifications https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Fork 13.2k https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Star 107k https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Code https://github.com/microsoft/TypeScript
Issues 5k https://github.com/microsoft/TypeScript/issues
Pull requests 496 https://github.com/microsoft/TypeScript/pulls
Actions https://github.com/microsoft/TypeScript/actions
Projects 1 https://github.com/microsoft/TypeScript/projects
Models https://github.com/microsoft/TypeScript/models
Wiki https://github.com/microsoft/TypeScript/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/microsoft/TypeScript/security
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36754
Insights https://github.com/microsoft/TypeScript/pulse
Code https://github.com/microsoft/TypeScript
Issues https://github.com/microsoft/TypeScript/issues
Pull requests https://github.com/microsoft/TypeScript/pulls
Actions https://github.com/microsoft/TypeScript/actions
Projects https://github.com/microsoft/TypeScript/projects
Models https://github.com/microsoft/TypeScript/models
Wiki https://github.com/microsoft/TypeScript/wiki
Security https://github.com/microsoft/TypeScript/security
Insights https://github.com/microsoft/TypeScript/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmicrosoft%2FTypeScript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmicrosoft%2FTypeScript%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/microsoft/TypeScript/pull/36754#issue-comment-box
ahejlsberghttps://github.com/ahejlsberg
masterhttps://github.com/microsoft/TypeScript/tree/master
mappedTypeMemberResolutionhttps://github.com/microsoft/TypeScript/tree/mappedTypeMemberResolution
Avoid expensive relationship checking in mapped type member resolution https://github.com/microsoft/TypeScript/pull/36754#top
ahejlsberghttps://github.com/ahejlsberg
masterhttps://github.com/microsoft/TypeScript/tree/master
mappedTypeMemberResolutionhttps://github.com/microsoft/TypeScript/tree/mappedTypeMemberResolution
Conversation 17 https://github.com/microsoft/TypeScript/pull/36754
Commits 2 https://github.com/microsoft/TypeScript/pull/36754/commits
Checks 0 https://github.com/microsoft/TypeScript/pull/36754/checks
Files changed https://github.com/microsoft/TypeScript/pull/36754/files
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36754
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
https://github.com/ahejlsberg
ahejlsberghttps://github.com/ahejlsberg
Feb 12, 2020https://github.com/microsoft/TypeScript/pull/36754#issue-564143804
#36564https://github.com/microsoft/TypeScript/issues/36564
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36754
https://github.com/ahejlsberg
Avoid expensive relationship checking in mapped type member resolutionhttps://github.com/microsoft/TypeScript/pull/36754/commits/868b7b9ec382fa18079af781d90e679298495d7d
868b7b9https://github.com/microsoft/TypeScript/pull/36754/commits/868b7b9ec382fa18079af781d90e679298495d7d
https://github.com/ahejlsberg
ahejlsberghttps://github.com/ahejlsberg
Feb 12, 2020https://github.com/microsoft/TypeScript/pull/36754#issuecomment-585313571
@typescript-bothttps://github.com/typescript-bot
@typescript-bothttps://github.com/typescript-bot
@typescript-bothttps://github.com/typescript-bot
@typescript-bothttps://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36754
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
Feb 12, 2020https://github.com/microsoft/TypeScript/pull/36754#issuecomment-585313600
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36754
@ahejlsberghttps://github.com/ahejlsberg
868b7b9https://github.com/microsoft/TypeScript/commit/868b7b9ec382fa18079af781d90e679298495d7d
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=64235
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36754
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
Feb 12, 2020https://github.com/microsoft/TypeScript/pull/36754#issuecomment-585313601
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36754
@ahejlsberghttps://github.com/ahejlsberg
868b7b9https://github.com/microsoft/TypeScript/commit/868b7b9ec382fa18079af781d90e679298495d7d
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=64236
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36754
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
Feb 12, 2020https://github.com/microsoft/TypeScript/pull/36754#issuecomment-585313602
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36754
@ahejlsberghttps://github.com/ahejlsberg
868b7b9https://github.com/microsoft/TypeScript/commit/868b7b9ec382fa18079af781d90e679298495d7d
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=64234
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36754
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
Feb 12, 2020https://github.com/microsoft/TypeScript/pull/36754#issuecomment-585313605
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36754
@ahejlsberghttps://github.com/ahejlsberg
868b7b9https://github.com/microsoft/TypeScript/commit/868b7b9ec382fa18079af781d90e679298495d7d
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=64237
The results are in!https://github.com/microsoft/TypeScript/pull/36754#issuecomment-585324413
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36754
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
Feb 12, 2020https://github.com/microsoft/TypeScript/pull/36754#issuecomment-585324413
@ahejlsberghttps://github.com/ahejlsberg
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36754
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
Feb 12, 2020 https://github.com/microsoft/TypeScript/pull/36754#ref-pullrequest-564163086
🤖 User test baselines have changed for mappedTypeMemberResolution #36755 https://github.com/microsoft/TypeScript/pull/36755
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
Feb 12, 2020https://github.com/microsoft/TypeScript/pull/36754#issuecomment-585330301
PR with the baseline diff from masterhttps://github.com/microsoft/TypeScript/pull/36755
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36754
https://github.com/ahejlsberg
Accept new baselineshttps://github.com/microsoft/TypeScript/pull/36754/commits/283118cf970f0f10fdedebcc4dd7eaa121efbe05
283118chttps://github.com/microsoft/TypeScript/pull/36754/commits/283118cf970f0f10fdedebcc4dd7eaa121efbe05
https://github.com/ahejlsberg
ahejlsberghttps://github.com/ahejlsberg
Feb 12, 2020https://github.com/microsoft/TypeScript/pull/36754#issuecomment-585375636
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36754
https://github.com/ahejlsberg
ahejlsberghttps://github.com/ahejlsberg
Feb 12, 2020https://github.com/microsoft/TypeScript/pull/36754#issuecomment-585376401
@amcaseyhttps://github.com/amcasey
@RyanCavanaughhttps://github.com/RyanCavanaugh
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36754
https://github.com/weswigham
weswighamhttps://github.com/weswigham
Feb 12, 2020 https://github.com/microsoft/TypeScript/pull/36754#pullrequestreview-357802957
View reviewed changes https://github.com/microsoft/TypeScript/pull/36754/files/283118cf970f0f10fdedebcc4dd7eaa121efbe05
tests/baselines/reference/definiteAssignmentOfDestructuredVariable.typeshttps://github.com/microsoft/TypeScript/pull/36754/files/283118cf970f0f10fdedebcc4dd7eaa121efbe05#diff-52c3ef02f81aad04d9027cd78edbf748a6ee3eb0d8b043f990f018f818863393
weswighamhttps://github.com/weswigham
Feb 12, 2020https://github.com/microsoft/TypeScript/pull/36754#discussion_r378524728
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36754
ahejlsberghttps://github.com/ahejlsberg
Feb 12, 2020https://github.com/microsoft/TypeScript/pull/36754#discussion_r378536281
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36754
weswighamhttps://github.com/weswigham
Feb 12, 2020https://github.com/microsoft/TypeScript/pull/36754#discussion_r378537846
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36754
https://github.com/weswigham
weswighamhttps://github.com/weswigham
Feb 12, 2020 https://github.com/microsoft/TypeScript/pull/36754#pullrequestreview-357807815
View reviewed changes https://github.com/microsoft/TypeScript/pull/36754/files/283118cf970f0f10fdedebcc4dd7eaa121efbe05
weswighamhttps://github.com/weswigham
https://github.com/microsoft/TypeScript/pull/36754#pullrequestreview-357807815
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36754
https://github.com/ahejlsberg
ahejlsberghttps://github.com/ahejlsberg
Feb 12, 2020https://github.com/microsoft/TypeScript/pull/36754#issuecomment-585441436
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36754
#36564https://github.com/microsoft/TypeScript/issues/36564
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36754
https://github.com/amcasey
amcaseyhttps://github.com/amcasey
Feb 12, 2020 https://github.com/microsoft/TypeScript/pull/36754#pullrequestreview-357835970
View reviewed changes https://github.com/microsoft/TypeScript/pull/36754/files/283118cf970f0f10fdedebcc4dd7eaa121efbe05
amcaseyhttps://github.com/amcasey
https://github.com/microsoft/TypeScript/pull/36754#pullrequestreview-357835970
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36754
https://github.com/amcasey
amcaseyhttps://github.com/amcasey
Feb 12, 2020https://github.com/microsoft/TypeScript/pull/36754#issuecomment-585451084
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36754
https://github.com/amcasey
amcaseyhttps://github.com/amcasey
Feb 12, 2020 https://github.com/microsoft/TypeScript/pull/36754#ref-issue-546029843
Can the typings be simplified to improve performance? mui/material-ui#19113 https://github.com/mui/material-ui/issues/19113
https://github.com/ahejlsberg
ahejlsberghttps://github.com/ahejlsberg
Feb 12, 2020https://github.com/microsoft/TypeScript/pull/36754#issuecomment-585462611
@amcaseyhttps://github.com/amcasey
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36754
https://github.com/ahejlsberg
ahejlsberghttps://github.com/ahejlsberg
7a1c5b7https://github.com/microsoft/TypeScript/commit/7a1c5b7a20886d7e08e03fa333e078f29f400ca5
Feb 12, 2020https://github.com/microsoft/TypeScript/pull/36754#event-3032800341
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 14, 2022 https://github.com/microsoft/TypeScript/pull/36754#ref-pullrequest-1338149347
Remove span tag in title and unnecessary TOC in Ko microsoft/TypeScript-Website-Localizations#164 https://github.com/microsoft/TypeScript-Website-Localizations/pull/164
https://github.com/jakebailey
jakebaileyhttps://github.com/jakebailey
November 7, 2022 17:35https://github.com/microsoft/TypeScript/pull/36754#event-7754887230
https://github.com/microsoft
microsofthttps://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/36754#event-20416885158
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
ahejlsberghttps://github.com/ahejlsberg
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/36754#event-20416885558
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F36754
https://github.com/weswigham
weswigham https://github.com/weswigham
https://github.com/microsoft/TypeScript/pull/36754/files/283118cf970f0f10fdedebcc4dd7eaa121efbe05
https://github.com/amcasey
amcasey https://github.com/amcasey
https://github.com/microsoft/TypeScript/pull/36754/files/283118cf970f0f10fdedebcc4dd7eaa121efbe05
https://github.com/ahejlsberg
ahejlsberg https://github.com/ahejlsberg
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36754
https://github.com/ahejlsberg
https://github.com/typescript-bot
https://github.com/amcasey
https://github.com/weswigham
https://github.com/apps/copilot-swe-agent
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.