René's URL Explorer Experiment


Title: Cache results of isGenericObjectType and isGenericIndexType by ahejlsberg · Pull Request #36622 · microsoft/TypeScript · GitHub

Open Graph Title: Cache results of isGenericObjectType and isGenericIndexType by ahejlsberg · Pull Request #36622 · microsoft/TypeScript

X Title: Cache results of isGenericObjectType and isGenericIndexType by ahejlsberg · Pull Request #36622 · microsoft/TypeScript

Description: With this PR we cache the results of isGenericObjectType and isGenericIndexType for unions and intersections. This improves total compile time of the repro in #36564 by about 6.5%.

Open Graph Description: With this PR we cache the results of isGenericObjectType and isGenericIndexType for unions and intersections. This improves total compile time of the repro in #36564 by about 6.5%.

X Description: With this PR we cache the results of isGenericObjectType and isGenericIndexType for unions and intersections. This improves total compile time of the repro in #36564 by about 6.5%.

Opengraph URL: https://github.com/microsoft/TypeScript/pull/36622

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8536eb8c-12c9-91e7-bbd4-a953f7e8bda8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBB7E:1721AF:1EC9E8E:2A56FC1:6964CAE8
html-safe-noncebd171c97cfc2ad8e8e360508b9ffd815f3e632f020cf89a5eb8e8d1fc21acd59
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjdFOjE3MjFBRjoxRUM5RThFOjJBNTZGQzE6Njk2NENBRTgiLCJ2aXNpdG9yX2lkIjoiOTIwOTM0NzY1MDgwNjAzOTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3656546457f65bd2ca38617979ae9165518a276a3c731fcf307fe2c7b6ea9d57
hovercard-subject-tagpull_request:371142724
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/36622/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3bc64d0a753a27bf7ca4bebf8ba088ae4421517ebd8a67c69595985c71973c28/microsoft/TypeScript/pull/36622
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3bc64d0a753a27bf7ca4bebf8ba088ae4421517ebd8a67c69595985c71973c28/microsoft/TypeScript/pull/36622
og:image:altWith this PR we cache the results of isGenericObjectType and isGenericIndexType for unions and intersections. This improves total compile time of the repro in #36564 by about 6.5%.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameahejlsberg
hostnamegithub.com
expected-hostnamegithub.com
None5838582163a1256e5ebd5086b7e1dc5cea93d82086c9c8b1395fb50f6ddab28d
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8f997e7f84bd1db9537ba403fa68be0da3423594
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/36622#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F36622
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F36622
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/36622
Reloadhttps://github.com/microsoft/TypeScript/pull/36622
Reloadhttps://github.com/microsoft/TypeScript/pull/36622
microsoft https://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Notifications https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Fork 13.2k https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Star 107k https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Code https://github.com/microsoft/TypeScript
Issues 5k https://github.com/microsoft/TypeScript/issues
Pull requests 496 https://github.com/microsoft/TypeScript/pulls
Actions https://github.com/microsoft/TypeScript/actions
Projects 1 https://github.com/microsoft/TypeScript/projects
Models https://github.com/microsoft/TypeScript/models
Wiki https://github.com/microsoft/TypeScript/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/microsoft/TypeScript/security
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36622
Insights https://github.com/microsoft/TypeScript/pulse
Code https://github.com/microsoft/TypeScript
Issues https://github.com/microsoft/TypeScript/issues
Pull requests https://github.com/microsoft/TypeScript/pulls
Actions https://github.com/microsoft/TypeScript/actions
Projects https://github.com/microsoft/TypeScript/projects
Models https://github.com/microsoft/TypeScript/models
Wiki https://github.com/microsoft/TypeScript/wiki
Security https://github.com/microsoft/TypeScript/security
Insights https://github.com/microsoft/TypeScript/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmicrosoft%2FTypeScript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmicrosoft%2FTypeScript%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/microsoft/TypeScript/pull/36622#issue-comment-box
ahejlsberghttps://github.com/ahejlsberg
masterhttps://github.com/microsoft/TypeScript/tree/master
optimizeGenericTypeCheckhttps://github.com/microsoft/TypeScript/tree/optimizeGenericTypeCheck
Cache results of isGenericObjectType and isGenericIndexType https://github.com/microsoft/TypeScript/pull/36622#top
ahejlsberghttps://github.com/ahejlsberg
masterhttps://github.com/microsoft/TypeScript/tree/master
optimizeGenericTypeCheckhttps://github.com/microsoft/TypeScript/tree/optimizeGenericTypeCheck
Conversation 6 https://github.com/microsoft/TypeScript/pull/36622
Commits 1 https://github.com/microsoft/TypeScript/pull/36622/commits
Checks 0 https://github.com/microsoft/TypeScript/pull/36622/checks
Files changed https://github.com/microsoft/TypeScript/pull/36622/files
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36622
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
https://github.com/ahejlsberg
ahejlsberghttps://github.com/ahejlsberg
Feb 5, 2020https://github.com/microsoft/TypeScript/pull/36622#issue-560089036
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36622
#36564https://github.com/microsoft/TypeScript/issues/36564
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36622
https://github.com/ahejlsberg
Cache results of isGenericObjectType and isGenericIndexTypehttps://github.com/microsoft/TypeScript/pull/36622/commits/a0546fc1f709afbbfb459b6496db438bb39f8b7e
a0546fchttps://github.com/microsoft/TypeScript/pull/36622/commits/a0546fc1f709afbbfb459b6496db438bb39f8b7e
https://github.com/ahejlsberg
ahejlsberghttps://github.com/ahejlsberg
Feb 5, 2020https://github.com/microsoft/TypeScript/pull/36622#issuecomment-582201170
@typescript-bothttps://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36622
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
Feb 5, 2020https://github.com/microsoft/TypeScript/pull/36622#issuecomment-582201181
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36622
@ahejlsberghttps://github.com/ahejlsberg
a0546fchttps://github.com/microsoft/TypeScript/commit/a0546fc1f709afbbfb459b6496db438bb39f8b7e
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=63319
The results are in!https://github.com/microsoft/TypeScript/pull/36622#issuecomment-582206664
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36622
https://github.com/ahejlsberg
ahejlsberghttps://github.com/ahejlsberg
amcaseyhttps://github.com/amcasey
February 5, 2020 01:46https://github.com/microsoft/TypeScript/pull/36622#event-3008349760
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
Feb 5, 2020https://github.com/microsoft/TypeScript/pull/36622#issuecomment-582206664
@ahejlsberghttps://github.com/ahejlsberg
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36622
https://github.com/ahejlsberg
ahejlsberghttps://github.com/ahejlsberg
RyanCavanaughhttps://github.com/RyanCavanaugh
February 5, 2020 18:23https://github.com/microsoft/TypeScript/pull/36622#event-3011095063
https://github.com/RyanCavanaugh
RyanCavanaughhttps://github.com/RyanCavanaugh
Feb 5, 2020 https://github.com/microsoft/TypeScript/pull/36622#pullrequestreview-354078854
View reviewed changes https://github.com/microsoft/TypeScript/pull/36622/files/a0546fc1f709afbbfb459b6496db438bb39f8b7e
https://github.com/ahejlsberg
ahejlsberghttps://github.com/ahejlsberg
b8b5948https://github.com/microsoft/TypeScript/commit/b8b59489e1040c288d6cf4593bd561d14770bbe7
Feb 6, 2020https://github.com/microsoft/TypeScript/pull/36622#event-3012044105
https://github.com/amcasey
amcaseyhttps://github.com/amcasey
Feb 21, 2020https://github.com/microsoft/TypeScript/pull/36622#issuecomment-589463701
@ahejlsberghttps://github.com/ahejlsberg
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36622
https://github.com/ahejlsberg
ahejlsberghttps://github.com/ahejlsberg
Feb 21, 2020https://github.com/microsoft/TypeScript/pull/36622#issuecomment-589480667
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36622
https://github.com/amcasey
amcaseyhttps://github.com/amcasey
Feb 21, 2020https://github.com/microsoft/TypeScript/pull/36622#issuecomment-589788750
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36622
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36622
https://github.com/amcasey
amcaseyhttps://github.com/amcasey
Feb 21, 2020 https://github.com/microsoft/TypeScript/pull/36622#ref-pullrequest-569217987
Convert UnionOrIntersectionType.couldContainTypeVariables to ObjectFlags #36947 https://github.com/microsoft/TypeScript/pull/36947
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 14, 2022 https://github.com/microsoft/TypeScript/pull/36622#ref-pullrequest-1338149347
Remove span tag in title and unnecessary TOC in Ko microsoft/TypeScript-Website-Localizations#164 https://github.com/microsoft/TypeScript-Website-Localizations/pull/164
https://github.com/jakebailey
jakebaileyhttps://github.com/jakebailey
November 7, 2022 17:35https://github.com/microsoft/TypeScript/pull/36622#event-7754885926
https://github.com/microsoft
microsofthttps://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/36622#event-20416880947
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
ahejlsberghttps://github.com/ahejlsberg
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/36622#event-20416881368
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F36622
https://github.com/RyanCavanaugh
RyanCavanaugh https://github.com/RyanCavanaugh
https://github.com/microsoft/TypeScript/pull/36622/files/a0546fc1f709afbbfb459b6496db438bb39f8b7e
https://github.com/amcasey
amcasey https://github.com/amcasey
https://github.com/ahejlsberg
ahejlsberg https://github.com/ahejlsberg
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36622
https://github.com/ahejlsberg
https://github.com/typescript-bot
https://github.com/amcasey
https://github.com/RyanCavanaugh
https://github.com/apps/copilot-swe-agent
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.