René's URL Explorer Experiment


Title: Fix contextually typed object literal completions where the object being edited affects its own inference by andrewbranch · Pull Request #36556 · microsoft/TypeScript · GitHub

Open Graph Title: Fix contextually typed object literal completions where the object being edited affects its own inference by andrewbranch · Pull Request #36556 · microsoft/TypeScript

X Title: Fix contextually typed object literal completions where the object being edited affects its own inference by andrewbranch · Pull Request #36556 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Fix contextually typed object literal completions where the object being edited affects its own inference by andrewbranch · Pull Request #36556 · microsoft/TypeScript

Open Graph Description: This is Wes’s alternative to my PR #36364, which fixes #35702.

X Description: This is Wes’s alternative to my PR #36364, which fixes #35702.

Opengraph URL: https://github.com/microsoft/TypeScript/pull/36556

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7c5fb035-c601-abf9-1ed4-9ddb07afb36d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDB74:229B2E:133FB95:19684E9:6B011BD7
html-safe-nonceaf242cb731e6ced5e5a9367787de1a1ceb66e418a1a3ff3ff491976a8875c56a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjc0OjIyOUIyRToxMzNGQjk1OjE5Njg0RTk6NkIwMTFCRDciLCJ2aXNpdG9yX2lkIjoiNzY4MjQzMDQxNTI4OTc4NTMwMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac00f3ecb95bf5cf90a7f5020ba8fc4306575fa9d65785421f544ae0b3ed5f6902
hovercard-subject-tagpull_request:369787416
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/36556/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3fc964b939556e33db96f9e3ed00ee5c4bdfac7211be7c00ae8c7a292ac3efc0/microsoft/TypeScript/pull/36556
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3fc964b939556e33db96f9e3ed00ee5c4bdfac7211be7c00ae8c7a292ac3efc0/microsoft/TypeScript/pull/36556
og:image:altThis is Wes’s alternative to my PR #36364, which fixes #35702.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameandrewbranch
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/36556#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F36556
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F36556
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/36556
Reloadhttps://github.com/microsoft/TypeScript/pull/36556
Reloadhttps://github.com/microsoft/TypeScript/pull/36556
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests310 (310)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Andrew Branch (andrewbranch)https://github.com/andrewbranch
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
andrewbranch:bug/35702-2https://github.com/andrewbranch/TypeScript/tree/bug/35702-2
Conversationhttps://github.com/microsoft/TypeScript/pull/36556
Commits9 (9)https://github.com/microsoft/TypeScript/pull/36556/commits
Checkshttps://github.com/microsoft/TypeScript/pull/36556/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/36556/files
Fix contextually typed object literal completions where the object being edited affects its own inferencehttps://github.com/microsoft/TypeScript/pull/36556#top
Andrew Branch (andrewbranch)https://github.com/andrewbranch
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
andrewbranch:bug/35702-2https://github.com/andrewbranch/TypeScript/tree/bug/35702-2
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Jan 31, 2020https://github.com/microsoft/TypeScript/pull/36556#issue-558393485
#36364https://github.com/microsoft/TypeScript/pull/36364
#35702https://github.com/microsoft/TypeScript/issues/35702
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36556
Wesley Wigham (weswigham)https://github.com/weswigham
January 22, 2020 17:53https://github.com/microsoft/TypeScript/pull/36556#commits-pushed-d08ae97
https://github.com/weswigham
Conditionally elide a parameter from contextual type signature calcul…https://github.com/microsoft/TypeScript/pull/36556/commits/d08ae97ae0db20f84a813c41bcdc2ff390dd3677
d08ae97https://github.com/microsoft/TypeScript/pull/36556/commits/d08ae97ae0db20f84a813c41bcdc2ff390dd3677
https://github.com/weswigham
Slightly different approach to forbid inference to specific expressionshttps://github.com/microsoft/TypeScript/pull/36556/commits/d4848aa4dfd19bd7bf900c6629955ab8d936a0b8
d4848aahttps://github.com/microsoft/TypeScript/pull/36556/commits/d4848aa4dfd19bd7bf900c6629955ab8d936a0b8
https://github.com/weswigham
Merge branch 'master' into conditionally-elide-parameterhttps://github.com/microsoft/TypeScript/pull/36556/commits/dd62129afb94a45b006ab8ced4304ff10d6047ae
dd62129https://github.com/microsoft/TypeScript/pull/36556/commits/dd62129afb94a45b006ab8ced4304ff10d6047ae
https://github.com/weswigham
Handle nested literals and mapped types correctlyhttps://github.com/microsoft/TypeScript/pull/36556/commits/e4cf72f652d18f3e04bce9f28f572d74368c0420
e4cf72fhttps://github.com/microsoft/TypeScript/pull/36556/commits/e4cf72f652d18f3e04bce9f28f572d74368c0420
https://github.com/weswigham
Delete unused cachehttps://github.com/microsoft/TypeScript/pull/36556/commits/e7793c1175c6b524eaf07e7bf32d731edf4a1305
e7793c1https://github.com/microsoft/TypeScript/pull/36556/commits/e7793c1175c6b524eaf07e7bf32d731edf4a1305
https://github.com/andrewbranch
Rename ContextFlags.BaseConstraint and related usagehttps://github.com/microsoft/TypeScript/pull/36556/commits/1a011612a09cebfaa7934aefd196c798eb11dfb5
1a01161https://github.com/microsoft/TypeScript/pull/36556/commits/1a011612a09cebfaa7934aefd196c798eb11dfb5
https://github.com/andrewbranch
Add tests from my PRhttps://github.com/microsoft/TypeScript/pull/36556/commits/873e28756030418fed310151cbc271124b0e4274
873e287https://github.com/microsoft/TypeScript/pull/36556/commits/873e28756030418fed310151cbc271124b0e4274
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Jan 31, 2020https://github.com/microsoft/TypeScript/pull/36556#event-2998639386
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
Jan 31, 2020https://github.com/microsoft/TypeScript/pull/36556#event-2998639457
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
Wesley Wigham (weswigham)https://github.com/weswigham
January 31, 2020 21:55https://github.com/microsoft/TypeScript/pull/36556#event-2998639856
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Jan 31, 2020 https://github.com/microsoft/TypeScript/pull/36556#pullrequestreview-351810023
View reviewed changes https://github.com/microsoft/TypeScript/pull/36556/files/873e28756030418fed310151cbc271124b0e4274
tests/cases/fourslash/completionsGenericIndexedAccess6.tshttps://github.com/microsoft/TypeScript/pull/36556/files/873e28756030418fed310151cbc271124b0e4274#diff-53863fe2e3d648f7664eff908c5b161bfc08f19a583ef519aa100d6bf22359d0
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36556
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Jan 31, 2020 https://github.com/microsoft/TypeScript/pull/36556#pullrequestreview-351810176
View reviewed changes https://github.com/microsoft/TypeScript/pull/36556/files/873e28756030418fed310151cbc271124b0e4274
tests/cases/fourslash/completionsGenericIndexedAccess5.tshttps://github.com/microsoft/TypeScript/pull/36556/files/873e28756030418fed310151cbc271124b0e4274#diff-6dd03892198169238fd9d1c4cf0cfa00080c13255cf9e74b63b6735ef94eff46
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36556
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Jan 31, 2020 https://github.com/microsoft/TypeScript/pull/36556#pullrequestreview-351810476
View reviewed changes https://github.com/microsoft/TypeScript/pull/36556/files/873e28756030418fed310151cbc271124b0e4274
src/compiler/types.tshttps://github.com/microsoft/TypeScript/pull/36556/files/873e28756030418fed310151cbc271124b0e4274#diff-e9fd483341eea176a38fbd370590e1dc65ce2d9bf70bfd317c5407f04dba9560
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36556
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Jan 31, 2020 https://github.com/microsoft/TypeScript/pull/36556#pullrequestreview-351810601
View reviewed changes https://github.com/microsoft/TypeScript/pull/36556/files/873e28756030418fed310151cbc271124b0e4274
src/compiler/types.tshttps://github.com/microsoft/TypeScript/pull/36556/files/873e28756030418fed310151cbc271124b0e4274#diff-e9fd483341eea176a38fbd370590e1dc65ce2d9bf70bfd317c5407f04dba9560
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36556
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Jan 31, 2020 https://github.com/microsoft/TypeScript/pull/36556#pullrequestreview-351811493
View reviewed changes https://github.com/microsoft/TypeScript/pull/36556/files/873e28756030418fed310151cbc271124b0e4274
Wesley Wigham (weswigham)https://github.com/weswigham
https://github.com/microsoft/TypeScript/pull/36556#pullrequestreview-351811493
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36556
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jan 31, 2020 https://github.com/microsoft/TypeScript/pull/36556#pullrequestreview-351819746
View reviewed changes https://github.com/microsoft/TypeScript/pull/36556/files/873e28756030418fed310151cbc271124b0e4274
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
https://github.com/microsoft/TypeScript/pull/36556#pullrequestreview-351819746
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Wesley Wigham (@weswigham)https://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36556
Andrew Branch (andrewbranch)https://github.com/andrewbranch
January 31, 2020 15:03https://github.com/microsoft/TypeScript/pull/36556#commits-pushed-27d95a6
https://github.com/andrewbranch
https://github.com/weswigham
Update ContextFlags commenthttps://github.com/microsoft/TypeScript/pull/36556/commits/27d95a6de22370f1adeb7e126a744a3e7ee88587
27d95a6https://github.com/microsoft/TypeScript/pull/36556/commits/27d95a6de22370f1adeb7e126a744a3e7ee88587
https://github.com/andrewbranch
Update comments and fourslash triple slash refshttps://github.com/microsoft/TypeScript/pull/36556/commits/729f837f39e3d0ea7fe2fc37b3b822841a5d2e12
729f837https://github.com/microsoft/TypeScript/pull/36556/commits/729f837f39e3d0ea7fe2fc37b3b822841a5d2e12
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
ef8eb0chttps://github.com/microsoft/TypeScript/commit/ef8eb0c876ccb71211eb61044ddba09a4010e30a
Jan 31, 2020https://github.com/microsoft/TypeScript/pull/36556#event-2998845963
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Jan 31, 2020 https://github.com/microsoft/TypeScript/pull/36556#ref-pullrequest-553879059
Don’t mix in base constraint completions on indexed access types with type parameter index types #36364 https://github.com/microsoft/TypeScript/pull/36364
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Jul 7, 2020 https://github.com/microsoft/TypeScript/pull/36556#ref-issue-391013840
TSX files doesn't suggest component properties #29017 https://github.com/microsoft/TypeScript/issues/29017
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Nov 25, 2020 https://github.com/microsoft/TypeScript/pull/36556#ref-issue-748669805
Incorrect inference/autocompletion on generic arrays, when values can be inferred from a defined object. #41645 https://github.com/microsoft/TypeScript/issues/41645
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Mar 24, 2022 https://github.com/microsoft/TypeScript/pull/36556#ref-pullrequest-1180167394
Fix string literal completions when a partially-typed string fixes inference to a type parameter #48410 https://github.com/microsoft/TypeScript/pull/48410
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Feb 22, 2023 https://github.com/microsoft/TypeScript/pull/36556#ref-pullrequest-1592389288
Retry querying string completions from the inferred type if the original completions request doesn't return anything #52875 https://github.com/microsoft/TypeScript/pull/52875
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Jul 9, 2023 https://github.com/microsoft/TypeScript/pull/36556#ref-issue-512860549
Wrong completions for discriminated unions with generic index #34752 https://github.com/microsoft/TypeScript/issues/34752
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/36556#event-20416878366
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F36556
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
https://github.com/microsoft/TypeScript/pull/36556/files/729f837f39e3d0ea7fe2fc37b3b822841a5d2e12
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
https://github.com/microsoft/TypeScript/pull/36556/files/873e28756030418fed310151cbc271124b0e4274
https://github.com/sheetalkamat
Sheetal Nandi (sheetalkamat) https://github.com/sheetalkamat
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36556
https://github.com/andrewbranch
Andrew Branch (andrewbranch) https://github.com/andrewbranch
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
Properties in object literal key completion list aren't filtered when a prior argument supplies a mapped type key https://github.com/microsoft/TypeScript/issues/35702
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36556
https://github.com/andrewbranch
https://github.com/sandersn
https://github.com/weswigham
https://github.com/typescript-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.