René's URL Explorer Experiment


Title: Don’t mix in base constraint completions on indexed access types with type parameter index types by andrewbranch · Pull Request #36364 · microsoft/TypeScript · GitHub

Open Graph Title: Don’t mix in base constraint completions on indexed access types with type parameter index types by andrewbranch · Pull Request #36364 · microsoft/TypeScript

X Title: Don’t mix in base constraint completions on indexed access types with type parameter index types by andrewbranch · Pull Request #36364 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Don’t mix in base constraint completions on indexed access types with type parameter index types by andrewbranch · Pull Request #36364 · microsoft/TypeScript

Open Graph Description: Recall #30507, trying to get completions at a position like: function f<T extends { x?: string }>(p: T) {} f({ /**/ }); Since an empty object satisfies the constraint { x?: string }, T is in...

X Description: Recall #30507, trying to get completions at a position like: function f&lt;T extends { x?: string }&gt;(p: T) {} f({ /**/ }); Since an empty object satisfies the constraint { x?: string },...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/36364

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:96de70b2-05d9-0980-5208-9aa2f42e06a5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA96E:213839:12FE4FB:18637B8:6B0113A7
html-safe-noncefdbfe41bcbc7f1889cf584cd7076e193a7ee2bf53d5a9aabf31268ca0c8f12af
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTZFOjIxMzgzOToxMkZFNEZCOjE4NjM3Qjg6NkIwMTEzQTciLCJ2aXNpdG9yX2lkIjoiMzk1MjUwMTI2NzYwNzc2NjE1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0d4647dd6c7c6bd0eab69c3322c1639fc7a0c79928fb79034d6f2ee6b3638836
hovercard-subject-tagpull_request:366133425
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/36364/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e2c247ca85ba72e91ad484568950e1893f6974cb454256e6af55037f3347ff4a/microsoft/TypeScript/pull/36364
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e2c247ca85ba72e91ad484568950e1893f6974cb454256e6af55037f3347ff4a/microsoft/TypeScript/pull/36364
og:image:altRecall #30507, trying to get completions at a position like: function f<T extends { x?: string }>(p: T) {} f({ /**/ }); Since an empty object satisfies the constraint { x?: string }, T is in...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameandrewbranch
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/36364#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F36364
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F36364
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/36364
Reloadhttps://github.com/microsoft/TypeScript/pull/36364
Reloadhttps://github.com/microsoft/TypeScript/pull/36364
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests310 (310)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Andrew Branch (andrewbranch)https://github.com/andrewbranch
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
andrewbranch:bug/35702https://github.com/andrewbranch/TypeScript/tree/bug/35702
Conversationhttps://github.com/microsoft/TypeScript/pull/36364
Commits4 (4)https://github.com/microsoft/TypeScript/pull/36364/commits
Checkshttps://github.com/microsoft/TypeScript/pull/36364/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/36364/files
Don’t mix in base constraint completions on indexed access types with type parameter index typeshttps://github.com/microsoft/TypeScript/pull/36364#top
Andrew Branch (andrewbranch)https://github.com/andrewbranch
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
andrewbranch:bug/35702https://github.com/andrewbranch/TypeScript/tree/bug/35702
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Jan 23, 2020https://github.com/microsoft/TypeScript/pull/36364#issue-553879059
#30507https://github.com/microsoft/TypeScript/issues/30507
#32100https://github.com/microsoft/TypeScript/pull/32100
#33937https://github.com/microsoft/TypeScript/pull/33937
#34855https://github.com/microsoft/TypeScript/pull/34855
#35702https://github.com/microsoft/TypeScript/issues/35702
#36025https://github.com/microsoft/TypeScript/issues/36025
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36364
Andrew Branch (andrewbranch)https://github.com/andrewbranch
January 10, 2020 10:10https://github.com/microsoft/TypeScript/pull/36364#commits-pushed-2f798a5
https://github.com/andrewbranch
Exclude indexed access type object literal completions from mixing in…https://github.com/microsoft/TypeScript/pull/36364/commits/2f798a548c08f214de48d8988e13aee7585a3d4b
2f798a5https://github.com/microsoft/TypeScript/pull/36364/commits/2f798a548c08f214de48d8988e13aee7585a3d4b
https://github.com/andrewbranch
Walk index type structure a bit to find type parameter in ithttps://github.com/microsoft/TypeScript/pull/36364/commits/83ce8a4df526bf7ad650158f9fe2358ea1eca297
83ce8a4https://github.com/microsoft/TypeScript/pull/36364/commits/83ce8a4df526bf7ad650158f9fe2358ea1eca297
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Jan 23, 2020https://github.com/microsoft/TypeScript/pull/36364#event-2972117410
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
Jan 23, 2020https://github.com/microsoft/TypeScript/pull/36364#event-2972117447
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
Wesley Wigham (weswigham)https://github.com/weswigham
January 23, 2020 00:50https://github.com/microsoft/TypeScript/pull/36364#event-2972117629
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Jan 23, 2020https://github.com/microsoft/TypeScript/pull/36364#issuecomment-577456167
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36364
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jan 23, 2020https://github.com/microsoft/TypeScript/pull/36364#issuecomment-577456187
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36364
Daniel Rosenwasser (@DanielRosenwasser)https://github.com/DanielRosenwasser
83ce8a4https://github.com/microsoft/TypeScript/commit/83ce8a4df526bf7ad650158f9fe2358ea1eca297
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=61347
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36364
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Jan 23, 2020https://github.com/microsoft/TypeScript/pull/36364#issuecomment-577456300
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36364
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Jan 23, 2020https://github.com/microsoft/TypeScript/pull/36364#issuecomment-577456965
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36364
https://github.com/andrewbranch
Fix refactor typohttps://github.com/microsoft/TypeScript/pull/36364/commits/56fdf948756d9cf5e1f0d5d47bde8fbdb4430f4c
56fdf94https://github.com/microsoft/TypeScript/pull/36364/commits/56fdf948756d9cf5e1f0d5d47bde8fbdb4430f4c
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Jan 23, 2020https://github.com/microsoft/TypeScript/pull/36364#issuecomment-577460439
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36364
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36364
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Jan 23, 2020https://github.com/microsoft/TypeScript/pull/36364#issuecomment-577461529
Wesley Wigham (@weswigham)https://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36364
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Jan 23, 2020https://github.com/microsoft/TypeScript/pull/36364#issuecomment-577462234
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36364
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Jan 23, 2020https://github.com/microsoft/TypeScript/pull/36364#issuecomment-577462532
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36364
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Jan 23, 2020https://github.com/microsoft/TypeScript/pull/36364#issuecomment-577463459
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36364
https://github.com/andrewbranch
Also look past simple mapped typeshttps://github.com/microsoft/TypeScript/pull/36364/commits/28cfb4c7e6ee4c19d56b1e179e600f79666a123b
28cfb4chttps://github.com/microsoft/TypeScript/pull/36364/commits/28cfb4c7e6ee4c19d56b1e179e600f79666a123b
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Jan 23, 2020https://github.com/microsoft/TypeScript/pull/36364#issuecomment-577469069
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36364
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jan 23, 2020https://github.com/microsoft/TypeScript/pull/36364#issuecomment-577469083
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36364
Andrew Branch (@andrewbranch)https://github.com/andrewbranch
28cfb4chttps://github.com/microsoft/TypeScript/commit/28cfb4c7e6ee4c19d56b1e179e600f79666a123b
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=61358
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36364
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Jan 23, 2020https://github.com/microsoft/TypeScript/pull/36364#issuecomment-577469665
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36364
Andrew Branch (@andrewbranch)https://github.com/andrewbranch
herehttps://github.com/weswigham/TypeScript/commit/d08ae97ae0db20f84a813c41bcdc2ff390dd3677
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36364
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Jan 23, 2020https://github.com/microsoft/TypeScript/pull/36364#issuecomment-577817494
Wesley Wigham (@weswigham)https://github.com/weswigham
https://user-images.githubusercontent.com/3277153/73013363-0635ca80-3dcd-11ea-93ca-d0c7563bc028.png
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36364
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Jan 23, 2020https://github.com/microsoft/TypeScript/pull/36364#issuecomment-577827037
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36364
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Jan 23, 2020https://github.com/microsoft/TypeScript/pull/36364#issuecomment-577827986
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36364
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Jan 23, 2020https://github.com/microsoft/TypeScript/pull/36364#issuecomment-577828419
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36364
Andrew Branch (@andrewbranch)https://github.com/andrewbranch
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36364
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Jan 23, 2020https://github.com/microsoft/TypeScript/pull/36364#issuecomment-577871364
Andrew Branch (@andrewbranch)https://github.com/andrewbranch
herehttps://github.com/weswigham/TypeScript/commit/d4848aa4dfd19bd7bf900c6629955ab8d936a0b8
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36364
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Jan 27, 2020https://github.com/microsoft/TypeScript/pull/36364#issuecomment-578912203
Wesley Wigham (@weswigham)https://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36364
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jan 30, 2020https://github.com/microsoft/TypeScript/pull/36364#event-2995144308
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jan 30, 2020https://github.com/microsoft/TypeScript/pull/36364#event-2995168806
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Jan 30, 2020https://github.com/microsoft/TypeScript/pull/36364#issuecomment-580516064
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36364
is visible in the branch diff herehttps://github.com/microsoft/TypeScript/compare/master...weswigham:conditionally-elide-parameter
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36364
Fix contextually typed object literal completions where the object being edited affects its own inference #36555 https://github.com/microsoft/TypeScript/pull/36555
Fix contextually typed object literal completions where the object being edited affects its own inference #36556 https://github.com/microsoft/TypeScript/pull/36556
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Jan 31, 2020https://github.com/microsoft/TypeScript/pull/36364#issuecomment-580956878
#36556https://github.com/microsoft/TypeScript/pull/36556
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36364
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Jan 31, 2020https://github.com/microsoft/TypeScript/pull/36364#event-2998846505
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/36364#event-20416871957
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F36364
https://github.com/sheetalkamat
Sheetal Nandi (sheetalkamat) https://github.com/sheetalkamat
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) https://github.com/DanielRosenwasser
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36364
https://github.com/andrewbranch
Andrew Branch (andrewbranch) https://github.com/andrewbranch
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
Properties in object literal key completion list aren't filtered when a prior argument supplies a mapped type key https://github.com/microsoft/TypeScript/issues/35702
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36364
https://github.com/andrewbranch
https://github.com/DanielRosenwasser
https://github.com/typescript-bot
https://github.com/weswigham
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.