René's URL Explorer Experiment


Title: Remove CFA discriminant check restrictions by ahejlsberg · Pull Request #36114 · microsoft/TypeScript · GitHub

Open Graph Title: Remove CFA discriminant check restrictions by ahejlsberg · Pull Request #36114 · microsoft/TypeScript

X Title: Remove CFA discriminant check restrictions by ahejlsberg · Pull Request #36114 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Remove CFA discriminant check restrictions by ahejlsberg · Pull Request #36114 · microsoft/TypeScript

Open Graph Description: In #10028 we added logic to reset control flow analysis based types following discriminant checks. This logic was really only needed in scenarios involving loops, and it now appears unnecessary, li...

X Description: In #10028 we added logic to reset control flow analysis based types following discriminant checks. This logic was really only needed in scenarios involving loops, and it now appears unnecessary, li...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/36114

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:44ffaf67-f8f4-5374-0fd3-37fab0a74243
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDCA8:1D8AA1:10B48BC:1607609:6B0107F9
html-safe-nonce203841120d09290b46ad63947d5555be2ececcedd9cc7ce323cb1daee99d2316
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0E4OjFEOEFBMToxMEI0OEJDOjE2MDc2MDk6NkIwMTA3RjkiLCJ2aXNpdG9yX2lkIjoiMTkzMzI3MzQzNTgwNzQ4Mzg5NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac984e78016428b59648d4899235fefaba16f7e1e1cb243bb401a1b19de9f8e2a7
hovercard-subject-tagpull_request:361240582
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/36114/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/dc914f785913e33ff964b4435d551b3cb209f7fea078fdf012650e33725e9a94/microsoft/TypeScript/pull/36114
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dc914f785913e33ff964b4435d551b3cb209f7fea078fdf012650e33725e9a94/microsoft/TypeScript/pull/36114
og:image:altIn #10028 we added logic to reset control flow analysis based types following discriminant checks. This logic was really only needed in scenarios involving loops, and it now appears unnecessary, li...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameahejlsberg
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/36114#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F36114
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F36114
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/36114
Reloadhttps://github.com/microsoft/TypeScript/pull/36114
Reloadhttps://github.com/microsoft/TypeScript/pull/36114
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
masterhttps://github.com/microsoft/TypeScript/tree/master
fix36028https://github.com/microsoft/TypeScript/tree/fix36028
Conversationhttps://github.com/microsoft/TypeScript/pull/36114
Commits2 (2)https://github.com/microsoft/TypeScript/pull/36114/commits
Checkshttps://github.com/microsoft/TypeScript/pull/36114/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/36114/files
Remove CFA discriminant check restrictionshttps://github.com/microsoft/TypeScript/pull/36114#top
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
masterhttps://github.com/microsoft/TypeScript/tree/master
fix36028https://github.com/microsoft/TypeScript/tree/fix36028
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Jan 10, 2020https://github.com/microsoft/TypeScript/pull/36114#issue-547821707
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36114
#10028https://github.com/microsoft/TypeScript/pull/10028
ade89a6https://github.com/microsoft/TypeScript/commit/ade89a60327763ac09bc7083d1f9ffc9935682b1
#36028https://github.com/microsoft/TypeScript/issues/36028
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36114
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
January 9, 2020 17:51https://github.com/microsoft/TypeScript/pull/36114#commits-pushed-abe4323
https://github.com/ahejlsberg
Remove unnecessary containsMatchingReferenceDiscriminant logichttps://github.com/microsoft/TypeScript/pull/36114/commits/abe432399d8407987efadc977b1ae2654e5979f3
abe4323https://github.com/microsoft/TypeScript/pull/36114/commits/abe432399d8407987efadc977b1ae2654e5979f3
https://github.com/ahejlsberg
Accept new baselineshttps://github.com/microsoft/TypeScript/pull/36114/commits/766cb83f5aad7de57dd4e9c3857d837c8d18a399
766cb83https://github.com/microsoft/TypeScript/pull/36114/commits/766cb83f5aad7de57dd4e9c3857d837c8d18a399
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Jan 10, 2020https://github.com/microsoft/TypeScript/pull/36114#issuecomment-572839108
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36114
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jan 10, 2020https://github.com/microsoft/TypeScript/pull/36114#issuecomment-572839237
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36114
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
766cb83https://github.com/microsoft/TypeScript/commit/766cb83f5aad7de57dd4e9c3857d837c8d18a399
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=59927
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36114
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jan 10, 2020https://github.com/microsoft/TypeScript/pull/36114#issuecomment-572839238
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36114
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
766cb83https://github.com/microsoft/TypeScript/commit/766cb83f5aad7de57dd4e9c3857d837c8d18a399
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=59928
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36114
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jan 10, 2020https://github.com/microsoft/TypeScript/pull/36114#issuecomment-572839239
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36114
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
766cb83https://github.com/microsoft/TypeScript/commit/766cb83f5aad7de57dd4e9c3857d837c8d18a399
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=59929
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36114
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jan 10, 2020 https://github.com/microsoft/TypeScript/pull/36114#ref-pullrequest-547828331
🤖 User test baselines have changed for fix36028 #36115 https://github.com/microsoft/TypeScript/pull/36115
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jan 10, 2020https://github.com/microsoft/TypeScript/pull/36114#issuecomment-572844613
PR with the baseline diff from masterhttps://github.com/microsoft/TypeScript/pull/36115
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36114
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Jan 10, 2020https://github.com/microsoft/TypeScript/pull/36114#issuecomment-573060401
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36114
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Jan 10, 2020 https://github.com/microsoft/TypeScript/pull/36114#ref-issue-545749613
Strict null check flow analysis broken by unrelated branch logic #36028 https://github.com/microsoft/TypeScript/issues/36028
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
January 10, 2020 15:09https://github.com/microsoft/TypeScript/pull/36114#event-2938832592
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Jan 10, 2020 https://github.com/microsoft/TypeScript/pull/36114#pullrequestreview-341316067
View reviewed changes https://github.com/microsoft/TypeScript/pull/36114/files/766cb83f5aad7de57dd4e9c3857d837c8d18a399
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
94271aahttps://github.com/microsoft/TypeScript/commit/94271aa753184a5a294b4ed6c6f219109632d552
Jan 10, 2020https://github.com/microsoft/TypeScript/pull/36114#event-2939313389
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Jan 22, 2020 https://github.com/microsoft/TypeScript/pull/36114#ref-issue-261654969
Type guards on variable break refinements on its properties #18840 https://github.com/microsoft/TypeScript/issues/18840
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Feb 29, 2020 https://github.com/microsoft/TypeScript/pull/36114#ref-pullrequest-573365565
Remove ordering restrictions in control flow analysis #37134 https://github.com/microsoft/TypeScript/pull/37134
Wenlu Wang (Kingwl)https://github.com/Kingwl
Mar 4, 2020 https://github.com/microsoft/TypeScript/pull/36114#ref-commit-b48c2c5
https://github.com/ahejlsberg
https://github.com/Kingwl
Remove CFA discriminant check restrictions (https://github.com/Kingwl/TypeScript/commit/b48c2c5c72bd5f8ae2413db1b4a52de5554d1063
microsoft#36114https://github.com/microsoft/TypeScript/pull/36114
)https://github.com/Kingwl/TypeScript/commit/b48c2c5c72bd5f8ae2413db1b4a52de5554d1063
b48c2c5https://github.com/Kingwl/TypeScript/commit/b48c2c5c72bd5f8ae2413db1b4a52de5554d1063
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
November 7, 2022 17:34https://github.com/microsoft/TypeScript/pull/36114#event-7754884177
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/36114#event-20416863211
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F36114
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh) https://github.com/RyanCavanaugh
https://github.com/microsoft/TypeScript/pull/36114/files/766cb83f5aad7de57dd4e9c3857d837c8d18a399
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36114
Strict null check flow analysis broken by unrelated branch logic https://github.com/microsoft/TypeScript/issues/36028
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/36114
https://github.com/ahejlsberg
https://github.com/typescript-bot
https://github.com/RyanCavanaugh
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.