| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:0a0eb2db-2ad7-2bc8-7c75-b31eacaddc39 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DD7C:154D88:236A11:2CD872:6B00FEEB |
| html-safe-nonce | f5401b08f8d6e5ff056b17b859c8126424d272f7610853791ae7fc4772fadd8d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDdDOjE1NEQ4ODoyMzZBMTE6MkNEODcyOjZCMDBGRUVCIiwidmlzaXRvcl9pZCI6IjcyNDQ0NjY0NDExMzM1NTU0MzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | a72a23343f1ce750ef9b118f737db056354771a9cd407e9ff243a95b01edf9fc |
| hovercard-subject-tag | pull_request:360205715 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/microsoft/TypeScript/pull/36063/files |
| twitter:image | https://avatars.githubusercontent.com/u/9092011?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/9092011?s=400&v=4 |
| og:image:alt | Supersedes #36043.
Here, we add a property to identify completion entries generated from the name table of an unchecked file, so that consumers can handle them differently from type-checker-based c... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/microsoft/TypeScript/pull/36063/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F36063%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F36063%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/36063/files |
| Reload | https://github.com/microsoft/TypeScript/pull/36063/files |
| Reload | https://github.com/microsoft/TypeScript/pull/36063/files |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests309 (309) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fmicrosoft%2FTypeScript%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript%2Fissues%2Fnew%2Fchoose |
| Ben Lichtman (uniqueiniquity) | https://github.com/uniqueiniquity |
| microsoft:master | https://github.com/microsoft/TypeScript/tree/master |
| uniqueiniquity:addWeakCompletionProperty | https://github.com/uniqueiniquity/TypeScript/tree/addWeakCompletionProperty |
|
Conversation
1
| https://github.com/microsoft/TypeScript/pull/36063 |
|
Commits
4
| https://github.com/microsoft/TypeScript/pull/36063/commits |
|
Checks
0
| https://github.com/microsoft/TypeScript/pull/36063/checks |
|
Files changed
| https://github.com/microsoft/TypeScript/pull/36063/files |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/36063/files |
|
Add completion property to identify completions from unchecked files
| https://github.com/microsoft/TypeScript/pull/36063/files#top |
|
Show all changes
4 commits
| https://github.com/microsoft/TypeScript/pull/36063/files |
|
1bc3879
Add property for unchecked completions
Jan 7, 2020
| https://github.com/microsoft/TypeScript/pull/36063/commits/1bc387938ae3a2edf89f062301eac19eb0271daf |
|
49f7f25
Rename new property
Jan 7, 2020
| https://github.com/microsoft/TypeScript/pull/36063/commits/49f7f2532cd8c54b9d4da181b3b3c8c814740d7e |
|
509d243
Add test
Jan 7, 2020
| https://github.com/microsoft/TypeScript/pull/36063/commits/509d243ea51b48feb962c13c073b8841e8d9efef |
|
d59c6f3
Make unchecked property assertion optional
Jan 7, 2020
| https://github.com/microsoft/TypeScript/pull/36063/commits/d59c6f3e6ab4090d654d4c9b11cd6168160e7459 |
|
Clear filters
| https://github.com/microsoft/TypeScript/pull/36063/files |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/36063/files |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/36063/files |
|
fourslashImpl.ts
| https://github.com/microsoft/TypeScript/pull/36063/files#diff-68e0a0bdd65b7a9bb405747188b445f5836ab24070c3c06501a961d5d69c910b |
|
fourslashInterfaceImpl.ts
| https://github.com/microsoft/TypeScript/pull/36063/files#diff-e50795ce40036c1b331e25464a5d9da74a0f60af02bc56302eb9efe57b344b2d |
|
protocol.ts
| https://github.com/microsoft/TypeScript/pull/36063/files#diff-eb376d3ed604f5f596e7a34bcd6b1f851af61d3c22393ebf1b48da8f9976a32e |
|
completions.ts
| https://github.com/microsoft/TypeScript/pull/36063/files#diff-4237fd08a5f920543e184b7748bc8ae000d9b1c031810ba375b0053362ec2b6a |
|
types.ts
| https://github.com/microsoft/TypeScript/pull/36063/files#diff-9717eb6d935579eea3b5662088dd258d4e1e17e2a405c3f1fa431e981e01b08f |
|
tsserverlibrary.d.ts
| https://github.com/microsoft/TypeScript/pull/36063/files#diff-d7739d440630d907a34b93d1905164a6f8fe27d2cc9d84c58495d02c886652d8 |
|
typescript.d.ts
| https://github.com/microsoft/TypeScript/pull/36063/files#diff-dd6d044fa72b2a5303fe2eb63efcf13ffbc5acc4420e5a4b1224ac4df7667e57 |
|
completionInUncheckedJSFile.ts
| https://github.com/microsoft/TypeScript/pull/36063/files#diff-52ddab7e264fedcccac7d8304a91a733fa2e21b6ec9ded4b67e74dde3d4de2f4 |
|
fourslash.ts
| https://github.com/microsoft/TypeScript/pull/36063/files#diff-5a71b4667ab007c662c8a83e3b65b87aa94f0e67f96ddef77517bc6c1c55ec35 |
| src/harness/fourslashImpl.ts | https://github.com/microsoft/TypeScript/pull/36063/files#diff-68e0a0bdd65b7a9bb405747188b445f5836ab24070c3c06501a961d5d69c910b |
|
View file
| https://github.com/uniqueiniquity/TypeScript/blob/d59c6f3e6ab4090d654d4c9b11cd6168160e7459/src/harness/fourslashImpl.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/36063/{{ revealButtonHref }} |
|
| https://github.com/microsoft/TypeScript/pull/36063/files#diff-68e0a0bdd65b7a9bb405747188b445f5836ab24070c3c06501a961d5d69c910b |
|
| https://github.com/microsoft/TypeScript/pull/36063/files#diff-68e0a0bdd65b7a9bb405747188b445f5836ab24070c3c06501a961d5d69c910b |
|
| https://github.com/microsoft/TypeScript/pull/36063/files#diff-68e0a0bdd65b7a9bb405747188b445f5836ab24070c3c06501a961d5d69c910b |
| src/harness/fourslashInterfaceImpl.ts | https://github.com/microsoft/TypeScript/pull/36063/files#diff-e50795ce40036c1b331e25464a5d9da74a0f60af02bc56302eb9efe57b344b2d |
|
View file
| https://github.com/uniqueiniquity/TypeScript/blob/d59c6f3e6ab4090d654d4c9b11cd6168160e7459/src/harness/fourslashInterfaceImpl.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/36063/{{ revealButtonHref }} |
|
| https://github.com/microsoft/TypeScript/pull/36063/files#diff-e50795ce40036c1b331e25464a5d9da74a0f60af02bc56302eb9efe57b344b2d |
|
| https://github.com/microsoft/TypeScript/pull/36063/files#diff-e50795ce40036c1b331e25464a5d9da74a0f60af02bc56302eb9efe57b344b2d |
| src/server/protocol.ts | https://github.com/microsoft/TypeScript/pull/36063/files#diff-eb376d3ed604f5f596e7a34bcd6b1f851af61d3c22393ebf1b48da8f9976a32e |
|
View file
| https://github.com/uniqueiniquity/TypeScript/blob/d59c6f3e6ab4090d654d4c9b11cd6168160e7459/src/server/protocol.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/36063/{{ revealButtonHref }} |
|
| https://github.com/microsoft/TypeScript/pull/36063/files#diff-eb376d3ed604f5f596e7a34bcd6b1f851af61d3c22393ebf1b48da8f9976a32e |
|
| https://github.com/microsoft/TypeScript/pull/36063/files#diff-eb376d3ed604f5f596e7a34bcd6b1f851af61d3c22393ebf1b48da8f9976a32e |
| src/services/completions.ts | https://github.com/microsoft/TypeScript/pull/36063/files#diff-4237fd08a5f920543e184b7748bc8ae000d9b1c031810ba375b0053362ec2b6a |
|
View file
| https://github.com/uniqueiniquity/TypeScript/blob/d59c6f3e6ab4090d654d4c9b11cd6168160e7459/src/services/completions.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/36063/{{ revealButtonHref }} |
|
| https://github.com/microsoft/TypeScript/pull/36063/files#diff-4237fd08a5f920543e184b7748bc8ae000d9b1c031810ba375b0053362ec2b6a |
|
| https://github.com/microsoft/TypeScript/pull/36063/files#diff-4237fd08a5f920543e184b7748bc8ae000d9b1c031810ba375b0053362ec2b6a |
| src/services/types.ts | https://github.com/microsoft/TypeScript/pull/36063/files#diff-9717eb6d935579eea3b5662088dd258d4e1e17e2a405c3f1fa431e981e01b08f |
|
View file
| https://github.com/uniqueiniquity/TypeScript/blob/d59c6f3e6ab4090d654d4c9b11cd6168160e7459/src/services/types.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/36063/{{ revealButtonHref }} |
|
| https://github.com/microsoft/TypeScript/pull/36063/files#diff-9717eb6d935579eea3b5662088dd258d4e1e17e2a405c3f1fa431e981e01b08f |
|
| https://github.com/microsoft/TypeScript/pull/36063/files#diff-9717eb6d935579eea3b5662088dd258d4e1e17e2a405c3f1fa431e981e01b08f |
| tests/baselines/reference/api/tsserverlibrary.d.ts | https://github.com/microsoft/TypeScript/pull/36063/files#diff-d7739d440630d907a34b93d1905164a6f8fe27d2cc9d84c58495d02c886652d8 |
|
View file
| https://github.com/uniqueiniquity/TypeScript/blob/d59c6f3e6ab4090d654d4c9b11cd6168160e7459/tests/baselines/reference/api/tsserverlibrary.d.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/36063/{{ revealButtonHref }} |
|
| https://github.com/microsoft/TypeScript/pull/36063/files#diff-d7739d440630d907a34b93d1905164a6f8fe27d2cc9d84c58495d02c886652d8 |
|
| https://github.com/microsoft/TypeScript/pull/36063/files#diff-d7739d440630d907a34b93d1905164a6f8fe27d2cc9d84c58495d02c886652d8 |
|
| https://github.com/microsoft/TypeScript/pull/36063/files#diff-d7739d440630d907a34b93d1905164a6f8fe27d2cc9d84c58495d02c886652d8 |
|
| https://github.com/microsoft/TypeScript/pull/36063/files#diff-d7739d440630d907a34b93d1905164a6f8fe27d2cc9d84c58495d02c886652d8 |
| tests/baselines/reference/api/typescript.d.ts | https://github.com/microsoft/TypeScript/pull/36063/files#diff-dd6d044fa72b2a5303fe2eb63efcf13ffbc5acc4420e5a4b1224ac4df7667e57 |
|
View file
| https://github.com/uniqueiniquity/TypeScript/blob/d59c6f3e6ab4090d654d4c9b11cd6168160e7459/tests/baselines/reference/api/typescript.d.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/36063/{{ revealButtonHref }} |
|
| https://github.com/microsoft/TypeScript/pull/36063/files#diff-dd6d044fa72b2a5303fe2eb63efcf13ffbc5acc4420e5a4b1224ac4df7667e57 |
|
| https://github.com/microsoft/TypeScript/pull/36063/files#diff-dd6d044fa72b2a5303fe2eb63efcf13ffbc5acc4420e5a4b1224ac4df7667e57 |
| tests/cases/fourslash/completionInUncheckedJSFile.ts | https://github.com/microsoft/TypeScript/pull/36063/files#diff-52ddab7e264fedcccac7d8304a91a733fa2e21b6ec9ded4b67e74dde3d4de2f4 |
|
View file
| https://github.com/uniqueiniquity/TypeScript/blob/d59c6f3e6ab4090d654d4c9b11cd6168160e7459/tests/cases/fourslash/completionInUncheckedJSFile.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/36063/{{ revealButtonHref }} |
| tests/cases/fourslash/fourslash.ts | https://github.com/microsoft/TypeScript/pull/36063/files#diff-5a71b4667ab007c662c8a83e3b65b87aa94f0e67f96ddef77517bc6c1c55ec35 |
|
View file
| https://github.com/uniqueiniquity/TypeScript/blob/d59c6f3e6ab4090d654d4c9b11cd6168160e7459/tests/cases/fourslash/fourslash.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/36063/{{ revealButtonHref }} |
|
| https://github.com/microsoft/TypeScript/pull/36063/files#diff-5a71b4667ab007c662c8a83e3b65b87aa94f0e67f96ddef77517bc6c1c55ec35 |
|
| https://github.com/microsoft/TypeScript/pull/36063/files#diff-5a71b4667ab007c662c8a83e3b65b87aa94f0e67f96ddef77517bc6c1c55ec35 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |