react-profiling 0
react-import-map react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controller voltron_pull_requests_fragments
route-action pull_request_layout
fetch-nonce v2:34985faa-0551-07b4-5014-de43f5971b04
current-catalog-service-hash ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id 87E2:28815B:C4ACE4:10774F9:6B00F9DC
html-safe-nonce 2f692aef262149f157737329ef34c0dfccbecc26db0457edfa8e7026cbb577ac
visitor-payload eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4N0UyOjI4ODE1QjpDNEFDRTQ6MTA3NzRGOTo2QjAwRjlEQyIsInZpc2l0b3JfaWQiOiIzMjAwNjcxNDY1NDE4NTg2NTg4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac 8ad387ca54b230dbb3a89e9715f588b44fd441e74167d336d2e8b746e7b7dcf6
hovercard-subject-tag pull_request:358795362
github-keyboard-shortcuts repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verification Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-url https://collector.github.com/github/collect
analytics-location ///voltron/pull_requests_fragments/pull_request_layout
fb:app_id 1401488693436528
apple-itunes-app app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/35967/pull_request_layout
twitter:image https://opengraph.githubassets.com/c994cf9104c6e1acd46fd4b6d7eb8a2679261019d2d4236bbba21c60af31918a/microsoft/TypeScript/pull/35967
twitter:card summary_large_image
og:image https://opengraph.githubassets.com/c994cf9104c6e1acd46fd4b6d7eb8a2679261019d2d4236bbba21c60af31918a/microsoft/TypeScript/pull/35967
og:image:alt This is an update/resync of #33587 with the feedback from the recent reviews applied and a merge with master. Hopefully you don't mind Michael Rawlings (@mlrawlings).
Fixes #12522
Fixes #6366
F...
og:image:width 1200
og:image:height 600
og:site_name GitHub
og:type object
og:author:username weswigham
hostname github.com
expected-hostname github.com
None e208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-control no-cache
go-import github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id 6154722
octolytics-dimension-user_login microsoft
octolytics-dimension-repository_id 20929025
octolytics-dimension-repository_nwo microsoft/TypeScript
octolytics-dimension-repository_public true
octolytics-dimension-repository_is_fork false
octolytics-dimension-repository_network_root_id 20929025
octolytics-dimension-repository_network_root_nwo microsoft/TypeScript
turbo-body-classes logged-out env-production page-responsive
disable-turbo false
browser-stats-url https://api.github.com/_private/browser/stats
browser-errors-url https://api.github.com/_private/browser/errors
release 7dafd017fb7809a839c443dba08622af38e63c09
ui-target full
theme-color #1e2327
color-scheme light dark
react-app-name pull-requests
Skip to content https://github.com/microsoft/TypeScript/pull/35967#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F35967
GitHubRepository hosting, code review, and collaboration https://github.com/platform
CopilotAI coding agent for tasks, projects, and automated work https://github.com/features/copilot
ActionsCI/CD and automation https://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcement https://github.com/features/code-quality
CodespacesCloud development environments https://github.com/features/codespaces
Code SecurityVulnerability detection and remediation https://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak prevention https://github.com/security/advanced-security/secret-protection
All Features https://github.com/features
Documentation https://docs.github.com/en
Training https://learn.github.com/skills
Certifications https://learn.github.com/credentials
Build with Copilot https://github.com/features/ai
Customize Copilot https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrations https://github.com/marketplace
Trending repos https://github.com/trending
GitHub Sponsors https://github.com/open-source/sponsors
Developer articles https://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. https://github.blog/changelog/
Enterprises https://github.com/enterprise
Team https://github.com/team
Startups https://github.com/enterprise/startups
Nonprofits https://github.com/solutions/industry/nonprofits
Healthcare https://github.com/solutions/industry/healthcare
Financial services https://github.com/solutions/industry/financial-services
Manufacturing https://github.com/solutions/industry/manufacturing
Government https://github.com/solutions/industry/government
See all industries https://github.com/solutions/industry
Why GitHub https://github.com/why-github
Customer Stories https://github.com/customer-stories
Business insights https://github.com/solutions/executive-insights
Trust Center https://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code security https://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI features https://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 support https://github.com/enterprise/premium-support
Documentation https://docs.github.com/en
Resource center https://github.com/resources
Blog https://github.blog/
Events & webinars https://github.com/resources/events
Community Forum https://github.com/orgs/community/discussions
Customer Stories https://github.com/customer-stories
Integrations https://github.com/marketplace
Customer support https://help.github.com/
Training https://learn.github.com/skills
GitHub Status https://www.githubstatus.com/
About https://github.com/about
Partners https://github.com/partners
Changelog https://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. https://githubuniverse.com/
Pricing https://github.com/pricing
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F35967
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reload https://github.com/microsoft/TypeScript/pull/35967
Reload https://github.com/microsoft/TypeScript/pull/35967
Reload https://github.com/microsoft/TypeScript/pull/35967
microsoft https://github.com/microsoft
TypeScript https://github.com/microsoft/TypeScript
Code https://github.com/microsoft/TypeScript
Issues5k (5k) https://github.com/microsoft/TypeScript/issues
Pull requests309 (309) https://github.com/microsoft/TypeScript/pulls
Actions https://github.com/microsoft/TypeScript/actions
Projects https://github.com/microsoft/TypeScript/projects
Wiki https://github.com/microsoft/TypeScript/wiki
Security and quality https://github.com/microsoft/TypeScript/security
Insights https://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Wesley Wigham (weswigham) https://github.com/weswigham
microsoft:master https://github.com/microsoft/TypeScript/tree/master
weswigham:live-bindings https://github.com/weswigham/TypeScript/tree/live-bindings
Conversation https://github.com/microsoft/TypeScript/pull/35967
Commits18 (18) https://github.com/microsoft/TypeScript/pull/35967/commits
Checks https://github.com/microsoft/TypeScript/pull/35967/checks
Files changed https://github.com/microsoft/TypeScript/pull/35967/files
Use getters to define live export bindings refresh https://github.com/microsoft/TypeScript/pull/35967#top
Wesley Wigham (weswigham) https://github.com/weswigham
microsoft:master https://github.com/microsoft/TypeScript/tree/master
weswigham:live-bindings https://github.com/weswigham/TypeScript/tree/live-bindings
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
Jan 2, 2020 https://github.com/microsoft/TypeScript/pull/35967#issue-544748356
#33587 https://github.com/microsoft/TypeScript/pull/33587
Michael Rawlings (@mlrawlings) https://github.com/mlrawlings
#12522 https://github.com/microsoft/TypeScript/issues/12522
#6366 https://github.com/microsoft/TypeScript/issues/6366
#33587 https://github.com/microsoft/TypeScript/pull/33587
Ron Buckton (@rbuckton) https://github.com/rbuckton
Klaus Meinhardt (@ajafff) https://github.com/ajafff
Please reload this page https://github.com/microsoft/TypeScript/pull/35967
Michael Rawlings (mlrawlings) https://github.com/mlrawlings
September 24, 2019 01:29 https://github.com/microsoft/TypeScript/pull/35967#commits-pushed-a8d6c2b
https://github.com/mlrawlings
use getters to define live export bindings https://github.com/microsoft/TypeScript/pull/35967/commits/a8d6c2beaf4a1ba91f24e3c17e427989419f82fd
a8d6c2b https://github.com/microsoft/TypeScript/pull/35967/commits/a8d6c2beaf4a1ba91f24e3c17e427989419f82fd
https://github.com/mlrawlings
fix scoping in export* helper https://github.com/microsoft/TypeScript/pull/35967/commits/27941d05b640148554dd60516144d04a2488536c
27941d0 https://github.com/microsoft/TypeScript/pull/35967/commits/27941d05b640148554dd60516144d04a2488536c
https://github.com/mlrawlings
Object.defineProperty cannot be used in ES3 target https://github.com/microsoft/TypeScript/pull/35967/commits/0b2cf9b71a04b3387acd052c063779e8d28b8fbb
0b2cf9b https://github.com/microsoft/TypeScript/pull/35967/commits/0b2cf9b71a04b3387acd052c063779e8d28b8fbb
https://github.com/weswigham
Merge branch 'master' into live-bindings https://github.com/microsoft/TypeScript/pull/35967/commits/96101aa3e103cb8623a1fe6eb0db3b883cf4de29
96101aa https://github.com/microsoft/TypeScript/pull/35967/commits/96101aa3e103cb8623a1fe6eb0db3b883cf4de29
https://github.com/weswigham
Accept changed baselines https://github.com/microsoft/TypeScript/pull/35967/commits/3ca0f401667c65059fd3d3b0c295176c8d6cfab3
3ca0f40 https://github.com/microsoft/TypeScript/pull/35967/commits/3ca0f401667c65059fd3d3b0c295176c8d6cfab3
https://github.com/weswigham
Use function expression, not arrow function https://github.com/microsoft/TypeScript/pull/35967/commits/2002062fcdbf023f9b3f02b0708cd5cbf0be94f9
2002062 https://github.com/microsoft/TypeScript/pull/35967/commits/2002062fcdbf023f9b3f02b0708cd5cbf0be94f9
https://github.com/weswigham
Update importStarHelper to match export helper in binding-making https://github.com/microsoft/TypeScript/pull/35967/commits/48dc60759f35286f89a5aa3f47c5fc83f298b0bc
48dc607 https://github.com/microsoft/TypeScript/pull/35967/commits/48dc60759f35286f89a5aa3f47c5fc83f298b0bc
https://github.com/weswigham
Fix whitespace https://github.com/microsoft/TypeScript/pull/35967/commits/4f24ad3b40bd579c12d29a97d6d11b7b1fe3d5a1
4f24ad3 https://github.com/microsoft/TypeScript/pull/35967/commits/4f24ad3b40bd579c12d29a97d6d11b7b1fe3d5a1
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
Ron Buckton (rbuckton) https://github.com/rbuckton
January 2, 2020 21:10 https://github.com/microsoft/TypeScript/pull/35967#event-2918800760
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) https://github.com/DanielRosenwasser
Jan 2, 2020
https://github.com/microsoft/TypeScript/pull/35967#pullrequestreview-337908311
View reviewed changes
https://github.com/microsoft/TypeScript/pull/35967/files/4f24ad3b40bd579c12d29a97d6d11b7b1fe3d5a1
tests/baselines/reference/ambientShorthand_reExport.js https://github.com/microsoft/TypeScript/pull/35967/files/4f24ad3b40bd579c12d29a97d6d11b7b1fe3d5a1#diff-8c937e9c26c3427ec1bf5e723af50e781a97568b4efccfe4019d83e9b19e4f2e
Daniel Rosenwasser (DanielRosenwasser) https://github.com/DanielRosenwasser
Jan 2, 2020 https://github.com/microsoft/TypeScript/pull/35967#discussion_r362670695
Learn more https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#33587 (comment) https://github.com/microsoft/TypeScript/pull/33587#discussion_r362659106
Please reload this page https://github.com/microsoft/TypeScript/pull/35967
Wesley Wigham (weswigham) https://github.com/weswigham
Jan 3, 2020 https://github.com/microsoft/TypeScript/pull/35967#discussion_r362682912
Please reload this page https://github.com/microsoft/TypeScript/pull/35967
Learn more https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this page https://github.com/microsoft/TypeScript/pull/35967
Daniel Rosenwasser (DanielRosenwasser) https://github.com/DanielRosenwasser
Jan 3, 2020 https://github.com/microsoft/TypeScript/pull/35967#discussion_r362936341
Learn more https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this page https://github.com/microsoft/TypeScript/pull/35967
Ron Buckton (rbuckton) https://github.com/rbuckton
Feb 24, 2020 https://github.com/microsoft/TypeScript/pull/35967#discussion_r383578277
Please reload this page https://github.com/microsoft/TypeScript/pull/35967
Learn more https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this page https://github.com/microsoft/TypeScript/pull/35967
Ron Buckton (rbuckton) https://github.com/rbuckton
Feb 24, 2020 https://github.com/microsoft/TypeScript/pull/35967#discussion_r383578731
Learn more https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this page https://github.com/microsoft/TypeScript/pull/35967
Wesley Wigham (weswigham) https://github.com/weswigham
Feb 24, 2020 https://github.com/microsoft/TypeScript/pull/35967#discussion_r383579327
Please reload this page https://github.com/microsoft/TypeScript/pull/35967
Learn more https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this page https://github.com/microsoft/TypeScript/pull/35967
Ron Buckton (rbuckton) https://github.com/rbuckton
Feb 24, 2020 https://github.com/microsoft/TypeScript/pull/35967#discussion_r383580054
Learn more https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this page https://github.com/microsoft/TypeScript/pull/35967
Ron Buckton (rbuckton) https://github.com/rbuckton
Feb 24, 2020 https://github.com/microsoft/TypeScript/pull/35967#discussion_r383580372
Learn more https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this page https://github.com/microsoft/TypeScript/pull/35967
https://github.com/mlrawlings
Michael Rawlings (mlrawlings) https://github.com/mlrawlings
Jan 3, 2020 https://github.com/microsoft/TypeScript/pull/35967#issuecomment-570416479
Wesley Wigham (@weswigham) https://github.com/weswigham
Please reload this page https://github.com/microsoft/TypeScript/pull/35967
https://github.com/weswigham
Adjust whitespace in edited helpers https://github.com/microsoft/TypeScript/pull/35967/commits/8935d498109ba01b7a7dd734afddda5adc09c875
8935d49 https://github.com/microsoft/TypeScript/pull/35967/commits/8935d498109ba01b7a7dd734afddda5adc09c875
https://github.com/ajafff
Klaus Meinhardt (ajafff) https://github.com/ajafff
Jan 3, 2020
https://github.com/microsoft/TypeScript/pull/35967#pullrequestreview-338010520
View reviewed changes
https://github.com/microsoft/TypeScript/pull/35967/files/8935d498109ba01b7a7dd734afddda5adc09c875
src/compiler/transformers/module/module.ts https://github.com/microsoft/TypeScript/pull/35967/files/8935d498109ba01b7a7dd734afddda5adc09c875#diff-3fa693abdf43c2781ae8cfa1d3b0450280b3aad90e7e8ae738efe58bcaced918
Klaus Meinhardt (ajafff) https://github.com/ajafff
Jan 3, 2020 https://github.com/microsoft/TypeScript/pull/35967#discussion_r362754586
Learn more https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this page https://github.com/microsoft/TypeScript/pull/35967
Wesley Wigham (weswigham) https://github.com/weswigham
January 6, 2020 14:39 https://github.com/microsoft/TypeScript/pull/35967#commits-pushed-19bb023
https://github.com/weswigham
Use new helper for setting bindings, use unscoped __exportStar helper… https://github.com/microsoft/TypeScript/pull/35967/commits/19bb023f74fd6723f8ccf4e9dfe6bc67147eb4d9
19bb023 https://github.com/microsoft/TypeScript/pull/35967/commits/19bb023f74fd6723f8ccf4e9dfe6bc67147eb4d9
https://github.com/weswigham
Merge branch 'master' into live-bindings https://github.com/microsoft/TypeScript/pull/35967/commits/ca45516d14f319adef52b916725a24d03209fe7a
ca45516 https://github.com/microsoft/TypeScript/pull/35967/commits/ca45516d14f319adef52b916725a24d03209fe7a
https://github.com/weswigham
Accept updated baselines https://github.com/microsoft/TypeScript/pull/35967/commits/deb3aeb8212bef557e6593f8406cee0693fa0e2b
deb3aeb https://github.com/microsoft/TypeScript/pull/35967/commits/deb3aeb8212bef557e6593f8406cee0693fa0e2b
https://github.com/weswigham
Use __createBinding for individual reexports when target is es3 https://github.com/microsoft/TypeScript/pull/35967/commits/3fa1d0f4e7d9d9e5193d646113bb5b1942a85bd0
3fa1d0f https://github.com/microsoft/TypeScript/pull/35967/commits/3fa1d0f4e7d9d9e5193d646113bb5b1942a85bd0
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
Jan 6, 2020 https://github.com/microsoft/TypeScript/pull/35967#issuecomment-571364596
Klaus Meinhardt (@ajafff) https://github.com/ajafff
Daniel Rosenwasser (@DanielRosenwasser) https://github.com/DanielRosenwasser
Ron Buckton (@rbuckton) https://github.com/rbuckton
Please reload this page https://github.com/microsoft/TypeScript/pull/35967
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) https://github.com/DanielRosenwasser
Jan 6, 2020 https://github.com/microsoft/TypeScript/pull/35967#issuecomment-571368422
Please reload this page https://github.com/microsoft/TypeScript/pull/35967
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
Jan 7, 2020 https://github.com/microsoft/TypeScript/pull/35967#issuecomment-571373323
Please reload this page https://github.com/microsoft/TypeScript/pull/35967
https://github.com/weswigham
Remove unneeded type assertion https://github.com/microsoft/TypeScript/pull/35967/commits/c5c882565f8a69b355e4da16ca5fe72010538524
c5c8825 https://github.com/microsoft/TypeScript/pull/35967/commits/c5c882565f8a69b355e4da16ca5fe72010538524
https://github.com/ajafff
Klaus Meinhardt (ajafff) https://github.com/ajafff
Jan 21, 2020 https://github.com/microsoft/TypeScript/pull/35967#issuecomment-576554283
Wesley Wigham (@weswigham) https://github.com/weswigham
Ron Buckton (@rbuckton) https://github.com/rbuckton
Please reload this page https://github.com/microsoft/TypeScript/pull/35967
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
For Backlog Bug
https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Backlog%20Bug%22
Feb 1, 2020 https://github.com/microsoft/TypeScript/pull/35967#event-2998912848
https://github.com/typescript-bot
TypeScript Bot (typescript-bot) https://github.com/typescript-bot
Wesley Wigham (weswigham) https://github.com/weswigham
Feb 1, 2020 https://github.com/microsoft/TypeScript/pull/35967#event-2998912894
https://github.com/typescript-bot
TypeScript Bot (typescript-bot) https://github.com/typescript-bot
Author: Team
https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
Feb 1, 2020 https://github.com/microsoft/TypeScript/pull/35967#event-2998912949
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
For Milestone Bug
https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22
For Backlog Bug
https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Backlog%20Bug%22
Feb 1, 2020 https://github.com/microsoft/TypeScript/pull/35967#event-2998913268
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
Feb 3, 2020
https://github.com/microsoft/TypeScript/pull/35967#ref-pullrequest-498052270
Use getters to define live export bindings
#33587
https://github.com/microsoft/TypeScript/pull/33587
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
Feb 11, 2020 https://github.com/microsoft/TypeScript/pull/35967#issuecomment-584757510
Please reload this page https://github.com/microsoft/TypeScript/pull/35967
Wesley Wigham (@weswigham) https://github.com/weswigham
Daniel Rosenwasser (@DanielRosenwasser) https://github.com/DanielRosenwasser
Please reload this page https://github.com/microsoft/TypeScript/pull/35967
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
Feb 11, 2020 https://github.com/microsoft/TypeScript/pull/35967#issuecomment-584758563
Ahmed Jaffery (@ajaff) https://github.com/ajaff
Please reload this page https://github.com/microsoft/TypeScript/pull/35967
https://github.com/weswigham
Merge branch 'master' into live-bindings https://github.com/microsoft/TypeScript/pull/35967/commits/da8b58aad747348d8e8140be36dca99166175cc2
da8b58a https://github.com/microsoft/TypeScript/pull/35967/commits/da8b58aad747348d8e8140be36dca99166175cc2
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
Feb 14, 2020
https://github.com/microsoft/TypeScript/pull/35967#ref-pullrequest-565585058
Retain undefined initializations
#36806
https://github.com/microsoft/TypeScript/pull/36806
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
Feb 14, 2020 https://github.com/microsoft/TypeScript/pull/35967#issuecomment-586497528
#36806 https://github.com/microsoft/TypeScript/pull/36806
Klaus Meinhardt (@ajafff) https://github.com/ajafff
Ron Buckton (@rbuckton) https://github.com/rbuckton
Please reload this page https://github.com/microsoft/TypeScript/pull/35967
https://github.com/ExE-Boss
ExE Boss (ExE-Boss) https://github.com/ExE-Boss
Feb 14, 2020 https://github.com/microsoft/TypeScript/pull/35967#issuecomment-586506117
Please reload this page https://github.com/microsoft/TypeScript/pull/35967
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
Feb 24, 2020 https://github.com/microsoft/TypeScript/pull/35967#issuecomment-590500049
Ron Buckton (@rbuckton) https://github.com/rbuckton
Please reload this page https://github.com/microsoft/TypeScript/pull/35967
https://github.com/rbuckton
Ron Buckton (rbuckton) https://github.com/rbuckton
Feb 24, 2020
https://github.com/microsoft/TypeScript/pull/35967#pullrequestreview-363634545
View reviewed changes
https://github.com/microsoft/TypeScript/pull/35967/files/c5c882565f8a69b355e4da16ca5fe72010538524
Ron Buckton (rbuckton) https://github.com/rbuckton
https://github.com/microsoft/TypeScript/pull/35967#pullrequestreview-363634545
Learn more https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this page https://github.com/microsoft/TypeScript/pull/35967
src/compiler/transformers/module/module.ts https://github.com/microsoft/TypeScript/pull/35967/files/c5c882565f8a69b355e4da16ca5fe72010538524#diff-3fa693abdf43c2781ae8cfa1d3b0450280b3aad90e7e8ae738efe58bcaced918
Please reload this page https://github.com/microsoft/TypeScript/pull/35967
src/compiler/transformers/module/module.ts https://github.com/microsoft/TypeScript/pull/35967/files/c5c882565f8a69b355e4da16ca5fe72010538524#diff-3fa693abdf43c2781ae8cfa1d3b0450280b3aad90e7e8ae738efe58bcaced918
Please reload this page https://github.com/microsoft/TypeScript/pull/35967
tests/baselines/reference/commentsOnRequireStatement.js https://github.com/microsoft/TypeScript/pull/35967/files/c5c882565f8a69b355e4da16ca5fe72010538524#diff-3c9ee40892d41514e0c07ef975a32a1989e1beea2f22955ca138be8ccf33894c
Please reload this page https://github.com/microsoft/TypeScript/pull/35967
src/compiler/transformers/module/module.ts https://github.com/microsoft/TypeScript/pull/35967/files/c5c882565f8a69b355e4da16ca5fe72010538524#diff-3fa693abdf43c2781ae8cfa1d3b0450280b3aad90e7e8ae738efe58bcaced918
Please reload this page https://github.com/microsoft/TypeScript/pull/35967
src/compiler/transformers/module/module.ts https://github.com/microsoft/TypeScript/pull/35967/files/c5c882565f8a69b355e4da16ca5fe72010538524#diff-3fa693abdf43c2781ae8cfa1d3b0450280b3aad90e7e8ae738efe58bcaced918
Please reload this page https://github.com/microsoft/TypeScript/pull/35967
src/compiler/transformers/module/module.ts https://github.com/microsoft/TypeScript/pull/35967/files/c5c882565f8a69b355e4da16ca5fe72010538524#diff-3fa693abdf43c2781ae8cfa1d3b0450280b3aad90e7e8ae738efe58bcaced918
Please reload this page https://github.com/microsoft/TypeScript/pull/35967
Wesley Wigham (weswigham) https://github.com/weswigham
February 24, 2020 13:50 https://github.com/microsoft/TypeScript/pull/35967#commits-pushed-8c2762e
https://github.com/weswigham
Merge branch 'master' into live-bindings https://github.com/microsoft/TypeScript/pull/35967/commits/8c2762edd48e893dbe089facec9b5469075e471d
8c2762e https://github.com/microsoft/TypeScript/pull/35967/commits/8c2762edd48e893dbe089facec9b5469075e471d
https://github.com/weswigham
Singeline the helpers https://github.com/microsoft/TypeScript/pull/35967/commits/2e857dcf31545f7a18cd77a5861043e793084771
2e857dc https://github.com/microsoft/TypeScript/pull/35967/commits/2e857dcf31545f7a18cd77a5861043e793084771
https://github.com/weswigham
Add check for createBinding helper, accept updated baselines with sho… https://github.com/microsoft/TypeScript/pull/35967/commits/6776f4cb8703088d47bc8230912399f7d197a40d
6776f4c https://github.com/microsoft/TypeScript/pull/35967/commits/6776f4cb8703088d47bc8230912399f7d197a40d
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
Ron Buckton (rbuckton) https://github.com/rbuckton
February 24, 2020 23:07 https://github.com/microsoft/TypeScript/pull/35967#event-3067341164
https://github.com/rbuckton
Ron Buckton (rbuckton) https://github.com/rbuckton
Feb 24, 2020
https://github.com/microsoft/TypeScript/pull/35967#pullrequestreview-363776534
View reviewed changes
https://github.com/microsoft/TypeScript/pull/35967/files/6776f4cb8703088d47bc8230912399f7d197a40d
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
65e7acc https://github.com/microsoft/TypeScript/commit/65e7acce58afa657ffd3153859b1f49f1d8568b7
Feb 24, 2020 https://github.com/microsoft/TypeScript/pull/35967#event-3067403887
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
February 24, 2020 23:36 https://github.com/microsoft/TypeScript/pull/35967#event-3067404100
https://github.com/rbuckton
Ron Buckton (rbuckton) https://github.com/rbuckton
Feb 24, 2020
https://github.com/microsoft/TypeScript/pull/35967#pullrequestreview-363781884
View reviewed changes
https://github.com/microsoft/TypeScript/pull/35967/files/6776f4cb8703088d47bc8230912399f7d197a40d
src/compiler/checker.ts https://github.com/microsoft/TypeScript/pull/35967/files/6776f4cb8703088d47bc8230912399f7d197a40d#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Please reload this page https://github.com/microsoft/TypeScript/pull/35967
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
Feb 24, 2020
https://github.com/microsoft/TypeScript/pull/35967#ref-pullrequest-570219621
Remove unneeded branch from getHelperName
#36998
https://github.com/microsoft/TypeScript/pull/36998
Wesley Wigham (weswigham) https://github.com/weswigham
Feb 25, 2020
https://github.com/microsoft/TypeScript/pull/35967#ref-commit-1dd176e
https://github.com/weswigham
Declare dependencies between helpers in the declaritive fashion intro… https://github.com/weswigham/TypeScript/commit/1dd176e15d879f0bbe8173fbddab21899a3b57b9
1dd176e https://github.com/weswigham/TypeScript/commit/1dd176e15d879f0bbe8173fbddab21899a3b57b9
microsoft#35967 https://github.com/microsoft/TypeScript/pull/35967
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
Feb 25, 2020
https://github.com/microsoft/TypeScript/pull/35967#ref-pullrequest-570226068
Declare dependencies between helpers in the declaritive fashion
#37001
https://github.com/microsoft/TypeScript/pull/37001
Wesley Wigham (weswigham) https://github.com/weswigham
Feb 25, 2020
https://github.com/microsoft/TypeScript/pull/35967#ref-commit-e54b796
https://github.com/weswigham
Declare dependencies between helpers in the declaritive fashion intro… https://github.com/microsoft/TypeScript/commit/e54b7963013a1c583063f49ed9c5ad6306870e33
e54b796 https://github.com/microsoft/TypeScript/commit/e54b7963013a1c583063f49ed9c5ad6306870e33
#35967 https://github.com/microsoft/TypeScript/pull/35967
#37001 https://github.com/microsoft/TypeScript/pull/37001
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) https://github.com/DanielRosenwasser
Mar 3, 2020
https://github.com/microsoft/TypeScript/pull/35967#ref-issue-575020163
TypeScript 3.9 Iteration Plan
#37198
https://github.com/microsoft/TypeScript/issues/37198
https://github.com/bluelovers
bluelovers (bluelovers) https://github.com/bluelovers
Mar 5, 2020
https://github.com/microsoft/TypeScript/pull/35967#ref-issue-572398507
Cannot set property default of # which has only a getter
#37090
https://github.com/microsoft/TypeScript/issues/37090
https://github.com/leon19
Lorens León (leon19) https://github.com/leon19
May 13, 2020
https://github.com/microsoft/TypeScript/pull/35967#ref-issue-617308305
Cannot redefine exports when exporting identifiers with the same name from different files
#38530
https://github.com/microsoft/TypeScript/issues/38530
Oscar Busk (oBusk) https://github.com/oBusk
May 13, 2020
https://github.com/microsoft/TypeScript/pull/35967#ref-commit-f7df632
https://github.com/oBusk
chore: Increase allowed size of index.js https://github.com/oBusk/walkable-buffer/commit/f7df6324d06606d5d3ddd4bac5df0c10759598e5
f7df632 https://github.com/oBusk/walkable-buffer/commit/f7df6324d06606d5d3ddd4bac5df0c10759598e5
https://github.com/microsoft/TypeScript/wiki/Breaking-Changes#exports-now-use-getters-for-live-bindings https://github.com/microsoft/TypeScript/wiki/Breaking-Changes#exports-now-use-getters-for-live-bindings
microsoft/TypeScript#35967 https://github.com/microsoft/TypeScript/pull/35967
https://github.com/sluukkonen
Sakumatti Luukkonen (sluukkonen) https://github.com/sluukkonen
May 19, 2020
https://github.com/microsoft/TypeScript/pull/35967#ref-issue-620941435
promisfyAll doesn't work with TypeScript 3.9 emitted code
petkaantonov/bluebird#1645
https://github.com/petkaantonov/bluebird/issues/1645
https://github.com/hansottowirtz
Hans Otto Wirtz (hansottowirtz) https://github.com/hansottowirtz
Aug 28, 2020
https://github.com/microsoft/TypeScript/pull/35967#ref-issue-686237205
cannot use named import from tsc generate code converted by rollup-plugin-commonjs
rollup/plugins#556
https://github.com/rollup/plugins/issues/556
https://github.com/BPScott
Ben Scott (BPScott) https://github.com/BPScott
Mar 1, 2021
https://github.com/microsoft/TypeScript/pull/35967#ref-issue-818413189
Cannot scan some TypeScript compiler CJS output
nodejs/cjs-module-lexer#37
https://github.com/nodejs/cjs-module-lexer/issues/37
https://github.com/komalali
Komal Ali (komalali) https://github.com/komalali
Jul 14, 2021
https://github.com/microsoft/TypeScript/pull/35967#ref-pullrequest-943767623
Update typescript version
pulumi/pulumi#7512
https://github.com/pulumi/pulumi/pull/7512
https://github.com/kwasimensah
kwasimensah https://github.com/kwasimensah
Aug 8, 2022
https://github.com/microsoft/TypeScript/pull/35967#ref-issue-1331362162
Feature Request: Ability to opt out of liveBinding with exports of const values
#50214
https://github.com/microsoft/TypeScript/issues/50214
https://github.com/yor-so
Roy Ramos (yor-so) https://github.com/yor-so
Jun 4, 2024
https://github.com/microsoft/TypeScript/pull/35967#ref-issue-2334105738
[Wiki] Breaking changes. TypeScript 3.9. Exports Now Use Getters for Live Bindings.
#58773
https://github.com/microsoft/TypeScript/issues/58773
https://github.com/yor-so
Roy Ramos (yor-so) https://github.com/yor-so
Jun 16, 2024
https://github.com/microsoft/TypeScript/pull/35967#ref-issue-2355847477
Broken link in Breaking-Changes.md. TypeScript 3.9. Exports Now Use Getters for Live Bindings
microsoft/TypeScript-wiki#331
https://github.com/microsoft/TypeScript-wiki/issues/331
https://github.com/microsoft
Microsoft (microsoft) https://github.com/microsoft
Oct 21, 2025 https://github.com/microsoft/TypeScript/pull/35967#event-20416858117
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for free https://github.com/join?source=comment-repo
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F35967
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)
https://github.com/DanielRosenwasser
https://github.com/microsoft/TypeScript/pull/35967/files/8935d498109ba01b7a7dd734afddda5adc09c875
https://github.com/rbuckton
Ron Buckton (rbuckton)
https://github.com/rbuckton
https://github.com/microsoft/TypeScript/pull/35967/files/6776f4cb8703088d47bc8230912399f7d197a40d
https://github.com/ajafff
Klaus Meinhardt (ajafff)
https://github.com/ajafff
https://github.com/microsoft/TypeScript/pull/35967/files/8935d498109ba01b7a7dd734afddda5adc09c875
Please reload this page https://github.com/microsoft/TypeScript/pull/35967
https://github.com/weswigham
Wesley Wigham (weswigham)
https://github.com/weswigham
Author: Team
https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Milestone Bug
https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22
PR Backlog
https://github.com/orgs/microsoft/projects/1252
[Bug] Re-exported binding doesn't track the original binding
https://github.com/microsoft/TypeScript/issues/12522
ES6 module variables are copied when re-exported
https://github.com/microsoft/TypeScript/issues/6366
Please reload this page https://github.com/microsoft/TypeScript/pull/35967
https://github.com/weswigham
https://github.com/mlrawlings
https://github.com/DanielRosenwasser
https://github.com/ajafff
https://github.com/sandersn
https://github.com/ExE-Boss
https://github.com/rbuckton
https://github.com/typescript-bot
https://github.com
Terms https://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacy https://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Security https://github.com/security
Status https://www.githubstatus.com/
Community https://github.community/
Docs https://docs.github.com/
Contact https://support.github.com?tags=dotcom-footer