René's URL Explorer Experiment


Title: Fix binding of this-assignments w/computed properties by sandersn · Pull Request #35639 · microsoft/TypeScript · GitHub

Open Graph Title: Fix binding of this-assignments w/computed properties by sandersn · Pull Request #35639 · microsoft/TypeScript

X Title: Fix binding of this-assignments w/computed properties by sandersn · Pull Request #35639 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Fix binding of this-assignments w/computed properties by sandersn · Pull Request #35639 · microsoft/TypeScript

Open Graph Description: Binding of top-level this-assignments forgets to check for computed properties and tries to bind them normally. Then it hits a helpful assert which prevents that. This change stops binding this-pro...

X Description: Binding of top-level this-assignments forgets to check for computed properties and tries to bind them normally. Then it hits a helpful assert which prevents that. This change stops binding this-pro...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/35639

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7e3fd1b8-e3d0-6764-7a68-67a6a6256856
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB5E8:36A3E:C74D48:10B18DE:6B00FD10
html-safe-nonce5d513841135f2049e994c63337bd69a636eaa30d094718aac3c1f829cebe2717
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNUU4OjM2QTNFOkM3NEQ0ODoxMEIxOERFOjZCMDBGRDEwIiwidmlzaXRvcl9pZCI6Ijc5Njg5Nzg0Mzk4NjY3NDQwODAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7c404cf66859faf7385750463a9ef1b67da9cea324fe7695d045f972629c613d
hovercard-subject-tagpull_request:352161219
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/35639/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0fd467367f5f699f046cf7a3611a4948156e551199ad0fd3ab37d7c51291dc12/microsoft/TypeScript/pull/35639
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0fd467367f5f699f046cf7a3611a4948156e551199ad0fd3ab37d7c51291dc12/microsoft/TypeScript/pull/35639
og:image:altBinding of top-level this-assignments forgets to check for computed properties and tries to bind them normally. Then it hits a helpful assert which prevents that. This change stops binding this-pro...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesandersn
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/35639#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F35639
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F35639
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/35639
Reloadhttps://github.com/microsoft/TypeScript/pull/35639
Reloadhttps://github.com/microsoft/TypeScript/pull/35639
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
fix-binding-this-computed-property-assignmenthttps://github.com/microsoft/TypeScript/tree/fix-binding-this-computed-property-assignment
Conversationhttps://github.com/microsoft/TypeScript/pull/35639
Commits1 (1)https://github.com/microsoft/TypeScript/pull/35639/commits
Checkshttps://github.com/microsoft/TypeScript/pull/35639/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/35639/files
Fix binding of this-assignments w/computed propertieshttps://github.com/microsoft/TypeScript/pull/35639#top
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
fix-binding-this-computed-property-assignmenthttps://github.com/microsoft/TypeScript/tree/fix-binding-this-computed-property-assignment
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Dec 11, 2019https://github.com/microsoft/TypeScript/pull/35639#issue-536669447
#35630https://github.com/microsoft/TypeScript/issues/35630
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/35639
https://github.com/sandersn
Fix binding of this-assignments w/computed propertieshttps://github.com/microsoft/TypeScript/pull/35639/commits/7c31be3b1758b55c6fec95f9630370d5bc916631
7c31be3https://github.com/microsoft/TypeScript/pull/35639/commits/7c31be3b1758b55c6fec95f9630370d5bc916631
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Wesley Wigham (weswigham)https://github.com/weswigham
December 11, 2019 23:24https://github.com/microsoft/TypeScript/pull/35639#event-2876121774
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Dec 11, 2019 https://github.com/microsoft/TypeScript/pull/35639#pullrequestreview-330912853
View reviewed changes https://github.com/microsoft/TypeScript/pull/35639/files/7c31be3b1758b55c6fec95f9630370d5bc916631
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
b98cb06https://github.com/microsoft/TypeScript/commit/b98cb0645d2e44947b369a4f7d8921f7d5ca8c56
Dec 11, 2019https://github.com/microsoft/TypeScript/pull/35639#event-2876175722
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Dec 11, 2019https://github.com/microsoft/TypeScript/pull/35639#issuecomment-564786153
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/35639
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Dec 11, 2019 https://github.com/microsoft/TypeScript/pull/35639#ref-pullrequest-536679785
🤖 Cherry-pick PR #35639 into release-3.7 #35640 https://github.com/microsoft/TypeScript/pull/35640
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Dec 11, 2019https://github.com/microsoft/TypeScript/pull/35639#issuecomment-564787187
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
#35640https://github.com/microsoft/TypeScript/pull/35640
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/35639
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Dec 11, 2019 https://github.com/microsoft/TypeScript/pull/35639#ref-commit-88adf89
https://github.com/sandersn
https://github.com/typescript-bot
Cherry-pick PRhttps://github.com/typescript-bot/TypeScript/commit/88adf89c62576e7441ca516e0ab01f014a53ed5a
microsoft#35639https://github.com/microsoft/TypeScript/pull/35639
into release-3.7https://github.com/typescript-bot/TypeScript/commit/88adf89c62576e7441ca516e0ab01f014a53ed5a
88adf89https://github.com/typescript-bot/TypeScript/commit/88adf89c62576e7441ca516e0ab01f014a53ed5a
7c31be3https://github.com/typescript-bot/TypeScript/commit/7c31be3b1758b55c6fec95f9630370d5bc916631
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Dec 12, 2019 https://github.com/microsoft/TypeScript/pull/35639#ref-commit-eb5170c
https://github.com/sandersn
Cherry-pick PRhttps://github.com/microsoft/TypeScript/commit/eb5170c7608d64a581dff5331274be811026ada1
#35639https://github.com/microsoft/TypeScript/pull/35639
into release-3.7 (https://github.com/microsoft/TypeScript/commit/eb5170c7608d64a581dff5331274be811026ada1
#35640https://github.com/microsoft/TypeScript/pull/35640
)https://github.com/microsoft/TypeScript/commit/eb5170c7608d64a581dff5331274be811026ada1
eb5170chttps://github.com/microsoft/TypeScript/commit/eb5170c7608d64a581dff5331274be811026ada1
7c31be3https://github.com/microsoft/TypeScript/commit/7c31be3b1758b55c6fec95f9630370d5bc916631
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
December 12, 2019 17:39https://github.com/microsoft/TypeScript/pull/35639#event-2878801726
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/35639#event-20416845771
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/35639#event-20416846643
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F35639
https://github.com/andrewbranch
Andrew Branch (andrewbranch) https://github.com/andrewbranch
https://github.com/microsoft/TypeScript/pull/35639/files/7c31be3b1758b55c6fec95f9630370d5bc916631
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/35639
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
VS tsserver crash in openExternalProjects: Error processing request. Debug Failure. False expression. https://github.com/microsoft/TypeScript/issues/35630
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/35639
https://github.com/sandersn
https://github.com/typescript-bot
https://github.com/andrewbranch
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.