René's URL Explorer Experiment


Title: Improve control flow type caching by ahejlsberg · Pull Request #35332 · microsoft/TypeScript · GitHub

Open Graph Title: Improve control flow type caching by ahejlsberg · Pull Request #35332 · microsoft/TypeScript

X Title: Improve control flow type caching by ahejlsberg · Pull Request #35332 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Improve control flow type caching by ahejlsberg · Pull Request #35332 · microsoft/TypeScript

Open Graph Description: This PR improves performance of getTypeOfExpression by caching results whenever control flow analysis was required to compute them. Unlike our existing caching schemes, this implementation works ev...

X Description: This PR improves performance of getTypeOfExpression by caching results whenever control flow analysis was required to compute them. Unlike our existing caching schemes, this implementation works ev...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/35332

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:665b8420-78f8-3e3e-bac7-679b3add8e89
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAF7C:10DACD:F01914:13F86CA:6B010787
html-safe-nonce21f819b989498b8b09a92c90d943f4354bcbd9c19ee2783e22ab8fa97c70273c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjdDOjEwREFDRDpGMDE5MTQ6MTNGODZDQTo2QjAxMDc4NyIsInZpc2l0b3JfaWQiOiI3MDk2MjE4MjQwMzg4NDk5MzM1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac560c2872e59978152807b7ce88f8e7b764300daa13f42b4b1d8e3a17302b2d5f
hovercard-subject-tagpull_request:345333611
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/35332/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1e1359d286664f6ae6797dadbf11e366047eaf21c180937f3db92c926d995700/microsoft/TypeScript/pull/35332
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1e1359d286664f6ae6797dadbf11e366047eaf21c180937f3db92c926d995700/microsoft/TypeScript/pull/35332
og:image:altThis PR improves performance of getTypeOfExpression by caching results whenever control flow analysis was required to compute them. Unlike our existing caching schemes, this implementation works ev...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameahejlsberg
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/35332#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F35332
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F35332
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/35332
Reloadhttps://github.com/microsoft/TypeScript/pull/35332
Reloadhttps://github.com/microsoft/TypeScript/pull/35332
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
masterhttps://github.com/microsoft/TypeScript/tree/master
cacheGetTypeOfExpressionhttps://github.com/microsoft/TypeScript/tree/cacheGetTypeOfExpression
Conversationhttps://github.com/microsoft/TypeScript/pull/35332
Commits3 (3)https://github.com/microsoft/TypeScript/pull/35332/commits
Checkshttps://github.com/microsoft/TypeScript/pull/35332/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/35332/files
Improve control flow type cachinghttps://github.com/microsoft/TypeScript/pull/35332#top
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
masterhttps://github.com/microsoft/TypeScript/tree/master
cacheGetTypeOfExpressionhttps://github.com/microsoft/TypeScript/tree/cacheGetTypeOfExpression
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Nov 25, 2019https://github.com/microsoft/TypeScript/pull/35332#issue-528231289
#35205https://github.com/microsoft/TypeScript/issues/35205
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/35332
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
November 25, 2019 09:08https://github.com/microsoft/TypeScript/pull/35332#commits-pushed-725aa48
https://github.com/ahejlsberg
Cache getTypeOfExpression results when CFA was invokedhttps://github.com/microsoft/TypeScript/pull/35332/commits/725aa48a6911e9e6cfd7110d068750933de22604
725aa48https://github.com/microsoft/TypeScript/pull/35332/commits/725aa48a6911e9e6cfd7110d068750933de22604
https://github.com/ahejlsberg
Add testshttps://github.com/microsoft/TypeScript/pull/35332/commits/5de5e09d8cc01bd19f604e735b640ac07d9e929f
5de5e09https://github.com/microsoft/TypeScript/pull/35332/commits/5de5e09d8cc01bd19f604e735b640ac07d9e929f
https://github.com/ahejlsberg
Accept new baselineshttps://github.com/microsoft/TypeScript/pull/35332/commits/2d19e83f5c5f38001f0f765b3b97d1d6656c7b5d
2d19e83https://github.com/microsoft/TypeScript/pull/35332/commits/2d19e83f5c5f38001f0f765b3b97d1d6656c7b5d
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Nov 25, 2019https://github.com/microsoft/TypeScript/pull/35332#issuecomment-558258761
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/35332
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Nov 25, 2019https://github.com/microsoft/TypeScript/pull/35332#issuecomment-558258793
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/35332
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
2d19e83https://github.com/microsoft/TypeScript/commit/2d19e83f5c5f38001f0f765b3b97d1d6656c7b5d
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=55360
The results are in!https://github.com/microsoft/TypeScript/pull/35332#issuecomment-558268030
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/35332
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Nov 25, 2019https://github.com/microsoft/TypeScript/pull/35332#issuecomment-558258794
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/35332
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
2d19e83https://github.com/microsoft/TypeScript/commit/2d19e83f5c5f38001f0f765b3b97d1d6656c7b5d
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=55361
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/35332
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Nov 25, 2019https://github.com/microsoft/TypeScript/pull/35332#issuecomment-558258795
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/35332
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
2d19e83https://github.com/microsoft/TypeScript/commit/2d19e83f5c5f38001f0f765b3b97d1d6656c7b5d
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=55362
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/35332
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Nov 25, 2019https://github.com/microsoft/TypeScript/pull/35332#issuecomment-558258796
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/35332
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
2d19e83https://github.com/microsoft/TypeScript/commit/2d19e83f5c5f38001f0f765b3b97d1d6656c7b5d
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=55363
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/35332
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Wesley Wigham (weswigham)https://github.com/weswigham
November 25, 2019 17:29https://github.com/microsoft/TypeScript/pull/35332#event-2828991704
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Nov 25, 2019https://github.com/microsoft/TypeScript/pull/35332#issuecomment-558268030
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/35332
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Nov 25, 2019 https://github.com/microsoft/TypeScript/pull/35332#ref-pullrequest-528246297
🤖 User test baselines have changed for cacheGetTypeOfExpression #35333 https://github.com/microsoft/TypeScript/pull/35333
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Nov 25, 2019https://github.com/microsoft/TypeScript/pull/35332#issuecomment-558270304
PR with the baseline diff from masterhttps://github.com/microsoft/TypeScript/pull/35333
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/35332
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Nov 25, 2019 https://github.com/microsoft/TypeScript/pull/35332#pullrequestreview-322474062
View reviewed changes https://github.com/microsoft/TypeScript/pull/35332/files/2d19e83f5c5f38001f0f765b3b97d1d6656c7b5d
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/35332/files/2d19e83f5c5f38001f0f765b3b97d1d6656c7b5d#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Wesley Wigham (weswigham)https://github.com/weswigham
Nov 25, 2019https://github.com/microsoft/TypeScript/pull/35332#discussion_r350338381
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/35332
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Nov 25, 2019https://github.com/microsoft/TypeScript/pull/35332#discussion_r350374333
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/35332
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Nov 25, 2019 https://github.com/microsoft/TypeScript/pull/35332#pullrequestreview-322476042
View reviewed changes https://github.com/microsoft/TypeScript/pull/35332/files/2d19e83f5c5f38001f0f765b3b97d1d6656c7b5d
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/35332/files/2d19e83f5c5f38001f0f765b3b97d1d6656c7b5d#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Wesley Wigham (weswigham)https://github.com/weswigham
Nov 25, 2019https://github.com/microsoft/TypeScript/pull/35332#discussion_r350339871
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/35332
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Nov 25, 2019https://github.com/microsoft/TypeScript/pull/35332#discussion_r350372957
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/35332
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Nov 25, 2019https://github.com/microsoft/TypeScript/pull/35332#issuecomment-558299225
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/35332
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Nov 25, 2019 https://github.com/microsoft/TypeScript/pull/35332#pullrequestreview-322611199
View reviewed changes https://github.com/microsoft/TypeScript/pull/35332/files/2d19e83f5c5f38001f0f765b3b97d1d6656c7b5d
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/35332/files/2d19e83f5c5f38001f0f765b3b97d1d6656c7b5d#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Wesley Wigham (weswigham)https://github.com/weswigham
Nov 25, 2019https://github.com/microsoft/TypeScript/pull/35332#discussion_r350448711
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/35332
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Nov 25, 2019 https://github.com/microsoft/TypeScript/pull/35332#pullrequestreview-322612964
View reviewed changes https://github.com/microsoft/TypeScript/pull/35332/files/2d19e83f5c5f38001f0f765b3b97d1d6656c7b5d
Wesley Wigham (weswigham)https://github.com/weswigham
https://github.com/microsoft/TypeScript/pull/35332#pullrequestreview-322612964
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/35332
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
ea4e6b3https://github.com/microsoft/TypeScript/commit/ea4e6b31ba63418156b0cf3d18141f69e587f261
Nov 25, 2019https://github.com/microsoft/TypeScript/pull/35332#event-2829950598
https://github.com/orta
Orta Therox (orta)https://github.com/orta
Nov 27, 2019 https://github.com/microsoft/TypeScript/pull/35332#ref-issue-483977150
vscode tsserver intellisense not working #33028 https://github.com/microsoft/TypeScript/issues/33028
https://github.com/JoostK
Joost Koehoorn (JoostK)https://github.com/JoostK
Jan 9, 2020 https://github.com/microsoft/TypeScript/pull/35332#ref-issue-547560948
large angular application v9 build extreamly slow >20m angular/angular#34699 https://github.com/angular/angular/issues/34699
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Feb 29, 2020 https://github.com/microsoft/TypeScript/pull/35332#ref-pullrequest-573365565
Remove ordering restrictions in control flow analysis #37134 https://github.com/microsoft/TypeScript/pull/37134
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
November 7, 2022 17:34https://github.com/microsoft/TypeScript/pull/35332#event-7754882504
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/35332#event-20416830058
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/35332#event-20416830471
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F35332
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
https://github.com/microsoft/TypeScript/pull/35332/files/2d19e83f5c5f38001f0f765b3b97d1d6656c7b5d
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/35332
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg) https://github.com/ahejlsberg
perf: exponential slowdown due to type narrowing with enums / type unions https://github.com/microsoft/TypeScript/issues/35205
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/35332
https://github.com/ahejlsberg
https://github.com/typescript-bot
https://github.com/weswigham
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.