| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:26c03459-c9e4-6741-462c-189c52b4fa63 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9F76:1F7384:97F0D4:CAD99F:6B00E536 |
| html-safe-nonce | b88699c074e2a9798f8a43a735910cb1dc2aa5fe354d8f492e3dcfdfc0e58f2b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Rjc2OjFGNzM4NDo5N0YwRDQ6Q0FEOTlGOjZCMDBFNTM2IiwidmlzaXRvcl9pZCI6Ijg0MzY2MjkyMjM2Nzc5NDUxNDIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | aa9210d1a726d3521128db5467a0ca8afafe58489813ffcf7ad1c40125f4c25d |
| hovercard-subject-tag | pull_request:338898831 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/35011/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/9c2d71c48745aa107e880d03954f7ee3fd64962b0ddea4b9c17e2c583e58426e/microsoft/TypeScript/pull/35011 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9c2d71c48745aa107e880d03954f7ee3fd64962b0ddea4b9c17e2c583e58426e/microsoft/TypeScript/pull/35011 |
| og:image:alt | Should help with #34843.
Basically, if go-to-defintion causes a node_modules file to be opened, it should probably not trigger loading of a new project (typically, the one at the project root, sinc... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | amcasey |
| hostname | github.com |
| expected-hostname | github.com |
| None | 27088b6977484d0d3321d9a11c907c6d6637b315cfa359ef7952dbf6292f9b14 |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 624179fb8b88d26ba5bba08894eb60a1c5a1d93d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/35011#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F35011 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F35011 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/35011 |
| Reload | https://github.com/microsoft/TypeScript/pull/35011 |
| Reload | https://github.com/microsoft/TypeScript/pull/35011 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests308 (308) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| microsoft:master | https://github.com/microsoft/TypeScript/tree/master |
| amcasey:NodeModulesProjectRoot | https://github.com/amcasey/TypeScript/tree/NodeModulesProjectRoot |
| Conversation | https://github.com/microsoft/TypeScript/pull/35011 |
| Commits3 (3) | https://github.com/microsoft/TypeScript/pull/35011/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/35011/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/35011/files |
| Stop looking for the default configured project at node_modules | https://github.com/microsoft/TypeScript/pull/35011#top |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| microsoft:master | https://github.com/microsoft/TypeScript/tree/master |
| amcasey:NodeModulesProjectRoot | https://github.com/amcasey/TypeScript/tree/NodeModulesProjectRoot |
|
| https://github.com/amcasey |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| Nov 8, 2019 | https://github.com/microsoft/TypeScript/pull/35011#issue-520282617 |
| #34843 | https://github.com/microsoft/TypeScript/issues/34843 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/35011 |
| https://github.com/amcasey |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
| November 8, 2019 23:29 | https://github.com/microsoft/TypeScript/pull/35011#event-2784833256 |
| https://github.com/amcasey |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| Nov 8, 2019 | https://github.com/microsoft/TypeScript/pull/35011#issuecomment-552034480 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/35011 |
| https://github.com/amcasey |
| Andrew Casey (amcasey) | https://github.com/amcasey |
|
Nov 11, 2019
| https://github.com/microsoft/TypeScript/pull/35011#pullrequestreview-315074199 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/35011/files |
| src/server/editorServices.ts | https://github.com/microsoft/TypeScript/pull/35011/files#diff-501dedafe824c2480f7f02a2cb5295a90d81a09b45aafaa135b739b51b108cb6 |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| Nov 11, 2019 | https://github.com/microsoft/TypeScript/pull/35011#discussion_r344845604 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Sheetal Nandi (@sheetalkamat) | https://github.com/sheetalkamat |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/35011 |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
| Nov 11, 2019 | https://github.com/microsoft/TypeScript/pull/35011#discussion_r344872878 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/35011 |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| Nov 11, 2019 | https://github.com/microsoft/TypeScript/pull/35011#discussion_r344912059 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/35011 |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
| Nov 11, 2019 | https://github.com/microsoft/TypeScript/pull/35011#discussion_r344919026 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/microsoft/TypeScript/blob/master/src/server/editorServices.ts#L2670 | https://github.com/microsoft/TypeScript/blob/master/src/server/editorServices.ts#L2670 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/35011 |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| Nov 11, 2019 | https://github.com/microsoft/TypeScript/pull/35011#discussion_r344923436 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/35011 |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| Feb 28, 2020 | https://github.com/microsoft/TypeScript/pull/35011#discussion_r385471952 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Sheetal Nandi (@sheetalkamat) | https://github.com/sheetalkamat |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/35011 |
|
| https://github.com/amcasey |
| Optionally stop looking for the default configured project at | https://github.com/microsoft/TypeScript/pull/35011/commits/6515d375bd602e7c711101e5b44356636b583647 |
| 6515d37 | https://github.com/microsoft/TypeScript/pull/35011/commits/6515d375bd602e7c711101e5b44356636b583647 |
| https://github.com/amcasey |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| force-pushed | https://github.com/microsoft/TypeScript/compare/8d35b16272d51ea72d9f4224ad6cc92ef68e3afa..6515d375bd602e7c711101e5b44356636b583647 |
| 8d35b16 | https://github.com/microsoft/TypeScript/commit/8d35b16272d51ea72d9f4224ad6cc92ef68e3afa |
| 6515d37 | https://github.com/microsoft/TypeScript/commit/6515d375bd602e7c711101e5b44356636b583647 |
|
Compare
| https://github.com/microsoft/TypeScript/compare/8d35b16272d51ea72d9f4224ad6cc92ef68e3afa..6515d375bd602e7c711101e5b44356636b583647 |
| February 28, 2020 01:56 | https://github.com/microsoft/TypeScript/pull/35011#event-3080164561 |
| https://github.com/amcasey |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| Feb 28, 2020 | https://github.com/microsoft/TypeScript/pull/35011#issuecomment-592272567 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/35011 |
| https://github.com/amcasey |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| February 28, 2020 01:58 | https://github.com/microsoft/TypeScript/pull/35011#event-3080167778 |
| https://github.com/amcasey |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| Feb 28, 2020 | https://github.com/microsoft/TypeScript/pull/35011#issuecomment-592272726 |
| Anders Hejlsberg (@ahejlsberg) | https://github.com/ahejlsberg |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/35011 |
|
| https://github.com/amcasey |
| Make stopping at node_modules non-optional | https://github.com/microsoft/TypeScript/pull/35011/commits/c2a412c50221b55d8916c2671f6e807ae3bdfb21 |
| c2a412c | https://github.com/microsoft/TypeScript/pull/35011/commits/c2a412c50221b55d8916c2671f6e807ae3bdfb21 |
| https://github.com/amcasey |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| Mar 2, 2020 | https://github.com/microsoft/TypeScript/pull/35011#event-3089804573 |
|
| https://github.com/amcasey |
| Generalize and simplify the change - node_modules files don't have de… | https://github.com/microsoft/TypeScript/pull/35011/commits/cb4a0a5f074fc77095ff27e7a582fd0c1297a56c |
| cb4a0a5 | https://github.com/microsoft/TypeScript/pull/35011/commits/cb4a0a5f074fc77095ff27e7a582fd0c1297a56c |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
|
Mar 2, 2020
| https://github.com/microsoft/TypeScript/pull/35011#pullrequestreview-367583083 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/35011/files/cb4a0a5f074fc77095ff27e7a582fd0c1297a56c |
| https://github.com/amcasey |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| dd6811f | https://github.com/microsoft/TypeScript/commit/dd6811fbe37f05a2b79427112a919d75a7417176 |
| Mar 3, 2020 | https://github.com/microsoft/TypeScript/pull/35011#event-3090244164 |
| https://github.com/amcasey |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| March 3, 2020 00:52 | https://github.com/microsoft/TypeScript/pull/35011#event-3090244304 |
| https://github.com/sheetalkamat |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
|
Mar 3, 2020
| https://github.com/microsoft/TypeScript/pull/35011#pullrequestreview-368211427 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/35011/files/cb4a0a5f074fc77095ff27e7a582fd0c1297a56c |
| src/server/editorServices.ts | https://github.com/microsoft/TypeScript/pull/35011/files/cb4a0a5f074fc77095ff27e7a582fd0c1297a56c#diff-501dedafe824c2480f7f02a2cb5295a90d81a09b45aafaa135b739b51b108cb6 |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
| Mar 3, 2020 | https://github.com/microsoft/TypeScript/pull/35011#discussion_r387203779 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/35011 |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| Mar 3, 2020 | https://github.com/microsoft/TypeScript/pull/35011#discussion_r387210577 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/35011 |
| Andrew Casey (amcasey) | https://github.com/amcasey |
|
Mar 10, 2020
| https://github.com/microsoft/TypeScript/pull/35011#ref-commit-bf71b9d |
|
| https://github.com/amcasey |
| Add test for | https://github.com/amcasey/TypeScript/commit/bf71b9d992037cfd550a735addc77769150db487 |
| microsoft#35011 | https://github.com/microsoft/TypeScript/pull/35011 |
| bf71b9d | https://github.com/amcasey/TypeScript/commit/bf71b9d992037cfd550a735addc77769150db487 |
| Andrew Casey (amcasey) | https://github.com/amcasey |
|
Mar 25, 2020
| https://github.com/microsoft/TypeScript/pull/35011#ref-commit-e1772fa |
|
| https://github.com/amcasey |
| Add test for | https://github.com/microsoft/TypeScript/commit/e1772fa40ee6858d09b1ad9f614c4b078f399c45 |
| #35011 | https://github.com/microsoft/TypeScript/pull/35011 |
| ( | https://github.com/microsoft/TypeScript/commit/e1772fa40ee6858d09b1ad9f614c4b078f399c45 |
| #37312 | https://github.com/microsoft/TypeScript/pull/37312 |
| ) | https://github.com/microsoft/TypeScript/commit/e1772fa40ee6858d09b1ad9f614c4b078f399c45 |
| e1772fa | https://github.com/microsoft/TypeScript/commit/e1772fa40ee6858d09b1ad9f614c4b078f399c45 |
| #35011 | https://github.com/microsoft/TypeScript/pull/35011 |
| https://github.com/sheetalkamat |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
|
May 7, 2020
| https://github.com/microsoft/TypeScript/pull/35011#ref-pullrequest-605155507 |
|
🤖 User test baselines have changed for refs/heads/master
#38128
| https://github.com/microsoft/TypeScript/pull/38128 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Oct 21, 2025 | https://github.com/microsoft/TypeScript/pull/35011#event-20416819898 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F35011 |
|
| https://github.com/sheetalkamat |
|
Sheetal Nandi (sheetalkamat)
| https://github.com/sheetalkamat |
|
| https://github.com/microsoft/TypeScript/pull/35011/files/cb4a0a5f074fc77095ff27e7a582fd0c1297a56c |
|
| https://github.com/ahejlsberg |
|
Anders Hejlsberg (ahejlsberg)
| https://github.com/ahejlsberg |
|
| https://github.com/microsoft/TypeScript/pull/35011/files/cb4a0a5f074fc77095ff27e7a582fd0c1297a56c |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/35011 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/35011 |
|
| https://github.com/amcasey |
|
| https://github.com/ahejlsberg |
|
| https://github.com/sheetalkamat |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |