René's URL Explorer Experiment


Title: Fix excess property checking for unions with index signatures by ahejlsberg · Pull Request #34927 · microsoft/TypeScript · GitHub

Open Graph Title: Fix excess property checking for unions with index signatures by ahejlsberg · Pull Request #34927 · microsoft/TypeScript

X Title: Fix excess property checking for unions with index signatures by ahejlsberg · Pull Request #34927 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Fix excess property checking for unions with index signatures by ahejlsberg · Pull Request #34927 · microsoft/TypeScript

Open Graph Description: This PR revises our excess property checking logic to properly handle union types with index signatures. For example, both of the following now error where previously they didn't: const obj1: {...

X Description: This PR revises our excess property checking logic to properly handle union types with index signatures. For example, both of the following now error where previously they didn't: const obj...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/34927

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:56dec612-a058-570a-8e92-37b53627436f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD9C0:117C62:A85F92:E234F2:6B00F042
html-safe-nonceb31556c3330019337cfe787f3c0b66884c15122540f899a1796b078b40c381dc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOUMwOjExN0M2MjpBODVGOTI6RTIzNEYyOjZCMDBGMDQyIiwidmlzaXRvcl9pZCI6IjY1NTIzODA1MTM0NzcyNTkzMzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace8384cc3cf03b9b070da219bf613bdc71b4dafe375e4dbdff116d53e8fb3d8b9
hovercard-subject-tagpull_request:337005554
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/34927/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b9ee93be4702433dedc50f965475d1a31eb2fffaf749367b3be8f9ce4e0cd23a/microsoft/TypeScript/pull/34927
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b9ee93be4702433dedc50f965475d1a31eb2fffaf749367b3be8f9ce4e0cd23a/microsoft/TypeScript/pull/34927
og:image:altThis PR revises our excess property checking logic to properly handle union types with index signatures. For example, both of the following now error where previously they didn't: const obj1: {...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameahejlsberg
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/34927#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F34927
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F34927
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/34927
Reloadhttps://github.com/microsoft/TypeScript/pull/34927
Reloadhttps://github.com/microsoft/TypeScript/pull/34927
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests308 (308)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
masterhttps://github.com/microsoft/TypeScript/tree/master
fix34611https://github.com/microsoft/TypeScript/tree/fix34611
Conversationhttps://github.com/microsoft/TypeScript/pull/34927
Commits5 (5)https://github.com/microsoft/TypeScript/pull/34927/commits
Checkshttps://github.com/microsoft/TypeScript/pull/34927/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/34927/files
Fix excess property checking for unions with index signatureshttps://github.com/microsoft/TypeScript/pull/34927#top
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
masterhttps://github.com/microsoft/TypeScript/tree/master
fix34611https://github.com/microsoft/TypeScript/tree/fix34611
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Nov 5, 2019https://github.com/microsoft/TypeScript/pull/34927#issue-518047736
#34611https://github.com/microsoft/TypeScript/issues/34611
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34927
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
November 5, 2019 09:07https://github.com/microsoft/TypeScript/pull/34927#commits-pushed-77f5768
https://github.com/ahejlsberg
Fix excess property checking for union targets with index signatureshttps://github.com/microsoft/TypeScript/pull/34927/commits/77f57688974809063247bb8aecb667351fcd4117
77f5768https://github.com/microsoft/TypeScript/pull/34927/commits/77f57688974809063247bb8aecb667351fcd4117
https://github.com/ahejlsberg
Accept new baselineshttps://github.com/microsoft/TypeScript/pull/34927/commits/6c981fd9a6a7228048b4ec3031c9cf9e488e323f
6c981fdhttps://github.com/microsoft/TypeScript/pull/34927/commits/6c981fd9a6a7228048b4ec3031c9cf9e488e323f
https://github.com/ahejlsberg
Remove unused codehttps://github.com/microsoft/TypeScript/pull/34927/commits/1509fefa152e471e62fc52b5472a010553749ea2
1509fefhttps://github.com/microsoft/TypeScript/pull/34927/commits/1509fefa152e471e62fc52b5472a010553749ea2
https://github.com/ahejlsberg
Add testshttps://github.com/microsoft/TypeScript/pull/34927/commits/f5d6327dbdc24e5d7f0c90e649b5a17a01c68f02
f5d6327https://github.com/microsoft/TypeScript/pull/34927/commits/f5d6327dbdc24e5d7f0c90e649b5a17a01c68f02
https://github.com/ahejlsberg
Accept new baselineshttps://github.com/microsoft/TypeScript/pull/34927/commits/386e55078f07b11821d0666be4a56b57655a6dff
386e550https://github.com/microsoft/TypeScript/pull/34927/commits/386e55078f07b11821d0666be4a56b57655a6dff
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Nov 5, 2019https://github.com/microsoft/TypeScript/pull/34927#issuecomment-550037837
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34927
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Nov 5, 2019https://github.com/microsoft/TypeScript/pull/34927#issuecomment-550037871
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34927
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
386e550https://github.com/microsoft/TypeScript/commit/386e55078f07b11821d0666be4a56b57655a6dff
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=52520
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34927
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Nov 5, 2019https://github.com/microsoft/TypeScript/pull/34927#issuecomment-550037872
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34927
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
386e550https://github.com/microsoft/TypeScript/commit/386e55078f07b11821d0666be4a56b57655a6dff
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=52519
The results are in!https://github.com/microsoft/TypeScript/pull/34927#issuecomment-550046885
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34927
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Nov 5, 2019https://github.com/microsoft/TypeScript/pull/34927#issuecomment-550037874
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34927
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
386e550https://github.com/microsoft/TypeScript/commit/386e55078f07b11821d0666be4a56b57655a6dff
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=52521
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34927
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Nov 5, 2019https://github.com/microsoft/TypeScript/pull/34927#issuecomment-550046885
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34927
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Wesley Wigham (weswigham)https://github.com/weswigham
November 5, 2019 22:28https://github.com/microsoft/TypeScript/pull/34927#event-2773236948
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Nov 6, 2019https://github.com/microsoft/TypeScript/pull/34927#issuecomment-550089332
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34927
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Nov 6, 2019 https://github.com/microsoft/TypeScript/pull/34927#pullrequestreview-312771873
View reviewed changes https://github.com/microsoft/TypeScript/pull/34927/files/386e55078f07b11821d0666be4a56b57655a6dff
Wesley Wigham (weswigham)https://github.com/weswigham
https://github.com/microsoft/TypeScript/pull/34927#pullrequestreview-312771873
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34927
tests/baselines/reference/deepExcessPropertyCheckingWhenTargetIsIntersection.errors.txthttps://github.com/microsoft/TypeScript/pull/34927/files/386e55078f07b11821d0666be4a56b57655a6dff#diff-8809c5d5100db510f319530d3057d4d36f50b2545d65007d3574d7b4f465ec65
Wesley Wigham (weswigham)https://github.com/weswigham
Nov 6, 2019https://github.com/microsoft/TypeScript/pull/34927#discussion_r343349616
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34927
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34927
tests/baselines/reference/discriminateObjectTypesOnly.errors.txthttps://github.com/microsoft/TypeScript/pull/34927/files/386e55078f07b11821d0666be4a56b57655a6dff#diff-713434352a17def6036acfabc1b40cc09289ad9aa6d141272ad38ec4263c81ce
Wesley Wigham (weswigham)https://github.com/weswigham
Nov 6, 2019https://github.com/microsoft/TypeScript/pull/34927#discussion_r343351013
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#31708https://github.com/microsoft/TypeScript/pull/31708
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34927
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Nov 11, 2019https://github.com/microsoft/TypeScript/pull/34927#discussion_r344785387
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#31708https://github.com/microsoft/TypeScript/pull/31708
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34927
Wesley Wigham (weswigham)https://github.com/weswigham
Nov 11, 2019https://github.com/microsoft/TypeScript/pull/34927#discussion_r344816729
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34927
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Nov 12, 2019https://github.com/microsoft/TypeScript/pull/34927#discussion_r345248469
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34927
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Nov 13, 2019 https://github.com/microsoft/TypeScript/pull/34927#ref-pullrequest-522489081
Prepare for TS #34927 DefinitelyTyped/DefinitelyTyped#40365 https://github.com/DefinitelyTyped/DefinitelyTyped/pull/40365
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Nov 15, 2019 https://github.com/microsoft/TypeScript/pull/34927#pullrequestreview-317804572
View reviewed changes https://github.com/microsoft/TypeScript/pull/34927/files/386e55078f07b11821d0666be4a56b57655a6dff
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Breaking Change https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Breaking%20Change%22
Nov 15, 2019https://github.com/microsoft/TypeScript/pull/34927#event-2803647905
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Nov 15, 2019https://github.com/microsoft/TypeScript/pull/34927#issuecomment-554485065
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34927
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
196c0aahttps://github.com/microsoft/TypeScript/commit/196c0aa0783ddd7520f9accd54d53c3223f5a47c
Nov 15, 2019https://github.com/microsoft/TypeScript/pull/34927#event-2803660295
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
November 15, 2019 19:00https://github.com/microsoft/TypeScript/pull/34927#event-2803660601
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/34927#event-20416817414
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/34927#event-20416817867
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F34927
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
https://github.com/microsoft/TypeScript/pull/34927/files/386e55078f07b11821d0666be4a56b57655a6dff
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh) https://github.com/RyanCavanaugh
https://github.com/microsoft/TypeScript/pull/34927/files/386e55078f07b11821d0666be4a56b57655a6dff
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34927
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg) https://github.com/ahejlsberg
Breaking Change https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Breaking%20Change%22
Type checking does not works for indexable type with number keys OR string keys https://github.com/microsoft/TypeScript/issues/34611
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34927
https://github.com/ahejlsberg
https://github.com/typescript-bot
https://github.com/weswigham
https://github.com/RyanCavanaugh
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.