| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:56dec612-a058-570a-8e92-37b53627436f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D9C0:117C62:A85F92:E234F2:6B00F042 |
| html-safe-nonce | b31556c3330019337cfe787f3c0b66884c15122540f899a1796b078b40c381dc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOUMwOjExN0M2MjpBODVGOTI6RTIzNEYyOjZCMDBGMDQyIiwidmlzaXRvcl9pZCI6IjY1NTIzODA1MTM0NzcyNTkzMzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | e8384cc3cf03b9b070da219bf613bdc71b4dafe375e4dbdff116d53e8fb3d8b9 |
| hovercard-subject-tag | pull_request:337005554 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/34927/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b9ee93be4702433dedc50f965475d1a31eb2fffaf749367b3be8f9ce4e0cd23a/microsoft/TypeScript/pull/34927 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b9ee93be4702433dedc50f965475d1a31eb2fffaf749367b3be8f9ce4e0cd23a/microsoft/TypeScript/pull/34927 |
| og:image:alt | This PR revises our excess property checking logic to properly handle union types with index signatures. For example, both of the following now error where previously they didn't:
const obj1: {... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ahejlsberg |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/34927#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F34927 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F34927 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/34927 |
| Reload | https://github.com/microsoft/TypeScript/pull/34927 |
| Reload | https://github.com/microsoft/TypeScript/pull/34927 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests308 (308) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| master | https://github.com/microsoft/TypeScript/tree/master |
| fix34611 | https://github.com/microsoft/TypeScript/tree/fix34611 |
| Conversation | https://github.com/microsoft/TypeScript/pull/34927 |
| Commits5 (5) | https://github.com/microsoft/TypeScript/pull/34927/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/34927/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/34927/files |
| Fix excess property checking for unions with index signatures | https://github.com/microsoft/TypeScript/pull/34927#top |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| master | https://github.com/microsoft/TypeScript/tree/master |
| fix34611 | https://github.com/microsoft/TypeScript/tree/fix34611 |
|
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| Nov 5, 2019 | https://github.com/microsoft/TypeScript/pull/34927#issue-518047736 |
| #34611 | https://github.com/microsoft/TypeScript/issues/34611 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34927 |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| November 5, 2019 09:07 | https://github.com/microsoft/TypeScript/pull/34927#commits-pushed-77f5768 |
|
| https://github.com/ahejlsberg |
| Fix excess property checking for union targets with index signatures | https://github.com/microsoft/TypeScript/pull/34927/commits/77f57688974809063247bb8aecb667351fcd4117 |
| 77f5768 | https://github.com/microsoft/TypeScript/pull/34927/commits/77f57688974809063247bb8aecb667351fcd4117 |
|
| https://github.com/ahejlsberg |
| Accept new baselines | https://github.com/microsoft/TypeScript/pull/34927/commits/6c981fd9a6a7228048b4ec3031c9cf9e488e323f |
| 6c981fd | https://github.com/microsoft/TypeScript/pull/34927/commits/6c981fd9a6a7228048b4ec3031c9cf9e488e323f |
|
| https://github.com/ahejlsberg |
| Remove unused code | https://github.com/microsoft/TypeScript/pull/34927/commits/1509fefa152e471e62fc52b5472a010553749ea2 |
| 1509fef | https://github.com/microsoft/TypeScript/pull/34927/commits/1509fefa152e471e62fc52b5472a010553749ea2 |
|
| https://github.com/ahejlsberg |
| Add tests | https://github.com/microsoft/TypeScript/pull/34927/commits/f5d6327dbdc24e5d7f0c90e649b5a17a01c68f02 |
| f5d6327 | https://github.com/microsoft/TypeScript/pull/34927/commits/f5d6327dbdc24e5d7f0c90e649b5a17a01c68f02 |
|
| https://github.com/ahejlsberg |
| Accept new baselines | https://github.com/microsoft/TypeScript/pull/34927/commits/386e55078f07b11821d0666be4a56b57655a6dff |
| 386e550 | https://github.com/microsoft/TypeScript/pull/34927/commits/386e55078f07b11821d0666be4a56b57655a6dff |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| Nov 5, 2019 | https://github.com/microsoft/TypeScript/pull/34927#issuecomment-550037837 |
| TypeScript Bot (@typescript-bot) | https://github.com/typescript-bot |
| TypeScript Bot (@typescript-bot) | https://github.com/typescript-bot |
| TypeScript Bot (@typescript-bot) | https://github.com/typescript-bot |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34927 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Nov 5, 2019 | https://github.com/microsoft/TypeScript/pull/34927#issuecomment-550037871 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34927 |
| Anders Hejlsberg (@ahejlsberg) | https://github.com/ahejlsberg |
| 386e550 | https://github.com/microsoft/TypeScript/commit/386e55078f07b11821d0666be4a56b57655a6dff |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=52520 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34927 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Nov 5, 2019 | https://github.com/microsoft/TypeScript/pull/34927#issuecomment-550037872 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34927 |
| Anders Hejlsberg (@ahejlsberg) | https://github.com/ahejlsberg |
| 386e550 | https://github.com/microsoft/TypeScript/commit/386e55078f07b11821d0666be4a56b57655a6dff |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=52519 |
| The results are in! | https://github.com/microsoft/TypeScript/pull/34927#issuecomment-550046885 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34927 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Nov 5, 2019 | https://github.com/microsoft/TypeScript/pull/34927#issuecomment-550037874 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34927 |
| Anders Hejlsberg (@ahejlsberg) | https://github.com/ahejlsberg |
| 386e550 | https://github.com/microsoft/TypeScript/commit/386e55078f07b11821d0666be4a56b57655a6dff |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=52521 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34927 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Nov 5, 2019 | https://github.com/microsoft/TypeScript/pull/34927#issuecomment-550046885 |
| Anders Hejlsberg (@ahejlsberg) | https://github.com/ahejlsberg |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34927 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| Ryan Cavanaugh (RyanCavanaugh) | https://github.com/RyanCavanaugh |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| November 5, 2019 22:28 | https://github.com/microsoft/TypeScript/pull/34927#event-2773236948 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| Nov 6, 2019 | https://github.com/microsoft/TypeScript/pull/34927#issuecomment-550089332 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34927 |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
|
Nov 6, 2019
| https://github.com/microsoft/TypeScript/pull/34927#pullrequestreview-312771873 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/34927/files/386e55078f07b11821d0666be4a56b57655a6dff |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| https://github.com/microsoft/TypeScript/pull/34927#pullrequestreview-312771873 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34927 |
| tests/baselines/reference/deepExcessPropertyCheckingWhenTargetIsIntersection.errors.txt | https://github.com/microsoft/TypeScript/pull/34927/files/386e55078f07b11821d0666be4a56b57655a6dff#diff-8809c5d5100db510f319530d3057d4d36f50b2545d65007d3574d7b4f465ec65 |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Nov 6, 2019 | https://github.com/microsoft/TypeScript/pull/34927#discussion_r343349616 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34927 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34927 |
| tests/baselines/reference/discriminateObjectTypesOnly.errors.txt | https://github.com/microsoft/TypeScript/pull/34927/files/386e55078f07b11821d0666be4a56b57655a6dff#diff-713434352a17def6036acfabc1b40cc09289ad9aa6d141272ad38ec4263c81ce |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Nov 6, 2019 | https://github.com/microsoft/TypeScript/pull/34927#discussion_r343351013 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #31708 | https://github.com/microsoft/TypeScript/pull/31708 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34927 |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| Nov 11, 2019 | https://github.com/microsoft/TypeScript/pull/34927#discussion_r344785387 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #31708 | https://github.com/microsoft/TypeScript/pull/31708 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34927 |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Nov 11, 2019 | https://github.com/microsoft/TypeScript/pull/34927#discussion_r344816729 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34927 |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| Nov 12, 2019 | https://github.com/microsoft/TypeScript/pull/34927#discussion_r345248469 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34927 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
|
Nov 13, 2019
| https://github.com/microsoft/TypeScript/pull/34927#ref-pullrequest-522489081 |
|
Prepare for TS #34927
DefinitelyTyped/DefinitelyTyped#40365
| https://github.com/DefinitelyTyped/DefinitelyTyped/pull/40365 |
| https://github.com/RyanCavanaugh |
| Ryan Cavanaugh (RyanCavanaugh) | https://github.com/RyanCavanaugh |
|
Nov 15, 2019
| https://github.com/microsoft/TypeScript/pull/34927#pullrequestreview-317804572 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/34927/files/386e55078f07b11821d0666be4a56b57655a6dff |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
|
Breaking Change
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Breaking%20Change%22 |
| Nov 15, 2019 | https://github.com/microsoft/TypeScript/pull/34927#event-2803647905 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| Nov 15, 2019 | https://github.com/microsoft/TypeScript/pull/34927#issuecomment-554485065 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34927 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| 196c0aa | https://github.com/microsoft/TypeScript/commit/196c0aa0783ddd7520f9accd54d53c3223f5a47c |
| Nov 15, 2019 | https://github.com/microsoft/TypeScript/pull/34927#event-2803660295 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| November 15, 2019 19:00 | https://github.com/microsoft/TypeScript/pull/34927#event-2803660601 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Oct 21, 2025 | https://github.com/microsoft/TypeScript/pull/34927#event-20416817414 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| Oct 21, 2025 | https://github.com/microsoft/TypeScript/pull/34927#event-20416817867 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F34927 |
|
| https://github.com/weswigham |
|
Wesley Wigham (weswigham)
| https://github.com/weswigham |
|
| https://github.com/microsoft/TypeScript/pull/34927/files/386e55078f07b11821d0666be4a56b57655a6dff |
|
| https://github.com/RyanCavanaugh |
|
Ryan Cavanaugh (RyanCavanaugh)
| https://github.com/RyanCavanaugh |
|
| https://github.com/microsoft/TypeScript/pull/34927/files/386e55078f07b11821d0666be4a56b57655a6dff |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34927 |
|
| https://github.com/ahejlsberg |
|
Anders Hejlsberg (ahejlsberg)
| https://github.com/ahejlsberg |
|
Breaking Change
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Breaking%20Change%22 |
|
Type checking does not works for indexable type with number keys OR string keys
| https://github.com/microsoft/TypeScript/issues/34611 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34927 |
|
| https://github.com/ahejlsberg |
|
| https://github.com/typescript-bot |
|
| https://github.com/weswigham |
|
| https://github.com/RyanCavanaugh |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |