| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:9220cddd-f477-3b9f-1fe4-b5ebe54ae36b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C7F0:20AA01:2F49861:3C1A142:6B01AE73 |
| html-safe-nonce | 3f70242e8a65f07f7422197b6c003094793f29d807bd8ba57b195d0879836abc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDN0YwOjIwQUEwMToyRjQ5ODYxOjNDMUExNDI6NkIwMUFFNzMiLCJ2aXNpdG9yX2lkIjoiODAxMzA5MDk0OTQ1MjM3NzcxNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f78589a5952df79886e2c856e4a127bf2f9a0e5314ee854bd4cc2798a4d92fa9 |
| hovercard-subject-tag | pull_request:331737842 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/34683/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d96c46400ec1c3d9962cf9e67f4f0c0197683ab020741a9e30baa966cec79a34/microsoft/TypeScript/pull/34683 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d96c46400ec1c3d9962cf9e67f4f0c0197683ab020741a9e30baa966cec79a34/microsoft/TypeScript/pull/34683 |
| og:image:alt | Previously it only handled types whose declaration was from require, but now it handles types whose reference is an import type as well.
Fixes #34671
This doesn't explain the differences in chr... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sandersn |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/34683#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F34683 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F34683 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/34683 |
| Reload | https://github.com/microsoft/TypeScript/pull/34683 |
| Reload | https://github.com/microsoft/TypeScript/pull/34683 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests312 (312) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| master | https://github.com/microsoft/TypeScript/tree/master |
| fix-jsdoc-import-type-w/class | https://github.com/microsoft/TypeScript/tree/fix-jsdoc-import-type-w/class |
| Conversation | https://github.com/microsoft/TypeScript/pull/34683 |
| Commits1 (1) | https://github.com/microsoft/TypeScript/pull/34683/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/34683/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/34683/files |
| getTypeFromJSDocValueReference: handle import types | https://github.com/microsoft/TypeScript/pull/34683#top |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| master | https://github.com/microsoft/TypeScript/tree/master |
| fix-jsdoc-import-type-w/class | https://github.com/microsoft/TypeScript/tree/fix-jsdoc-import-type-w/class |
|
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Oct 23, 2019 | https://github.com/microsoft/TypeScript/pull/34683#issue-511562544 |
| #34671 | https://github.com/microsoft/TypeScript/issues/34671 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34683 |
|
| https://github.com/sandersn |
| getTypeFromJSDocValueReference: handle import types | https://github.com/microsoft/TypeScript/pull/34683/commits/2aa257df80e88a7ac920015f982ef549bf2121cb |
| 2aa257d | https://github.com/microsoft/TypeScript/pull/34683/commits/2aa257df80e88a7ac920015f982ef549bf2121cb |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
| Orta Therox (orta) | https://github.com/orta |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| October 23, 2019 20:46 | https://github.com/microsoft/TypeScript/pull/34683#event-2738516572 |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
|
Oct 23, 2019
| https://github.com/microsoft/TypeScript/pull/34683#pullrequestreview-306227109 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/34683/files/2aa257df80e88a7ac920015f982ef549bf2121cb |
| tests/cases/conformance/jsdoc/jsdocImportTypeReferenceToClassAlias.ts | https://github.com/microsoft/TypeScript/pull/34683/files/2aa257df80e88a7ac920015f982ef549bf2121cb#diff-d92c51257537f1b173d96542ad29df05ab6ab6b52938e85575200c5fae4b1e05 |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Oct 23, 2019 | https://github.com/microsoft/TypeScript/pull/34683#discussion_r338307019 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34683 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34683 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Oct 23, 2019 | https://github.com/microsoft/TypeScript/pull/34683#discussion_r338314304 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34683 |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
|
Oct 23, 2019
| https://github.com/microsoft/TypeScript/pull/34683#pullrequestreview-306236969 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/34683/files/2aa257df80e88a7ac920015f982ef549bf2121cb |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| 8223c07 | https://github.com/microsoft/TypeScript/commit/8223c0752773ed6d4d42934adadd3d2cb15d5c3d |
| Oct 23, 2019 | https://github.com/microsoft/TypeScript/pull/34683#event-2738816438 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| October 23, 2019 22:53 | https://github.com/microsoft/TypeScript/pull/34683#event-2738816577 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Oct 24, 2019 | https://github.com/microsoft/TypeScript/pull/34683#issuecomment-545985416 |
| TypeScript Bot (@typescript-bot) | https://github.com/typescript-bot |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34683 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
|
Oct 24, 2019
| https://github.com/microsoft/TypeScript/pull/34683#ref-pullrequest-512039485 |
|
🤖 Cherry-pick PR #34683 into release-3.7
#34705
| https://github.com/microsoft/TypeScript/pull/34705 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Oct 24, 2019 | https://github.com/microsoft/TypeScript/pull/34683#issuecomment-545987173 |
| Nathan Shively-Sanders (@sandersn) | https://github.com/sandersn |
| #34705 | https://github.com/microsoft/TypeScript/pull/34705 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34683 |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
|
Oct 24, 2019
| https://github.com/microsoft/TypeScript/pull/34683#ref-commit-d4cf30d |
|
| https://github.com/sandersn |
|
| https://github.com/typescript-bot |
| Cherry-pick PR | https://github.com/typescript-bot/TypeScript/commit/d4cf30dbd7b6646ab5172c2025b0939f513c7349 |
| microsoft#34683 | https://github.com/microsoft/TypeScript/pull/34683 |
| into release-3.7 | https://github.com/typescript-bot/TypeScript/commit/d4cf30dbd7b6646ab5172c2025b0939f513c7349 |
| d4cf30d | https://github.com/typescript-bot/TypeScript/commit/d4cf30dbd7b6646ab5172c2025b0939f513c7349 |
| 2aa257d | https://github.com/typescript-bot/TypeScript/commit/2aa257df80e88a7ac920015f982ef549bf2121cb |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
|
Oct 24, 2019
| https://github.com/microsoft/TypeScript/pull/34683#ref-commit-4930148 |
|
| https://github.com/sandersn |
| Cherry-pick PR | https://github.com/microsoft/TypeScript/commit/49301482a045a9e074c92f8fe0a93c6b249a6ed7 |
| #34683 | https://github.com/microsoft/TypeScript/pull/34683 |
| into release-3.7 ( | https://github.com/microsoft/TypeScript/commit/49301482a045a9e074c92f8fe0a93c6b249a6ed7 |
| #34705 | https://github.com/microsoft/TypeScript/pull/34705 |
| ) | https://github.com/microsoft/TypeScript/commit/49301482a045a9e074c92f8fe0a93c6b249a6ed7 |
| 4930148 | https://github.com/microsoft/TypeScript/commit/49301482a045a9e074c92f8fe0a93c6b249a6ed7 |
| 2aa257d | https://github.com/microsoft/TypeScript/commit/2aa257df80e88a7ac920015f982ef549bf2121cb |
| Max Heiber (mheiber) | https://github.com/mheiber |
|
Oct 25, 2019
| https://github.com/microsoft/TypeScript/pull/34683#ref-commit-7bb4f28 |
|
| https://github.com/sandersn |
|
| https://github.com/mheiber |
| getTypeFromJSDocValueReference: handle import types ( | https://github.com/mheiber/TypeScript/commit/7bb4f28d95898fc389f1ec21c5f2c35443775b57 |
| microsoft#34683 | https://github.com/microsoft/TypeScript/pull/34683 |
| ) | https://github.com/mheiber/TypeScript/commit/7bb4f28d95898fc389f1ec21c5f2c35443775b57 |
| 7bb4f28 | https://github.com/mheiber/TypeScript/commit/7bb4f28d95898fc389f1ec21c5f2c35443775b57 |
| https://github.com/voxpelli |
| Pelle Wessman (voxpelli) | https://github.com/voxpelli |
|
Nov 7, 2019
| https://github.com/microsoft/TypeScript/pull/34683#ref-issue-517992363 |
|
JS: Maximum call stack size exceeded at getTypeFromJSDocValueReference in 3.7.2
#34926
| https://github.com/microsoft/TypeScript/issues/34926 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Oct 21, 2025 | https://github.com/microsoft/TypeScript/pull/34683#event-20416809640 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F34683 |
|
| https://github.com/weswigham |
|
Wesley Wigham (weswigham)
| https://github.com/weswigham |
|
| https://github.com/microsoft/TypeScript/pull/34683/files/2aa257df80e88a7ac920015f982ef549bf2121cb |
|
| https://github.com/andrewbranch |
|
Andrew Branch (andrewbranch)
| https://github.com/andrewbranch |
|
| https://github.com/orta |
|
Orta Therox (orta)
| https://github.com/orta |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34683 |
|
In JS, imported class type references resolve to static, not instance type.
| https://github.com/microsoft/TypeScript/issues/34671 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34683 |
|
| https://github.com/sandersn |
|
| https://github.com/typescript-bot |
|
| https://github.com/weswigham |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |