René's URL Explorer Experiment


Title: getTypeFromJSDocValueReference: handle import types by sandersn · Pull Request #34683 · microsoft/TypeScript · GitHub

Open Graph Title: getTypeFromJSDocValueReference: handle import types by sandersn · Pull Request #34683 · microsoft/TypeScript

X Title: getTypeFromJSDocValueReference: handle import types by sandersn · Pull Request #34683 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - getTypeFromJSDocValueReference: handle import types by sandersn · Pull Request #34683 · microsoft/TypeScript

Open Graph Description: Previously it only handled types whose declaration was from require, but now it handles types whose reference is an import type as well. Fixes #34671 This doesn't explain the differences in chr...

X Description: Previously it only handled types whose declaration was from require, but now it handles types whose reference is an import type as well. Fixes #34671 This doesn't explain the differences in...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/34683

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9220cddd-f477-3b9f-1fe4-b5ebe54ae36b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC7F0:20AA01:2F49861:3C1A142:6B01AE73
html-safe-nonce3f70242e8a65f07f7422197b6c003094793f29d807bd8ba57b195d0879836abc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDN0YwOjIwQUEwMToyRjQ5ODYxOjNDMUExNDI6NkIwMUFFNzMiLCJ2aXNpdG9yX2lkIjoiODAxMzA5MDk0OTQ1MjM3NzcxNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf78589a5952df79886e2c856e4a127bf2f9a0e5314ee854bd4cc2798a4d92fa9
hovercard-subject-tagpull_request:331737842
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/34683/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d96c46400ec1c3d9962cf9e67f4f0c0197683ab020741a9e30baa966cec79a34/microsoft/TypeScript/pull/34683
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d96c46400ec1c3d9962cf9e67f4f0c0197683ab020741a9e30baa966cec79a34/microsoft/TypeScript/pull/34683
og:image:altPreviously it only handled types whose declaration was from require, but now it handles types whose reference is an import type as well. Fixes #34671 This doesn't explain the differences in chr...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesandersn
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/34683#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F34683
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F34683
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/34683
Reloadhttps://github.com/microsoft/TypeScript/pull/34683
Reloadhttps://github.com/microsoft/TypeScript/pull/34683
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
fix-jsdoc-import-type-w/classhttps://github.com/microsoft/TypeScript/tree/fix-jsdoc-import-type-w/class
Conversationhttps://github.com/microsoft/TypeScript/pull/34683
Commits1 (1)https://github.com/microsoft/TypeScript/pull/34683/commits
Checkshttps://github.com/microsoft/TypeScript/pull/34683/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/34683/files
getTypeFromJSDocValueReference: handle import typeshttps://github.com/microsoft/TypeScript/pull/34683#top
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
fix-jsdoc-import-type-w/classhttps://github.com/microsoft/TypeScript/tree/fix-jsdoc-import-type-w/class
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 23, 2019https://github.com/microsoft/TypeScript/pull/34683#issue-511562544
#34671https://github.com/microsoft/TypeScript/issues/34671
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34683
https://github.com/sandersn
getTypeFromJSDocValueReference: handle import typeshttps://github.com/microsoft/TypeScript/pull/34683/commits/2aa257df80e88a7ac920015f982ef549bf2121cb
2aa257dhttps://github.com/microsoft/TypeScript/pull/34683/commits/2aa257df80e88a7ac920015f982ef549bf2121cb
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Orta Therox (orta)https://github.com/orta
Wesley Wigham (weswigham)https://github.com/weswigham
October 23, 2019 20:46https://github.com/microsoft/TypeScript/pull/34683#event-2738516572
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Oct 23, 2019 https://github.com/microsoft/TypeScript/pull/34683#pullrequestreview-306227109
View reviewed changes https://github.com/microsoft/TypeScript/pull/34683/files/2aa257df80e88a7ac920015f982ef549bf2121cb
tests/cases/conformance/jsdoc/jsdocImportTypeReferenceToClassAlias.tshttps://github.com/microsoft/TypeScript/pull/34683/files/2aa257df80e88a7ac920015f982ef549bf2121cb#diff-d92c51257537f1b173d96542ad29df05ab6ab6b52938e85575200c5fae4b1e05
Wesley Wigham (weswigham)https://github.com/weswigham
Oct 23, 2019https://github.com/microsoft/TypeScript/pull/34683#discussion_r338307019
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34683
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34683
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 23, 2019https://github.com/microsoft/TypeScript/pull/34683#discussion_r338314304
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34683
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Oct 23, 2019 https://github.com/microsoft/TypeScript/pull/34683#pullrequestreview-306236969
View reviewed changes https://github.com/microsoft/TypeScript/pull/34683/files/2aa257df80e88a7ac920015f982ef549bf2121cb
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
8223c07https://github.com/microsoft/TypeScript/commit/8223c0752773ed6d4d42934adadd3d2cb15d5c3d
Oct 23, 2019https://github.com/microsoft/TypeScript/pull/34683#event-2738816438
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
October 23, 2019 22:53https://github.com/microsoft/TypeScript/pull/34683#event-2738816577
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 24, 2019https://github.com/microsoft/TypeScript/pull/34683#issuecomment-545985416
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34683
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Oct 24, 2019 https://github.com/microsoft/TypeScript/pull/34683#ref-pullrequest-512039485
🤖 Cherry-pick PR #34683 into release-3.7 #34705 https://github.com/microsoft/TypeScript/pull/34705
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Oct 24, 2019https://github.com/microsoft/TypeScript/pull/34683#issuecomment-545987173
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
#34705https://github.com/microsoft/TypeScript/pull/34705
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34683
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Oct 24, 2019 https://github.com/microsoft/TypeScript/pull/34683#ref-commit-d4cf30d
https://github.com/sandersn
https://github.com/typescript-bot
Cherry-pick PRhttps://github.com/typescript-bot/TypeScript/commit/d4cf30dbd7b6646ab5172c2025b0939f513c7349
microsoft#34683https://github.com/microsoft/TypeScript/pull/34683
into release-3.7https://github.com/typescript-bot/TypeScript/commit/d4cf30dbd7b6646ab5172c2025b0939f513c7349
d4cf30dhttps://github.com/typescript-bot/TypeScript/commit/d4cf30dbd7b6646ab5172c2025b0939f513c7349
2aa257dhttps://github.com/typescript-bot/TypeScript/commit/2aa257df80e88a7ac920015f982ef549bf2121cb
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 24, 2019 https://github.com/microsoft/TypeScript/pull/34683#ref-commit-4930148
https://github.com/sandersn
Cherry-pick PRhttps://github.com/microsoft/TypeScript/commit/49301482a045a9e074c92f8fe0a93c6b249a6ed7
#34683https://github.com/microsoft/TypeScript/pull/34683
into release-3.7 (https://github.com/microsoft/TypeScript/commit/49301482a045a9e074c92f8fe0a93c6b249a6ed7
#34705https://github.com/microsoft/TypeScript/pull/34705
)https://github.com/microsoft/TypeScript/commit/49301482a045a9e074c92f8fe0a93c6b249a6ed7
4930148https://github.com/microsoft/TypeScript/commit/49301482a045a9e074c92f8fe0a93c6b249a6ed7
2aa257dhttps://github.com/microsoft/TypeScript/commit/2aa257df80e88a7ac920015f982ef549bf2121cb
Max Heiber (mheiber)https://github.com/mheiber
Oct 25, 2019 https://github.com/microsoft/TypeScript/pull/34683#ref-commit-7bb4f28
https://github.com/sandersn
https://github.com/mheiber
getTypeFromJSDocValueReference: handle import types (https://github.com/mheiber/TypeScript/commit/7bb4f28d95898fc389f1ec21c5f2c35443775b57
microsoft#34683https://github.com/microsoft/TypeScript/pull/34683
)https://github.com/mheiber/TypeScript/commit/7bb4f28d95898fc389f1ec21c5f2c35443775b57
7bb4f28https://github.com/mheiber/TypeScript/commit/7bb4f28d95898fc389f1ec21c5f2c35443775b57
https://github.com/voxpelli
Pelle Wessman (voxpelli)https://github.com/voxpelli
Nov 7, 2019 https://github.com/microsoft/TypeScript/pull/34683#ref-issue-517992363
JS: Maximum call stack size exceeded at getTypeFromJSDocValueReference in 3.7.2 #34926 https://github.com/microsoft/TypeScript/issues/34926
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/34683#event-20416809640
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F34683
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
https://github.com/microsoft/TypeScript/pull/34683/files/2aa257df80e88a7ac920015f982ef549bf2121cb
https://github.com/andrewbranch
Andrew Branch (andrewbranch) https://github.com/andrewbranch
https://github.com/orta
Orta Therox (orta) https://github.com/orta
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34683
In JS, imported class type references resolve to static, not instance type. https://github.com/microsoft/TypeScript/issues/34671
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34683
https://github.com/sandersn
https://github.com/typescript-bot
https://github.com/weswigham
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.