René's URL Explorer Experiment


Title: Common properties check:Fix intersection-parent check by sandersn · Pull Request #34646 · microsoft/TypeScript · GitHub

Open Graph Title: Common properties check:Fix intersection-parent check by sandersn · Pull Request #34646 · microsoft/TypeScript

X Title: Common properties check:Fix intersection-parent check by sandersn · Pull Request #34646 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Common properties check:Fix intersection-parent check by sandersn · Pull Request #34646 · microsoft/TypeScript

Open Graph Description: The check for common properties ("weak type check") when the target is an intersection is supposed to skip the common property check for constituents and instead check assignability of pr...

X Description: The check for common properties ("weak type check") when the target is an intersection is supposed to skip the common property check for constituents and instead check assignabili...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/34646

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b4f17b8a-f13c-e4dc-3387-b77ba40c15fd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9FAC:EA09B:E68F97:13260BE:6B01066B
html-safe-noncee2751579cb6954fe8414fc39e3f3f774f0f57bb727dc4a05e0da15cd27c5aa03
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RkFDOkVBMDlCOkU2OEY5NzoxMzI2MEJFOjZCMDEwNjZCIiwidmlzaXRvcl9pZCI6IjU1OTU5MDI0OTc5MzI3NzI5NzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1226606af74311e6dfed782db151ee58edf0ec836e65bf27967747a0e874df3e
hovercard-subject-tagpull_request:331093374
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/34646/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/92a66b45e9dcc9fb0be767375d4bac5e9475825f89f3b9fcc835e2a5341c645e/microsoft/TypeScript/pull/34646
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/92a66b45e9dcc9fb0be767375d4bac5e9475825f89f3b9fcc835e2a5341c645e/microsoft/TypeScript/pull/34646
og:image:altThe check for common properties ("weak type check") when the target is an intersection is supposed to skip the common property check for constituents and instead check assignability of pr...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesandersn
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/34646#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F34646
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F34646
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/34646
Reloadhttps://github.com/microsoft/TypeScript/pull/34646
Reloadhttps://github.com/microsoft/TypeScript/pull/34646
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
fix-common-property-intersection-parent-checkhttps://github.com/microsoft/TypeScript/tree/fix-common-property-intersection-parent-check
Conversationhttps://github.com/microsoft/TypeScript/pull/34646
Commits3 (3)https://github.com/microsoft/TypeScript/pull/34646/commits
Checkshttps://github.com/microsoft/TypeScript/pull/34646/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/34646/files
Common properties check:Fix intersection-parent checkhttps://github.com/microsoft/TypeScript/pull/34646#top
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
fix-common-property-intersection-parent-checkhttps://github.com/microsoft/TypeScript/tree/fix-common-property-intersection-parent-check
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 22, 2019https://github.com/microsoft/TypeScript/pull/34646#issue-510779119
#33944https://github.com/microsoft/TypeScript/issues/33944
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34646
https://github.com/sandersn
Common props check:Fix intersection-parent checkhttps://github.com/microsoft/TypeScript/pull/34646/commits/2526ca563ab2c412b3c5d5c06cd0035e851dae1f
2526ca5https://github.com/microsoft/TypeScript/pull/34646/commits/2526ca563ab2c412b3c5d5c06cd0035e851dae1f
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 22, 2019https://github.com/microsoft/TypeScript/pull/34646#event-2734039758
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Wesley Wigham (weswigham)https://github.com/weswigham
October 22, 2019 16:46https://github.com/microsoft/TypeScript/pull/34646#event-2734040133
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 22, 2019https://github.com/microsoft/TypeScript/pull/34646#issuecomment-545052976
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34646
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
October 22, 2019 09:48https://github.com/microsoft/TypeScript/pull/34646#commits-pushed-7b5c085
https://github.com/sandersn
fix trailing space linthttps://github.com/microsoft/TypeScript/pull/34646/commits/7b5c0850e288203caee802dcb3e09a92a9333fe8
7b5c085https://github.com/microsoft/TypeScript/pull/34646/commits/7b5c0850e288203caee802dcb3e09a92a9333fe8
https://github.com/sandersn
Update baselineshttps://github.com/microsoft/TypeScript/pull/34646/commits/9ba344cc58144dd16aaf785be568db6943e82500
9ba344chttps://github.com/microsoft/TypeScript/pull/34646/commits/9ba344cc58144dd16aaf785be568db6943e82500
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 22, 2019https://github.com/microsoft/TypeScript/pull/34646#issuecomment-545162522
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34646
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34646
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 28, 2019 https://github.com/microsoft/TypeScript/pull/34646#ref-commit-2e0b451
https://github.com/sandersn
Add isIntersectionConstituent to relation keyhttps://github.com/microsoft/TypeScript/commit/2e0b4513ef2727f9ce81f00319b1d271430ec825
2e0b451https://github.com/microsoft/TypeScript/commit/2e0b4513ef2727f9ce81f00319b1d271430ec825
#33133https://github.com/microsoft/TypeScript/issues/33133
#33133https://github.com/microsoft/TypeScript/issues/33133
#33213https://github.com/microsoft/TypeScript/pull/33213
#34762https://github.com/microsoft/TypeScript/issues/34762
#33213https://github.com/microsoft/TypeScript/pull/33213
#33944https://github.com/microsoft/TypeScript/issues/33944
#34646https://github.com/microsoft/TypeScript/pull/34646
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 28, 2019 https://github.com/microsoft/TypeScript/pull/34646#ref-pullrequest-513591914
Add isIntersectionConstituent to relation key #34789 https://github.com/microsoft/TypeScript/pull/34789
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 28, 2019https://github.com/microsoft/TypeScript/pull/34646#issuecomment-547174602
#34789https://github.com/microsoft/TypeScript/pull/34789
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34646
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 29, 2019 https://github.com/microsoft/TypeScript/pull/34646#ref-commit-00dd1f0
https://github.com/sandersn
Add isIntersectionConstituent to relation key (https://github.com/microsoft/TypeScript/commit/00dd1f0609a65b6854b6b68e41c35f315c91f310
#34789https://github.com/microsoft/TypeScript/pull/34789
)https://github.com/microsoft/TypeScript/commit/00dd1f0609a65b6854b6b68e41c35f315c91f310
00dd1f0https://github.com/microsoft/TypeScript/commit/00dd1f0609a65b6854b6b68e41c35f315c91f310
#33133https://github.com/microsoft/TypeScript/issues/33133
#33133https://github.com/microsoft/TypeScript/issues/33133
#33213https://github.com/microsoft/TypeScript/pull/33213
#34762https://github.com/microsoft/TypeScript/issues/34762
#33213https://github.com/microsoft/TypeScript/pull/33213
#33944https://github.com/microsoft/TypeScript/issues/33944
#34646https://github.com/microsoft/TypeScript/pull/34646
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Oct 29, 2019 https://github.com/microsoft/TypeScript/pull/34646#ref-commit-459099c
https://github.com/sandersn
https://github.com/typescript-bot
Cherry-pick PRhttps://github.com/typescript-bot/TypeScript/commit/459099c0825daf1984b7847292feca6f0d405b74
microsoft#34789https://github.com/microsoft/TypeScript/pull/34789
into release-3.7https://github.com/typescript-bot/TypeScript/commit/459099c0825daf1984b7847292feca6f0d405b74
459099chttps://github.com/typescript-bot/TypeScript/commit/459099c0825daf1984b7847292feca6f0d405b74
2e0b451https://github.com/typescript-bot/TypeScript/commit/2e0b4513ef2727f9ce81f00319b1d271430ec825
microsoft#33133https://github.com/microsoft/TypeScript/issues/33133
microsoft#33133https://github.com/microsoft/TypeScript/issues/33133
microsoft#33213https://github.com/microsoft/TypeScript/pull/33213
microsoft#34762https://github.com/microsoft/TypeScript/issues/34762
microsoft#33213https://github.com/microsoft/TypeScript/pull/33213
microsoft#33944https://github.com/microsoft/TypeScript/issues/33944
microsoft#34646https://github.com/microsoft/TypeScript/pull/34646
14d7a44https://github.com/typescript-bot/TypeScript/commit/14d7a44c509bdc9d2eab2500f41a7086bce11ec4
ea80362https://github.com/typescript-bot/TypeScript/commit/ea803620ecf3c76f012dda07ef7c13b6c8a6cf48
0764275https://github.com/typescript-bot/TypeScript/commit/0764275c30d7cbfb3e93a52bfb0d07e5a41794a7
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 29, 2019 https://github.com/microsoft/TypeScript/pull/34646#ref-commit-28050d5
https://github.com/sandersn
Cherry-pick PRhttps://github.com/microsoft/TypeScript/commit/28050d5c47c6cd7627555f12cf13b1062f80322a
#34789https://github.com/microsoft/TypeScript/pull/34789
into release-3.7 (https://github.com/microsoft/TypeScript/commit/28050d5c47c6cd7627555f12cf13b1062f80322a
#34812https://github.com/microsoft/TypeScript/pull/34812
)https://github.com/microsoft/TypeScript/commit/28050d5c47c6cd7627555f12cf13b1062f80322a
28050d5https://github.com/microsoft/TypeScript/commit/28050d5c47c6cd7627555f12cf13b1062f80322a
2e0b451https://github.com/microsoft/TypeScript/commit/2e0b4513ef2727f9ce81f00319b1d271430ec825
#33133https://github.com/microsoft/TypeScript/issues/33133
#33133https://github.com/microsoft/TypeScript/issues/33133
#33213https://github.com/microsoft/TypeScript/pull/33213
#34762https://github.com/microsoft/TypeScript/issues/34762
#33213https://github.com/microsoft/TypeScript/pull/33213
#33944https://github.com/microsoft/TypeScript/issues/33944
#34646https://github.com/microsoft/TypeScript/pull/34646
14d7a44https://github.com/microsoft/TypeScript/commit/14d7a44c509bdc9d2eab2500f41a7086bce11ec4
ea80362https://github.com/microsoft/TypeScript/commit/ea803620ecf3c76f012dda07ef7c13b6c8a6cf48
0764275https://github.com/microsoft/TypeScript/commit/0764275c30d7cbfb3e93a52bfb0d07e5a41794a7
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Oct 30, 2019https://github.com/microsoft/TypeScript/pull/34646#issuecomment-547990034
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34646
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 30, 2019https://github.com/microsoft/TypeScript/pull/34646#event-2757503699
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
October 30, 2019 20:16https://github.com/microsoft/TypeScript/pull/34646#event-2757503941
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/34646#event-20416808036
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/34646#event-20416808912
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F34646
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg) https://github.com/ahejlsberg
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34646
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
3.6.4 Partial field matching does not work for conditional type https://github.com/microsoft/TypeScript/issues/33944
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34646
https://github.com/sandersn
https://github.com/weswigham
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.