| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:0b249612-441b-0745-7aef-2fc0861d004d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BE1A:37820D:10FAE09:169E907:6B0107DB |
| html-safe-nonce | 93845c066024917f8d87a418f15e7b81d93479f28cd542b480d9af5fbdfdfe09 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRTFBOjM3ODIwRDoxMEZBRTA5OjE2OUU5MDc6NkIwMTA3REIiLCJ2aXNpdG9yX2lkIjoiNjUxMTI4MDk2MjEwNDUyNjgxMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 36a513c7dd60aab71e6078f470a9b8f29dbb86ba8f4ae8781f8bd5e45df5b8b4 |
| hovercard-subject-tag | pull_request:328959113 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/34524/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d219611ea0ec103380d30a72f8ed812d939e6d62ba96f9b3a3c3859c7f7dcf10/microsoft/TypeScript/pull/34524 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d219611ea0ec103380d30a72f8ed812d939e6d62ba96f9b3a3c3859c7f7dcf10/microsoft/TypeScript/pull/34524 |
| og:image:alt | Fixes #32675
There are no duplication checks for exported completions, which is typically not a problem, but turns out to be an issue when you are taking a umd global and re-exporting it as a globa... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | orta |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/34524#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F34524 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F34524 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/34524 |
| Reload | https://github.com/microsoft/TypeScript/pull/34524 |
| Reload | https://github.com/microsoft/TypeScript/pull/34524 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests309 (309) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Orta Therox (orta) | https://github.com/orta |
| microsoft:master | https://github.com/microsoft/TypeScript/tree/master |
| orta:fix_32675 | https://github.com/orta/TypeScript/tree/fix_32675 |
| Conversation | https://github.com/microsoft/TypeScript/pull/34524 |
| Commits2 (2) | https://github.com/microsoft/TypeScript/pull/34524/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/34524/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/34524/files |
| Does not add a duplicate completion when offering an export which was re-declared as a global | https://github.com/microsoft/TypeScript/pull/34524#top |
| Orta Therox (orta) | https://github.com/orta |
| microsoft:master | https://github.com/microsoft/TypeScript/tree/master |
| orta:fix_32675 | https://github.com/orta/TypeScript/tree/fix_32675 |
|
| https://github.com/orta |
| Orta Therox (orta) | https://github.com/orta |
| Oct 16, 2019 | https://github.com/microsoft/TypeScript/pull/34524#issue-508099935 |
| #32675 | https://github.com/microsoft/TypeScript/issues/32675 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34524 |
|
| https://github.com/orta |
| Does not add a duplicate completion when offering an export which was… | https://github.com/microsoft/TypeScript/pull/34524/commits/c40ddb183e8c02fc27db6e1daf9dc8826da4f856 |
| c40ddb1 | https://github.com/microsoft/TypeScript/pull/34524/commits/c40ddb183e8c02fc27db6e1daf9dc8826da4f856 |
| microsoft#32675 | https://github.com/microsoft/TypeScript/issues/32675 |
| https://github.com/orta |
| Orta Therox (orta) | https://github.com/orta |
| Ryan Cavanaugh (RyanCavanaugh) | https://github.com/RyanCavanaugh |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| October 16, 2019 21:07 | https://github.com/microsoft/TypeScript/pull/34524#event-2719131778 |
| https://github.com/orta |
| Orta Therox (orta) | https://github.com/orta |
| Oct 16, 2019 | https://github.com/microsoft/TypeScript/pull/34524#event-2719131788 |
| https://github.com/orta |
| Orta Therox (orta) | https://github.com/orta |
|
Oct 16, 2019
| https://github.com/microsoft/TypeScript/pull/34524#pullrequestreview-302879371 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/34524/files/c40ddb183e8c02fc27db6e1daf9dc8826da4f856 |
| src/services/completions.ts | https://github.com/microsoft/TypeScript/pull/34524/files/c40ddb183e8c02fc27db6e1daf9dc8826da4f856#diff-4237fd08a5f920543e184b7748bc8ae000d9b1c031810ba375b0053362ec2b6a |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34524 |
| https://github.com/andrewbranch |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
|
Oct 16, 2019
| https://github.com/microsoft/TypeScript/pull/34524#pullrequestreview-302879934 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/34524/files/c40ddb183e8c02fc27db6e1daf9dc8826da4f856 |
| src/services/completions.ts | https://github.com/microsoft/TypeScript/pull/34524/files/c40ddb183e8c02fc27db6e1daf9dc8826da4f856#diff-4237fd08a5f920543e184b7748bc8ae000d9b1c031810ba375b0053362ec2b6a |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34524 |
| https://github.com/orta |
| Orta Therox (orta) | https://github.com/orta |
| force-pushed | https://github.com/microsoft/TypeScript/compare/cdcfbc25b90f2b798604933db14cf6292a14c80b..89d7cd5dc83fb8a715cbf52737cf2f78966e0f92 |
| cdcfbc2 | https://github.com/microsoft/TypeScript/commit/cdcfbc25b90f2b798604933db14cf6292a14c80b |
| 89d7cd5 | https://github.com/microsoft/TypeScript/commit/89d7cd5dc83fb8a715cbf52737cf2f78966e0f92 |
|
Compare
| https://github.com/microsoft/TypeScript/compare/cdcfbc25b90f2b798604933db14cf6292a14c80b..89d7cd5dc83fb8a715cbf52737cf2f78966e0f92 |
| October 17, 2019 16:15 | https://github.com/microsoft/TypeScript/pull/34524#event-2721922289 |
| https://github.com/sheetalkamat |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
|
Oct 17, 2019
| https://github.com/microsoft/TypeScript/pull/34524#pullrequestreview-303382541 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/34524/files |
|
| https://github.com/orta |
| Make sure that global module re-exports are short-cutted to be added … | https://github.com/microsoft/TypeScript/pull/34524/commits/85010fa6fefae471f6b70959deea81239195f46e |
| 85010fa | https://github.com/microsoft/TypeScript/pull/34524/commits/85010fa6fefae471f6b70959deea81239195f46e |
| https://github.com/orta |
| Orta Therox (orta) | https://github.com/orta |
| force-pushed | https://github.com/microsoft/TypeScript/compare/89d7cd5dc83fb8a715cbf52737cf2f78966e0f92..85010fa6fefae471f6b70959deea81239195f46e |
| 89d7cd5 | https://github.com/microsoft/TypeScript/commit/89d7cd5dc83fb8a715cbf52737cf2f78966e0f92 |
| 85010fa | https://github.com/microsoft/TypeScript/commit/85010fa6fefae471f6b70959deea81239195f46e |
|
Compare
| https://github.com/microsoft/TypeScript/compare/89d7cd5dc83fb8a715cbf52737cf2f78966e0f92..85010fa6fefae471f6b70959deea81239195f46e |
| October 17, 2019 16:33 | https://github.com/microsoft/TypeScript/pull/34524#event-2721975608 |
| https://github.com/orta |
| Orta Therox (orta) | https://github.com/orta |
| 5d20c57 | https://github.com/microsoft/TypeScript/commit/5d20c573a65844672c45ca883db519a15c041920 |
| Oct 17, 2019 | https://github.com/microsoft/TypeScript/pull/34524#event-2722081575 |
| https://github.com/andrewbranch |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
|
Oct 17, 2019
| https://github.com/microsoft/TypeScript/pull/34524#pullrequestreview-303412533 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/34524/files/85010fa6fefae471f6b70959deea81239195f46e |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
| https://github.com/microsoft/TypeScript/pull/34524#pullrequestreview-303412533 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34524 |
| src/services/completions.ts | https://github.com/microsoft/TypeScript/pull/34524/files/85010fa6fefae471f6b70959deea81239195f46e#diff-4237fd08a5f920543e184b7748bc8ae000d9b1c031810ba375b0053362ec2b6a |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
| Oct 17, 2019 | https://github.com/microsoft/TypeScript/pull/34524#discussion_r336124737 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://user-images.githubusercontent.com/3277153/67031415-56aed500-f0c6-11e9-9ab3-2b2b69958e27.png |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34524 |
| Orta Therox (orta) | https://github.com/orta |
| Oct 17, 2019 | https://github.com/microsoft/TypeScript/pull/34524#discussion_r336125326 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34524 |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
| Oct 17, 2019 | https://github.com/microsoft/TypeScript/pull/34524#discussion_r336126267 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34524 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Oct 21, 2025 | https://github.com/microsoft/TypeScript/pull/34524#event-20416801914 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F34524 |
|
| https://github.com/andrewbranch |
|
Andrew Branch (andrewbranch)
| https://github.com/andrewbranch |
|
| https://github.com/microsoft/TypeScript/pull/34524/files/85010fa6fefae471f6b70959deea81239195f46e |
|
| https://github.com/sheetalkamat |
|
Sheetal Nandi (sheetalkamat)
| https://github.com/sheetalkamat |
|
| https://github.com/microsoft/TypeScript/pull/34524/files/89d7cd5dc83fb8a715cbf52737cf2f78966e0f92 |
|
| https://github.com/sandersn |
|
Nathan Shively-Sanders (sandersn)
| https://github.com/sandersn |
|
| https://github.com/RyanCavanaugh |
|
Ryan Cavanaugh (RyanCavanaugh)
| https://github.com/RyanCavanaugh |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34524 |
|
| https://github.com/orta |
|
Orta Therox (orta)
| https://github.com/orta |
|
Autocompletion doesn't suggest global variables exposed from dependent packages (regression)
| https://github.com/microsoft/TypeScript/issues/32675 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/34524 |
|
| https://github.com/orta |
|
| https://github.com/andrewbranch |
|
| https://github.com/sheetalkamat |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |