René's URL Explorer Experiment


Title: Does not add a duplicate completion when offering an export which was re-declared as a global by orta · Pull Request #34524 · microsoft/TypeScript · GitHub

Open Graph Title: Does not add a duplicate completion when offering an export which was re-declared as a global by orta · Pull Request #34524 · microsoft/TypeScript

X Title: Does not add a duplicate completion when offering an export which was re-declared as a global by orta · Pull Request #34524 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Does not add a duplicate completion when offering an export which was re-declared as a global by orta · Pull Request #34524 · microsoft/TypeScript

Open Graph Description: Fixes #32675 There are no duplication checks for exported completions, which is typically not a problem, but turns out to be an issue when you are taking a umd global and re-exporting it as a globa...

X Description: Fixes #32675 There are no duplication checks for exported completions, which is typically not a problem, but turns out to be an issue when you are taking a umd global and re-exporting it as a globa...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/34524

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0b249612-441b-0745-7aef-2fc0861d004d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBE1A:37820D:10FAE09:169E907:6B0107DB
html-safe-nonce93845c066024917f8d87a418f15e7b81d93479f28cd542b480d9af5fbdfdfe09
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRTFBOjM3ODIwRDoxMEZBRTA5OjE2OUU5MDc6NkIwMTA3REIiLCJ2aXNpdG9yX2lkIjoiNjUxMTI4MDk2MjEwNDUyNjgxMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac36a513c7dd60aab71e6078f470a9b8f29dbb86ba8f4ae8781f8bd5e45df5b8b4
hovercard-subject-tagpull_request:328959113
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/34524/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d219611ea0ec103380d30a72f8ed812d939e6d62ba96f9b3a3c3859c7f7dcf10/microsoft/TypeScript/pull/34524
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d219611ea0ec103380d30a72f8ed812d939e6d62ba96f9b3a3c3859c7f7dcf10/microsoft/TypeScript/pull/34524
og:image:altFixes #32675 There are no duplication checks for exported completions, which is typically not a problem, but turns out to be an issue when you are taking a umd global and re-exporting it as a globa...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameorta
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/34524#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F34524
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F34524
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/34524
Reloadhttps://github.com/microsoft/TypeScript/pull/34524
Reloadhttps://github.com/microsoft/TypeScript/pull/34524
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Orta Therox (orta)https://github.com/orta
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
orta:fix_32675https://github.com/orta/TypeScript/tree/fix_32675
Conversationhttps://github.com/microsoft/TypeScript/pull/34524
Commits2 (2)https://github.com/microsoft/TypeScript/pull/34524/commits
Checkshttps://github.com/microsoft/TypeScript/pull/34524/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/34524/files
Does not add a duplicate completion when offering an export which was re-declared as a globalhttps://github.com/microsoft/TypeScript/pull/34524#top
Orta Therox (orta)https://github.com/orta
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
orta:fix_32675https://github.com/orta/TypeScript/tree/fix_32675
https://github.com/orta
Orta Therox (orta)https://github.com/orta
Oct 16, 2019https://github.com/microsoft/TypeScript/pull/34524#issue-508099935
#32675https://github.com/microsoft/TypeScript/issues/32675
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34524
https://github.com/orta
Does not add a duplicate completion when offering an export which was…https://github.com/microsoft/TypeScript/pull/34524/commits/c40ddb183e8c02fc27db6e1daf9dc8826da4f856
c40ddb1https://github.com/microsoft/TypeScript/pull/34524/commits/c40ddb183e8c02fc27db6e1daf9dc8826da4f856
microsoft#32675https://github.com/microsoft/TypeScript/issues/32675
https://github.com/orta
Orta Therox (orta)https://github.com/orta
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
October 16, 2019 21:07https://github.com/microsoft/TypeScript/pull/34524#event-2719131778
https://github.com/orta
Orta Therox (orta)https://github.com/orta
Oct 16, 2019https://github.com/microsoft/TypeScript/pull/34524#event-2719131788
https://github.com/orta
Orta Therox (orta)https://github.com/orta
Oct 16, 2019 https://github.com/microsoft/TypeScript/pull/34524#pullrequestreview-302879371
View reviewed changes https://github.com/microsoft/TypeScript/pull/34524/files/c40ddb183e8c02fc27db6e1daf9dc8826da4f856
src/services/completions.tshttps://github.com/microsoft/TypeScript/pull/34524/files/c40ddb183e8c02fc27db6e1daf9dc8826da4f856#diff-4237fd08a5f920543e184b7748bc8ae000d9b1c031810ba375b0053362ec2b6a
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34524
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Oct 16, 2019 https://github.com/microsoft/TypeScript/pull/34524#pullrequestreview-302879934
View reviewed changes https://github.com/microsoft/TypeScript/pull/34524/files/c40ddb183e8c02fc27db6e1daf9dc8826da4f856
src/services/completions.tshttps://github.com/microsoft/TypeScript/pull/34524/files/c40ddb183e8c02fc27db6e1daf9dc8826da4f856#diff-4237fd08a5f920543e184b7748bc8ae000d9b1c031810ba375b0053362ec2b6a
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34524
https://github.com/orta
Orta Therox (orta)https://github.com/orta
force-pushedhttps://github.com/microsoft/TypeScript/compare/cdcfbc25b90f2b798604933db14cf6292a14c80b..89d7cd5dc83fb8a715cbf52737cf2f78966e0f92
cdcfbc2https://github.com/microsoft/TypeScript/commit/cdcfbc25b90f2b798604933db14cf6292a14c80b
89d7cd5https://github.com/microsoft/TypeScript/commit/89d7cd5dc83fb8a715cbf52737cf2f78966e0f92
Compare https://github.com/microsoft/TypeScript/compare/cdcfbc25b90f2b798604933db14cf6292a14c80b..89d7cd5dc83fb8a715cbf52737cf2f78966e0f92
October 17, 2019 16:15https://github.com/microsoft/TypeScript/pull/34524#event-2721922289
https://github.com/sheetalkamat
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
Oct 17, 2019 https://github.com/microsoft/TypeScript/pull/34524#pullrequestreview-303382541
View reviewed changes https://github.com/microsoft/TypeScript/pull/34524/files
https://github.com/orta
Make sure that global module re-exports are short-cutted to be added …https://github.com/microsoft/TypeScript/pull/34524/commits/85010fa6fefae471f6b70959deea81239195f46e
85010fahttps://github.com/microsoft/TypeScript/pull/34524/commits/85010fa6fefae471f6b70959deea81239195f46e
https://github.com/orta
Orta Therox (orta)https://github.com/orta
force-pushedhttps://github.com/microsoft/TypeScript/compare/89d7cd5dc83fb8a715cbf52737cf2f78966e0f92..85010fa6fefae471f6b70959deea81239195f46e
89d7cd5https://github.com/microsoft/TypeScript/commit/89d7cd5dc83fb8a715cbf52737cf2f78966e0f92
85010fahttps://github.com/microsoft/TypeScript/commit/85010fa6fefae471f6b70959deea81239195f46e
Compare https://github.com/microsoft/TypeScript/compare/89d7cd5dc83fb8a715cbf52737cf2f78966e0f92..85010fa6fefae471f6b70959deea81239195f46e
October 17, 2019 16:33https://github.com/microsoft/TypeScript/pull/34524#event-2721975608
https://github.com/orta
Orta Therox (orta)https://github.com/orta
5d20c57https://github.com/microsoft/TypeScript/commit/5d20c573a65844672c45ca883db519a15c041920
Oct 17, 2019https://github.com/microsoft/TypeScript/pull/34524#event-2722081575
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Oct 17, 2019 https://github.com/microsoft/TypeScript/pull/34524#pullrequestreview-303412533
View reviewed changes https://github.com/microsoft/TypeScript/pull/34524/files/85010fa6fefae471f6b70959deea81239195f46e
Andrew Branch (andrewbranch)https://github.com/andrewbranch
https://github.com/microsoft/TypeScript/pull/34524#pullrequestreview-303412533
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34524
src/services/completions.tshttps://github.com/microsoft/TypeScript/pull/34524/files/85010fa6fefae471f6b70959deea81239195f46e#diff-4237fd08a5f920543e184b7748bc8ae000d9b1c031810ba375b0053362ec2b6a
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Oct 17, 2019https://github.com/microsoft/TypeScript/pull/34524#discussion_r336124737
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://user-images.githubusercontent.com/3277153/67031415-56aed500-f0c6-11e9-9ab3-2b2b69958e27.png
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34524
Orta Therox (orta)https://github.com/orta
Oct 17, 2019https://github.com/microsoft/TypeScript/pull/34524#discussion_r336125326
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34524
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Oct 17, 2019https://github.com/microsoft/TypeScript/pull/34524#discussion_r336126267
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34524
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/34524#event-20416801914
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F34524
https://github.com/andrewbranch
Andrew Branch (andrewbranch) https://github.com/andrewbranch
https://github.com/microsoft/TypeScript/pull/34524/files/85010fa6fefae471f6b70959deea81239195f46e
https://github.com/sheetalkamat
Sheetal Nandi (sheetalkamat) https://github.com/sheetalkamat
https://github.com/microsoft/TypeScript/pull/34524/files/89d7cd5dc83fb8a715cbf52737cf2f78966e0f92
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh) https://github.com/RyanCavanaugh
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34524
https://github.com/orta
Orta Therox (orta) https://github.com/orta
Autocompletion doesn't suggest global variables exposed from dependent packages (regression) https://github.com/microsoft/TypeScript/issues/32675
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34524
https://github.com/orta
https://github.com/andrewbranch
https://github.com/sheetalkamat
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.