René's URL Explorer Experiment


Title: Resolve more jsdoc value references as types by sandersn · Pull Request #34515 · microsoft/TypeScript · GitHub

Open Graph Title: Resolve more jsdoc value references as types by sandersn · Pull Request #34515 · microsoft/TypeScript

X Title: Resolve more jsdoc value references as types by sandersn · Pull Request #34515 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Resolve more jsdoc value references as types by sandersn · Pull Request #34515 · microsoft/TypeScript

Open Graph Description: Make detection of require calls smarter. When the reference is not to the result of a require call, use the type of the value instead. This is similar to pre-3.7 behaviour. Fixes #33106

X Description: Make detection of require calls smarter. When the reference is not to the result of a require call, use the type of the value instead. This is similar to pre-3.7 behaviour. Fixes #33106

Opengraph URL: https://github.com/microsoft/TypeScript/pull/34515

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d541e255-024d-8952-003b-8d825709a180
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE5A2:B53AF:2634B4D:32E0681:6B01A5EA
html-safe-nonce313ecad29563568dc8646bbe2eca4d41df568427d76e8011a46087f57b07eb32
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNUEyOkI1M0FGOjI2MzRCNEQ6MzJFMDY4MTo2QjAxQTVFQSIsInZpc2l0b3JfaWQiOiI4MzYyODg1MTI5MTI2OTEzNTE0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac33832c1d67dec566a26735a00b9ca8d7664de3a76af0793c975a380770794e54
hovercard-subject-tagpull_request:328855474
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/34515/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e1fa910860ffe0e849403c3ecf48c7f0c66df2119b93e563b1b075b471a63738/microsoft/TypeScript/pull/34515
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e1fa910860ffe0e849403c3ecf48c7f0c66df2119b93e563b1b075b471a63738/microsoft/TypeScript/pull/34515
og:image:altMake detection of require calls smarter. When the reference is not to the result of a require call, use the type of the value instead. This is similar to pre-3.7 behaviour. Fixes #33106
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesandersn
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/34515#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F34515
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F34515
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/34515
Reloadhttps://github.com/microsoft/TypeScript/pull/34515
Reloadhttps://github.com/microsoft/TypeScript/pull/34515
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
resolve-more-jsdoc-types-as-valueshttps://github.com/microsoft/TypeScript/tree/resolve-more-jsdoc-types-as-values
Conversationhttps://github.com/microsoft/TypeScript/pull/34515
Commits2 (2)https://github.com/microsoft/TypeScript/pull/34515/commits
Checkshttps://github.com/microsoft/TypeScript/pull/34515/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/34515/files
Resolve more jsdoc value references as typeshttps://github.com/microsoft/TypeScript/pull/34515#top
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
resolve-more-jsdoc-types-as-valueshttps://github.com/microsoft/TypeScript/tree/resolve-more-jsdoc-types-as-values
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 16, 2019https://github.com/microsoft/TypeScript/pull/34515#issue-507967361
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34515
#33106https://github.com/microsoft/TypeScript/issues/33106
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34515
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
October 16, 2019 09:40https://github.com/microsoft/TypeScript/pull/34515#commits-pushed-c37efd7
https://github.com/sandersn
Resolve more jsdoc value references as typeshttps://github.com/microsoft/TypeScript/pull/34515/commits/c37efd7a29c344cee9a85051705dd0c6d499026d
c37efd7https://github.com/microsoft/TypeScript/pull/34515/commits/c37efd7a29c344cee9a85051705dd0c6d499026d
https://github.com/sandersn
add testhttps://github.com/microsoft/TypeScript/pull/34515/commits/e0673d36f3d7841383839f534f410408a226dde5
e0673d3https://github.com/microsoft/TypeScript/pull/34515/commits/e0673d36f3d7841383839f534f410408a226dde5
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Wesley Wigham (weswigham)https://github.com/weswigham
October 16, 2019 16:51https://github.com/microsoft/TypeScript/pull/34515#event-2718374921
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 16, 2019 https://github.com/microsoft/TypeScript/pull/34515#ref-issue-497638002
jsdoc @enum with import/export #33575 https://github.com/microsoft/TypeScript/issues/33575
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Oct 16, 2019 https://github.com/microsoft/TypeScript/pull/34515#pullrequestreview-302852329
View reviewed changes https://github.com/microsoft/TypeScript/pull/34515/files/e0673d36f3d7841383839f534f410408a226dde5
Wesley Wigham (weswigham)https://github.com/weswigham
https://github.com/microsoft/TypeScript/pull/34515#pullrequestreview-302852329
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34515
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 17, 2019https://github.com/microsoft/TypeScript/pull/34515#issuecomment-543300496
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34515
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
f5dbcb7https://github.com/microsoft/TypeScript/commit/f5dbcb78af2d488a2638d2ed6e50b9e35da2f9ac
Oct 17, 2019https://github.com/microsoft/TypeScript/pull/34515#event-2722298164
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
October 17, 2019 18:21https://github.com/microsoft/TypeScript/pull/34515#event-2722298337
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Oct 17, 2019https://github.com/microsoft/TypeScript/pull/34515#issuecomment-543301857
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34515
In JS, imported class type references resolve to static, not instance type. #34671 https://github.com/microsoft/TypeScript/issues/34671
JSDoc type reference resolves incorrectly if checked before the constructor function it refers to #34685 https://github.com/microsoft/TypeScript/issues/34685
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/34515#event-20416801691
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/34515#event-20416802152
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F34515
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
https://github.com/microsoft/TypeScript/pull/34515/files/e0673d36f3d7841383839f534f410408a226dde5
https://github.com/andrewbranch
Andrew Branch (andrewbranch) https://github.com/andrewbranch
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34515
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
stricter jsdoc type resolution causes weird behaviour for value-only declarations https://github.com/microsoft/TypeScript/issues/33106
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/34515
https://github.com/sandersn
https://github.com/weswigham
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.