| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e147611a-443f-3d19-a504-157e3610e155 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D0BE:31B4CC:BB03CD:F78495:6B00EE40 |
| html-safe-nonce | 8af7f4e8f88e8d4a42c9e3c2463ed30818132cff16593ef82ffe9f6838d53cfb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMEJFOjMxQjRDQzpCQjAzQ0Q6Rjc4NDk1OjZCMDBFRTQwIiwidmlzaXRvcl9pZCI6Ijg0NjE2NTIwNjgyMTY2NjM2MTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 4121eb0d0c7cbc512f08d3ebd088f10a636e48aa1b5cd78cc5992966661c4789 |
| hovercard-subject-tag | pull_request:321911446 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/33622/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2482e109637ba08ad6ae01780b230424c6d6fdfd03407edc4be6da5259dde009/microsoft/TypeScript/pull/33622 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2482e109637ba08ad6ae01780b230424c6d6fdfd03407edc4be6da5259dde009/microsoft/TypeScript/pull/33622 |
| og:image:alt | With this PR we issue errors when calls to assertion functions are written in a manner that isn't recognized by control flow analysis (see #32695 for the specific requirements). For example:
cl... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ahejlsberg |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/33622#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F33622 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F33622 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/33622 |
| Reload | https://github.com/microsoft/TypeScript/pull/33622 |
| Reload | https://github.com/microsoft/TypeScript/pull/33622 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests308 (308) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| master | https://github.com/microsoft/TypeScript/tree/master |
| fix33580 | https://github.com/microsoft/TypeScript/tree/fix33580 |
| Conversation | https://github.com/microsoft/TypeScript/pull/33622 |
| Commits9 (9) | https://github.com/microsoft/TypeScript/pull/33622/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/33622/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/33622/files |
| Error when assertion function calls aren't CFA'd | https://github.com/microsoft/TypeScript/pull/33622#top |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| master | https://github.com/microsoft/TypeScript/tree/master |
| fix33580 | https://github.com/microsoft/TypeScript/tree/fix33580 |
|
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| Sep 26, 2019 | https://github.com/microsoft/TypeScript/pull/33622#issue-499120919 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33622 |
| #32695 | https://github.com/microsoft/TypeScript/pull/32695 |
| #33580 | https://github.com/microsoft/TypeScript/issues/33580 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33622 |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| September 26, 2019 13:51 | https://github.com/microsoft/TypeScript/pull/33622#commits-pushed-8619bff |
|
| https://github.com/ahejlsberg |
| Error on assertion and non-returning function calls that aren't CFA-ed | https://github.com/microsoft/TypeScript/pull/33622/commits/8619bff9c2a9448aa3b60874022c654802de3e1a |
| 8619bff | https://github.com/microsoft/TypeScript/pull/33622/commits/8619bff9c2a9448aa3b60874022c654802de3e1a |
|
| https://github.com/ahejlsberg |
| Add tests | https://github.com/microsoft/TypeScript/pull/33622/commits/894cc63be1895c0ac1d000d89454d7d9ddf51cc7 |
| 894cc63 | https://github.com/microsoft/TypeScript/pull/33622/commits/894cc63be1895c0ac1d000d89454d7d9ddf51cc7 |
|
| https://github.com/ahejlsberg |
| Accept new baselines | https://github.com/microsoft/TypeScript/pull/33622/commits/0595d6160618935b586e27a128a3a3db876b5888 |
| 0595d61 | https://github.com/microsoft/TypeScript/pull/33622/commits/0595d6160618935b586e27a128a3a3db876b5888 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| Ryan Cavanaugh (RyanCavanaugh) | https://github.com/RyanCavanaugh |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Ryan Cavanaugh (RyanCavanaugh) | https://github.com/RyanCavanaugh |
| September 26, 2019 21:18 | https://github.com/microsoft/TypeScript/pull/33622#event-2666732445 |
|
| https://github.com/ahejlsberg |
| Handle alias symbols in getTypeOfDottedName | https://github.com/microsoft/TypeScript/pull/33622/commits/a13f8621c223814f720dbe2de24bf92a57bda54a |
| a13f862 | https://github.com/microsoft/TypeScript/pull/33622/commits/a13f8621c223814f720dbe2de24bf92a57bda54a |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| Sep 27, 2019 | https://github.com/microsoft/TypeScript/pull/33622#issuecomment-535741995 |
| TypeScript Bot (@typescript-bot) | https://github.com/typescript-bot |
| TypeScript Bot (@typescript-bot) | https://github.com/typescript-bot |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33622 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Sep 27, 2019 | https://github.com/microsoft/TypeScript/pull/33622#issuecomment-535742011 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33622 |
| Anders Hejlsberg (@ahejlsberg) | https://github.com/ahejlsberg |
| a13f862 | https://github.com/microsoft/TypeScript/commit/a13f8621c223814f720dbe2de24bf92a57bda54a |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=46074 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33622 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Sep 27, 2019 | https://github.com/microsoft/TypeScript/pull/33622#issuecomment-535742012 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33622 |
| Anders Hejlsberg (@ahejlsberg) | https://github.com/ahejlsberg |
| a13f862 | https://github.com/microsoft/TypeScript/commit/a13f8621c223814f720dbe2de24bf92a57bda54a |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=46075 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33622 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Sep 27, 2019 | https://github.com/microsoft/TypeScript/pull/33622#issuecomment-535833307 |
| TypeScript Bot (@typescript-bot) | https://github.com/typescript-bot |
| TypeScript Bot (@typescript-bot) | https://github.com/typescript-bot |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33622 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Sep 27, 2019 | https://github.com/microsoft/TypeScript/pull/33622#issuecomment-535833336 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33622 |
| Daniel Rosenwasser (@DanielRosenwasser) | https://github.com/DanielRosenwasser |
| a13f862 | https://github.com/microsoft/TypeScript/commit/a13f8621c223814f720dbe2de24bf92a57bda54a |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=46108 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33622 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Sep 27, 2019 | https://github.com/microsoft/TypeScript/pull/33622#issuecomment-535833337 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33622 |
| Daniel Rosenwasser (@DanielRosenwasser) | https://github.com/DanielRosenwasser |
| a13f862 | https://github.com/microsoft/TypeScript/commit/a13f8621c223814f720dbe2de24bf92a57bda54a |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=46109 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33622 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
|
Sep 27, 2019
| https://github.com/microsoft/TypeScript/pull/33622#pullrequestreview-294158258 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/33622/files/a13f8621c223814f720dbe2de24bf92a57bda54a |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| https://github.com/microsoft/TypeScript/pull/33622#pullrequestreview-294158258 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33622 |
| src/compiler/diagnosticMessages.json | https://github.com/microsoft/TypeScript/pull/33622/files/a13f8621c223814f720dbe2de24bf92a57bda54a#diff-fdf3f532dc2d3188ad1c05c8c9e064d0aa4143b8ba09b8f3313a0243f0a43eff |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Sep 27, 2019 | https://github.com/microsoft/TypeScript/pull/33622#discussion_r328947521 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33622 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Sep 27, 2019 | https://github.com/microsoft/TypeScript/pull/33622#discussion_r329152721 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Daniel Rosenwasser (@DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33622 |
| tests/baselines/reference/assertionTypePredicates1.errors.txt | https://github.com/microsoft/TypeScript/pull/33622/files/a13f8621c223814f720dbe2de24bf92a57bda54a#diff-40d7950aa17280f63b79f3098c3a59376d41d8669d2e5b5611fa8c1c23d50505 |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Sep 27, 2019 | https://github.com/microsoft/TypeScript/pull/33622#discussion_r328948424 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33622 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
|
Sep 27, 2019
| https://github.com/microsoft/TypeScript/pull/33622#ref-pullrequest-499306740 |
|
🤖 User test baselines have changed for fix33580
#33632
| https://github.com/microsoft/TypeScript/pull/33632 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Sep 27, 2019 | https://github.com/microsoft/TypeScript/pull/33622#issuecomment-535843175 |
| PR with the baseline diff from master | https://github.com/microsoft/TypeScript/pull/33632 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33622 |
| https://github.com/jack-williams |
| Jack Williams (jack-williams) | https://github.com/jack-williams |
| Sep 27, 2019 | https://github.com/microsoft/TypeScript/pull/33622#issuecomment-535913694 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33622 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
|
Sep 27, 2019
| https://github.com/microsoft/TypeScript/pull/33622#pullrequestreview-294432374 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/33622/files/a13f8621c223814f720dbe2de24bf92a57bda54a |
| src/compiler/diagnosticMessages.json | https://github.com/microsoft/TypeScript/pull/33622/files/a13f8621c223814f720dbe2de24bf92a57bda54a#diff-fdf3f532dc2d3188ad1c05c8c9e064d0aa4143b8ba09b8f3313a0243f0a43eff |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Sep 27, 2019 | https://github.com/microsoft/TypeScript/pull/33622#discussion_r329152721 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Daniel Rosenwasser (@DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33622 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Sep 27, 2019 | https://github.com/microsoft/TypeScript/pull/33622#issuecomment-536008841 |
| Jack Williams (@jack-williams) | https://github.com/jack-williams |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33622 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Sep 27, 2019 | https://github.com/microsoft/TypeScript/pull/33622#issuecomment-536025461 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33622 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Sep 27, 2019 | https://github.com/microsoft/TypeScript/pull/33622#issuecomment-536028660 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33622 |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| September 27, 2019 15:05 | https://github.com/microsoft/TypeScript/pull/33622#commits-pushed-4648d6a |
|
| https://github.com/ahejlsberg |
| Revise error messages + related spans + no errors on never-returning … | https://github.com/microsoft/TypeScript/pull/33622/commits/4648d6aeb24aad5d10713c4a93d5fea4050d7c7d |
| 4648d6a | https://github.com/microsoft/TypeScript/pull/33622/commits/4648d6aeb24aad5d10713c4a93d5fea4050d7c7d |
|
| https://github.com/ahejlsberg |
| Fix error message | https://github.com/microsoft/TypeScript/pull/33622/commits/02395a9b271c3e5688d67dab74c91211a119ceb1 |
| 02395a9 | https://github.com/microsoft/TypeScript/pull/33622/commits/02395a9b271c3e5688d67dab74c91211a119ceb1 |
|
| https://github.com/ahejlsberg |
| Accept new baselines | https://github.com/microsoft/TypeScript/pull/33622/commits/56e0c6b16ed4c24661deadda890220c012e7003f |
| 56e0c6b | https://github.com/microsoft/TypeScript/pull/33622/commits/56e0c6b16ed4c24661deadda890220c012e7003f |
|
| https://github.com/ahejlsberg |
| Update tests | https://github.com/microsoft/TypeScript/pull/33622/commits/34f6e681c492650d36438cf23838a4c33d496a11 |
| 34f6e68 | https://github.com/microsoft/TypeScript/pull/33622/commits/34f6e681c492650d36438cf23838a4c33d496a11 |
|
| https://github.com/ahejlsberg |
| Accept new baselines | https://github.com/microsoft/TypeScript/pull/33622/commits/e5af71e3cd00c9803b07767e65d4afdd8419e661 |
| e5af71e | https://github.com/microsoft/TypeScript/pull/33622/commits/e5af71e3cd00c9803b07767e65d4afdd8419e661 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
|
Sep 27, 2019
| https://github.com/microsoft/TypeScript/pull/33622#pullrequestreview-294589608 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/33622/files/e5af71e3cd00c9803b07767e65d4afdd8419e661 |
| tests/baselines/reference/assertionTypePredicates1.errors.txt | https://github.com/microsoft/TypeScript/pull/33622/files/e5af71e3cd00c9803b07767e65d4afdd8419e661#diff-40d7950aa17280f63b79f3098c3a59376d41d8669d2e5b5611fa8c1c23d50505 |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Sep 27, 2019 | https://github.com/microsoft/TypeScript/pull/33622#discussion_r329271396 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33622 |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| Sep 27, 2019 | https://github.com/microsoft/TypeScript/pull/33622#discussion_r329271982 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33622 |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Oct 1, 2019 | https://github.com/microsoft/TypeScript/pull/33622#discussion_r330184180 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33622 |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| Oct 1, 2019 | https://github.com/microsoft/TypeScript/pull/33622#discussion_r330195892 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33622 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| Sep 27, 2019 | https://github.com/microsoft/TypeScript/pull/33622#issuecomment-536115673 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33622 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| September 27, 2019 22:44 | https://github.com/microsoft/TypeScript/pull/33622#event-2670081210 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| stale review | https://github.com/microsoft/TypeScript/pull/33622#pullrequestreview-294432374 |
| September 27, 2019 22:45 | https://github.com/microsoft/TypeScript/pull/33622#event-2670082266 |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
|
Sep 27, 2019
| https://github.com/microsoft/TypeScript/pull/33622#pullrequestreview-294602410 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/33622/files/e5af71e3cd00c9803b07767e65d4afdd8419e661 |
| src/compiler/utilities.ts | https://github.com/microsoft/TypeScript/pull/33622/files/e5af71e3cd00c9803b07767e65d4afdd8419e661#diff-1516c8349f7a625a2e4a2aa60f6bbe84e4b1a499128e8705d3087d893e01d367 |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Sep 27, 2019 | https://github.com/microsoft/TypeScript/pull/33622#discussion_r329281479 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33622 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| Sep 28, 2019 | https://github.com/microsoft/TypeScript/pull/33622#event-2670551069 |
| https://github.com/RyanCavanaugh |
| Ryan Cavanaugh (RyanCavanaugh) | https://github.com/RyanCavanaugh |
| TypeScript 3.7.0 | https://github.com/microsoft/TypeScript/milestone/98 |
| Sep 30, 2019 | https://github.com/microsoft/TypeScript/pull/33622#event-2674119632 |
| https://github.com/RyanCavanaugh |
| Ryan Cavanaugh (RyanCavanaugh) | https://github.com/RyanCavanaugh |
|
Sep 30, 2019
| https://github.com/microsoft/TypeScript/pull/33622#pullrequestreview-295145089 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/33622/files/e5af71e3cd00c9803b07767e65d4afdd8419e661 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| ff5d38a | https://github.com/microsoft/TypeScript/commit/ff5d38a94b8ff36b381c3e4a8eb67d2b43519141 |
| Sep 30, 2019 | https://github.com/microsoft/TypeScript/pull/33622#event-2674223317 |
| https://github.com/jcalz |
| Joe Calzaretta (jcalz) | https://github.com/jcalz |
|
Oct 17, 2019
| https://github.com/microsoft/TypeScript/pull/33622#ref-issue-508079201 |
|
asserts x is type doesn't work when using arrow functions
#34523
| https://github.com/microsoft/TypeScript/issues/34523 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
|
Oct 18, 2019
| https://github.com/microsoft/TypeScript/pull/33622#ref-issue-509299187 |
|
Design Meeting Notes, 9/27/2019
#34573
| https://github.com/microsoft/TypeScript/issues/34573 |
| https://github.com/jcalz |
| Joe Calzaretta (jcalz) | https://github.com/jcalz |
|
Oct 20, 2019
| https://github.com/microsoft/TypeScript/pull/33622#ref-issue-509493451 |
|
TS 3.7: unlike x is T, asserts x is T cannot close over generics defined in outer scopes
#34596
| https://github.com/microsoft/TypeScript/issues/34596 |
| https://github.com/targos |
| Michaël Zasso (targos) | https://github.com/targos |
|
Dec 19, 2019
| https://github.com/microsoft/TypeScript/pull/33622#ref-pullrequest-534473953 |
|
fix(response): use never return type for abort method
adonisjs/http-server#13
| https://github.com/adonisjs/http-server/pull/13 |
| https://github.com/mgcrea |
| Olivier Louvignes (mgcrea) | https://github.com/mgcrea |
| Jan 16, 2020 | https://github.com/microsoft/TypeScript/pull/33622#issuecomment-575301357 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33622 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33622 |
| https://github.com/mlhaufe |
| Michael Haufe (mlhaufe) | https://github.com/mlhaufe |
|
Feb 21, 2020
| https://github.com/microsoft/TypeScript/pull/33622#ref-issue-568956082 |
|
Assertion functions don't work when defined as methods
#36931
| https://github.com/microsoft/TypeScript/issues/36931 |
| https://github.com/earthlyreason |
| Gavin Cannizzaro (earthlyreason) | https://github.com/earthlyreason |
|
Feb 23, 2020
| https://github.com/microsoft/TypeScript/pull/33622#ref-issue-569545961 |
|
Use TypeScript assertion function signatures
avajs/ava#2411
| https://github.com/avajs/ava/issues/2411 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
|
Apr 2, 2020
| https://github.com/microsoft/TypeScript/pull/33622#ref-issue-592320692 |
|
I hope the type checker to report an error when I call a function which return never.
#37747
| https://github.com/microsoft/TypeScript/issues/37747 |
| https://github.com/jsoverson |
| Jarrod Overson (jsoverson) | https://github.com/jsoverson |
|
May 18, 2020
| https://github.com/microsoft/TypeScript/pull/33622#ref-pullrequest-619362341 |
|
added node type, exported expression and statement types
shapesecurity/shift-ast-js#59
| https://github.com/shapesecurity/shift-ast-js/pull/59 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| July 30, 2020 21:58 | https://github.com/microsoft/TypeScript/pull/33622#event-3605968191 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
|
Jul 30, 2020
| https://github.com/microsoft/TypeScript/pull/33622#ref-issue-669216777 |
|
Methods that always throw aren't always recognized as a return from a function
#39839
| https://github.com/microsoft/TypeScript/issues/39839 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
|
Jul 26, 2021
| https://github.com/microsoft/TypeScript/pull/33622#ref-pullrequest-950952402 |
|
Allow narrowing for any left-hand in operand
#45152
| https://github.com/microsoft/TypeScript/pull/45152 |
| https://github.com/andrewbranch |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
|
Sep 2, 2021
| https://github.com/microsoft/TypeScript/pull/33622#ref-issue-984499266 |
|
Type narrowing not work with inferred function arguments
#45671
| https://github.com/microsoft/TypeScript/issues/45671 |
| https://github.com/jcalz |
| Joe Calzaretta (jcalz) | https://github.com/jcalz |
|
Sep 21, 2021
| https://github.com/microsoft/TypeScript/pull/33622#ref-issue-964448303 |
|
Feature Request/Question: Lift the explicit type requirement in assertions for participation in CFA
#45385
| https://github.com/microsoft/TypeScript/issues/45385 |
| https://github.com/ZachHaber |
| Zachary Haber (ZachHaber) | https://github.com/ZachHaber |
|
Aug 16, 2023
| https://github.com/microsoft/TypeScript/pull/33622#ref-issue-1718528281 |
|
Make assertions throw
avajs/ava#3201
| https://github.com/avajs/ava/issues/3201 |
| https://github.com/acuarica |
| Luis Mastrangelo (acuarica) | https://github.com/acuarica |
|
Dec 30, 2023
| https://github.com/microsoft/TypeScript/pull/33622#ref-issue-2060878103 |
|
Support return type assertions for steps
acuarica/evm#60
| https://github.com/acuarica/evm/issues/60 |
| https://github.com/danvk |
| Dan Vanderkam (danvk) | https://github.com/danvk |
|
May 13, 2024
| https://github.com/microsoft/TypeScript/pull/33622#ref-pullrequest-2290086715 |
|
Infer AssertsIdentifier type predicates
#58495
| https://github.com/microsoft/TypeScript/pull/58495 |
| https://github.com/jcalz |
| Joe Calzaretta (jcalz) | https://github.com/jcalz |
|
Aug 21, 2024
| https://github.com/microsoft/TypeScript/pull/33622#ref-issue-2477480260 |
|
Unions of assertion functions do not act as assertion functions
#59707
| https://github.com/microsoft/TypeScript/issues/59707 |
| https://github.com/ruanyf |
| Ruan YiFeng (ruanyf) | https://github.com/ruanyf |
|
Sep 23, 2024
| https://github.com/microsoft/TypeScript/pull/33622#ref-issue-2541435462 |
|
断言函数用于函数表达式时,ts 报错,
wangdoc/typescript-tutorial#119
| https://github.com/wangdoc/typescript-tutorial/issues/119 |
| https://github.com/jcalz |
| Joe Calzaretta (jcalz) | https://github.com/jcalz |
|
Oct 4, 2024
| https://github.com/microsoft/TypeScript/pull/33622#ref-issue-2564397487 |
|
Assertion signature on generics doesn't narrow
#60130
| https://github.com/microsoft/TypeScript/issues/60130 |
| https://github.com/rotu |
| Dan Rose (rotu) | https://github.com/rotu |
|
Feb 3, 2025
| https://github.com/microsoft/TypeScript/pull/33622#ref-issue-2826678006 |
|
Type predicate silently ignored when used as non-statement expression
#61105
| https://github.com/microsoft/TypeScript/issues/61105 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Oct 21, 2025 | https://github.com/microsoft/TypeScript/pull/33622#event-20416785786 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| Oct 21, 2025 | https://github.com/microsoft/TypeScript/pull/33622#event-20416786170 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F33622 |
|
| https://github.com/DanielRosenwasser |
|
Daniel Rosenwasser (DanielRosenwasser)
| https://github.com/DanielRosenwasser |
|
| https://github.com/microsoft/TypeScript/pull/33622/files/e5af71e3cd00c9803b07767e65d4afdd8419e661 |
|
| https://github.com/weswigham |
|
Wesley Wigham (weswigham)
| https://github.com/weswigham |
|
| https://github.com/microsoft/TypeScript/pull/33622/files/e5af71e3cd00c9803b07767e65d4afdd8419e661 |
|
| https://github.com/RyanCavanaugh |
|
Ryan Cavanaugh (RyanCavanaugh)
| https://github.com/RyanCavanaugh |
|
| https://github.com/microsoft/TypeScript/pull/33622/files/e5af71e3cd00c9803b07767e65d4afdd8419e661 |
|
| https://github.com/sandersn |
|
Nathan Shively-Sanders (sandersn)
| https://github.com/sandersn |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33622 |
|
| https://github.com/ahejlsberg |
|
Anders Hejlsberg (ahejlsberg)
| https://github.com/ahejlsberg |
|
TypeScript 3.7.0
| https://github.com/microsoft/TypeScript/milestone/98 |
|
CFA Assertions Not Active on Implicitly-Typed Function Calls
| https://github.com/microsoft/TypeScript/issues/33580 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33622 |
|
| https://github.com/ahejlsberg |
|
| https://github.com/typescript-bot |
|
| https://github.com/DanielRosenwasser |
|
| https://github.com/jack-williams |
|
| https://github.com/sandersn |
|
| https://github.com/mgcrea |
|
| https://github.com/weswigham |
|
| https://github.com/RyanCavanaugh |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |