René's URL Explorer Experiment


Title: Use getters to define live export bindings by mlrawlings · Pull Request #33587 · microsoft/TypeScript · GitHub

Open Graph Title: Use getters to define live export bindings by mlrawlings · Pull Request #33587 · microsoft/TypeScript

X Title: Use getters to define live export bindings by mlrawlings · Pull Request #33587 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Use getters to define live export bindings by mlrawlings · Pull Request #33587 · microsoft/TypeScript

Open Graph Description: Fixes #12522 Fixes #6366 When re-exporting a binding, it should remain live instead of being a snapshot. This PR uses the same approach as Babel: use getters instead of property assignments . Summ...

X Description: Fixes #12522 Fixes #6366 When re-exporting a binding, it should remain live instead of being a snapshot. This PR uses the same approach as Babel: use getters instead of property assignments . Summ...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/33587

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2e2cf315-478a-4fa4-59a8-d3d13eae421d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD94:38C5CF:FD4595:144D3BB:6B00FD01
html-safe-nonce7a575f78084b8e4afa85c15cf45bd0b7d00add4d336934d95d5cd33fa9eb1189
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDk0OjM4QzVDRjpGRDQ1OTU6MTQ0RDNCQjo2QjAwRkQwMSIsInZpc2l0b3JfaWQiOiI2NjgzMDAwMzU1OTYzMzM3OTg1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc80610bccc63d8035d6ae9de4ffe6492e01b865879034dfc295f959cfedb6ba5
hovercard-subject-tagpull_request:321063519
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/33587/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0ce8addb9e026268fce8d5a1eb31caab345ef9e87bdce2ee9acf575f2c30653e/microsoft/TypeScript/pull/33587
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0ce8addb9e026268fce8d5a1eb31caab345ef9e87bdce2ee9acf575f2c30653e/microsoft/TypeScript/pull/33587
og:image:altFixes #12522 Fixes #6366 When re-exporting a binding, it should remain live instead of being a snapshot. This PR uses the same approach as Babel: use getters instead of property assignments . Summ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemlrawlings
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/33587#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F33587
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F33587
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/33587
Reloadhttps://github.com/microsoft/TypeScript/pull/33587
Reloadhttps://github.com/microsoft/TypeScript/pull/33587
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Michael Rawlings (mlrawlings)https://github.com/mlrawlings
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
mlrawlings:live-bindingshttps://github.com/mlrawlings/TypeScript/tree/live-bindings
Conversationhttps://github.com/microsoft/TypeScript/pull/33587
Commits3 (3)https://github.com/microsoft/TypeScript/pull/33587/commits
Checkshttps://github.com/microsoft/TypeScript/pull/33587/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/33587/files
Use getters to define live export bindingshttps://github.com/microsoft/TypeScript/pull/33587#top
Michael Rawlings (mlrawlings)https://github.com/mlrawlings
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
mlrawlings:live-bindingshttps://github.com/mlrawlings/TypeScript/tree/live-bindings
https://github.com/mlrawlings
Michael Rawlings (mlrawlings)https://github.com/mlrawlings
Sep 25, 2019https://github.com/microsoft/TypeScript/pull/33587#issue-498052270
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
#12522https://github.com/microsoft/TypeScript/issues/12522
#6366https://github.com/microsoft/TypeScript/issues/6366
Babelhttps://babeljs.io/repl#?babili=false&browsers=safari%20%3E%2011&build=&builtIns=false&spec=true&loose=false&code_lz=KYDwDg9gTgLgBAbzgIwIZTgXzgMyhAWzgCIcIJiBuIA&debug=false&forceAllTransforms=false&shippedProposals=false&circleciRepo=&evaluate=false&fileSize=false&timeTravel=false&sourceType=module&lineWrap=true&presets=env&prettier=false&targets=&version=7.6.2&externalPlugins=
causes a getter to be definedhttps://github.com/mlrawlings/TypeScript/blob/a8d6c2beaf4a1ba91f24e3c17e427989419f82fd/src/compiler/transformers/module/module.ts#L1507-L1534
visitExportDeclarationhttps://github.com/mlrawlings/TypeScript/blob/a8d6c2beaf4a1ba91f24e3c17e427989419f82fd/src/compiler/transformers/module/module.ts#L1001
appendExportsOfImportDeclarationhttps://github.com/mlrawlings/TypeScript/blob/a8d6c2beaf4a1ba91f24e3c17e427989419f82fd/src/compiler/transformers/module/module.ts#L1313
appendExportsOfDeclarationhttps://github.com/mlrawlings/TypeScript/blob/a8d6c2beaf4a1ba91f24e3c17e427989419f82fd/src/compiler/transformers/module/module.ts#L1428
appendExportStatementhttps://github.com/mlrawlings/TypeScript/blob/a8d6c2beaf4a1ba91f24e3c17e427989419f82fd/src/compiler/transformers/module/module.ts#L1447
createExportStatementhttps://github.com/mlrawlings/TypeScript/blob/a8d6c2beaf4a1ba91f24e3c17e427989419f82fd/src/compiler/transformers/module/module.ts#L1489
exportStarHelperhttps://github.com/mlrawlings/TypeScript/blob/a8d6c2beaf4a1ba91f24e3c17e427989419f82fd/src/compiler/transformers/module/module.ts#L1810-L1815
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
https://github.com/mlrawlings
use getters to define live export bindingshttps://github.com/microsoft/TypeScript/pull/33587/commits/a8d6c2beaf4a1ba91f24e3c17e427989419f82fd
a8d6c2bhttps://github.com/microsoft/TypeScript/pull/33587/commits/a8d6c2beaf4a1ba91f24e3c17e427989419f82fd
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
Sep 25, 2019https://github.com/microsoft/TypeScript/pull/33587#issuecomment-534855573
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
https://cla.opensource.microsoft.com/microsoft/TypeScript?pullRequest=33587
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
https://github.com/ajafff
Klaus Meinhardt (ajafff)https://github.com/ajafff
Sep 25, 2019 https://github.com/microsoft/TypeScript/pull/33587#pullrequestreview-292862179
View reviewed changes https://github.com/microsoft/TypeScript/pull/33587/files/a8d6c2beaf4a1ba91f24e3c17e427989419f82fd
src/compiler/transformers/module/module.tshttps://github.com/microsoft/TypeScript/pull/33587/files/a8d6c2beaf4a1ba91f24e3c17e427989419f82fd#diff-3fa693abdf43c2781ae8cfa1d3b0450280b3aad90e7e8ae738efe58bcaced918
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
https://github.com/mlrawlings
fix scoping in export* helperhttps://github.com/microsoft/TypeScript/pull/33587/commits/27941d05b640148554dd60516144d04a2488536c
27941d0https://github.com/microsoft/TypeScript/pull/33587/commits/27941d05b640148554dd60516144d04a2488536c
https://github.com/Jessidhia
Jessica Franco (Jessidhia)https://github.com/Jessidhia
Sep 26, 2019 https://github.com/microsoft/TypeScript/pull/33587#pullrequestreview-293490157
View reviewed changes https://github.com/microsoft/TypeScript/pull/33587/files/27941d05b640148554dd60516144d04a2488536c
tests/baselines/reference/ambientShorthand_reExport.jshttps://github.com/microsoft/TypeScript/pull/33587/files/27941d05b640148554dd60516144d04a2488536c#diff-8c937e9c26c3427ec1bf5e723af50e781a97568b4efccfe4019d83e9b19e4f2e
Jessica Franco (Jessidhia)https://github.com/Jessidhia
Sep 26, 2019https://github.com/microsoft/TypeScript/pull/33587#discussion_r328439383
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
Michael Rawlings (mlrawlings)https://github.com/mlrawlings
Sep 26, 2019https://github.com/microsoft/TypeScript/pull/33587#discussion_r328817537
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#12522https://github.com/microsoft/TypeScript/issues/12522
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
tests/baselines/reference/ambientShorthand_reExport.jshttps://github.com/microsoft/TypeScript/pull/33587/files/27941d05b640148554dd60516144d04a2488536c#diff-8c937e9c26c3427ec1bf5e723af50e781a97568b4efccfe4019d83e9b19e4f2e
Jessica Franco (Jessidhia)https://github.com/Jessidhia
Sep 26, 2019https://github.com/microsoft/TypeScript/pull/33587#discussion_r328439512
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
Michael Rawlings (mlrawlings)https://github.com/mlrawlings
Sep 26, 2019https://github.com/microsoft/TypeScript/pull/33587#discussion_r328817561
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
TypeScript/src/compiler/transformers/module/module.tshttps://github.com/microsoft/TypeScript/blob/27941d05b640148554dd60516144d04a2488536c/src/compiler/transformers/module/module.ts#L1451-L1478
27941d0https://github.com/microsoft/TypeScript/commit/27941d05b640148554dd60516144d04a2488536c
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
tests/baselines/reference/ambientShorthand_reExport.jshttps://github.com/microsoft/TypeScript/pull/33587/files/27941d05b640148554dd60516144d04a2488536c#diff-8c937e9c26c3427ec1bf5e723af50e781a97568b4efccfe4019d83e9b19e4f2e
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
tests/baselines/reference/es6ExportClauseWithoutModuleSpecifierInEs5.jshttps://github.com/microsoft/TypeScript/pull/33587/files/27941d05b640148554dd60516144d04a2488536c#diff-c16e2e943a7359a644b2c7d2cabbfb6be99f86aef2eaf136829f5753c35ff62b
Jessica Franco (Jessidhia)https://github.com/Jessidhia
Sep 26, 2019https://github.com/microsoft/TypeScript/pull/33587#discussion_r328440340
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
Michael Rawlings (mlrawlings)https://github.com/mlrawlings
Sep 26, 2019https://github.com/microsoft/TypeScript/pull/33587#discussion_r328818395
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
https://github.com/mlrawlings
Michael Rawlings (mlrawlings)https://github.com/mlrawlings
Sep 26, 2019 https://github.com/microsoft/TypeScript/pull/33587#ref-pullrequest-499074344
use getters for exportStar helper microsoft/tslib#78 https://github.com/microsoft/tslib/pull/78
https://github.com/mlrawlings
Michael Rawlings (mlrawlings)https://github.com/mlrawlings
Oct 1, 2019https://github.com/microsoft/TypeScript/pull/33587#issuecomment-537214458
Jessica Franco (@Jessidhia)https://github.com/Jessidhia
Klaus Meinhardt (@ajafff)https://github.com/ajafff
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
https://github.com/squidfunk
Martin Donath (squidfunk)https://github.com/squidfunk
Oct 23, 2019https://github.com/microsoft/TypeScript/pull/33587#issuecomment-545333396
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Dec 16, 2019https://github.com/microsoft/TypeScript/pull/33587#issuecomment-566195370
Ron Buckton (@rbuckton)https://github.com/rbuckton
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Dec 16, 2019 https://github.com/microsoft/TypeScript/pull/33587#pullrequestreview-332811273
View reviewed changes https://github.com/microsoft/TypeScript/pull/33587/files/27941d05b640148554dd60516144d04a2488536c
src/compiler/transformers/module/module.tshttps://github.com/microsoft/TypeScript/pull/33587/files/27941d05b640148554dd60516144d04a2488536c#diff-3fa693abdf43c2781ae8cfa1d3b0450280b3aad90e7e8ae738efe58bcaced918
Ron Buckton (rbuckton)https://github.com/rbuckton
Dec 16, 2019https://github.com/microsoft/TypeScript/pull/33587#discussion_r358422329
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
ExE Boss (ExE-Boss)https://github.com/ExE-Boss
Dec 21, 2019https://github.com/microsoft/TypeScript/pull/33587#discussion_r360628972
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
src/compiler/transformers/module/module.tshttps://github.com/microsoft/TypeScript/pull/33587/files/27941d05b640148554dd60516144d04a2488536c#diff-3fa693abdf43c2781ae8cfa1d3b0450280b3aad90e7e8ae738efe58bcaced918
Ron Buckton (rbuckton)https://github.com/rbuckton
Dec 16, 2019https://github.com/microsoft/TypeScript/pull/33587#discussion_r358423269
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
tests/baselines/reference/ambientShorthand_reExport.jshttps://github.com/microsoft/TypeScript/pull/33587/files/27941d05b640148554dd60516144d04a2488536c#diff-8c937e9c26c3427ec1bf5e723af50e781a97568b4efccfe4019d83e9b19e4f2e
Ron Buckton (rbuckton)https://github.com/rbuckton
Dec 16, 2019https://github.com/microsoft/TypeScript/pull/33587#discussion_r358424845
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
src/compiler/transformers/module/module.tshttps://github.com/microsoft/TypeScript/pull/33587/files/27941d05b640148554dd60516144d04a2488536c#diff-3fa693abdf43c2781ae8cfa1d3b0450280b3aad90e7e8ae738efe58bcaced918
Ron Buckton (rbuckton)https://github.com/rbuckton
Dec 16, 2019https://github.com/microsoft/TypeScript/pull/33587#discussion_r358425478
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
https://github.com/mlrawlings
Object.defineProperty cannot be used in ES3 targethttps://github.com/microsoft/TypeScript/pull/33587/commits/0b2cf9b71a04b3387acd052c063779e8d28b8fbb
0b2cf9bhttps://github.com/microsoft/TypeScript/pull/33587/commits/0b2cf9b71a04b3387acd052c063779e8d28b8fbb
https://github.com/mlrawlings
Michael Rawlings (mlrawlings)https://github.com/mlrawlings
Dec 16, 2019https://github.com/microsoft/TypeScript/pull/33587#issuecomment-566255126
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
Ron Buckton (@rbuckton)https://github.com/rbuckton
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Dec 16, 2019 https://github.com/microsoft/TypeScript/pull/33587#pullrequestreview-332881933
View reviewed changes https://github.com/microsoft/TypeScript/pull/33587/files/0b2cf9b71a04b3387acd052c063779e8d28b8fbb
tests/baselines/reference/declarationEmitReexportedSymlinkReference.jshttps://github.com/microsoft/TypeScript/pull/33587/files/0b2cf9b71a04b3387acd052c063779e8d28b8fbb#diff-b3b7bd6c1398bbd76e470f6dec4631dd8395f89fdb2b592452fbe548fdb021bd
Ron Buckton (rbuckton)https://github.com/rbuckton
Dec 16, 2019https://github.com/microsoft/TypeScript/pull/33587#discussion_r358477219
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
tests/baselines/reference/declarationEmitReexportedSymlinkReference3.jshttps://github.com/microsoft/TypeScript/pull/33587/files/0b2cf9b71a04b3387acd052c063779e8d28b8fbb#diff-cd8412d3ff4e72cfde129972d451746e22fd72cc4543327b36aa7d4b5f9bb646
Ron Buckton (rbuckton)https://github.com/rbuckton
Dec 16, 2019https://github.com/microsoft/TypeScript/pull/33587#discussion_r358477359
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
src/compiler/transformers/module/module.tshttps://github.com/microsoft/TypeScript/pull/33587/files/0b2cf9b71a04b3387acd052c063779e8d28b8fbb#diff-3fa693abdf43c2781ae8cfa1d3b0450280b3aad90e7e8ae738efe58bcaced918
Ron Buckton (rbuckton)https://github.com/rbuckton
Dec 16, 2019https://github.com/microsoft/TypeScript/pull/33587#discussion_r358478358
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
tests/baselines/reference/transformApi/transformsCorrectly.transformAddCommentToImport.jshttps://github.com/microsoft/TypeScript/pull/33587/files/0b2cf9b71a04b3387acd052c063779e8d28b8fbb#diff-945cb63652f61ecf4139efccfddc753cecca874f0ffd5b4d99c8f870d43df0e9
Ron Buckton (rbuckton)https://github.com/rbuckton
Dec 16, 2019https://github.com/microsoft/TypeScript/pull/33587#discussion_r358478909
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Dec 16, 2019https://github.com/microsoft/TypeScript/pull/33587#issuecomment-566262273
tslibhttps://github.com/microsoft/tslib
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Dec 16, 2019https://github.com/microsoft/TypeScript/pull/33587#issuecomment-566263894
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
Wesley Wigham (@weswigham)https://github.com/weswigham
Daniel Rosenwasser (@DanielRosenwasser)https://github.com/DanielRosenwasser
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Dec 16, 2019https://github.com/microsoft/TypeScript/pull/33587#issuecomment-566278888
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
https://github.com/rbuckton
Ron Buckton (rbuckton)https://github.com/rbuckton
Dec 16, 2019https://github.com/microsoft/TypeScript/pull/33587#issuecomment-566284458
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Dec 17, 2019https://github.com/microsoft/TypeScript/pull/33587#issuecomment-566319256
Michael Rawlings (@mlrawlings)https://github.com/mlrawlings
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Dec 17, 2019https://github.com/microsoft/TypeScript/pull/33587#issuecomment-566319665
Ron Buckton (@rbuckton)https://github.com/rbuckton
Michael Rawlings (@mlrawlings)https://github.com/mlrawlings
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Breaking Change https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Breaking%20Change%22
Update Docs on Next Release https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Update%20Docs%20on%20Next%20Release%22
Dec 20, 2019https://github.com/microsoft/TypeScript/pull/33587#event-2901895859
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Dec 20, 2019 https://github.com/microsoft/TypeScript/pull/33587#ref-issue-541207224
Design Meeting Notes, 12/20/2019 #35807 https://github.com/microsoft/TypeScript/issues/35807
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Dec 23, 2019https://github.com/microsoft/TypeScript/pull/33587#issuecomment-568565048
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
Michael Rawlings (@mlrawlings)https://github.com/mlrawlings
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
https://github.com/ajafff
Klaus Meinhardt (ajafff)https://github.com/ajafff
Dec 30, 2019 https://github.com/microsoft/TypeScript/pull/33587#pullrequestreview-337066767
View reviewed changes https://github.com/microsoft/TypeScript/pull/33587/files/0b2cf9b71a04b3387acd052c063779e8d28b8fbb
Klaus Meinhardt (ajafff)https://github.com/ajafff
https://github.com/microsoft/TypeScript/pull/33587#pullrequestreview-337066767
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Jan 2, 2020 https://github.com/microsoft/TypeScript/pull/33587#ref-pullrequest-544748356
Use getters to define live export bindings refresh #35967 https://github.com/microsoft/TypeScript/pull/35967
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Jan 2, 2020 https://github.com/microsoft/TypeScript/pull/33587#pullrequestreview-337894766
View reviewed changes https://github.com/microsoft/TypeScript/pull/33587/files/0b2cf9b71a04b3387acd052c063779e8d28b8fbb
src/compiler/transformers/module/module.tshttps://github.com/microsoft/TypeScript/pull/33587/files/0b2cf9b71a04b3387acd052c063779e8d28b8fbb#diff-3fa693abdf43c2781ae8cfa1d3b0450280b3aad90e7e8ae738efe58bcaced918
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Jan 2, 2020https://github.com/microsoft/TypeScript/pull/33587#discussion_r362659106
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Feb 3, 2020 https://github.com/microsoft/TypeScript/pull/33587#pullrequestreview-352480688
View reviewed changes https://github.com/microsoft/TypeScript/pull/33587/files/0b2cf9b71a04b3387acd052c063779e8d28b8fbb
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
https://github.com/microsoft/TypeScript/pull/33587#pullrequestreview-352480688
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Feb 3, 2020https://github.com/microsoft/TypeScript/pull/33587#issuecomment-581561534
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
#35967https://github.com/microsoft/TypeScript/pull/35967
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Feb 3, 2020https://github.com/microsoft/TypeScript/pull/33587#event-3003380845
https://github.com/mwpenny
Matt Penny (mwpenny)https://github.com/mwpenny
Dec 4, 2020 https://github.com/microsoft/TypeScript/pull/33587#ref-issue-757403724
New Proposed API checking causes extensions to fail to load when using "import * as vscode" with TypeScript < 3.9 microsoft/vscode#111913 https://github.com/microsoft/vscode/issues/111913
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/33587#event-20416783853
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/33587#issuecomment-3429843929
#12522https://github.com/microsoft/TypeScript/issues/12522
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F33587
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) https://github.com/DanielRosenwasser
https://github.com/microsoft/TypeScript/pull/33587/files/0b2cf9b71a04b3387acd052c063779e8d28b8fbb
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
https://github.com/microsoft/TypeScript/pull/33587/files/0b2cf9b71a04b3387acd052c063779e8d28b8fbb
https://github.com/Jessidhia
Jessica Franco (Jessidhia) https://github.com/Jessidhia
https://github.com/microsoft/TypeScript/pull/33587/files/27941d05b640148554dd60516144d04a2488536c
https://github.com/ExE-Boss
ExE Boss (ExE-Boss) https://github.com/ExE-Boss
https://github.com/microsoft/TypeScript/pull/33587/files/0b2cf9b71a04b3387acd052c063779e8d28b8fbb
https://github.com/rbuckton
Ron Buckton (rbuckton) https://github.com/rbuckton
https://github.com/microsoft/TypeScript/pull/33587/files/0b2cf9b71a04b3387acd052c063779e8d28b8fbb
https://github.com/ajafff
Klaus Meinhardt (ajafff) https://github.com/ajafff
https://github.com/microsoft/TypeScript/pull/33587/files/0b2cf9b71a04b3387acd052c063779e8d28b8fbb
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
Breaking Change https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Breaking%20Change%22
Update Docs on Next Release https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Update%20Docs%20on%20Next%20Release%22
[Bug] Re-exported binding doesn't track the original binding https://github.com/microsoft/TypeScript/issues/12522
ES6 module variables are copied when re-exported https://github.com/microsoft/TypeScript/issues/6366
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33587
https://github.com/mlrawlings
https://github.com/msftclas
https://github.com/squidfunk
https://github.com/weswigham
https://github.com/rbuckton
https://github.com/DanielRosenwasser
https://github.com/typescript-bot
https://github.com/Jessidhia
https://github.com/sandersn
https://github.com/ExE-Boss
https://github.com/ajafff
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.