René's URL Explorer Experiment


Title: Disallow uninitialised property overrides by sandersn · Pull Request #33423 · microsoft/TypeScript · GitHub

Open Graph Title: Disallow uninitialised property overrides by sandersn · Pull Request #33423 · microsoft/TypeScript

X Title: Disallow uninitialised property overrides by sandersn · Pull Request #33423 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Disallow uninitialised property overrides by sandersn · Pull Request #33423 · microsoft/TypeScript

Open Graph Description: This PR is part of the migration from [[Set]] semantics to [[Define]] semantics. #27644 tracks the complete migration. This is the third step. Briefly, uninitialised property declarations that must...

X Description: This PR is part of the migration from [[Set]] semantics to [[Define]] semantics. #27644 tracks the complete migration. This is the third step. Briefly, uninitialised property declarations that must...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/33423

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:056d3d9b-c34a-22af-1046-08ebcc631405
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDA1E:65478:2397D98:2F32BC6:6B018C90
html-safe-nonce54555a176612062a4ec5552ee700069ed0614dca366dd0da45242c094ade9d6d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQTFFOjY1NDc4OjIzOTdEOTg6MkYzMkJDNjo2QjAxOEM5MCIsInZpc2l0b3JfaWQiOiI1Nzc1OTM2NjEzNDY5MjI4MTc2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac80f407e87aa2b85bbae84abf4c577ad606a78cf0c0b5ef88511eb20b70ec71c5
hovercard-subject-tagpull_request:317492941
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/33423/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/bc1fa876e1aa3ce10870b24523ea4102e3256d6d3fb50ef4b39eaf1cf7cca67a/microsoft/TypeScript/pull/33423
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bc1fa876e1aa3ce10870b24523ea4102e3256d6d3fb50ef4b39eaf1cf7cca67a/microsoft/TypeScript/pull/33423
og:image:altThis PR is part of the migration from [[Set]] semantics to [[Define]] semantics. #27644 tracks the complete migration. This is the third step. Briefly, uninitialised property declarations that must...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesandersn
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/33423#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F33423
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F33423
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/33423
Reloadhttps://github.com/microsoft/TypeScript/pull/33423
Reloadhttps://github.com/microsoft/TypeScript/pull/33423
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
disallow-uninitialised-property-overridehttps://github.com/microsoft/TypeScript/tree/disallow-uninitialised-property-override
Conversationhttps://github.com/microsoft/TypeScript/pull/33423
Commits18 (18)https://github.com/microsoft/TypeScript/pull/33423/commits
Checkshttps://github.com/microsoft/TypeScript/pull/33423/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/33423/files
Disallow uninitialised property overrideshttps://github.com/microsoft/TypeScript/pull/33423#top
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
disallow-uninitialised-property-overridehttps://github.com/microsoft/TypeScript/tree/disallow-uninitialised-property-override
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Sep 13, 2019https://github.com/microsoft/TypeScript/pull/33423#issue-493528861
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
#27644https://github.com/microsoft/TypeScript/issues/27644
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
https://github.com/sandersn
Disallow uninitialised property overrideshttps://github.com/microsoft/TypeScript/pull/33423/commits/ac9673977758afb864137da021f728afc30f7139
ac96739https://github.com/microsoft/TypeScript/pull/33423/commits/ac9673977758afb864137da021f728afc30f7139
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Sep 13, 2019https://github.com/microsoft/TypeScript/pull/33423#issuecomment-531401153
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Sep 13, 2019https://github.com/microsoft/TypeScript/pull/33423#issuecomment-531401161
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
ac96739https://github.com/microsoft/TypeScript/commit/ac9673977758afb864137da021f728afc30f7139
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=43925
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Sep 13, 2019https://github.com/microsoft/TypeScript/pull/33423#issuecomment-531401162
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
ac96739https://github.com/microsoft/TypeScript/commit/ac9673977758afb864137da021f728afc30f7139
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=43927
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Sep 13, 2019https://github.com/microsoft/TypeScript/pull/33423#issuecomment-531401164
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
ac96739https://github.com/microsoft/TypeScript/commit/ac9673977758afb864137da021f728afc30f7139
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=43926
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Sep 13, 2019https://github.com/microsoft/TypeScript/pull/33423#issuecomment-531408057
PR with the baseline diff from masterhttps://github.com/microsoft/TypeScript/pull/33424
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Sep 13, 2019 https://github.com/microsoft/TypeScript/pull/33423#ref-pullrequest-493537563
🤖 User test baselines have changed for disallow-uninitialised-property-override #33424 https://github.com/microsoft/TypeScript/pull/33424
https://github.com/AlCalzone
AlCalzonehttps://github.com/AlCalzone
Sep 14, 2019https://github.com/microsoft/TypeScript/pull/33423#issuecomment-531468541
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Sep 16, 2019 https://github.com/microsoft/TypeScript/pull/33423#ref-pullrequest-493059496
Disallow property/accessor overrides #33401 https://github.com/microsoft/TypeScript/pull/33401
https://github.com/sandersn
Need to add a couple of errors and squash onehttps://github.com/microsoft/TypeScript/pull/33423/commits/70a15bdeeb432e77bc62ee9e2ffd378922da3c3f
70a15bdhttps://github.com/microsoft/TypeScript/pull/33423/commits/70a15bdeeb432e77bc62ee9e2ffd378922da3c3f
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Sep 16, 2019https://github.com/microsoft/TypeScript/pull/33423#issuecomment-531888559
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
AlCalzonehttps://github.com/AlCalzone
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Sep 16, 2019https://github.com/microsoft/TypeScript/pull/33423#issuecomment-531888999
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
ac96739https://github.com/microsoft/TypeScript/commit/ac9673977758afb864137da021f728afc30f7139
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=44156
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Sep 16, 2019https://github.com/microsoft/TypeScript/pull/33423#issuecomment-531891302
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
an installable tgzhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/44156/artifacts?artifactName=tgz&fileId=1E6A72F0C6E099FF6B046F9DBFDBA5D1CF45DD963781CEFBCFDBBDE15FD60F7C02&fileName=/typescript-3.7.0-insiders.20190916.tgz
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
September 16, 2019 13:36https://github.com/microsoft/TypeScript/pull/33423#commits-pushed-feb0fb6
https://github.com/sandersn
Everything works so farhttps://github.com/microsoft/TypeScript/pull/33423/commits/feb0fb6dc4c3e4b93af9f07f1f57275f80fe61cc
feb0fb6https://github.com/microsoft/TypeScript/pull/33423/commits/feb0fb6dc4c3e4b93af9f07f1f57275f80fe61cc
https://github.com/sandersn
Check for constructor initialisationhttps://github.com/microsoft/TypeScript/pull/33423/commits/868624293d156985e08eae49ab7a834b30c255ad
8686242https://github.com/microsoft/TypeScript/pull/33423/commits/868624293d156985e08eae49ab7a834b30c255ad
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Sep 16, 2019https://github.com/microsoft/TypeScript/pull/33423#issuecomment-531980203
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Sep 16, 2019https://github.com/microsoft/TypeScript/pull/33423#issuecomment-531980233
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
8686242https://github.com/microsoft/TypeScript/commit/868624293d156985e08eae49ab7a834b30c255ad
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=44184
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Sep 16, 2019https://github.com/microsoft/TypeScript/pull/33423#issuecomment-531980234
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
8686242https://github.com/microsoft/TypeScript/commit/868624293d156985e08eae49ab7a834b30c255ad
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=44185
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Sep 16, 2019https://github.com/microsoft/TypeScript/pull/33423#issuecomment-531980235
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
8686242https://github.com/microsoft/TypeScript/commit/868624293d156985e08eae49ab7a834b30c255ad
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=44186
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
https://github.com/sandersn
change error wordinghttps://github.com/microsoft/TypeScript/pull/33423/commits/2916c29204de34bb7dbbef93a18b18d9c4dd8ec4
2916c29https://github.com/microsoft/TypeScript/pull/33423/commits/2916c29204de34bb7dbbef93a18b18d9c4dd8ec4
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Sep 16, 2019https://github.com/microsoft/TypeScript/pull/33423#issuecomment-531988036
PR with the baseline diff from masterhttps://github.com/microsoft/TypeScript/pull/33456
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Sep 16, 2019 https://github.com/microsoft/TypeScript/pull/33423#ref-pullrequest-494313686
🤖 User test baselines have changed for disallow-uninitialised-property-override #33456 https://github.com/microsoft/TypeScript/pull/33456
https://github.com/sandersn
Improve error wordinghttps://github.com/microsoft/TypeScript/pull/33423/commits/2e5f57ce2b94bb08c29f58bde252c858a9e753f4
2e5f57chttps://github.com/microsoft/TypeScript/pull/33423/commits/2e5f57ce2b94bb08c29f58bde252c858a9e753f4
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Sep 16, 2019https://github.com/microsoft/TypeScript/pull/33423#issuecomment-531995120
Rado Kirov (@rkirov)https://github.com/rkirov
Martin Probst (@mprobst)https://github.com/mprobst
Evan Martin (@evmar)https://github.com/evmar
#33401https://github.com/microsoft/TypeScript/pull/33401
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
https://github.com/sandersn
Add codefix to add missing 'declare'https://github.com/microsoft/TypeScript/pull/33423/commits/f11f2beb5e287b891022335030a36da3ab0ac49a
f11f2behttps://github.com/microsoft/TypeScript/pull/33423/commits/f11f2beb5e287b891022335030a36da3ab0ac49a
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Sep 17, 2019https://github.com/microsoft/TypeScript/pull/33423#issuecomment-532295536
Ron Buckton (@rbuckton)https://github.com/rbuckton
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
September 17, 2019 09:47https://github.com/microsoft/TypeScript/pull/33423#commits-pushed-a8f4610
https://github.com/sandersn
Merge branch 'master' into disallow-uninitialised-property-overridehttps://github.com/microsoft/TypeScript/pull/33423/commits/a8f46107434935f2e1c32a8cc1fb09cf7b952e05
a8f4610https://github.com/microsoft/TypeScript/pull/33423/commits/a8f46107434935f2e1c32a8cc1fb09cf7b952e05
https://github.com/sandersn
Allow 'declare' on any uninitialised property declhttps://github.com/microsoft/TypeScript/pull/33423/commits/fcf0ff1dfde03a31100102af2adc8a512819e66c
fcf0ff1https://github.com/microsoft/TypeScript/pull/33423/commits/fcf0ff1dfde03a31100102af2adc8a512819e66c
https://github.com/sandersn
Undo code moveshttps://github.com/microsoft/TypeScript/pull/33423/commits/810f923d54445346fbc28cadf46271372c204c11
810f923https://github.com/microsoft/TypeScript/pull/33423/commits/810f923d54445346fbc28cadf46271372c204c11
https://github.com/sandersn
Let sleeping dogs liehttps://github.com/microsoft/TypeScript/pull/33423/commits/6408d7abe6bc39e703ab568e40063c75b83bceee
6408d7ahttps://github.com/microsoft/TypeScript/pull/33423/commits/6408d7abe6bc39e703ab568e40063c75b83bceee
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
September 17, 2019 13:45https://github.com/microsoft/TypeScript/pull/33423#commits-pushed-5ee3271
https://github.com/sandersn
Correctly set NodeFlags.Ambienthttps://github.com/microsoft/TypeScript/pull/33423/commits/5ee327185c07853791361d2fe692798930461c8e
5ee3271https://github.com/microsoft/TypeScript/pull/33423/commits/5ee327185c07853791361d2fe692798930461c8e
https://github.com/sandersn
Remove more unneeded codehttps://github.com/microsoft/TypeScript/pull/33423/commits/e0ddced06c4c68ab881e58c76cafd4f027b7ed7c
e0ddcedhttps://github.com/microsoft/TypeScript/pull/33423/commits/e0ddced06c4c68ab881e58c76cafd4f027b7ed7c
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Sep 17, 2019 https://github.com/microsoft/TypeScript/pull/33423#pullrequestreview-289463198
View reviewed changes https://github.com/microsoft/TypeScript/pull/33423/files/810f923d54445346fbc28cadf46271372c204c11
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/33423/files/810f923d54445346fbc28cadf46271372c204c11#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Sep 17, 2019https://github.com/microsoft/TypeScript/pull/33423#discussion_r325321694
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
https://github.com/sandersn
Update baselineshttps://github.com/microsoft/TypeScript/pull/33423/commits/6a066b9a7edc8cdc89ccbecccb633f7f5fcc2b3a
6a066b9https://github.com/microsoft/TypeScript/pull/33423/commits/6a066b9a7edc8cdc89ccbecccb633f7f5fcc2b3a
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Sep 17, 2019 https://github.com/microsoft/TypeScript/pull/33423#ref-issue-368417831
Handle breaking change in class property runtime behavior #27644 https://github.com/microsoft/TypeScript/issues/27644
https://github.com/ljharb
Jordan Harband (ljharb)https://github.com/ljharb
Sep 17, 2019https://github.com/microsoft/TypeScript/pull/33423#issuecomment-532442238
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Sep 18, 2019https://github.com/microsoft/TypeScript/pull/33423#issuecomment-532743027
Jordan Harband (@ljharb)https://github.com/ljharb
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
https://github.com/ljharb
Jordan Harband (ljharb)https://github.com/ljharb
Sep 18, 2019https://github.com/microsoft/TypeScript/pull/33423#issuecomment-532746329
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Sep 18, 2019https://github.com/microsoft/TypeScript/pull/33423#issuecomment-532747654
#33401https://github.com/microsoft/TypeScript/pull/33401
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Sep 18, 2019https://github.com/microsoft/TypeScript/pull/33423#issuecomment-532904045
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
September 19, 2019 10:51https://github.com/microsoft/TypeScript/pull/33423#commits-pushed-a645ca9
https://github.com/sandersn
Do not error when base parent is interfacehttps://github.com/microsoft/TypeScript/pull/33423/commits/a645ca9839005137d824622d245a16055092458e
a645ca9https://github.com/microsoft/TypeScript/pull/33423/commits/a645ca9839005137d824622d245a16055092458e
https://github.com/sandersn
Fix base interface checkhttps://github.com/microsoft/TypeScript/pull/33423/commits/030c768d91d4dfc61b2ca60fa94836098a64ddb1
030c768https://github.com/microsoft/TypeScript/pull/33423/commits/030c768d91d4dfc61b2ca60fa94836098a64ddb1
https://github.com/sandersn
Add missed baselineshttps://github.com/microsoft/TypeScript/pull/33423/commits/003d04151547cc14d6e613ff6b25c737fd730534
003d041https://github.com/microsoft/TypeScript/pull/33423/commits/003d04151547cc14d6e613ff6b25c737fd730534
https://github.com/sandersn
Fix new errors in serviceshttps://github.com/microsoft/TypeScript/pull/33423/commits/1c5f699994332a5cd6fbb22507b1535aca884b84
1c5f699https://github.com/microsoft/TypeScript/pull/33423/commits/1c5f699994332a5cd6fbb22507b1535aca884b84
https://github.com/littledan
Daniel Ehrenberg (littledan)https://github.com/littledan
Sep 21, 2019https://github.com/microsoft/TypeScript/pull/33423#issuecomment-533835995
Jordan Harband (@ljharb)https://github.com/ljharb
October 2019 TC39 agendahttps://github.com/tc39/agendas/blob/master/2019/10.md
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
https://github.com/ljharb
Jordan Harband (ljharb)https://github.com/ljharb
Sep 22, 2019https://github.com/microsoft/TypeScript/pull/33423#issuecomment-533856653
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
https://github.com/AlCalzone
AlCalzonehttps://github.com/AlCalzone
Sep 23, 2019https://github.com/microsoft/TypeScript/pull/33423#issuecomment-534124653
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Sep 23, 2019 https://github.com/microsoft/TypeScript/pull/33423#ref-pullrequest-495858078
Add useDefineForClassFields flag for Set -> Define property declaration #33509 https://github.com/microsoft/TypeScript/pull/33509
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Sep 23, 2019https://github.com/microsoft/TypeScript/pull/33423#issuecomment-534266184
#33509https://github.com/microsoft/TypeScript/pull/33509
AlCalzonehttps://github.com/AlCalzone
Jordan Harband (@ljharb)https://github.com/ljharb
#33509https://github.com/microsoft/TypeScript/pull/33509
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Sep 23, 2019https://github.com/microsoft/TypeScript/pull/33423#event-2655758879
https://github.com/AlCalzone
AlCalzonehttps://github.com/AlCalzone
Sep 24, 2019https://github.com/microsoft/TypeScript/pull/33423#issuecomment-534405513
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 1, 2019https://github.com/microsoft/TypeScript/pull/33423#issuecomment-537215244
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
https://github.com/AlCalzone
AlCalzonehttps://github.com/AlCalzone
Oct 2, 2019https://github.com/microsoft/TypeScript/pull/33423#issuecomment-537340923
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jan 24, 2020 https://github.com/microsoft/TypeScript/pull/33423#ref-issue-554879517
useDefineForClassFields and parameter properties: missing error or bad emit #36410 https://github.com/microsoft/TypeScript/issues/36410
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
November 7, 2022 17:34https://github.com/microsoft/TypeScript/pull/33423#event-7754881154
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/33423#event-20416777784
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/33423#event-20416778229
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F33423
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33423
https://github.com/sandersn
https://github.com/typescript-bot
https://github.com/AlCalzone
https://github.com/ljharb
https://github.com/littledan
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.