| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2f592351-a6e1-e4c9-7f79-80ccf6bec01a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EAC8:2463BD:2973B42:34EEB82:6B019706 |
| html-safe-nonce | 0161098269321471bd638c26d7f5bf713800c8158084964ea4b683b8bbec91ef |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQUM4OjI0NjNCRDoyOTczQjQyOjM0RUVCODI6NkIwMTk3MDYiLCJ2aXNpdG9yX2lkIjoiNTE4MDA3MjE3ODE3NTAyMjg1NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | d5ca46809b4f5f165bf6fb46365ff001b87cd79e1209d0f8edd0676b04984b77 |
| hovercard-subject-tag | pull_request:317116919 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/33402/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/005d34d819cb104a720e703ca63f7586efaa69b461dd43811d3b4dc171f6f2a8/microsoft/TypeScript/pull/33402 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/005d34d819cb104a720e703ca63f7586efaa69b461dd43811d3b4dc171f6f2a8/microsoft/TypeScript/pull/33402 |
| og:image:alt | Fixes #32831
Related: #18780
Corresponding VS Code PR: microsoft/vscode#80828
Adds a first-class formatter option for optional semicolons, with three options:
Ignore (default): Don’t touch semicol... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | andrewbranch |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/33402#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F33402 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F33402 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/33402 |
| Reload | https://github.com/microsoft/TypeScript/pull/33402 |
| Reload | https://github.com/microsoft/TypeScript/pull/33402 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests312 (312) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
| microsoft:master | https://github.com/microsoft/TypeScript/tree/master |
| andrewbranch:feature/semicolon-preference | https://github.com/andrewbranch/TypeScript/tree/feature/semicolon-preference |
| Conversation | https://github.com/microsoft/TypeScript/pull/33402 |
| Commits27 (27) | https://github.com/microsoft/TypeScript/pull/33402/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/33402/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/33402/files |
| Add semicolon preference to formatter options | https://github.com/microsoft/TypeScript/pull/33402#top |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
| microsoft:master | https://github.com/microsoft/TypeScript/tree/master |
| andrewbranch:feature/semicolon-preference | https://github.com/andrewbranch/TypeScript/tree/feature/semicolon-preference |
|
| https://github.com/andrewbranch |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
| Sep 12, 2019 | https://github.com/microsoft/TypeScript/pull/33402#issue-493063283 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
| #32831 | https://github.com/microsoft/TypeScript/issues/32831 |
| #18780 | https://github.com/microsoft/TypeScript/issues/18780 |
| microsoft/vscode#80828 | https://github.com/microsoft/vscode/pull/80828 |
| #31801 | https://github.com/microsoft/TypeScript/pull/31801 |
| #32903 | https://github.com/microsoft/TypeScript/pull/32903 |
| https://user-images.githubusercontent.com/3277153/64820234-cdefc700-d564-11e9-9ca8-479c623965cd.gif |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
| September 5, 2019 14:58 | https://github.com/microsoft/TypeScript/pull/33402#commits-pushed-df151ac |
|
| https://github.com/andrewbranch |
| Add UserPreferences for semicolons | https://github.com/microsoft/TypeScript/pull/33402/commits/df151ac8b3b9bebc249509bd6efa4fe51fc4ee24 |
| df151ac | https://github.com/microsoft/TypeScript/pull/33402/commits/df151ac8b3b9bebc249509bd6efa4fe51fc4ee24 |
|
| https://github.com/andrewbranch |
| Prototype formatter semicolon removal | https://github.com/microsoft/TypeScript/pull/33402/commits/7cca9f47bc21d86661bbbed02e039569f50b38c1 |
| 7cca9f4 | https://github.com/microsoft/TypeScript/pull/33402/commits/7cca9f47bc21d86661bbbed02e039569f50b38c1 |
|
| https://github.com/andrewbranch |
| Implement semicolon insertion | https://github.com/microsoft/TypeScript/pull/33402/commits/461e6ad8ea6231a13017ce7b65ca1b65ab217b1c |
| 461e6ad | https://github.com/microsoft/TypeScript/pull/33402/commits/461e6ad8ea6231a13017ce7b65ca1b65ab217b1c |
|
| https://github.com/andrewbranch |
| Fix existing tests | https://github.com/microsoft/TypeScript/pull/33402/commits/0d96d40cfd6cef5d95297eee5c16581a2c7d076a |
| 0d96d40 | https://github.com/microsoft/TypeScript/pull/33402/commits/0d96d40cfd6cef5d95297eee5c16581a2c7d076a |
|
| https://github.com/andrewbranch |
| Start adding tests | https://github.com/microsoft/TypeScript/pull/33402/commits/7cae3cdbd136b275d2560617fd546bace6ad9f8f |
| 7cae3cd | https://github.com/microsoft/TypeScript/pull/33402/commits/7cae3cdbd136b275d2560617fd546bace6ad9f8f |
|
| https://github.com/andrewbranch |
| Fix some edge cases of semicolon deletion | https://github.com/microsoft/TypeScript/pull/33402/commits/e27bc9646a3f6cec82650b6f7243cd1cbabae6e3 |
| e27bc96 | https://github.com/microsoft/TypeScript/pull/33402/commits/e27bc9646a3f6cec82650b6f7243cd1cbabae6e3 |
|
| https://github.com/andrewbranch |
| Fix semicolon removal before comments | https://github.com/microsoft/TypeScript/pull/33402/commits/ae9a234de0e8fde9557cfdd97c08ed89caac0785 |
| ae9a234 | https://github.com/microsoft/TypeScript/pull/33402/commits/ae9a234de0e8fde9557cfdd97c08ed89caac0785 |
|
| https://github.com/andrewbranch |
| Fix indentation | https://github.com/microsoft/TypeScript/pull/33402/commits/0ac2807216c4d149ca56c71a40bf6b7ba7de96dd |
| 0ac2807 | https://github.com/microsoft/TypeScript/pull/33402/commits/0ac2807216c4d149ca56c71a40bf6b7ba7de96dd |
|
| https://github.com/andrewbranch |
| Test on checker | https://github.com/microsoft/TypeScript/pull/33402/commits/4027433e53e4168bb9b2f1d506479ce6401bef41 |
| 4027433 | https://github.com/microsoft/TypeScript/pull/33402/commits/4027433e53e4168bb9b2f1d506479ce6401bef41 |
|
| https://github.com/andrewbranch |
| Replace semicolon-omitting writer with formatter preference | https://github.com/microsoft/TypeScript/pull/33402/commits/149eaf67eed8aeff434236a770bce6594b45c1d2 |
| 149eaf6 | https://github.com/microsoft/TypeScript/pull/33402/commits/149eaf67eed8aeff434236a770bce6594b45c1d2 |
|
| https://github.com/andrewbranch |
| Fix writing new nodes, update protocol | https://github.com/microsoft/TypeScript/pull/33402/commits/4555bb815b69981bcb8d1da1c0553c5815e30cda |
| 4555bb8 | https://github.com/microsoft/TypeScript/pull/33402/commits/4555bb815b69981bcb8d1da1c0553c5815e30cda |
|
| https://github.com/andrewbranch |
| Rename option | https://github.com/microsoft/TypeScript/pull/33402/commits/ac30127317a2df3d1a28e66fe6cdbb95b068b65e |
| ac30127 | https://github.com/microsoft/TypeScript/pull/33402/commits/ac30127317a2df3d1a28e66fe6cdbb95b068b65e |
|
| https://github.com/andrewbranch |
| Really fix formatting synthetic nodes | https://github.com/microsoft/TypeScript/pull/33402/commits/ca8b8f06386094d395ffcaf9e9d6e1c9a959d37b |
| ca8b8f0 | https://github.com/microsoft/TypeScript/pull/33402/commits/ca8b8f06386094d395ffcaf9e9d6e1c9a959d37b |
|
| https://github.com/andrewbranch |
| Fix refactoring misses | https://github.com/microsoft/TypeScript/pull/33402/commits/9c335909652608ecbe447e4dbd449320eab53f0a |
| 9c33590 | https://github.com/microsoft/TypeScript/pull/33402/commits/9c335909652608ecbe447e4dbd449320eab53f0a |
|
| https://github.com/andrewbranch |
| Merge branch 'master' into feature/semicolon-preference | https://github.com/microsoft/TypeScript/pull/33402/commits/d5d23a2fab73f3cfca47b101afa79515e63db4a2 |
| d5d23a2 | https://github.com/microsoft/TypeScript/pull/33402/commits/d5d23a2fab73f3cfca47b101afa79515e63db4a2 |
|
| https://github.com/andrewbranch |
| Un-update submodules gahhhh | https://github.com/microsoft/TypeScript/pull/33402/commits/5743d761e7c9036852002e95288501ddd8e58433 |
| 5743d76 | https://github.com/microsoft/TypeScript/pull/33402/commits/5743d761e7c9036852002e95288501ddd8e58433 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Sep 12, 2019 | https://github.com/microsoft/TypeScript/pull/33402#issuecomment-531035465 |
| Sheetal Nandi (@sheetalkamat) | https://github.com/sheetalkamat |
| Andrew Casey (@amcasey) | https://github.com/amcasey |
| Matt Bierner (@mjbvz) | https://github.com/mjbvz |
| Mine Starks (@minestarks) | https://github.com/minestarks |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
| https://github.com/amcasey |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| Sep 12, 2019 | https://github.com/microsoft/TypeScript/pull/33402#issuecomment-531036443 |
| Jesse Trinity (@jessetrinity) | https://github.com/jessetrinity |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
| https://github.com/andrewbranch |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
|
Sep 12, 2019
| https://github.com/microsoft/TypeScript/pull/33402#ref-pullrequest-493064995 |
|
[typescript-language-features] Add formatter option for semicolons
microsoft/vscode#80828
| https://github.com/microsoft/vscode/pull/80828 |
| https://github.com/andrewbranch |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Ryan Cavanaugh (RyanCavanaugh) | https://github.com/RyanCavanaugh |
| Orta Therox (orta) | https://github.com/orta |
| Ron Buckton (rbuckton) | https://github.com/rbuckton |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| September 12, 2019 22:54 | https://github.com/microsoft/TypeScript/pull/33402#event-2630784053 |
|
| https://github.com/andrewbranch |
| Update APIs | https://github.com/microsoft/TypeScript/pull/33402/commits/d36155fa3f54ef90603b63a8183a7be4e4de7aad |
| d36155f | https://github.com/microsoft/TypeScript/pull/33402/commits/d36155fa3f54ef90603b63a8183a7be4e4de7aad |
| https://github.com/andrewbranch |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
|
Sep 12, 2019
| https://github.com/microsoft/TypeScript/pull/33402#pullrequestreview-287760705 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/33402/files/d36155fa3f54ef90603b63a8183a7be4e4de7aad |
| src/services/formatting/rules.ts | https://github.com/microsoft/TypeScript/pull/33402/files/d36155fa3f54ef90603b63a8183a7be4e4de7aad#diff-7cb606e938a01498a467ff2d9e4715e413b9ed692137e0852998ef7357d9abae |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
| Sep 12, 2019 | https://github.com/microsoft/TypeScript/pull/33402#discussion_r323993672 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
| https://github.com/orta |
| Orta Therox (orta) | https://github.com/orta |
|
Update Docs on Next Release
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Update%20Docs%20on%20Next%20Release%22 |
| Sep 13, 2019 | https://github.com/microsoft/TypeScript/pull/33402#event-2632503455 |
|
| https://github.com/andrewbranch |
| Update for ESLint | https://github.com/microsoft/TypeScript/pull/33402/commits/047b55fe8e762e490aac71e6f126dd20621bef43 |
| 047b55f | https://github.com/microsoft/TypeScript/pull/33402/commits/047b55fe8e762e490aac71e6f126dd20621bef43 |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
|
Sep 13, 2019
| https://github.com/microsoft/TypeScript/pull/33402#pullrequestreview-288153833 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/33402/files/047b55fe8e762e490aac71e6f126dd20621bef43 |
| .vscode/settings.json | https://github.com/microsoft/TypeScript/pull/33402/files/d36155fa3f54ef90603b63a8183a7be4e4de7aad..047b55fe8e762e490aac71e6f126dd20621bef43#diff-a5de3e5871ffcc383a2294845bd3df25d3eeff6c29ad46e3a396577c413bf357 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
| .vscode/settings.json | https://github.com/microsoft/TypeScript/pull/33402/files/047b55fe8e762e490aac71e6f126dd20621bef43#diff-a5de3e5871ffcc383a2294845bd3df25d3eeff6c29ad46e3a396577c413bf357 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
|
| https://github.com/andrewbranch |
| Revert accidental test change | https://github.com/microsoft/TypeScript/pull/33402/commits/9bd7d54ba93ead64943bdf6cdddd6f847c3d3155 |
| 9bd7d54 | https://github.com/microsoft/TypeScript/pull/33402/commits/9bd7d54ba93ead64943bdf6cdddd6f847c3d3155 |
| https://github.com/andrewbranch |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
|
Sep 13, 2019
| https://github.com/microsoft/TypeScript/pull/33402#pullrequestreview-288158840 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/33402/files/9bd7d54ba93ead64943bdf6cdddd6f847c3d3155 |
| src/services/formatting/formatting.ts | https://github.com/microsoft/TypeScript/pull/33402/files/9bd7d54ba93ead64943bdf6cdddd6f847c3d3155#diff-853328a69fa29e01eda0b7b5e4ef672c45640a0bacae48a031159ea916761834 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
|
| https://github.com/andrewbranch |
| De-kludge deduplication of EOF processing | https://github.com/microsoft/TypeScript/pull/33402/commits/2c1eef235ad853d8a69b476fa10a1bbcb8215e50 |
| 2c1eef2 | https://github.com/microsoft/TypeScript/pull/33402/commits/2c1eef235ad853d8a69b476fa10a1bbcb8215e50 |
| https://github.com/amcasey |
| Andrew Casey (amcasey) | https://github.com/amcasey |
|
Sep 16, 2019
| https://github.com/microsoft/TypeScript/pull/33402#pullrequestreview-288811757 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/33402/files/2c1eef235ad853d8a69b476fa10a1bbcb8215e50 |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
| https://github.com/microsoft/TypeScript/pull/33402#pullrequestreview-288811757 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
| https://github.com/amcasey |
| Andrew Casey (amcasey) | https://github.com/amcasey |
|
Sep 16, 2019
| https://github.com/microsoft/TypeScript/pull/33402#pullrequestreview-288950487 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/33402/files/2c1eef235ad853d8a69b476fa10a1bbcb8215e50 |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| https://github.com/microsoft/TypeScript/pull/33402#pullrequestreview-288950487 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
| src/compiler/core.ts | https://github.com/microsoft/TypeScript/pull/33402/files/2c1eef235ad853d8a69b476fa10a1bbcb8215e50#diff-8eee8edc4cdf82aaa3b0c0ba3c8c74fa80ac6d5214540a460c49fb2ee1031b25 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
| src/compiler/core.ts | https://github.com/microsoft/TypeScript/pull/33402/files/2c1eef235ad853d8a69b476fa10a1bbcb8215e50#diff-8eee8edc4cdf82aaa3b0c0ba3c8c74fa80ac6d5214540a460c49fb2ee1031b25 |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| Sep 16, 2019 | https://github.com/microsoft/TypeScript/pull/33402#discussion_r324926425 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
| Sep 17, 2019 | https://github.com/microsoft/TypeScript/pull/33402#discussion_r324935105 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| Sep 17, 2019 | https://github.com/microsoft/TypeScript/pull/33402#discussion_r324949474 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
| Sep 23, 2019 | https://github.com/microsoft/TypeScript/pull/33402#discussion_r327223051 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
| Andrew Casey (amcasey) | https://github.com/amcasey |
| Sep 24, 2019 | https://github.com/microsoft/TypeScript/pull/33402#discussion_r327747164 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
| src/server/protocol.ts | https://github.com/microsoft/TypeScript/pull/33402/files/2c1eef235ad853d8a69b476fa10a1bbcb8215e50#diff-eb376d3ed604f5f596e7a34bcd6b1f851af61d3c22393ebf1b48da8f9976a32e |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
| src/server/protocol.ts | https://github.com/microsoft/TypeScript/pull/33402/files/2c1eef235ad853d8a69b476fa10a1bbcb8215e50#diff-eb376d3ed604f5f596e7a34bcd6b1f851af61d3c22393ebf1b48da8f9976a32e |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
| https://github.com/andrewbranch |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
|
Sep 20, 2019
| https://github.com/microsoft/TypeScript/pull/33402#ref-issue-496108429 |
|
Await insert break ASI
#33522
| https://github.com/microsoft/TypeScript/issues/33522 |
| https://github.com/andrewbranch |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
| Sep 23, 2019 | https://github.com/microsoft/TypeScript/pull/33402#issuecomment-534185024 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
| September 24, 2019 10:32 | https://github.com/microsoft/TypeScript/pull/33402#commits-pushed-4675779 |
|
| https://github.com/andrewbranch |
| Merge branch 'master' into feature/semicolon-preference | https://github.com/microsoft/TypeScript/pull/33402/commits/46757797f2c4c9c1bca6ce3b5a4a0b4d0c9592ea |
| 4675779 | https://github.com/microsoft/TypeScript/pull/33402/commits/46757797f2c4c9c1bca6ce3b5a4a0b4d0c9592ea |
|
| https://github.com/andrewbranch |
| Omit last element semicolon from single-line object-like types | https://github.com/microsoft/TypeScript/pull/33402/commits/5625cb023743215d4721bf07b2d41f831399977d |
| 5625cb0 | https://github.com/microsoft/TypeScript/pull/33402/commits/5625cb023743215d4721bf07b2d41f831399977d |
| https://github.com/andrewbranch |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
| Sep 25, 2019 | https://github.com/microsoft/TypeScript/pull/33402#issuecomment-534801075 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
|
| https://github.com/andrewbranch |
| Revert "Omit last element semicolon from single-line object-like types" | https://github.com/microsoft/TypeScript/pull/33402/commits/525e32e9348a1998954c97ddd71f391f4a37645a |
| 525e32e | https://github.com/microsoft/TypeScript/pull/33402/commits/525e32e9348a1998954c97ddd71f391f4a37645a |
| 5625cb0 | https://github.com/andrewbranch/TypeScript/commit/5625cb023743215d4721bf07b2d41f831399977d |
| https://github.com/andrewbranch |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
| Sep 25, 2019 | https://github.com/microsoft/TypeScript/pull/33402#issuecomment-535126930 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Sep 25, 2019 | https://github.com/microsoft/TypeScript/pull/33402#event-2663420655 |
|
| https://github.com/andrewbranch |
| Fix straggler test | https://github.com/microsoft/TypeScript/pull/33402/commits/498a320229fb59c1ada80c4e15659926ea1e1936 |
| 498a320 | https://github.com/microsoft/TypeScript/pull/33402/commits/498a320229fb59c1ada80c4e15659926ea1e1936 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
|
Sep 25, 2019
| https://github.com/microsoft/TypeScript/pull/33402#pullrequestreview-293415456 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/33402/files/525e32e9348a1998954c97ddd71f391f4a37645a |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| https://github.com/microsoft/TypeScript/pull/33402#pullrequestreview-293415456 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
| tests/cases/fourslash/formatAddSemicolons1.ts | https://github.com/microsoft/TypeScript/pull/33402/files/525e32e9348a1998954c97ddd71f391f4a37645a#diff-5b8797be580a5c3d3d10c960e463ef4fad7138da05a63701d7df08eb1dd187f2 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
|
| https://github.com/andrewbranch |
| Add test for leading semicolon class members | https://github.com/microsoft/TypeScript/pull/33402/commits/68cf56d35be75913f5eda97018a7bf95d4c811e6 |
| 68cf56d | https://github.com/microsoft/TypeScript/pull/33402/commits/68cf56d35be75913f5eda97018a7bf95d4c811e6 |
| https://github.com/andrewbranch |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
|
Sep 25, 2019
| https://github.com/microsoft/TypeScript/pull/33402#pullrequestreview-293421212 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/33402/files/68cf56d35be75913f5eda97018a7bf95d4c811e6 |
| tests/cases/fourslash/formatAddSemicolons1.ts | https://github.com/microsoft/TypeScript/pull/33402/files/68cf56d35be75913f5eda97018a7bf95d4c811e6#diff-5b8797be580a5c3d3d10c960e463ef4fad7138da05a63701d7df08eb1dd187f2 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
|
Sep 26, 2019
| https://github.com/microsoft/TypeScript/pull/33402#pullrequestreview-293851616 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/33402/files/68cf56d35be75913f5eda97018a7bf95d4c811e6 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| https://github.com/microsoft/TypeScript/pull/33402#pullrequestreview-293851616 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
| src/services/textChanges.ts | https://github.com/microsoft/TypeScript/pull/33402/files/68cf56d35be75913f5eda97018a7bf95d4c811e6#diff-386d93db50a938da0c4af7bb293ac679b5da235cebeeee9adbc040fbf8aa222c |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
| src/services/formatting/rulesMap.ts | https://github.com/microsoft/TypeScript/pull/33402/files/68cf56d35be75913f5eda97018a7bf95d4c811e6#diff-c8a51e4eb824a574fd04737972e6c523d653fec303d342fa0b55fa89bc432ad4 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
| src/services/formatting/rulesMap.ts | https://github.com/microsoft/TypeScript/pull/33402/files/68cf56d35be75913f5eda97018a7bf95d4c811e6#diff-c8a51e4eb824a574fd04737972e6c523d653fec303d342fa0b55fa89bc432ad4 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
| src/services/formatting/formatting.ts | https://github.com/microsoft/TypeScript/pull/33402/files/68cf56d35be75913f5eda97018a7bf95d4c811e6#diff-853328a69fa29e01eda0b7b5e4ef672c45640a0bacae48a031159ea916761834 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
| src/services/formatting/formatting.ts | https://github.com/microsoft/TypeScript/pull/33402/files/68cf56d35be75913f5eda97018a7bf95d4c811e6#diff-853328a69fa29e01eda0b7b5e4ef672c45640a0bacae48a031159ea916761834 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
| src/services/formatting/rules.ts | https://github.com/microsoft/TypeScript/pull/33402/files/68cf56d35be75913f5eda97018a7bf95d4c811e6#diff-7cb606e938a01498a467ff2d9e4715e413b9ed692137e0852998ef7357d9abae |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
| src/services/formatting/rules.ts | https://github.com/microsoft/TypeScript/pull/33402/files/68cf56d35be75913f5eda97018a7bf95d4c811e6#diff-7cb606e938a01498a467ff2d9e4715e413b9ed692137e0852998ef7357d9abae |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
| September 26, 2019 11:47 | https://github.com/microsoft/TypeScript/pull/33402#commits-pushed-623b4b3 |
|
| https://github.com/andrewbranch |
| Rename a lot of stuff for clarity | https://github.com/microsoft/TypeScript/pull/33402/commits/623b4b30f1c2b8c77eaeec8b33c1fd5536515291 |
| 623b4b3 | https://github.com/microsoft/TypeScript/pull/33402/commits/623b4b30f1c2b8c77eaeec8b33c1fd5536515291 |
|
| https://github.com/andrewbranch |
| Invert some boolean logic | https://github.com/microsoft/TypeScript/pull/33402/commits/61c3e61f3e56e2f570b2b6b478913c3878aaa17a |
| 61c3e61 | https://github.com/microsoft/TypeScript/pull/33402/commits/61c3e61f3e56e2f570b2b6b478913c3878aaa17a |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
|
Sep 26, 2019
| https://github.com/microsoft/TypeScript/pull/33402#pullrequestreview-293979852 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/33402/files/61c3e61f3e56e2f570b2b6b478913c3878aaa17a |
| https://github.com/andrewbranch |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
| 7d9b22e | https://github.com/microsoft/TypeScript/commit/7d9b22eea011a260a51fd91f7c97f89b7737244a |
| Sep 26, 2019 | https://github.com/microsoft/TypeScript/pull/33402#event-2666589482 |
| https://github.com/andrewbranch |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
| September 26, 2019 20:23 | https://github.com/microsoft/TypeScript/pull/33402#event-2666589710 |
| https://github.com/thermarthae |
| thermarthae | https://github.com/thermarthae |
| Nov 9, 2019 | https://github.com/microsoft/TypeScript/pull/33402#issuecomment-552109201 |
| Andrew Branch (@andrewbranch) | https://github.com/andrewbranch |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
| https://github.com/andrewbranch |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
|
Nov 11, 2019
| https://github.com/microsoft/TypeScript/pull/33402#ref-issue-521162159 |
|
Drop emit of last semicolon in single-line object literal types
#35042
| https://github.com/microsoft/TypeScript/issues/35042 |
| https://github.com/andrewbranch |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
| Nov 11, 2019 | https://github.com/microsoft/TypeScript/pull/33402#issuecomment-552595336 |
| thermarthae | https://github.com/thermarthae |
| #35042 | https://github.com/microsoft/TypeScript/issues/35042 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Oct 21, 2025 | https://github.com/microsoft/TypeScript/pull/33402#event-20416777141 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F33402 |
|
| https://github.com/weswigham |
|
Wesley Wigham (weswigham)
| https://github.com/weswigham |
|
| https://github.com/microsoft/TypeScript/pull/33402/files/9bd7d54ba93ead64943bdf6cdddd6f847c3d3155 |
|
| https://github.com/sandersn |
|
Nathan Shively-Sanders (sandersn)
| https://github.com/sandersn |
|
| https://github.com/microsoft/TypeScript/pull/33402/files/61c3e61f3e56e2f570b2b6b478913c3878aaa17a |
|
| https://github.com/sheetalkamat |
|
Sheetal Nandi (sheetalkamat)
| https://github.com/sheetalkamat |
|
| https://github.com/DanielRosenwasser |
|
Daniel Rosenwasser (DanielRosenwasser)
| https://github.com/DanielRosenwasser |
|
| https://github.com/orta |
|
Orta Therox (orta)
| https://github.com/orta |
|
| https://github.com/rbuckton |
|
Ron Buckton (rbuckton)
| https://github.com/rbuckton |
|
| https://github.com/RyanCavanaugh |
|
Ryan Cavanaugh (RyanCavanaugh)
| https://github.com/RyanCavanaugh |
|
| https://github.com/amcasey |
|
Andrew Casey (amcasey)
| https://github.com/amcasey |
|
| https://github.com/microsoft/TypeScript/pull/33402/files/2c1eef235ad853d8a69b476fa10a1bbcb8215e50 |
|
| https://github.com/jessetrinity |
|
Jesse Trinity (jessetrinity)
| https://github.com/jessetrinity |
|
| https://github.com/microsoft/TypeScript/pull/33402/files/2c1eef235ad853d8a69b476fa10a1bbcb8215e50 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
|
| https://github.com/sandersn |
|
Nathan Shively-Sanders (sandersn)
| https://github.com/sandersn |
|
Update Docs on Next Release
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Update%20Docs%20on%20Next%20Release%22 |
|
Improve semicolon detection experience for new files
| https://github.com/microsoft/TypeScript/issues/32831 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/33402 |
|
| https://github.com/andrewbranch |
|
| https://github.com/typescript-bot |
|
| https://github.com/amcasey |
|
| https://github.com/thermarthae |
|
| https://github.com/sandersn |
|
| https://github.com/weswigham |
|
| https://github.com/jessetrinity |
|
| https://github.com/orta |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |