René's URL Explorer Experiment


Title: Only skip following inference steps after union member matching if an inference is actually made by weswigham · Pull Request #33154 · microsoft/TypeScript · GitHub

Open Graph Title: Only skip following inference steps after union member matching if an inference is actually made by weswigham · Pull Request #33154 · microsoft/TypeScript

X Title: Only skip following inference steps after union member matching if an inference is actually made by weswigham · Pull Request #33154 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Only skip following inference steps after union member matching if an inference is actually made by weswigham · Pull Request #33154 · microsoft/TypeScript

Open Graph Description: Fixes #33131 I'm not sure if you'd like to reconsider more here, but, generally speaking, this seems like a fairly minimal tweak to the logic we added to better match union/intersection typ...

X Description: Fixes #33131 I'm not sure if you'd like to reconsider more here, but, generally speaking, this seems like a fairly minimal tweak to the logic we added to better match union/intersec...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/33154

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:461dd1dd-7195-145b-bea2-7c609dd1141b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBC1E:2A7C1C:169C4C:1DF7F8:6B018672
html-safe-nonce1390d06d1f1ced577eb21729b13113753274461993c1301702802c0ce681cf0c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzFFOjJBN0MxQzoxNjlDNEM6MURGN0Y4OjZCMDE4NjcyIiwidmlzaXRvcl9pZCI6IjY3ODE3NjE0MjM4MzI4NzY2NTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2be445cfe05ff8e879d78bf1658914d0d074b5415e77cc5f9e102a6f5d819f05
hovercard-subject-tagpull_request:312527315
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/33154/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a7fb5a71174160a6a53289bc9bb61998a6e05b993911d7619211a2bb98a13351/microsoft/TypeScript/pull/33154
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a7fb5a71174160a6a53289bc9bb61998a6e05b993911d7619211a2bb98a13351/microsoft/TypeScript/pull/33154
og:image:altFixes #33131 I'm not sure if you'd like to reconsider more here, but, generally speaking, this seems like a fairly minimal tweak to the logic we added to better match union/intersection typ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameweswigham
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/33154#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F33154
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F33154
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/33154
Reloadhttps://github.com/microsoft/TypeScript/pull/33154
Reloadhttps://github.com/microsoft/TypeScript/pull/33154
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
weswigham:observable-subscription-inferencehttps://github.com/weswigham/TypeScript/tree/observable-subscription-inference
Conversationhttps://github.com/microsoft/TypeScript/pull/33154
Commits1 (1)https://github.com/microsoft/TypeScript/pull/33154/commits
Checkshttps://github.com/microsoft/TypeScript/pull/33154/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/33154/files
Only skip following inference steps after union member matching if an inference is actually madehttps://github.com/microsoft/TypeScript/pull/33154#top
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
weswigham:observable-subscription-inferencehttps://github.com/weswigham/TypeScript/tree/observable-subscription-inference
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Aug 29, 2019https://github.com/microsoft/TypeScript/pull/33154#issue-487216174
#33131https://github.com/microsoft/TypeScript/issues/33131
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33154
https://github.com/weswigham
Only skip following inference steps after union member matching if an…https://github.com/microsoft/TypeScript/pull/33154/commits/737d1e7b643067ca8e204b245e524f7bef453f5a
737d1e7https://github.com/microsoft/TypeScript/pull/33154/commits/737d1e7b643067ca8e204b245e524f7bef453f5a
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
August 29, 2019 23:19https://github.com/microsoft/TypeScript/pull/33154#event-2595586400
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Aug 29, 2019https://github.com/microsoft/TypeScript/pull/33154#issuecomment-526397459
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33154
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 29, 2019https://github.com/microsoft/TypeScript/pull/33154#issuecomment-526397486
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33154
Wesley Wigham (@weswigham)https://github.com/weswigham
737d1e7https://github.com/microsoft/TypeScript/commit/737d1e7b643067ca8e204b245e524f7bef453f5a
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=42163
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33154
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 29, 2019https://github.com/microsoft/TypeScript/pull/33154#issuecomment-526397487
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33154
Wesley Wigham (@weswigham)https://github.com/weswigham
737d1e7https://github.com/microsoft/TypeScript/commit/737d1e7b643067ca8e204b245e524f7bef453f5a
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=42164
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33154
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 29, 2019https://github.com/microsoft/TypeScript/pull/33154#issuecomment-526397488
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33154
Wesley Wigham (@weswigham)https://github.com/weswigham
737d1e7https://github.com/microsoft/TypeScript/commit/737d1e7b643067ca8e204b245e524f7bef453f5a
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=42165
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33154
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 29, 2019 https://github.com/microsoft/TypeScript/pull/33154#ref-pullrequest-487223320
🤖 User test baselines have changed for observable-subscription-inference weswigham/TypeScript#37 https://github.com/weswigham/TypeScript/pull/37
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 29, 2019https://github.com/microsoft/TypeScript/pull/33154#issuecomment-526402334
PR with the baseline diff from masterhttps://github.com/weswigham/TypeScript/pull/37
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33154
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Aug 30, 2019https://github.com/microsoft/TypeScript/pull/33154#issuecomment-526404005
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33154
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Aug 30, 2019https://github.com/microsoft/TypeScript/pull/33154#issuecomment-526404260
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33154
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Aug 30, 2019 https://github.com/microsoft/TypeScript/pull/33154#ref-issue-486638110
Update RxJS in user test suite #33125 https://github.com/microsoft/TypeScript/issues/33125
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Aug 30, 2019https://github.com/microsoft/TypeScript/pull/33154#issuecomment-526406238
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Ben Lesh (@benlesh)https://github.com/benlesh
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33154
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 30, 2019https://github.com/microsoft/TypeScript/pull/33154#issuecomment-526406258
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33154
Wesley Wigham (@weswigham)https://github.com/weswigham
737d1e7https://github.com/microsoft/TypeScript/commit/737d1e7b643067ca8e204b245e524f7bef453f5a
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=42167
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33154
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 30, 2019https://github.com/microsoft/TypeScript/pull/33154#issuecomment-526408993
Wesley Wigham (@weswigham)https://github.com/weswigham
an installable tgzhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/42167/artifacts?artifactName=tgz&fileId=84FA9BD7390E9AE04ED6006D9E265FBCF309C643377CBBC8CB1CE445229AAB2B02&fileName=/typescript-3.7.0-insiders.20190830.tgz
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33154
https://github.com/fatcerberus
Bruce Pascoe (fatcerberus)https://github.com/fatcerberus
Aug 30, 2019 https://github.com/microsoft/TypeScript/pull/33154#ref-issue-486830242
RxJS type inference fails in 3.6.2 #33131 https://github.com/microsoft/TypeScript/issues/33131
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Sep 4, 2019 https://github.com/microsoft/TypeScript/pull/33154#ref-issue-488874646
Change in inferred type in 3.6 for function call using generic union instantiated at string literal #33227 https://github.com/microsoft/TypeScript/issues/33227
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
TypeScript 3.6.3https://github.com/microsoft/TypeScript/milestone/103
Sep 4, 2019https://github.com/microsoft/TypeScript/pull/33154#event-2607897067
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Sep 4, 2019https://github.com/microsoft/TypeScript/pull/33154#issuecomment-528129992
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33154
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Sep 4, 2019https://github.com/microsoft/TypeScript/pull/33154#event-2608787876
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/33154#event-20416766193
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Wesley Wigham (weswigham)https://github.com/weswigham
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/33154#event-20416766742
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F33154
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) https://github.com/DanielRosenwasser
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg) https://github.com/ahejlsberg
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33154
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg) https://github.com/ahejlsberg
TypeScript 3.6.3 https://github.com/microsoft/TypeScript/milestone/103
RxJS type inference fails in 3.6.2 https://github.com/microsoft/TypeScript/issues/33131
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/33154
https://github.com/weswigham
https://github.com/typescript-bot
https://github.com/sandersn
https://github.com/ahejlsberg
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.