| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e754cdec-81a8-d5e3-9632-4043d4490d3d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CC86:1050BD:B09B6D:EA1D7C:6B01C0CC |
| html-safe-nonce | 522c3268ac7c812c6e9958c8c916a204a1bc45a549b85b533f892547fa33cf8d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzg2OjEwNTBCRDpCMDlCNkQ6RUExRDdDOjZCMDFDMENDIiwidmlzaXRvcl9pZCI6IjkxOTI0MTY0NzQxODA5OTMyMjgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | dbfa1c6fea660b44f82e367885dded4c14220c334a800982f3d0ae28112d5474 |
| hovercard-subject-tag | pull_request:308228030 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/32944/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f1304cc5c6ab296c4c923dd08a80013458e41a632281dc764a6e195dfcb476db/microsoft/TypeScript/pull/32944 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f1304cc5c6ab296c4c923dd08a80013458e41a632281dc764a6e195dfcb476db/microsoft/TypeScript/pull/32944 |
| og:image:alt | In JS, constructor functions are now classes. That means:
They use the normal class type machinery for creation and caching.
this types work.
Generics work.
And it only adds about 40 lines of cod... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sandersn |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/32944#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F32944 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F32944 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/32944 |
| Reload | https://github.com/microsoft/TypeScript/pull/32944 |
| Reload | https://github.com/microsoft/TypeScript/pull/32944 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests312 (312) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| master | https://github.com/microsoft/TypeScript/tree/master |
| constructor-functions-as-classes | https://github.com/microsoft/TypeScript/tree/constructor-functions-as-classes |
| Conversation | https://github.com/microsoft/TypeScript/pull/32944 |
| Commits16 (16) | https://github.com/microsoft/TypeScript/pull/32944/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/32944/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/32944/files |
| Constructor functions as classes | https://github.com/microsoft/TypeScript/pull/32944#top |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| master | https://github.com/microsoft/TypeScript/tree/master |
| constructor-functions-as-classes | https://github.com/microsoft/TypeScript/tree/constructor-functions-as-classes |
|
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Aug 16, 2019 | https://github.com/microsoft/TypeScript/pull/32944#issue-481797328 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/32944 |
| #26833 | https://github.com/microsoft/TypeScript/issues/26833 |
| #23007 | https://github.com/microsoft/TypeScript/issues/23007 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/32944 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| August 13, 2019 11:11 | https://github.com/microsoft/TypeScript/pull/32944#commits-pushed-44c3419 |
|
| https://github.com/sandersn |
| Initial implementation | https://github.com/microsoft/TypeScript/pull/32944/commits/44c34194b1b66d62f0df6f12b013159213d81e72 |
| 44c3419 | https://github.com/microsoft/TypeScript/pull/32944/commits/44c34194b1b66d62f0df6f12b013159213d81e72 |
|
| https://github.com/sandersn |
| Append constructor function construct sigs | https://github.com/microsoft/TypeScript/pull/32944/commits/49be412619d2ca1a72c98cbace16713025a5970d |
| 49be412 | https://github.com/microsoft/TypeScript/pull/32944/commits/49be412619d2ca1a72c98cbace16713025a5970d |
|
| https://github.com/sandersn |
| Grab bag of improvements. | https://github.com/microsoft/TypeScript/pull/32944/commits/38aeafdf9b42a631074f6021e273adef117a110d |
| 38aeafd | https://github.com/microsoft/TypeScript/pull/32944/commits/38aeafdf9b42a631074f6021e273adef117a110d |
|
| https://github.com/sandersn |
| Merge branch 'master' into constructor-functions-as-classes | https://github.com/microsoft/TypeScript/pull/32944/commits/3df0afcfa3c1f11d7705756d6df89d8ccc3b4da0 |
| 3df0afc | https://github.com/microsoft/TypeScript/pull/32944/commits/3df0afcfa3c1f11d7705756d6df89d8ccc3b4da0 |
|
| https://github.com/sandersn |
| Prototype assignments work now | https://github.com/microsoft/TypeScript/pull/32944/commits/0a27ec671cc85fba0298627f42cad3dfb16b3614 |
| 0a27ec6 | https://github.com/microsoft/TypeScript/pull/32944/commits/0a27ec671cc85fba0298627f42cad3dfb16b3614 |
|
| https://github.com/sandersn |
| Mark prototype-property assignments as Class | https://github.com/microsoft/TypeScript/pull/32944/commits/5e1db764fc39b70eaa8e458e2c54dc163ee9cac8 |
| 5e1db76 | https://github.com/microsoft/TypeScript/pull/32944/commits/5e1db764fc39b70eaa8e458e2c54dc163ee9cac8 |
|
| https://github.com/sandersn |
| Simplify getJSClassType, remove calls to its guts | https://github.com/microsoft/TypeScript/pull/32944/commits/6c499a0d0b3f46081fc5631a2728ef9fe11c5edc |
| 6c499a0 | https://github.com/microsoft/TypeScript/pull/32944/commits/6c499a0d0b3f46081fc5631a2728ef9fe11c5edc |
|
| https://github.com/sandersn |
| isJSDocConstructor doesn't need to check prototype anymore | https://github.com/microsoft/TypeScript/pull/32944/commits/3277da0546260bfeafa76423358f06519ed9d86d |
| 3277da0 | https://github.com/microsoft/TypeScript/pull/32944/commits/3277da0546260bfeafa76423358f06519ed9d86d |
|
| https://github.com/sandersn |
| outer type parameter lookup follow prototype assignment | https://github.com/microsoft/TypeScript/pull/32944/commits/5a09bbedae33aed15f5388dcf434caec77dbe6fc |
| 5a09bbe | https://github.com/microsoft/TypeScript/pull/32944/commits/5a09bbedae33aed15f5388dcf434caec77dbe6fc |
|
| https://github.com/sandersn |
| this-type and -expression support in ctor funcs | https://github.com/microsoft/TypeScript/pull/32944/commits/dc4fb65a57feaca563c4273d47fc50e9e561f63f |
| dc4fb65 | https://github.com/microsoft/TypeScript/pull/32944/commits/dc4fb65a57feaca563c4273d47fc50e9e561f63f |
|
| https://github.com/sandersn |
| Fix remaining tests | https://github.com/microsoft/TypeScript/pull/32944/commits/cd1b183a4ccd027636bdf32948b86580f2c56354 |
| cd1b183 | https://github.com/microsoft/TypeScript/pull/32944/commits/cd1b183a4ccd027636bdf32948b86580f2c56354 |
|
| https://github.com/sandersn |
| Fix minor lint | https://github.com/microsoft/TypeScript/pull/32944/commits/537bd1bedc9f32e3904e60c77c36a0abf7ac537e |
| 537bd1b | https://github.com/microsoft/TypeScript/pull/32944/commits/537bd1bedc9f32e3904e60c77c36a0abf7ac537e |
|
| https://github.com/sandersn |
| Merge branch 'master' into constructor-functions-as-classes | https://github.com/microsoft/TypeScript/pull/32944/commits/d99eb1675a9c91fa5dd14eb754a0cdde566c3769 |
| d99eb16 | https://github.com/microsoft/TypeScript/pull/32944/commits/d99eb1675a9c91fa5dd14eb754a0cdde566c3769 |
|
| https://github.com/sandersn |
| Delete now-unused code | https://github.com/microsoft/TypeScript/pull/32944/commits/e2f8545786112f185e6905259b0148e284ff6c48 |
| e2f8545 | https://github.com/microsoft/TypeScript/pull/32944/commits/e2f8545786112f185e6905259b0148e284ff6c48 |
|
| https://github.com/sandersn |
| Merge branch 'master' into constructor-functions-as-classes | https://github.com/microsoft/TypeScript/pull/32944/commits/b2e72cfe442e0632d42ee310c97e17a23cec6b4a |
| b2e72cf | https://github.com/microsoft/TypeScript/pull/32944/commits/b2e72cfe442e0632d42ee310c97e17a23cec6b4a |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
|
Aug 16, 2019
| https://github.com/microsoft/TypeScript/pull/32944#pullrequestreview-276183187 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| https://github.com/microsoft/TypeScript/pull/32944#pullrequestreview-276183187 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/32944 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Aug 16, 2019 | https://github.com/microsoft/TypeScript/pull/32944#discussion_r314900586 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/32944 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Aug 16, 2019 | https://github.com/microsoft/TypeScript/pull/32944#discussion_r314901105 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/32944 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Aug 16, 2019 | https://github.com/microsoft/TypeScript/pull/32944#discussion_r314901514 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| hilarious tweet | https://twitter.com/sanders_n/status/1162131784009523202 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/32944 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Aug 16, 2019 | https://github.com/microsoft/TypeScript/pull/32944#discussion_r314901647 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/32944 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Aug 16, 2019 | https://github.com/microsoft/TypeScript/pull/32944#discussion_r314901977 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/32944 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Aug 16, 2019 | https://github.com/microsoft/TypeScript/pull/32944#discussion_r314902532 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/32944 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Aug 16, 2019 | https://github.com/microsoft/TypeScript/pull/32944#discussion_r314903037 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/32944 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Aug 16, 2019 | https://github.com/microsoft/TypeScript/pull/32944#discussion_r314903348 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/32944 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Aug 16, 2019 | https://github.com/microsoft/TypeScript/pull/32944#discussion_r314903644 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/32944 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Pranav Senthilnathan (PranavSenthilnathan) | https://github.com/PranavSenthilnathan |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
| Orta Therox (orta) | https://github.com/orta |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| August 16, 2019 22:01 | https://github.com/microsoft/TypeScript/pull/32944#event-2563523343 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Aug 16, 2019 | https://github.com/microsoft/TypeScript/pull/32944#issuecomment-522164991 |
| Andrew Branch (@andrewbranch) | https://github.com/andrewbranch |
| Orta Therox (@orta) | https://github.com/orta |
| Pranav Senthilnathan (@PranavSenthilnathan) | https://github.com/PranavSenthilnathan |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/32944 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Aug 16, 2019 | https://github.com/microsoft/TypeScript/pull/32944#issuecomment-522167895 |
| TypeScript Bot (@typescript-bot) | https://github.com/typescript-bot |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/32944 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Aug 16, 2019 | https://github.com/microsoft/TypeScript/pull/32944#issuecomment-522167898 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/32944 |
| Nathan Shively-Sanders (@sandersn) | https://github.com/sandersn |
| b2e72cf | https://github.com/microsoft/TypeScript/commit/b2e72cfe442e0632d42ee310c97e17a23cec6b4a |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=40645 |
| The results are in! | https://github.com/microsoft/TypeScript/pull/32944#issuecomment-522173249 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/32944 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Aug 16, 2019 | https://github.com/microsoft/TypeScript/pull/32944#issuecomment-522173249 |
| Nathan Shively-Sanders (@sandersn) | https://github.com/sandersn |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/32944 |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
|
Aug 16, 2019
| https://github.com/microsoft/TypeScript/pull/32944#pullrequestreview-276199859 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a |
| src/compiler/binder.ts | https://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a#diff-9ad14a2e2e66533cd0c3f02ecf01f7e6bc9d60cdf2e125df2a14ce0713222898 |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Aug 16, 2019 | https://github.com/microsoft/TypeScript/pull/32944#discussion_r314914564 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/32944 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Aug 16, 2019 | https://github.com/microsoft/TypeScript/pull/32944#discussion_r314919358 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/32944 |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Aug 17, 2019 | https://github.com/microsoft/TypeScript/pull/32944#discussion_r314923253 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/32944 |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
|
Aug 16, 2019
| https://github.com/microsoft/TypeScript/pull/32944#pullrequestreview-276199899 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a |
| src/compiler/binder.ts | https://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a#diff-9ad14a2e2e66533cd0c3f02ecf01f7e6bc9d60cdf2e125df2a14ce0713222898 |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Aug 16, 2019 | https://github.com/microsoft/TypeScript/pull/32944#discussion_r314914605 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/32944 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Aug 19, 2019 | https://github.com/microsoft/TypeScript/pull/32944#discussion_r315381399 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| JS: Object.defineProperty "undefined namespaces" don't merge cross-file #32979 | https://github.com/microsoft/TypeScript/issues/32979 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/32944 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
|
Aug 16, 2019
| https://github.com/microsoft/TypeScript/pull/32944#pullrequestreview-276200051 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a |
| src/compiler/binder.ts | https://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a#diff-9ad14a2e2e66533cd0c3f02ecf01f7e6bc9d60cdf2e125df2a14ce0713222898 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Aug 16, 2019 | https://github.com/microsoft/TypeScript/pull/32944#discussion_r314914753 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/32944 |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
|
Aug 16, 2019
| https://github.com/microsoft/TypeScript/pull/32944#pullrequestreview-276202449 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Aug 16, 2019 | https://github.com/microsoft/TypeScript/pull/32944#discussion_r314916712 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/32944 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Aug 19, 2019 | https://github.com/microsoft/TypeScript/pull/32944#discussion_r315414225 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/32944 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
|
Aug 19, 2019
| https://github.com/microsoft/TypeScript/pull/32944#ref-issue-482493619 |
|
JS: Object.defineProperty "undefined namespaces" don't merge cross-file
#32979
| https://github.com/microsoft/TypeScript/issues/32979 |
|
| https://github.com/sandersn |
| Add class flag to nested class declarations | https://github.com/microsoft/TypeScript/pull/32944/commits/76fc3966a41156670563f6b5918286b8c7ed1da3 |
| 76fc396 | https://github.com/microsoft/TypeScript/pull/32944/commits/76fc3966a41156670563f6b5918286b8c7ed1da3 |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
|
Aug 19, 2019
| https://github.com/microsoft/TypeScript/pull/32944#pullrequestreview-276795088 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/32944/files/76fc3966a41156670563f6b5918286b8c7ed1da3 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| 6ca9d04 | https://github.com/microsoft/TypeScript/commit/6ca9d04b60fd3861ed595e968e266f5ef19b29f2 |
| Aug 19, 2019 | https://github.com/microsoft/TypeScript/pull/32944#event-2567694544 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| August 19, 2019 21:13 | https://github.com/microsoft/TypeScript/pull/32944#event-2567696280 |
| Tim Suchanek (timsuchanek) | https://github.com/timsuchanek |
|
Sep 11, 2019
| https://github.com/microsoft/TypeScript/pull/32944#ref-commit-cdc572a |
|
| https://github.com/sandersn |
|
| https://github.com/timsuchanek |
| Constructor functions as classes ( | https://github.com/timsuchanek/TypeScript/commit/cdc572a97203f2443cb7cc0b4c751a6cda15809a |
| microsoft#32944 | https://github.com/microsoft/TypeScript/pull/32944 |
| ) | https://github.com/timsuchanek/TypeScript/commit/cdc572a97203f2443cb7cc0b4c751a6cda15809a |
| cdc572a | https://github.com/timsuchanek/TypeScript/commit/cdc572a97203f2443cb7cc0b4c751a6cda15809a |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Oct 21, 2025 | https://github.com/microsoft/TypeScript/pull/32944#event-20416755104 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Oct 21, 2025 | https://github.com/microsoft/TypeScript/pull/32944#event-20416755758 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F32944 |
|
| https://github.com/weswigham |
|
Wesley Wigham (weswigham)
| https://github.com/weswigham |
|
| https://github.com/microsoft/TypeScript/pull/32944/files/76fc3966a41156670563f6b5918286b8c7ed1da3 |
|
| https://github.com/andrewbranch |
|
Andrew Branch (andrewbranch)
| https://github.com/andrewbranch |
|
| https://github.com/orta |
|
Orta Therox (orta)
| https://github.com/orta |
|
| https://github.com/PranavSenthilnathan |
|
Pranav Senthilnathan (PranavSenthilnathan)
| https://github.com/PranavSenthilnathan |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/32944 |
|
| https://github.com/sandersn |
|
Nathan Shively-Sanders (sandersn)
| https://github.com/sandersn |
|
getApplicableRefactors on file with recursive types freezes TSServer
| https://github.com/microsoft/TypeScript/issues/26833 |
|
In JS, function declarations should allow subsequent prototype assignment
| https://github.com/microsoft/TypeScript/issues/23007 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/32944 |
|
| https://github.com/sandersn |
|
| https://github.com/typescript-bot |
|
| https://github.com/weswigham |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |