René's URL Explorer Experiment


Title: Constructor functions as classes by sandersn · Pull Request #32944 · microsoft/TypeScript · GitHub

Open Graph Title: Constructor functions as classes by sandersn · Pull Request #32944 · microsoft/TypeScript

X Title: Constructor functions as classes by sandersn · Pull Request #32944 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Constructor functions as classes by sandersn · Pull Request #32944 · microsoft/TypeScript

Open Graph Description: In JS, constructor functions are now classes. That means: They use the normal class type machinery for creation and caching. this types work. Generics work. And it only adds about 40 lines of cod...

X Description: In JS, constructor functions are now classes. That means: They use the normal class type machinery for creation and caching. this types work. Generics work. And it only adds about 40 lines of cod...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/32944

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e754cdec-81a8-d5e3-9632-4043d4490d3d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCC86:1050BD:B09B6D:EA1D7C:6B01C0CC
html-safe-nonce522c3268ac7c812c6e9958c8c916a204a1bc45a549b85b533f892547fa33cf8d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzg2OjEwNTBCRDpCMDlCNkQ6RUExRDdDOjZCMDFDMENDIiwidmlzaXRvcl9pZCI6IjkxOTI0MTY0NzQxODA5OTMyMjgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacdbfa1c6fea660b44f82e367885dded4c14220c334a800982f3d0ae28112d5474
hovercard-subject-tagpull_request:308228030
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/32944/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f1304cc5c6ab296c4c923dd08a80013458e41a632281dc764a6e195dfcb476db/microsoft/TypeScript/pull/32944
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f1304cc5c6ab296c4c923dd08a80013458e41a632281dc764a6e195dfcb476db/microsoft/TypeScript/pull/32944
og:image:altIn JS, constructor functions are now classes. That means: They use the normal class type machinery for creation and caching. this types work. Generics work. And it only adds about 40 lines of cod...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesandersn
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/32944#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F32944
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F32944
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/32944
Reloadhttps://github.com/microsoft/TypeScript/pull/32944
Reloadhttps://github.com/microsoft/TypeScript/pull/32944
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
constructor-functions-as-classeshttps://github.com/microsoft/TypeScript/tree/constructor-functions-as-classes
Conversationhttps://github.com/microsoft/TypeScript/pull/32944
Commits16 (16)https://github.com/microsoft/TypeScript/pull/32944/commits
Checkshttps://github.com/microsoft/TypeScript/pull/32944/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/32944/files
Constructor functions as classeshttps://github.com/microsoft/TypeScript/pull/32944#top
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
constructor-functions-as-classeshttps://github.com/microsoft/TypeScript/tree/constructor-functions-as-classes
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 16, 2019https://github.com/microsoft/TypeScript/pull/32944#issue-481797328
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32944
#26833https://github.com/microsoft/TypeScript/issues/26833
#23007https://github.com/microsoft/TypeScript/issues/23007
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32944
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
August 13, 2019 11:11https://github.com/microsoft/TypeScript/pull/32944#commits-pushed-44c3419
https://github.com/sandersn
Initial implementationhttps://github.com/microsoft/TypeScript/pull/32944/commits/44c34194b1b66d62f0df6f12b013159213d81e72
44c3419https://github.com/microsoft/TypeScript/pull/32944/commits/44c34194b1b66d62f0df6f12b013159213d81e72
https://github.com/sandersn
Append constructor function construct sigshttps://github.com/microsoft/TypeScript/pull/32944/commits/49be412619d2ca1a72c98cbace16713025a5970d
49be412https://github.com/microsoft/TypeScript/pull/32944/commits/49be412619d2ca1a72c98cbace16713025a5970d
https://github.com/sandersn
Grab bag of improvements.https://github.com/microsoft/TypeScript/pull/32944/commits/38aeafdf9b42a631074f6021e273adef117a110d
38aeafdhttps://github.com/microsoft/TypeScript/pull/32944/commits/38aeafdf9b42a631074f6021e273adef117a110d
https://github.com/sandersn
Merge branch 'master' into constructor-functions-as-classeshttps://github.com/microsoft/TypeScript/pull/32944/commits/3df0afcfa3c1f11d7705756d6df89d8ccc3b4da0
3df0afchttps://github.com/microsoft/TypeScript/pull/32944/commits/3df0afcfa3c1f11d7705756d6df89d8ccc3b4da0
https://github.com/sandersn
Prototype assignments work nowhttps://github.com/microsoft/TypeScript/pull/32944/commits/0a27ec671cc85fba0298627f42cad3dfb16b3614
0a27ec6https://github.com/microsoft/TypeScript/pull/32944/commits/0a27ec671cc85fba0298627f42cad3dfb16b3614
https://github.com/sandersn
Mark prototype-property assignments as Classhttps://github.com/microsoft/TypeScript/pull/32944/commits/5e1db764fc39b70eaa8e458e2c54dc163ee9cac8
5e1db76https://github.com/microsoft/TypeScript/pull/32944/commits/5e1db764fc39b70eaa8e458e2c54dc163ee9cac8
https://github.com/sandersn
Simplify getJSClassType, remove calls to its gutshttps://github.com/microsoft/TypeScript/pull/32944/commits/6c499a0d0b3f46081fc5631a2728ef9fe11c5edc
6c499a0https://github.com/microsoft/TypeScript/pull/32944/commits/6c499a0d0b3f46081fc5631a2728ef9fe11c5edc
https://github.com/sandersn
isJSDocConstructor doesn't need to check prototype anymorehttps://github.com/microsoft/TypeScript/pull/32944/commits/3277da0546260bfeafa76423358f06519ed9d86d
3277da0https://github.com/microsoft/TypeScript/pull/32944/commits/3277da0546260bfeafa76423358f06519ed9d86d
https://github.com/sandersn
outer type parameter lookup follow prototype assignmenthttps://github.com/microsoft/TypeScript/pull/32944/commits/5a09bbedae33aed15f5388dcf434caec77dbe6fc
5a09bbehttps://github.com/microsoft/TypeScript/pull/32944/commits/5a09bbedae33aed15f5388dcf434caec77dbe6fc
https://github.com/sandersn
this-type and -expression support in ctor funcshttps://github.com/microsoft/TypeScript/pull/32944/commits/dc4fb65a57feaca563c4273d47fc50e9e561f63f
dc4fb65https://github.com/microsoft/TypeScript/pull/32944/commits/dc4fb65a57feaca563c4273d47fc50e9e561f63f
https://github.com/sandersn
Fix remaining testshttps://github.com/microsoft/TypeScript/pull/32944/commits/cd1b183a4ccd027636bdf32948b86580f2c56354
cd1b183https://github.com/microsoft/TypeScript/pull/32944/commits/cd1b183a4ccd027636bdf32948b86580f2c56354
https://github.com/sandersn
Fix minor linthttps://github.com/microsoft/TypeScript/pull/32944/commits/537bd1bedc9f32e3904e60c77c36a0abf7ac537e
537bd1bhttps://github.com/microsoft/TypeScript/pull/32944/commits/537bd1bedc9f32e3904e60c77c36a0abf7ac537e
https://github.com/sandersn
Merge branch 'master' into constructor-functions-as-classeshttps://github.com/microsoft/TypeScript/pull/32944/commits/d99eb1675a9c91fa5dd14eb754a0cdde566c3769
d99eb16https://github.com/microsoft/TypeScript/pull/32944/commits/d99eb1675a9c91fa5dd14eb754a0cdde566c3769
https://github.com/sandersn
Delete now-unused codehttps://github.com/microsoft/TypeScript/pull/32944/commits/e2f8545786112f185e6905259b0148e284ff6c48
e2f8545https://github.com/microsoft/TypeScript/pull/32944/commits/e2f8545786112f185e6905259b0148e284ff6c48
https://github.com/sandersn
Merge branch 'master' into constructor-functions-as-classeshttps://github.com/microsoft/TypeScript/pull/32944/commits/b2e72cfe442e0632d42ee310c97e17a23cec6b4a
b2e72cfhttps://github.com/microsoft/TypeScript/pull/32944/commits/b2e72cfe442e0632d42ee310c97e17a23cec6b4a
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 16, 2019 https://github.com/microsoft/TypeScript/pull/32944#pullrequestreview-276183187
View reviewed changes https://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
https://github.com/microsoft/TypeScript/pull/32944#pullrequestreview-276183187
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32944
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 16, 2019https://github.com/microsoft/TypeScript/pull/32944#discussion_r314900586
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32944
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 16, 2019https://github.com/microsoft/TypeScript/pull/32944#discussion_r314901105
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32944
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 16, 2019https://github.com/microsoft/TypeScript/pull/32944#discussion_r314901514
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
hilarious tweethttps://twitter.com/sanders_n/status/1162131784009523202
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32944
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 16, 2019https://github.com/microsoft/TypeScript/pull/32944#discussion_r314901647
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32944
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 16, 2019https://github.com/microsoft/TypeScript/pull/32944#discussion_r314901977
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32944
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 16, 2019https://github.com/microsoft/TypeScript/pull/32944#discussion_r314902532
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32944
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 16, 2019https://github.com/microsoft/TypeScript/pull/32944#discussion_r314903037
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32944
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 16, 2019https://github.com/microsoft/TypeScript/pull/32944#discussion_r314903348
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32944
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 16, 2019https://github.com/microsoft/TypeScript/pull/32944#discussion_r314903644
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32944
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Pranav Senthilnathan (PranavSenthilnathan)https://github.com/PranavSenthilnathan
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Orta Therox (orta)https://github.com/orta
Wesley Wigham (weswigham)https://github.com/weswigham
August 16, 2019 22:01https://github.com/microsoft/TypeScript/pull/32944#event-2563523343
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 16, 2019https://github.com/microsoft/TypeScript/pull/32944#issuecomment-522164991
Andrew Branch (@andrewbranch)https://github.com/andrewbranch
Orta Therox (@orta)https://github.com/orta
Pranav Senthilnathan (@PranavSenthilnathan)https://github.com/PranavSenthilnathan
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32944
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 16, 2019https://github.com/microsoft/TypeScript/pull/32944#issuecomment-522167895
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32944
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 16, 2019https://github.com/microsoft/TypeScript/pull/32944#issuecomment-522167898
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32944
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
b2e72cfhttps://github.com/microsoft/TypeScript/commit/b2e72cfe442e0632d42ee310c97e17a23cec6b4a
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=40645
The results are in!https://github.com/microsoft/TypeScript/pull/32944#issuecomment-522173249
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32944
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 16, 2019https://github.com/microsoft/TypeScript/pull/32944#issuecomment-522173249
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32944
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Aug 16, 2019 https://github.com/microsoft/TypeScript/pull/32944#pullrequestreview-276199859
View reviewed changes https://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a
src/compiler/binder.tshttps://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a#diff-9ad14a2e2e66533cd0c3f02ecf01f7e6bc9d60cdf2e125df2a14ce0713222898
Wesley Wigham (weswigham)https://github.com/weswigham
Aug 16, 2019https://github.com/microsoft/TypeScript/pull/32944#discussion_r314914564
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32944
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 16, 2019https://github.com/microsoft/TypeScript/pull/32944#discussion_r314919358
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32944
Wesley Wigham (weswigham)https://github.com/weswigham
Aug 17, 2019https://github.com/microsoft/TypeScript/pull/32944#discussion_r314923253
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32944
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Aug 16, 2019 https://github.com/microsoft/TypeScript/pull/32944#pullrequestreview-276199899
View reviewed changes https://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a
src/compiler/binder.tshttps://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a#diff-9ad14a2e2e66533cd0c3f02ecf01f7e6bc9d60cdf2e125df2a14ce0713222898
Wesley Wigham (weswigham)https://github.com/weswigham
Aug 16, 2019https://github.com/microsoft/TypeScript/pull/32944#discussion_r314914605
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32944
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 19, 2019https://github.com/microsoft/TypeScript/pull/32944#discussion_r315381399
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
JS: Object.defineProperty "undefined namespaces" don't merge cross-file #32979https://github.com/microsoft/TypeScript/issues/32979
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32944
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 16, 2019 https://github.com/microsoft/TypeScript/pull/32944#pullrequestreview-276200051
View reviewed changes https://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a
src/compiler/binder.tshttps://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a#diff-9ad14a2e2e66533cd0c3f02ecf01f7e6bc9d60cdf2e125df2a14ce0713222898
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 16, 2019https://github.com/microsoft/TypeScript/pull/32944#discussion_r314914753
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32944
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Aug 16, 2019 https://github.com/microsoft/TypeScript/pull/32944#pullrequestreview-276202449
View reviewed changes https://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/32944/files/b2e72cfe442e0632d42ee310c97e17a23cec6b4a#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Wesley Wigham (weswigham)https://github.com/weswigham
Aug 16, 2019https://github.com/microsoft/TypeScript/pull/32944#discussion_r314916712
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32944
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 19, 2019https://github.com/microsoft/TypeScript/pull/32944#discussion_r315414225
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32944
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 19, 2019 https://github.com/microsoft/TypeScript/pull/32944#ref-issue-482493619
JS: Object.defineProperty "undefined namespaces" don't merge cross-file #32979 https://github.com/microsoft/TypeScript/issues/32979
https://github.com/sandersn
Add class flag to nested class declarationshttps://github.com/microsoft/TypeScript/pull/32944/commits/76fc3966a41156670563f6b5918286b8c7ed1da3
76fc396https://github.com/microsoft/TypeScript/pull/32944/commits/76fc3966a41156670563f6b5918286b8c7ed1da3
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Aug 19, 2019 https://github.com/microsoft/TypeScript/pull/32944#pullrequestreview-276795088
View reviewed changes https://github.com/microsoft/TypeScript/pull/32944/files/76fc3966a41156670563f6b5918286b8c7ed1da3
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
6ca9d04https://github.com/microsoft/TypeScript/commit/6ca9d04b60fd3861ed595e968e266f5ef19b29f2
Aug 19, 2019https://github.com/microsoft/TypeScript/pull/32944#event-2567694544
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
August 19, 2019 21:13https://github.com/microsoft/TypeScript/pull/32944#event-2567696280
Tim Suchanek (timsuchanek)https://github.com/timsuchanek
Sep 11, 2019 https://github.com/microsoft/TypeScript/pull/32944#ref-commit-cdc572a
https://github.com/sandersn
https://github.com/timsuchanek
Constructor functions as classes (https://github.com/timsuchanek/TypeScript/commit/cdc572a97203f2443cb7cc0b4c751a6cda15809a
microsoft#32944https://github.com/microsoft/TypeScript/pull/32944
)https://github.com/timsuchanek/TypeScript/commit/cdc572a97203f2443cb7cc0b4c751a6cda15809a
cdc572ahttps://github.com/timsuchanek/TypeScript/commit/cdc572a97203f2443cb7cc0b4c751a6cda15809a
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/32944#event-20416755104
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/32944#event-20416755758
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F32944
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
https://github.com/microsoft/TypeScript/pull/32944/files/76fc3966a41156670563f6b5918286b8c7ed1da3
https://github.com/andrewbranch
Andrew Branch (andrewbranch) https://github.com/andrewbranch
https://github.com/orta
Orta Therox (orta) https://github.com/orta
https://github.com/PranavSenthilnathan
Pranav Senthilnathan (PranavSenthilnathan) https://github.com/PranavSenthilnathan
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32944
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
getApplicableRefactors on file with recursive types freezes TSServer https://github.com/microsoft/TypeScript/issues/26833
In JS, function declarations should allow subsequent prototype assignment https://github.com/microsoft/TypeScript/issues/23007
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32944
https://github.com/sandersn
https://github.com/typescript-bot
https://github.com/weswigham
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.