René's URL Explorer Experiment


Title: Improve excess property checking for intersections by sandersn · Pull Request #32582 · microsoft/TypeScript · GitHub

Open Graph Title: Improve excess property checking for intersections by sandersn · Pull Request #32582 · microsoft/TypeScript

X Title: Improve excess property checking for intersections by sandersn · Pull Request #32582 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Improve excess property checking for intersections by sandersn · Pull Request #32582 · microsoft/TypeScript

Open Graph Description: Excess property checking incorrectly applies to half of an intersection when nested deeply enough because isIntersectionConstituent is not sufficiently threaded through the checkTypeRelatedTo code....

X Description: Excess property checking incorrectly applies to half of an intersection when nested deeply enough because isIntersectionConstituent is not sufficiently threaded through the checkTypeRelatedTo code....

Opengraph URL: https://github.com/microsoft/TypeScript/pull/32582

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:18b02d4a-8ffc-ccf9-299d-5cd728df793e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBA5E:38E318:1EB5C9:26917E:6B00FCF2
html-safe-noncea36d34c12514926471ea308faa40affc98483dbb9bb42add1ad2c0bb5b69fc52
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTVFOjM4RTMxODoxRUI1Qzk6MjY5MTdFOjZCMDBGQ0YyIiwidmlzaXRvcl9pZCI6Ijc4ODI0MTU4MjY0NDIxOTAwNjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9d10d0f4e0c9c70614e007c35e4bb544f940e867513c1f8afdbeeb82f1307808
hovercard-subject-tagpull_request:301672437
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/32582/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0dd715202ccd65d6616c69d0c1f568b72c170906b66f66b97c58a56143d2f5fb/microsoft/TypeScript/pull/32582
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0dd715202ccd65d6616c69d0c1f568b72c170906b66f66b97c58a56143d2f5fb/microsoft/TypeScript/pull/32582
og:image:altExcess property checking incorrectly applies to half of an intersection when nested deeply enough because isIntersectionConstituent is not sufficiently threaded through the checkTypeRelatedTo code....
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesandersn
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/32582#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F32582
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F32582
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/32582
Reloadhttps://github.com/microsoft/TypeScript/pull/32582
Reloadhttps://github.com/microsoft/TypeScript/pull/32582
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
excess-property-check-nested-array-intersectionhttps://github.com/microsoft/TypeScript/tree/excess-property-check-nested-array-intersection
Conversationhttps://github.com/microsoft/TypeScript/pull/32582
Commits5 (5)https://github.com/microsoft/TypeScript/pull/32582/commits
Checkshttps://github.com/microsoft/TypeScript/pull/32582/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/32582/files
Improve excess property checking for intersectionshttps://github.com/microsoft/TypeScript/pull/32582#top
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
excess-property-check-nested-array-intersectionhttps://github.com/microsoft/TypeScript/tree/excess-property-check-nested-array-intersection
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jul 26, 2019https://github.com/microsoft/TypeScript/pull/32582#issue-473520088
#30715https://github.com/microsoft/TypeScript/issues/30715
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32582
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
July 26, 2019 11:17https://github.com/microsoft/TypeScript/pull/32582#commits-pushed-9d274f6
https://github.com/sandersn
Improve excess property checking for intersectionshttps://github.com/microsoft/TypeScript/pull/32582/commits/9d274f612ee01b8f2beb18c607b0be042c426024
9d274f6https://github.com/microsoft/TypeScript/pull/32582/commits/9d274f612ee01b8f2beb18c607b0be042c426024
https://github.com/sandersn
Use mutable isIntersection in checkTypeRelatedTohttps://github.com/microsoft/TypeScript/pull/32582/commits/b8dccff2a25495867cff070b94601015e689b8ff
b8dccffhttps://github.com/microsoft/TypeScript/pull/32582/commits/b8dccff2a25495867cff070b94601015e689b8ff
https://github.com/sandersn
Fix semicolon linthttps://github.com/microsoft/TypeScript/pull/32582/commits/3784b9b7526863296af3f318132896d8cdcc577f
3784b9bhttps://github.com/microsoft/TypeScript/pull/32582/commits/3784b9b7526863296af3f318132896d8cdcc577f
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Wesley Wigham (weswigham)https://github.com/weswigham
Jul 26, 2019https://github.com/microsoft/TypeScript/pull/32582#event-2513737033
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jul 26, 2019https://github.com/microsoft/TypeScript/pull/32582#issuecomment-515603298
Wesley Wigham (@weswigham)https://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32582
https://github.com/sandersn
Remove TODOOOOhttps://github.com/microsoft/TypeScript/pull/32582/commits/74113b3a27276c44f1d0311345211a08f9edcfb2
74113b3https://github.com/microsoft/TypeScript/pull/32582/commits/74113b3a27276c44f1d0311345211a08f9edcfb2
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Jul 26, 2019 https://github.com/microsoft/TypeScript/pull/32582#pullrequestreview-267432948
View reviewed changes https://github.com/microsoft/TypeScript/pull/32582/files/74113b3a27276c44f1d0311345211a08f9edcfb2
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/32582/files/74113b3a27276c44f1d0311345211a08f9edcfb2#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Wesley Wigham (weswigham)https://github.com/weswigham
Jul 26, 2019https://github.com/microsoft/TypeScript/pull/32582#discussion_r307933455
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32582
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 5, 2019https://github.com/microsoft/TypeScript/pull/32582#discussion_r310801107
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32582
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32582
Wesley Wigham (weswigham)https://github.com/weswigham
Aug 5, 2019https://github.com/microsoft/TypeScript/pull/32582#discussion_r310806576
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32582
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Jul 26, 2019 https://github.com/microsoft/TypeScript/pull/32582#pullrequestreview-267433792
View reviewed changes https://github.com/microsoft/TypeScript/pull/32582/files/74113b3a27276c44f1d0311345211a08f9edcfb2
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/32582/files/74113b3a27276c44f1d0311345211a08f9edcfb2#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Wesley Wigham (weswigham)https://github.com/weswigham
Jul 26, 2019https://github.com/microsoft/TypeScript/pull/32582#discussion_r307934180
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32582
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 6, 2019https://github.com/microsoft/TypeScript/pull/32582#discussion_r311209635
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32582
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 6, 2019https://github.com/microsoft/TypeScript/pull/32582#issuecomment-518787885
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32582
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 6, 2019https://github.com/microsoft/TypeScript/pull/32582#issuecomment-518787934
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32582
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
74113b3https://github.com/microsoft/TypeScript/commit/74113b3a27276c44f1d0311345211a08f9edcfb2
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=39110
The results are in!https://github.com/microsoft/TypeScript/pull/32582#issuecomment-518805777
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32582
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 6, 2019https://github.com/microsoft/TypeScript/pull/32582#issuecomment-518805777
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32582
https://github.com/sandersn
Revert "Use mutable isIntersection in checkTypeRelatedTo"https://github.com/microsoft/TypeScript/pull/32582/commits/b8507d2293873fc401009d253656599f867a2919
b8507d2https://github.com/microsoft/TypeScript/pull/32582/commits/b8507d2293873fc401009d253656599f867a2919
b8dccffhttps://github.com/microsoft/TypeScript/commit/b8dccff2a25495867cff070b94601015e689b8ff
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 6, 2019https://github.com/microsoft/TypeScript/pull/32582#issuecomment-518820859
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32582
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 6, 2019https://github.com/microsoft/TypeScript/pull/32582#issuecomment-518820893
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32582
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
b8507d2https://github.com/microsoft/TypeScript/commit/b8507d2293873fc401009d253656599f867a2919
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=39139
The results are in!https://github.com/microsoft/TypeScript/pull/32582#issuecomment-518835954
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32582
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 6, 2019https://github.com/microsoft/TypeScript/pull/32582#issuecomment-518835954
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32582
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 6, 2019https://github.com/microsoft/TypeScript/pull/32582#issuecomment-518841309
Wesley Wigham (@weswigham)https://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32582
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Aug 6, 2019 https://github.com/microsoft/TypeScript/pull/32582#pullrequestreview-271629447
View reviewed changes https://github.com/microsoft/TypeScript/pull/32582/files/b8507d2293873fc401009d253656599f867a2919
Wesley Wigham (weswigham)https://github.com/weswigham
https://github.com/microsoft/TypeScript/pull/32582#pullrequestreview-271629447
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32582
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Aug 6, 2019 https://github.com/microsoft/TypeScript/pull/32582#pullrequestreview-271629805
View reviewed changes https://github.com/microsoft/TypeScript/pull/32582/files/b8507d2293873fc401009d253656599f867a2919
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/32582/files/b8507d2293873fc401009d253656599f867a2919#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Wesley Wigham (weswigham)https://github.com/weswigham
Aug 6, 2019https://github.com/microsoft/TypeScript/pull/32582#discussion_r311286775
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32582
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
480b739https://github.com/microsoft/TypeScript/commit/480b73915fdd805952fd355e4cf3e1bc803e0878
Aug 6, 2019https://github.com/microsoft/TypeScript/pull/32582#event-2538243745
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
August 6, 2019 22:03https://github.com/microsoft/TypeScript/pull/32582#event-2538243875
3.6 regression: Error: Debug Failure. No error for last overload signature #33133 https://github.com/microsoft/TypeScript/issues/33133
someTypeRelatedToType now passes isIntersectionConstituent #33213 https://github.com/microsoft/TypeScript/pull/33213
https://github.com/lookfirst
Public Profile (lookfirst)https://github.com/lookfirst
Sep 17, 2019 https://github.com/microsoft/TypeScript/pull/32582#ref-issue-494526154
[tsc] Regression causing 'Maximum call stack size exceeded' #33460 https://github.com/microsoft/TypeScript/issues/33460
https://github.com/amcasey
Andrew Casey (amcasey)https://github.com/amcasey
Jan 31, 2020 https://github.com/microsoft/TypeScript/pull/32582#ref-issue-558432516
Performance regression in #32582 #36562 https://github.com/microsoft/TypeScript/issues/36562
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/32582#event-20416734859
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F32582
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
https://github.com/microsoft/TypeScript/pull/32582/files/b8507d2293873fc401009d253656599f867a2919
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32582
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
Excess property checking only applies to half of an intersection https://github.com/microsoft/TypeScript/issues/30715
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/32582
https://github.com/sandersn
https://github.com/typescript-bot
https://github.com/weswigham
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.