René's URL Explorer Experiment


Title: Detect semicolons before writing from TextChanges by andrewbranch · Pull Request #31801 · microsoft/TypeScript · GitHub

Open Graph Title: Detect semicolons before writing from TextChanges by andrewbranch · Pull Request #31801 · microsoft/TypeScript

X Title: Detect semicolons before writing from TextChanges by andrewbranch · Pull Request #31801 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Detect semicolons before writing from TextChanges by andrewbranch · Pull Request #31801 · microsoft/TypeScript

Open Graph Description: Fixes #19882 Note that this change affects more than just auto-imports; it should affect all quick fixes that insert new nodes into a file. Screen captures The detection algorithm is: Traverse...

X Description: Fixes #19882 Note that this change affects more than just auto-imports; it should affect all quick fixes that insert new nodes into a file. Screen captures The detection algorithm is: Traverse...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/31801

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fcd06b12-54ea-833f-0116-87e17446297e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBCA0:1F65:175AD82:1DAABCC:6B01970A
html-safe-nonce183e01ed86137da365f3592dfcec88f12b75d40f6eb8703a4170ce43773e8782
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQ0EwOjFGNjU6MTc1QUQ4MjoxREFBQkNDOjZCMDE5NzBBIiwidmlzaXRvcl9pZCI6IjEyNDkzODU4MTgwMTI3NzE5NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6d4b3f130ad72e6eae7ece8384d937897d3fbee157ce870098ac295dcfe3a55e
hovercard-subject-tagpull_request:285922058
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/31801/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5ee4ae1d4fb33afaab2e4c07636aaec825a790e9dc9b6a618ec5de69360812ac/microsoft/TypeScript/pull/31801
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5ee4ae1d4fb33afaab2e4c07636aaec825a790e9dc9b6a618ec5de69360812ac/microsoft/TypeScript/pull/31801
og:image:altFixes #19882 Note that this change affects more than just auto-imports; it should affect all quick fixes that insert new nodes into a file. Screen captures The detection algorithm is: Traverse...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameandrewbranch
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/31801#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F31801
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F31801
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/31801
Reloadhttps://github.com/microsoft/TypeScript/pull/31801
Reloadhttps://github.com/microsoft/TypeScript/pull/31801
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Andrew Branch (andrewbranch)https://github.com/andrewbranch
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
andrewbranch:semicolonshttps://github.com/andrewbranch/TypeScript/tree/semicolons
Conversationhttps://github.com/microsoft/TypeScript/pull/31801
Commits4 (4)https://github.com/microsoft/TypeScript/pull/31801/commits
Checkshttps://github.com/microsoft/TypeScript/pull/31801/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/31801/files
Detect semicolons before writing from TextChangeshttps://github.com/microsoft/TypeScript/pull/31801#top
Andrew Branch (andrewbranch)https://github.com/andrewbranch
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
andrewbranch:semicolonshttps://github.com/andrewbranch/TypeScript/tree/semicolons
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Jun 6, 2019https://github.com/microsoft/TypeScript/pull/31801#issue-453179784
#19882https://github.com/microsoft/TypeScript/issues/19882
https://user-images.githubusercontent.com/3277153/59057067-67188e80-884e-11e9-9167-2a2a57b413c1.gif
https://user-images.githubusercontent.com/3277153/59057061-62ec7100-884e-11e9-8a8c-ef11a4706c8c.gif
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/31801
Andrew Branch (andrewbranch)https://github.com/andrewbranch
June 6, 2019 10:39https://github.com/microsoft/TypeScript/pull/31801#commits-pushed-ca44ee8
https://github.com/andrewbranch
Update fourslash tests to have semicolonshttps://github.com/microsoft/TypeScript/pull/31801/commits/ca44ee8f975b32d275a7f6470f2232fc68cbc8a5
ca44ee8https://github.com/microsoft/TypeScript/pull/31801/commits/ca44ee8f975b32d275a7f6470f2232fc68cbc8a5
https://github.com/andrewbranch
Update fourslash tests that shouldn’t insert semicolonshttps://github.com/microsoft/TypeScript/pull/31801/commits/7815778fb053e453e17f83442fc45261937b3bb0
7815778https://github.com/microsoft/TypeScript/pull/31801/commits/7815778fb053e453e17f83442fc45261937b3bb0
https://github.com/andrewbranch
Detect semicolons in file before writing quick fixeshttps://github.com/microsoft/TypeScript/pull/31801/commits/b37875ff7aac7c85e1a3a4859c6589ef8d50e4cf
b37875fhttps://github.com/microsoft/TypeScript/pull/31801/commits/b37875ff7aac7c85e1a3a4859c6589ef8d50e4cf
https://github.com/andrewbranch
Add test for semicolon detection in auto-importhttps://github.com/microsoft/TypeScript/pull/31801/commits/6282c9fb5e2097c86f44ee67da872423df1c1d5c
6282c9fhttps://github.com/microsoft/TypeScript/pull/31801/commits/6282c9fb5e2097c86f44ee67da872423df1c1d5c
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Ron Buckton (rbuckton)https://github.com/rbuckton
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
June 6, 2019 18:36https://github.com/microsoft/TypeScript/pull/31801#event-2395276757
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Jun 6, 2019https://github.com/microsoft/TypeScript/pull/31801#event-2395277385
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Orta Therox (orta)https://github.com/orta
June 13, 2019 21:53https://github.com/microsoft/TypeScript/pull/31801#event-2412022766
https://github.com/orta
Orta Therox (orta)https://github.com/orta
Jun 14, 2019 https://github.com/microsoft/TypeScript/pull/31801#pullrequestreview-249665490
View reviewed changes https://github.com/microsoft/TypeScript/pull/31801/files/6282c9fb5e2097c86f44ee67da872423df1c1d5c
Orta Therox (orta)https://github.com/orta
https://github.com/microsoft/TypeScript/pull/31801#pullrequestreview-249665490
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/31801
tests/cases/fourslash/extract-method-in-anonymous-function-declaration.tshttps://github.com/microsoft/TypeScript/pull/31801/files/6282c9fb5e2097c86f44ee67da872423df1c1d5c#diff-6d2de8fce947a03e638530bfbb8b4460c094c065a5833558dd9cb22883770754
Orta Therox (orta)https://github.com/orta
Jun 14, 2019https://github.com/microsoft/TypeScript/pull/31801#discussion_r293624552
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/31801
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
11a62cbhttps://github.com/microsoft/TypeScript/commit/11a62cb0ab868267d4a76d72a594e87a0bdbd469
Jul 1, 2019https://github.com/microsoft/TypeScript/pull/31801#event-2452345647
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
July 1, 2019 20:23https://github.com/microsoft/TypeScript/pull/31801#event-2452345838
https://github.com/abumalick
Abdullah Hilson (abumalick)https://github.com/abumalick
Jul 1, 2019https://github.com/microsoft/TypeScript/pull/31801#issuecomment-507413012
Andrew Branch (@andrewbranch)https://github.com/andrewbranch
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/31801
https://github.com/janosh
Janosh Riebesell (janosh)https://github.com/janosh
Jul 19, 2019https://github.com/microsoft/TypeScript/pull/31801#issuecomment-513328924
Andrew Branch (@andrewbranch)https://github.com/andrewbranch
TypeScript 3.6.0 Betahttps://devblogs.microsoft.com/typescript/announcing-typescript-3-6-beta
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/31801
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Jul 19, 2019https://github.com/microsoft/TypeScript/pull/31801#issuecomment-513330252
Janosh Riebesell (@janosh)https://github.com/janosh
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/31801
https://github.com/janosh
Janosh Riebesell (janosh)https://github.com/janosh
Jul 19, 2019https://github.com/microsoft/TypeScript/pull/31801#issuecomment-513346148
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/31801
Andrew Branch (@andrewbranch)https://github.com/andrewbranch
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/31801
https://github.com/mjomble
Andres Kalle (mjomble)https://github.com/mjomble
Aug 6, 2019 https://github.com/microsoft/TypeScript/pull/31801#ref-issue-272719548
autoimport should care about semicolons #19882 https://github.com/microsoft/TypeScript/issues/19882
https://github.com/cancerberoSgx
Sebastián Gurin (cancerberoSgx)https://github.com/cancerberoSgx
Aug 6, 2019https://github.com/microsoft/TypeScript/pull/31801#issuecomment-518718313
Andrew Branch (@andrewbranch)https://github.com/andrewbranch
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/31801
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Aug 6, 2019https://github.com/microsoft/TypeScript/pull/31801#issuecomment-518742263
Sebastián Gurin (@cancerberoSgx)https://github.com/cancerberoSgx
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/31801
https://github.com/mjomble
Andres Kalle (mjomble)https://github.com/mjomble
Aug 6, 2019https://github.com/microsoft/TypeScript/pull/31801#issuecomment-518746307
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/31801
Ryan Cavanaugh (@RyanCavanaugh)https://github.com/RyanCavanaugh
#19882 (comment)https://github.com/microsoft/TypeScript/issues/19882#issuecomment-518720259
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/31801
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Aug 6, 2019https://github.com/microsoft/TypeScript/pull/31801#issuecomment-518748955
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/31801
https://github.com/cancerberoSgx
Sebastián Gurin (cancerberoSgx)https://github.com/cancerberoSgx
Aug 6, 2019https://github.com/microsoft/TypeScript/pull/31801#issuecomment-518769137
Andrew Branch (@andrewbranch)https://github.com/andrewbranch
https://github.com/cancerberoSgx/magica/blob/master/formatCodeSettings.jsonhttps://github.com/cancerberoSgx/magica/blob/master/formatCodeSettings.json
Matt Bierner (@mjbvz)https://github.com/mjbvz
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/31801
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Aug 6, 2019https://github.com/microsoft/TypeScript/pull/31801#issuecomment-518771845
Sebastián Gurin (@cancerberoSgx)https://github.com/cancerberoSgx
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/31801
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Aug 6, 2019https://github.com/microsoft/TypeScript/pull/31801#issuecomment-518780881
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/31801
https://github.com/cancerberoSgx
Sebastián Gurin (cancerberoSgx)https://github.com/cancerberoSgx
Aug 6, 2019https://github.com/microsoft/TypeScript/pull/31801#issuecomment-518786477
Ryan Cavanaugh (@RyanCavanaugh)https://github.com/RyanCavanaugh
Andrew Branch (@andrewbranch)https://github.com/andrewbranch
https://github.com/cancerberoSgx/ts-refactorhttps://github.com/cancerberoSgx/ts-refactor
https://github.com/cancerberoSgx/ts-refactor/blob/master/src/fix/formatTypes.tshttps://github.com/cancerberoSgx/ts-refactor/blob/master/src/fix/formatTypes.ts
https://github.com/cancerberoSgx/typescript-plugins-of-mine/blob/master/ts-simple-ast-extra/src/refactor/trailingSemicolons.tshttps://github.com/cancerberoSgx/typescript-plugins-of-mine/blob/master/ts-simple-ast-extra/src/refactor/trailingSemicolons.ts
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/31801
https://github.com/mjbvz
Matt Bierner (mjbvz)https://github.com/mjbvz
Aug 12, 2019 https://github.com/microsoft/TypeScript/pull/31801#ref-issue-479891234
Improve semicolon detection experience for new files #32831 https://github.com/microsoft/TypeScript/issues/32831
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Aug 14, 2019 https://github.com/microsoft/TypeScript/pull/31801#ref-pullrequest-480935914
Fix writing multi-line text without semicolons #32903 https://github.com/microsoft/TypeScript/pull/32903
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Sep 12, 2019 https://github.com/microsoft/TypeScript/pull/31801#ref-pullrequest-493063283
Add semicolon preference to formatter options #33402 https://github.com/microsoft/TypeScript/pull/33402
https://github.com/orblazer
orblazerhttps://github.com/orblazer
Sep 17, 2022 https://github.com/microsoft/TypeScript/pull/31801#ref-issue-1376817280
Semicolon is added when organize import in specific case #50817 https://github.com/microsoft/TypeScript/issues/50817
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/31801#event-20416695289
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/31801#event-20416695703
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F31801
https://github.com/rbuckton
Ron Buckton (rbuckton) https://github.com/rbuckton
https://github.com/sheetalkamat
Sheetal Nandi (sheetalkamat) https://github.com/sheetalkamat
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh) https://github.com/RyanCavanaugh
https://github.com/orta
Orta Therox (orta) https://github.com/orta
https://github.com/microsoft/TypeScript/pull/31801/files/6282c9fb5e2097c86f44ee67da872423df1c1d5c
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/31801
https://github.com/andrewbranch
Andrew Branch (andrewbranch) https://github.com/andrewbranch
autoimport should care about semicolons https://github.com/microsoft/TypeScript/issues/19882
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/31801
https://github.com/andrewbranch
https://github.com/abumalick
https://github.com/janosh
https://github.com/cancerberoSgx
https://github.com/mjomble
https://github.com/RyanCavanaugh
https://github.com/orta
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.