René's URL Explorer Experiment


Title: Filter primitives from union when checking for mismatched excess props if nonprimitive type is present by weswigham · Pull Request #31708 · microsoft/TypeScript · GitHub

Open Graph Title: Filter primitives from union when checking for mismatched excess props if nonprimitive type is present by weswigham · Pull Request #31708 · microsoft/TypeScript

X Title: Filter primitives from union when checking for mismatched excess props if nonprimitive type is present by weswigham · Pull Request #31708 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Filter primitives from union when checking for mismatched excess props if nonprimitive type is present by weswigham · Pull Request #31708 · microsoft/TypeScript

Open Graph Description: Fixes #31668

X Description: Fixes #31668

Opengraph URL: https://github.com/microsoft/TypeScript/pull/31708

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:95c1ee1a-a0ce-04b9-8437-b7afc0ec0c15
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA1F0:1CEA6F:B62D7A:F25C18:6B00EE52
html-safe-nonce7b0b1a4733d3126b1716e598f0108587542d35903ebc7bb51b7e8fdfaba92cc8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMUYwOjFDRUE2RjpCNjJEN0E6RjI1QzE4OjZCMDBFRTUyIiwidmlzaXRvcl9pZCI6IjU0MDE0MDY0NTAxMjE2MzMzNjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace470f99aa78c90eb3106884418503826db9236a5cea8a5658868bccdbaf13a7a
hovercard-subject-tagpull_request:284213372
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/31708/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1fcd7d00d9721081d5d7c29f2295b770d496d312ef57ab802c3df7276af2e40d/microsoft/TypeScript/pull/31708
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1fcd7d00d9721081d5d7c29f2295b770d496d312ef57ab802c3df7276af2e40d/microsoft/TypeScript/pull/31708
og:image:altFixes #31668
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameweswigham
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/31708#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F31708
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F31708
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/31708
Reloadhttps://github.com/microsoft/TypeScript/pull/31708
Reloadhttps://github.com/microsoft/TypeScript/pull/31708
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests308 (308)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
weswigham:discriminate-objects-onlyhttps://github.com/weswigham/TypeScript/tree/discriminate-objects-only
Conversationhttps://github.com/microsoft/TypeScript/pull/31708
Commits2 (2)https://github.com/microsoft/TypeScript/pull/31708/commits
Checkshttps://github.com/microsoft/TypeScript/pull/31708/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/31708/files
Filter primitives from union when checking for mismatched excess props if nonprimitive type is presenthttps://github.com/microsoft/TypeScript/pull/31708#top
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
weswigham:discriminate-objects-onlyhttps://github.com/weswigham/TypeScript/tree/discriminate-objects-only
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
May 31, 2019https://github.com/microsoft/TypeScript/pull/31708#issue-451005987
#31668https://github.com/microsoft/TypeScript/issues/31668
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/31708
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 31, 2019 22:42https://github.com/microsoft/TypeScript/pull/31708#event-2382302607
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Jun 4, 2019 https://github.com/microsoft/TypeScript/pull/31708#pullrequestreview-245217568
View reviewed changes https://github.com/microsoft/TypeScript/pull/31708/files
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/31708/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Jun 4, 2019https://github.com/microsoft/TypeScript/pull/31708#discussion_r290113740
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/31708
Wesley Wigham (weswigham)https://github.com/weswigham
June 11, 2019 16:51https://github.com/microsoft/TypeScript/pull/31708#commits-pushed-2bbdcc8
https://github.com/weswigham
Filter primitives from union when checking for mismatched excess prop…https://github.com/microsoft/TypeScript/pull/31708/commits/2bbdcc81ec0ede80485df8df14ac8a8de61230f9
2bbdcc8https://github.com/microsoft/TypeScript/pull/31708/commits/2bbdcc81ec0ede80485df8df14ac8a8de61230f9
https://github.com/weswigham
Use maybeTypeOfKindhttps://github.com/microsoft/TypeScript/pull/31708/commits/b2359982f5d2a1205eb1d4685780a57fc59dc09e
b235998https://github.com/microsoft/TypeScript/pull/31708/commits/b2359982f5d2a1205eb1d4685780a57fc59dc09e
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
force-pushedhttps://github.com/microsoft/TypeScript/compare/a1c5b5dde160a26f1164a74e0a8cadab2d0119d1..b2359982f5d2a1205eb1d4685780a57fc59dc09e
a1c5b5dhttps://github.com/microsoft/TypeScript/commit/a1c5b5dde160a26f1164a74e0a8cadab2d0119d1
b235998https://github.com/microsoft/TypeScript/commit/b2359982f5d2a1205eb1d4685780a57fc59dc09e
Compare https://github.com/microsoft/TypeScript/compare/a1c5b5dde160a26f1164a74e0a8cadab2d0119d1..b2359982f5d2a1205eb1d4685780a57fc59dc09e
June 11, 2019 23:56https://github.com/microsoft/TypeScript/pull/31708#event-2405802742
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Jun 11, 2019https://github.com/microsoft/TypeScript/pull/31708#issuecomment-501067586
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/31708
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jun 11, 2019https://github.com/microsoft/TypeScript/pull/31708#issuecomment-501067597
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/31708
Wesley Wigham (@weswigham)https://github.com/weswigham
b235998https://github.com/microsoft/TypeScript/commit/b2359982f5d2a1205eb1d4685780a57fc59dc09e
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=33042
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/31708
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jun 11, 2019https://github.com/microsoft/TypeScript/pull/31708#issuecomment-501067598
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/31708
Wesley Wigham (@weswigham)https://github.com/weswigham
b235998https://github.com/microsoft/TypeScript/commit/b2359982f5d2a1205eb1d4685780a57fc59dc09e
herehttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=33043
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/31708
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Jun 12, 2019https://github.com/microsoft/TypeScript/pull/31708#issuecomment-501072593
Daniel Rosenwasser (@DanielRosenwasser)https://github.com/DanielRosenwasser
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/31708
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jun 12, 2019 https://github.com/microsoft/TypeScript/pull/31708#pullrequestreview-248986091
View reviewed changes https://github.com/microsoft/TypeScript/pull/31708/files/b2359982f5d2a1205eb1d4685780a57fc59dc09e
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
https://github.com/microsoft/TypeScript/pull/31708#pullrequestreview-248986091
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/31708
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
74c6bc1https://github.com/microsoft/TypeScript/commit/74c6bc1f85c2ab36fdb789aa0ef6ee5dbde5afdd
Jun 13, 2019https://github.com/microsoft/TypeScript/pull/31708#event-2409060684
https://github.com/GulajavaMinistudio
Gulajava Ministudio (GulajavaMinistudio)https://github.com/GulajavaMinistudio
Jun 13, 2019 https://github.com/microsoft/TypeScript/pull/31708#ref-pullrequest-455849444
Promote LimitRange e2e test to Conformance GulajavaMinistudio/TypeScript#139 https://github.com/GulajavaMinistudio/TypeScript/pull/139
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
June 15, 2019 00:22https://github.com/microsoft/TypeScript/pull/31708#event-2415123976
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Nov 6, 2019 https://github.com/microsoft/TypeScript/pull/31708#ref-pullrequest-518047736
Fix excess property checking for unions with index signatures #34927 https://github.com/microsoft/TypeScript/pull/34927
https://github.com/heguro
hegurohttps://github.com/heguro
Sep 14, 2024 https://github.com/microsoft/TypeScript/pull/31708#ref-issue-2526368025
Type 'never' incorrectly inferred for mixed primitive type properties assignment with strictNullChecks disabled #59969 https://github.com/microsoft/TypeScript/issues/59969
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/31708#event-20416690407
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Wesley Wigham (weswigham)https://github.com/weswigham
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/31708#event-20416692645
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F31708
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) https://github.com/DanielRosenwasser
https://github.com/microsoft/TypeScript/pull/31708/files/a1c5b5dde160a26f1164a74e0a8cadab2d0119d1
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
https://github.com/microsoft/TypeScript/pull/31708/files/b2359982f5d2a1205eb1d4685780a57fc59dc09e
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh) https://github.com/RyanCavanaugh
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/31708
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
Apparent properties in union of primitive and object causes incorrect error https://github.com/microsoft/TypeScript/issues/31668
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/31708
https://github.com/weswigham
https://github.com/typescript-bot
https://github.com/sandersn
https://github.com/DanielRosenwasser
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.