René's URL Explorer Experiment


Title: external modules resolve by node_modules and package.json-main by basarat · Pull Request #3147 · microsoft/TypeScript · GitHub

Open Graph Title: external modules resolve by node_modules and package.json-main by basarat · Pull Request #3147 · microsoft/TypeScript

X Title: external modules resolve by node_modules and package.json-main by basarat · Pull Request #3147 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - external modules resolve by node_modules and package.json-main by basarat · Pull Request #3147 · microsoft/TypeScript

Open Graph Description: Code for #2338. This is just for the node_modules resolution. Does everything for node_modules except for the typings stuff as I don't see the rational for that considering there is no way to h...

X Description: Code for #2338. This is just for the node_modules resolution. Does everything for node_modules except for the typings stuff as I don't see the rational for that considering there is no way ...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/3147

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3245ac83-6dd2-c1b7-4df4-6ec7492329b4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAAEA:1CEA6F:E3E11A:12E305E:6B00FE5F
html-safe-nonced12c54aefaba415d09f28c575df34baed00e20e7effee10b100b311813f4d002
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQUVBOjFDRUE2RjpFM0UxMUE6MTJFMzA1RTo2QjAwRkU1RiIsInZpc2l0b3JfaWQiOiIxNjc5OTc3Mjk3MTQ0MjQ5OTUyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac39bb7df6be7ad6324cb02d522a8d4a64a9a75fbdd53d62ae684e92354e7e7962
hovercard-subject-tagpull_request:35314172
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/3147/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/719fa729ee991c593d6fb0226425ed4cb03fa44b7c74420fcddab0df99886f61/microsoft/TypeScript/pull/3147
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/719fa729ee991c593d6fb0226425ed4cb03fa44b7c74420fcddab0df99886f61/microsoft/TypeScript/pull/3147
og:image:altCode for #2338. This is just for the node_modules resolution. Does everything for node_modules except for the typings stuff as I don't see the rational for that considering there is no way to h...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebasarat
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/3147#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F3147
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F3147
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/3147
Reloadhttps://github.com/microsoft/TypeScript/pull/3147
Reloadhttps://github.com/microsoft/TypeScript/pull/3147
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Basarat Ali Syed (basarat)https://github.com/basarat
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
Conversationhttps://github.com/microsoft/TypeScript/pull/3147
Commits6 (6)https://github.com/microsoft/TypeScript/pull/3147/commits
Checkshttps://github.com/microsoft/TypeScript/pull/3147/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/3147/files
external modules resolve by node_modules and package.json-mainhttps://github.com/microsoft/TypeScript/pull/3147#top
Basarat Ali Syed (basarat)https://github.com/basarat
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
https://github.com/basarat
Basarat Ali Syed (basarat)https://github.com/basarat
May 13, 2015https://github.com/microsoft/TypeScript/pull/3147#issue-75940289
#2338https://github.com/microsoft/TypeScript/issues/2338
master...Nemo157:node_modules)https://github.com/microsoft/TypeScript/compare/master...Nemo157:node_modules)
https://github.com/Microsoft/TypeScript/blob/e76439b2ff39e1e8afd926450e7cebba2149fe28/src/harness/projectsRunner.ts#L212-L222%29%29https://github.com/Microsoft/TypeScript/blob/e76439b2ff39e1e8afd926450e7cebba2149fe28/src/harness/projectsRunner.ts#L212-L222%29%29
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/3147
https://github.com/basarat
external modules resolve by node_modules and package.json-mainhttps://github.com/microsoft/TypeScript/pull/3147/commits/d4ce70d094bfccd496db32f22e8855e67907b527
d4ce70dhttps://github.com/microsoft/TypeScript/pull/3147/commits/d4ce70d094bfccd496db32f22e8855e67907b527
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-already-signed https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-already-signed
May 13, 2015https://github.com/microsoft/TypeScript/pull/3147#event-303739182
DanielRosenwasserhttps://github.com/DanielRosenwasser
May 13, 2015 https://github.com/microsoft/TypeScript/pull/3147#discussion-diff-30253964
View reviewed changes https://github.com/microsoft/TypeScript/pull/3147/files/d4ce70d094bfccd496db32f22e8855e67907b527#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/3147/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
May 13, 2015https://github.com/microsoft/TypeScript/pull/3147#discussion_r30253964
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/3147
Basarat Ali Syed (basarat)https://github.com/basarat
May 13, 2015https://github.com/microsoft/TypeScript/pull/3147#discussion_r30285918
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/3147
Basarat Ali Syed (basarat)https://github.com/basarat
May 14, 2015 09:21https://github.com/microsoft/TypeScript/pull/3147#commits-pushed-0321474
https://github.com/basarat
CR feedback : remove type annotations for inferred typeshttps://github.com/microsoft/TypeScript/pull/3147/commits/0321474676c7d6acb03f092aba67d4a2f99607bc
0321474https://github.com/microsoft/TypeScript/pull/3147/commits/0321474676c7d6acb03f092aba67d4a2f99607bc
https://github.com/basarat
chore(test) get tests passing as a demonstrationhttps://github.com/microsoft/TypeScript/pull/3147/commits/a7819160fed625aa9d45336ce38d67a79f70ff35
a781916https://github.com/microsoft/TypeScript/pull/3147/commits/a7819160fed625aa9d45336ce38d67a79f70ff35
https://github.com/basarat
Basarat Ali Syed (basarat)https://github.com/basarat
May 13, 2015https://github.com/microsoft/TypeScript/pull/3147#issuecomment-101847480
a781916https://github.com/microsoft/TypeScript/commit/a7819160fed625aa9d45336ce38d67a79f70ff35
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/3147
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
May 14, 2015https://github.com/microsoft/TypeScript/pull/3147#issuecomment-101872161
Basarat Ali Syed (@basarat)https://github.com/basarat
Vladimir Matveev (@vladima)https://github.com/vladima
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/3147
https://github.com/basarat
Basarat Ali Syed (basarat)https://github.com/basarat
May 14, 2015https://github.com/microsoft/TypeScript/pull/3147#issuecomment-101891514
https://github.com/TypeStrong/atom-typescript/blob/8df1482222fb88363b504d9c27f98692e938e44f/lib/main/lang/core/languageServiceHost2.ts#L353-L358https://github.com/TypeStrong/atom-typescript/blob/8df1482222fb88363b504d9c27f98692e938e44f/lib/main/lang/core/languageServiceHost2.ts#L353-L358
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/3147
https://github.com/vladima
Vladimir Matveev (vladima)https://github.com/vladima
May 14, 2015https://github.com/microsoft/TypeScript/pull/3147#issuecomment-101908368
External module resolution logic #2338https://github.com/microsoft/TypeScript/issues/2338
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/3147
https://github.com/basarat
Basarat Ali Syed (basarat)https://github.com/basarat
May 14, 2015https://github.com/microsoft/TypeScript/pull/3147#issuecomment-101923477
Vladimir Matveev (@vladima)https://github.com/vladima
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/3147
https://github.com/vladima
Vladimir Matveev (vladima)https://github.com/vladima
May 14, 2015https://github.com/microsoft/TypeScript/pull/3147#issuecomment-101929406
this guyhttps://github.com/Microsoft/TypeScript/blob/master/src/services/shims.ts#L46
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/3147
https://github.com/basarat
Basarat Ali Syed (basarat)https://github.com/basarat
May 14, 2015https://github.com/microsoft/TypeScript/pull/3147#issuecomment-101941179
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/3147
Basarat Ali Syed (basarat)https://github.com/basarat
May 15, 2015 17:47https://github.com/microsoft/TypeScript/pull/3147#commits-pushed-dbe2ed2
https://github.com/basarat
feat(node_modules) add fileExists and readFile to CompilerHosthttps://github.com/microsoft/TypeScript/pull/3147/commits/dbe2ed2e1ba25bd516d807237a85d71d38a680e7
dbe2ed2https://github.com/microsoft/TypeScript/pull/3147/commits/dbe2ed2e1ba25bd516d807237a85d71d38a680e7
https://github.com/basarat
allow test harness to provide a mock fileExists functionhttps://github.com/microsoft/TypeScript/pull/3147/commits/a17c6aaec3b25624111c3fcd8026b5af2340c471
a17c6aahttps://github.com/microsoft/TypeScript/pull/3147/commits/a17c6aaec3b25624111c3fcd8026b5af2340c471
https://github.com/basarat
Basarat Ali Syed (basarat)https://github.com/basarat
May 15, 2015https://github.com/microsoft/TypeScript/pull/3147#issuecomment-102361847
basarat@a17c6aahttps://github.com/basarat/TypeScript/commit/a17c6aaec3b25624111c3fcd8026b5af2340c471
current changeset is ready for an early review if anyone is interestedhttps://github.com/Microsoft/TypeScript/pull/3147/files
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/3147
https://github.com/basarat
test for node_modules resolutionhttps://github.com/microsoft/TypeScript/pull/3147/commits/07c9ea01b4384c78e81315119c50be251ed21032
07c9ea0https://github.com/microsoft/TypeScript/pull/3147/commits/07c9ea01b4384c78e81315119c50be251ed21032
https://github.com/basarat
Basarat Ali Syed (basarat)https://github.com/basarat
May 15, 2015https://github.com/microsoft/TypeScript/pull/3147#issuecomment-102370988
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/3147
https://github.com/MicahZoltu
Micah Zoltu (MicahZoltu)https://github.com/MicahZoltu
May 16, 2015https://github.com/microsoft/TypeScript/pull/3147#issuecomment-102569378
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/3147
https://github.com/basarat
Basarat Ali Syed (basarat)https://github.com/basarat
May 16, 2015https://github.com/microsoft/TypeScript/pull/3147#issuecomment-102570790
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/3147
https://github.com/basarat
Basarat Ali Syed (basarat)https://github.com/basarat
May 16, 2015 https://github.com/microsoft/TypeScript/pull/3147#ref-issue-60991541
External module resolution logic #2338 https://github.com/microsoft/TypeScript/issues/2338
https://github.com/poelstra
Martin Poelstra (poelstra)https://github.com/poelstra
May 19, 2015https://github.com/microsoft/TypeScript/pull/3147#issuecomment-103655413
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/3147
https://github.com/vladima
Vladimir Matveev (vladima)https://github.com/vladima
May 19, 2015https://github.com/microsoft/TypeScript/pull/3147#issuecomment-103674537
moduleResolution branchhttps://github.com/Microsoft/TypeScript/tree/moduleResolution
#2338https://github.com/microsoft/TypeScript/issues/2338
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/3147
https://github.com/vladima
Vladimir Matveev (vladima)https://github.com/vladima
May 19, 2015https://github.com/microsoft/TypeScript/pull/3147#event-308943104
https://github.com/basarat
Basarat Ali Syed (basarat)https://github.com/basarat
May 20, 2015 00:11https://github.com/microsoft/TypeScript/pull/3147#event-309035886
https://github.com/basarat
Basarat Ali Syed (basarat)https://github.com/basarat
May 20, 2015https://github.com/microsoft/TypeScript/pull/3147#issuecomment-103702632
Vladimir Matveev (@vladima)https://github.com/vladima
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/3147
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Jul 28, 2015 https://github.com/microsoft/TypeScript/pull/3147#ref-issue-60255156
Importing Typescript class from another npm library #2262 https://github.com/microsoft/TypeScript/issues/2262
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Aug 17, 2015 https://github.com/microsoft/TypeScript/pull/3147#ref-issue-38735235
Support looking for modules under node_modules when importing #247 https://github.com/microsoft/TypeScript/issues/247
Basarat Ali Syed (basarat)https://github.com/basarat
Aug 20, 2015 https://github.com/microsoft/TypeScript/pull/3147#ref-commit-1c82c69
https://github.com/basarat
chore(typescript) support node_modules lookup natively.https://github.com/TypeStrong/atom-typescript/commit/1c82c69bfd4c0aac654269b16d637d65ae1c575f
1c82c69https://github.com/TypeStrong/atom-typescript/commit/1c82c69bfd4c0aac654269b16d637d65ae1c575f
microsoft/TypeScript#3147https://github.com/microsoft/TypeScript/pull/3147
microsoft/TypeScript#4154https://github.com/microsoft/TypeScript/pull/4154
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Aug 31, 2015https://github.com/microsoft/TypeScript/pull/3147#issuecomment-136434780
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/3147
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Aug 31, 2015 https://github.com/microsoft/TypeScript/pull/3147#ref-pullrequest-83309600
External module resolution #3325 https://github.com/microsoft/TypeScript/pull/3325
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 19, 2018https://github.com/microsoft/TypeScript/pull/3147#event-1689598796
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F3147
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/3147
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/3147
https://github.com/basarat
https://github.com/DanielRosenwasser
https://github.com/vladima
https://github.com/MicahZoltu
https://github.com/poelstra
https://github.com/mhegazy
https://github.com/msftclas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.