| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:0d8b64df-4fd8-30a8-d525-8f5dfc98dabb |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E510:2E124E:BE1D6D:F3A7C3:6B00FF1A |
| html-safe-nonce | 5d456df7ef95a66a9b43b6bdd5c4945da42e3e5507b7dc1db1b992f373a6cb8b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNTEwOjJFMTI0RTpCRTFENkQ6RjNBN0MzOjZCMDBGRjFBIiwidmlzaXRvcl9pZCI6Ijg5ODE1MDY5MDM5MDU0NjgxODYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | a4e0d25caee47912d8d77a2b9502af3e9cda60c8f9ca9604554d3a103a66ed15 |
| hovercard-subject-tag | pull_request:228625451 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/microsoft/TypeScript/pull/28366/files |
| twitter:image | https://avatars.githubusercontent.com/u/1606997?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1606997?s=400&v=4 |
| og:image:alt | Fixes #28053
I decided to forgo addressing the plurals issue to avoid polluting Diagnostics.json with all the different permutations of the error messages. I believe that should ideally be handled... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/microsoft/TypeScript/pull/28366/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F28366%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F28366%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/28366/files |
| Reload | https://github.com/microsoft/TypeScript/pull/28366/files |
| Reload | https://github.com/microsoft/TypeScript/pull/28366/files |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests309 (309) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fmicrosoft%2FTypeScript%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript%2Fissues%2Fnew%2Fchoose |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| microsoft:master | https://github.com/microsoft/TypeScript/tree/master |
| pesca:fix-issue/28053 | https://github.com/pesca/TypeScript/tree/fix-issue/28053 |
|
Conversation
12
| https://github.com/microsoft/TypeScript/pull/28366 |
|
Commits
9
| https://github.com/microsoft/TypeScript/pull/28366/commits |
|
Checks
0
| https://github.com/microsoft/TypeScript/pull/28366/checks |
|
Files changed
| https://github.com/microsoft/TypeScript/pull/28366/files |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/28366/files |
|
Fix error message when type argument arity is wrong
| https://github.com/microsoft/TypeScript/pull/28366/files#top |
|
Show all changes
9 commits
| https://github.com/microsoft/TypeScript/pull/28366/files |
|
bbe1fac
Fix error message when type argument arity is wrong
pesca Nov 6, 2018
| https://github.com/microsoft/TypeScript/pull/28366/commits/bbe1faca3c46e490a489bb73f9c64d2d0055ca2e |
|
5d9c0f3
Merge branch 'master' into fix-issue/28053
pesca Nov 12, 2018
| https://github.com/microsoft/TypeScript/pull/28366/commits/5d9c0f374a025339c10218f1df710cd7c3504369 |
|
1720a73
Parenthesize 's' in plurals
pesca Nov 13, 2018
| https://github.com/microsoft/TypeScript/pull/28366/commits/1720a735827c9d26ac7040ca7138df21c5978237 |
|
12b2d85
Merge branch 'master' into fix-issue/28053
pesca Nov 13, 2018
| https://github.com/microsoft/TypeScript/pull/28366/commits/12b2d850101813db7457cf4de8f69c1bc27c2c0c |
|
0751d79
Update baseline
pesca Nov 13, 2018
| https://github.com/microsoft/TypeScript/pull/28366/commits/0751d7985f77e1e607bab204c65a0d2565884519 |
|
c12f9fc
Merge branch 'master' into fix-issue/28053
pesca Nov 14, 2018
| https://github.com/microsoft/TypeScript/pull/28366/commits/c12f9fc2544fc018debf6ececa56825c0aa419c1 |
|
ed3e1bf
Update baseline
pesca Nov 14, 2018
| https://github.com/microsoft/TypeScript/pull/28366/commits/ed3e1bfece4f080d0e11f52602ab4392144a492e |
|
097ac42
Use old error message
pesca Dec 11, 2018
| https://github.com/microsoft/TypeScript/pull/28366/commits/097ac42b2aa2a7881963dcf72f61ffdbe0aca656 |
|
688eabc
Revert parantheses
pesca Dec 11, 2018
| https://github.com/microsoft/TypeScript/pull/28366/commits/688eabca974251913103ee9ade17e5fec8f2d581 |
|
Clear filters
| https://github.com/microsoft/TypeScript/pull/28366/files |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/28366/files |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/28366/files |
|
checker.ts
| https://github.com/microsoft/TypeScript/pull/28366/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
|
diagnosticMessages.json
| https://github.com/microsoft/TypeScript/pull/28366/files#diff-fdf3f532dc2d3188ad1c05c8c9e064d0aa4143b8ba09b8f3313a0243f0a43eff |
|
functionTypeArgumentArityErrors.errors.txt
| https://github.com/microsoft/TypeScript/pull/28366/files#diff-b1f05ecc57169cb797549ecb408cfafc632f53c7ca7fd381b07e15bb2ac9ac5c |
|
functionTypeArgumentArityErrors.js
| https://github.com/microsoft/TypeScript/pull/28366/files#diff-31a8f07250f7146ad40d7c8d20b03d54fc055c7ab1312e9dde211a36dd9c2218 |
|
functionTypeArgumentArityErrors.symbols
| https://github.com/microsoft/TypeScript/pull/28366/files#diff-1a08f37d7ffa87467bc3b739c0dd9a4309dd1964c71ddfa342bd7589ef9c00c0 |
|
functionTypeArgumentArityErrors.types
| https://github.com/microsoft/TypeScript/pull/28366/files#diff-49013ad438f4132d2f5707697da44758518a137925938adb88514fac20324eec |
|
newMap.errors.txt
| https://github.com/microsoft/TypeScript/pull/28366/files#diff-4dce6e536b43d527ef65cc77e05c94a4018448ef0030642bc577ec9d5f21a7d5 |
|
overloadResolution.errors.txt
| https://github.com/microsoft/TypeScript/pull/28366/files#diff-af740c14dd8d631e29219725f472986d0c493f321534d002dab4859edebf746f |
|
overloadResolutionConstructors.errors.txt
| https://github.com/microsoft/TypeScript/pull/28366/files#diff-60310a948a3a0c7f1182ccacc4c00097f328485532894aaec05efd60d8ebb3f7 |
|
overloadsAndTypeArgumentArityErrors.errors.txt
| https://github.com/microsoft/TypeScript/pull/28366/files#diff-978ed09544090024ea6632dbd8402b2c706c8b14b2157408385828b725d5ab7a |
|
functionTypeArgumentArityErrors.ts
| https://github.com/microsoft/TypeScript/pull/28366/files#diff-4cf2583955e0e516dbb2f64b3a6e42080f5300c123e3dd906dccc0c5c986326a |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/28366/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
|
View file
| https://github.com/pesca/TypeScript/blob/688eabca974251913103ee9ade17e5fec8f2d581/src/compiler/checker.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/28366/{{ revealButtonHref }} |
|
| https://github.com/microsoft/TypeScript/pull/28366/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Dec 10, 2018 | https://github.com/microsoft/TypeScript/pull/28366/files#r240411239 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/28366/files |
| Philip Pesca (pesca) | https://github.com/pesca |
| Dec 11, 2018 | https://github.com/microsoft/TypeScript/pull/28366/files#r240480092 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/28366/files |
|
| https://github.com/microsoft/TypeScript/pull/28366/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| src/compiler/diagnosticMessages.json | https://github.com/microsoft/TypeScript/pull/28366/files#diff-fdf3f532dc2d3188ad1c05c8c9e064d0aa4143b8ba09b8f3313a0243f0a43eff |
|
View file
| https://github.com/pesca/TypeScript/blob/688eabca974251913103ee9ade17e5fec8f2d581/src/compiler/diagnosticMessages.json |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/28366/{{ revealButtonHref }} |
|
| https://github.com/microsoft/TypeScript/pull/28366/files#diff-fdf3f532dc2d3188ad1c05c8c9e064d0aa4143b8ba09b8f3313a0243f0a43eff |
|
| https://github.com/microsoft/TypeScript/pull/28366/files#diff-fdf3f532dc2d3188ad1c05c8c9e064d0aa4143b8ba09b8f3313a0243f0a43eff |
| tests/baselines/reference/functionTypeArgumentArityErrors.errors.txt | https://github.com/microsoft/TypeScript/pull/28366/files#diff-b1f05ecc57169cb797549ecb408cfafc632f53c7ca7fd381b07e15bb2ac9ac5c |
|
View file
| https://github.com/pesca/TypeScript/blob/688eabca974251913103ee9ade17e5fec8f2d581/tests/baselines/reference/functionTypeArgumentArityErrors.errors.txt |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/28366/{{ revealButtonHref }} |
| tests/baselines/reference/functionTypeArgumentArityErrors.js | https://github.com/microsoft/TypeScript/pull/28366/files#diff-31a8f07250f7146ad40d7c8d20b03d54fc055c7ab1312e9dde211a36dd9c2218 |
|
View file
| https://github.com/pesca/TypeScript/blob/688eabca974251913103ee9ade17e5fec8f2d581/tests/baselines/reference/functionTypeArgumentArityErrors.js |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/28366/{{ revealButtonHref }} |
| tests/baselines/reference/functionTypeArgumentArityErrors.symbols | https://github.com/microsoft/TypeScript/pull/28366/files#diff-1a08f37d7ffa87467bc3b739c0dd9a4309dd1964c71ddfa342bd7589ef9c00c0 |
|
View file
| https://github.com/pesca/TypeScript/blob/688eabca974251913103ee9ade17e5fec8f2d581/tests/baselines/reference/functionTypeArgumentArityErrors.symbols |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/28366/{{ revealButtonHref }} |
| tests/baselines/reference/functionTypeArgumentArityErrors.types | https://github.com/microsoft/TypeScript/pull/28366/files#diff-49013ad438f4132d2f5707697da44758518a137925938adb88514fac20324eec |
|
View file
| https://github.com/pesca/TypeScript/blob/688eabca974251913103ee9ade17e5fec8f2d581/tests/baselines/reference/functionTypeArgumentArityErrors.types |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/28366/{{ revealButtonHref }} |
| tests/baselines/reference/newMap.errors.txt | https://github.com/microsoft/TypeScript/pull/28366/files#diff-4dce6e536b43d527ef65cc77e05c94a4018448ef0030642bc577ec9d5f21a7d5 |
|
View file
| https://github.com/pesca/TypeScript/blob/688eabca974251913103ee9ade17e5fec8f2d581/tests/baselines/reference/newMap.errors.txt |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/28366/{{ revealButtonHref }} |
| tests/baselines/reference/overloadResolution.errors.txt | https://github.com/microsoft/TypeScript/pull/28366/files#diff-af740c14dd8d631e29219725f472986d0c493f321534d002dab4859edebf746f |
|
View file
| https://github.com/pesca/TypeScript/blob/688eabca974251913103ee9ade17e5fec8f2d581/tests/baselines/reference/overloadResolution.errors.txt |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/28366/{{ revealButtonHref }} |
|
| https://github.com/microsoft/TypeScript/pull/28366/files#diff-af740c14dd8d631e29219725f472986d0c493f321534d002dab4859edebf746f |
|
| https://github.com/microsoft/TypeScript/pull/28366/files#diff-af740c14dd8d631e29219725f472986d0c493f321534d002dab4859edebf746f |
|
| https://github.com/microsoft/TypeScript/pull/28366/files#diff-af740c14dd8d631e29219725f472986d0c493f321534d002dab4859edebf746f |
| tests/baselines/reference/overloadResolutionConstructors.errors.txt | https://github.com/microsoft/TypeScript/pull/28366/files#diff-60310a948a3a0c7f1182ccacc4c00097f328485532894aaec05efd60d8ebb3f7 |
|
View file
| https://github.com/pesca/TypeScript/blob/688eabca974251913103ee9ade17e5fec8f2d581/tests/baselines/reference/overloadResolutionConstructors.errors.txt |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/28366/{{ revealButtonHref }} |
|
| https://github.com/microsoft/TypeScript/pull/28366/files#diff-60310a948a3a0c7f1182ccacc4c00097f328485532894aaec05efd60d8ebb3f7 |
|
| https://github.com/microsoft/TypeScript/pull/28366/files#diff-60310a948a3a0c7f1182ccacc4c00097f328485532894aaec05efd60d8ebb3f7 |
|
| https://github.com/microsoft/TypeScript/pull/28366/files#diff-60310a948a3a0c7f1182ccacc4c00097f328485532894aaec05efd60d8ebb3f7 |
| tests/baselines/reference/overloadsAndTypeArgumentArityErrors.errors.txt | https://github.com/microsoft/TypeScript/pull/28366/files#diff-978ed09544090024ea6632dbd8402b2c706c8b14b2157408385828b725d5ab7a |
|
View file
| https://github.com/pesca/TypeScript/blob/688eabca974251913103ee9ade17e5fec8f2d581/tests/baselines/reference/overloadsAndTypeArgumentArityErrors.errors.txt |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/28366/{{ revealButtonHref }} |
|
| https://github.com/microsoft/TypeScript/pull/28366/files#diff-978ed09544090024ea6632dbd8402b2c706c8b14b2157408385828b725d5ab7a |
|
| https://github.com/microsoft/TypeScript/pull/28366/files#diff-978ed09544090024ea6632dbd8402b2c706c8b14b2157408385828b725d5ab7a |
| tests/cases/compiler/functionTypeArgumentArityErrors.ts | https://github.com/microsoft/TypeScript/pull/28366/files#diff-4cf2583955e0e516dbb2f64b3a6e42080f5300c123e3dd906dccc0c5c986326a |
|
View file
| https://github.com/pesca/TypeScript/blob/688eabca974251913103ee9ade17e5fec8f2d581/tests/cases/compiler/functionTypeArgumentArityErrors.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/28366/{{ revealButtonHref }} |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |