René's URL Explorer Experiment


Title: Fix error message when type argument arity is wrong by pesca · Pull Request #28366 · microsoft/TypeScript · GitHub

Open Graph Title: Fix error message when type argument arity is wrong by pesca · Pull Request #28366 · microsoft/TypeScript

X Title: Fix error message when type argument arity is wrong by pesca · Pull Request #28366 · microsoft/TypeScript

Description: Fixes #28053 I decided to forgo addressing the plurals issue to avoid polluting Diagnostics.json with all the different permutations of the error messages. I believe that should ideally be handled in the "diagnostic emitter". Generic functions with no overloads are handled as a special case and uses the old error message.

Open Graph Description: Fixes #28053 I decided to forgo addressing the plurals issue to avoid polluting Diagnostics.json with all the different permutations of the error messages. I believe that should ideally be handled...

X Description: Fixes #28053 I decided to forgo addressing the plurals issue to avoid polluting Diagnostics.json with all the different permutations of the error messages. I believe that should ideally be handled...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/28366

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0d8b64df-4fd8-30a8-d525-8f5dfc98dabb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE510:2E124E:BE1D6D:F3A7C3:6B00FF1A
html-safe-nonce5d456df7ef95a66a9b43b6bdd5c4945da42e3e5507b7dc1db1b992f373a6cb8b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNTEwOjJFMTI0RTpCRTFENkQ6RjNBN0MzOjZCMDBGRjFBIiwidmlzaXRvcl9pZCI6Ijg5ODE1MDY5MDM5MDU0NjgxODYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca4e0d25caee47912d8d77a2b9502af3e9cda60c8f9ca9604554d3a103a66ed15
hovercard-subject-tagpull_request:228625451
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/microsoft/TypeScript/pull/28366/files
twitter:imagehttps://avatars.githubusercontent.com/u/1606997?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1606997?s=400&v=4
og:image:altFixes #28053 I decided to forgo addressing the plurals issue to avoid polluting Diagnostics.json with all the different permutations of the error messages. I believe that should ideally be handled...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/28366/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F28366%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F28366%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/28366/files
Reloadhttps://github.com/microsoft/TypeScript/pull/28366/files
Reloadhttps://github.com/microsoft/TypeScript/pull/28366/files
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fmicrosoft%2FTypeScript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmicrosoft%2FTypeScript%2Fissues%2Fnew%2Fchoose
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
pesca:fix-issue/28053https://github.com/pesca/TypeScript/tree/fix-issue/28053
Conversation 12 https://github.com/microsoft/TypeScript/pull/28366
Commits 9 https://github.com/microsoft/TypeScript/pull/28366/commits
Checks 0 https://github.com/microsoft/TypeScript/pull/28366/checks
Files changed https://github.com/microsoft/TypeScript/pull/28366/files
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/28366/files
Fix error message when type argument arity is wrong https://github.com/microsoft/TypeScript/pull/28366/files#top
Show all changes 9 commits https://github.com/microsoft/TypeScript/pull/28366/files
bbe1fac Fix error message when type argument arity is wrong pesca Nov 6, 2018 https://github.com/microsoft/TypeScript/pull/28366/commits/bbe1faca3c46e490a489bb73f9c64d2d0055ca2e
5d9c0f3 Merge branch 'master' into fix-issue/28053 pesca Nov 12, 2018 https://github.com/microsoft/TypeScript/pull/28366/commits/5d9c0f374a025339c10218f1df710cd7c3504369
1720a73 Parenthesize 's' in plurals pesca Nov 13, 2018 https://github.com/microsoft/TypeScript/pull/28366/commits/1720a735827c9d26ac7040ca7138df21c5978237
12b2d85 Merge branch 'master' into fix-issue/28053 pesca Nov 13, 2018 https://github.com/microsoft/TypeScript/pull/28366/commits/12b2d850101813db7457cf4de8f69c1bc27c2c0c
0751d79 Update baseline pesca Nov 13, 2018 https://github.com/microsoft/TypeScript/pull/28366/commits/0751d7985f77e1e607bab204c65a0d2565884519
c12f9fc Merge branch 'master' into fix-issue/28053 pesca Nov 14, 2018 https://github.com/microsoft/TypeScript/pull/28366/commits/c12f9fc2544fc018debf6ececa56825c0aa419c1
ed3e1bf Update baseline pesca Nov 14, 2018 https://github.com/microsoft/TypeScript/pull/28366/commits/ed3e1bfece4f080d0e11f52602ab4392144a492e
097ac42 Use old error message pesca Dec 11, 2018 https://github.com/microsoft/TypeScript/pull/28366/commits/097ac42b2aa2a7881963dcf72f61ffdbe0aca656
688eabc Revert parantheses pesca Dec 11, 2018 https://github.com/microsoft/TypeScript/pull/28366/commits/688eabca974251913103ee9ade17e5fec8f2d581
Clear filters https://github.com/microsoft/TypeScript/pull/28366/files
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/28366/files
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/28366/files
checker.ts https://github.com/microsoft/TypeScript/pull/28366/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
diagnosticMessages.json https://github.com/microsoft/TypeScript/pull/28366/files#diff-fdf3f532dc2d3188ad1c05c8c9e064d0aa4143b8ba09b8f3313a0243f0a43eff
functionTypeArgumentArityErrors.errors.txt https://github.com/microsoft/TypeScript/pull/28366/files#diff-b1f05ecc57169cb797549ecb408cfafc632f53c7ca7fd381b07e15bb2ac9ac5c
functionTypeArgumentArityErrors.js https://github.com/microsoft/TypeScript/pull/28366/files#diff-31a8f07250f7146ad40d7c8d20b03d54fc055c7ab1312e9dde211a36dd9c2218
functionTypeArgumentArityErrors.symbols https://github.com/microsoft/TypeScript/pull/28366/files#diff-1a08f37d7ffa87467bc3b739c0dd9a4309dd1964c71ddfa342bd7589ef9c00c0
functionTypeArgumentArityErrors.types https://github.com/microsoft/TypeScript/pull/28366/files#diff-49013ad438f4132d2f5707697da44758518a137925938adb88514fac20324eec
newMap.errors.txt https://github.com/microsoft/TypeScript/pull/28366/files#diff-4dce6e536b43d527ef65cc77e05c94a4018448ef0030642bc577ec9d5f21a7d5
overloadResolution.errors.txt https://github.com/microsoft/TypeScript/pull/28366/files#diff-af740c14dd8d631e29219725f472986d0c493f321534d002dab4859edebf746f
overloadResolutionConstructors.errors.txt https://github.com/microsoft/TypeScript/pull/28366/files#diff-60310a948a3a0c7f1182ccacc4c00097f328485532894aaec05efd60d8ebb3f7
overloadsAndTypeArgumentArityErrors.errors.txt https://github.com/microsoft/TypeScript/pull/28366/files#diff-978ed09544090024ea6632dbd8402b2c706c8b14b2157408385828b725d5ab7a
functionTypeArgumentArityErrors.ts https://github.com/microsoft/TypeScript/pull/28366/files#diff-4cf2583955e0e516dbb2f64b3a6e42080f5300c123e3dd906dccc0c5c986326a
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/28366/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
View file https://github.com/pesca/TypeScript/blob/688eabca974251913103ee9ade17e5fec8f2d581/src/compiler/checker.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/28366/{{ revealButtonHref }}
https://github.com/microsoft/TypeScript/pull/28366/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Dec 10, 2018https://github.com/microsoft/TypeScript/pull/28366/files#r240411239
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/28366/files
Philip Pesca (pesca)https://github.com/pesca
Dec 11, 2018https://github.com/microsoft/TypeScript/pull/28366/files#r240480092
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/28366/files
https://github.com/microsoft/TypeScript/pull/28366/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
src/compiler/diagnosticMessages.jsonhttps://github.com/microsoft/TypeScript/pull/28366/files#diff-fdf3f532dc2d3188ad1c05c8c9e064d0aa4143b8ba09b8f3313a0243f0a43eff
View file https://github.com/pesca/TypeScript/blob/688eabca974251913103ee9ade17e5fec8f2d581/src/compiler/diagnosticMessages.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/28366/{{ revealButtonHref }}
https://github.com/microsoft/TypeScript/pull/28366/files#diff-fdf3f532dc2d3188ad1c05c8c9e064d0aa4143b8ba09b8f3313a0243f0a43eff
https://github.com/microsoft/TypeScript/pull/28366/files#diff-fdf3f532dc2d3188ad1c05c8c9e064d0aa4143b8ba09b8f3313a0243f0a43eff
tests/baselines/reference/functionTypeArgumentArityErrors.errors.txthttps://github.com/microsoft/TypeScript/pull/28366/files#diff-b1f05ecc57169cb797549ecb408cfafc632f53c7ca7fd381b07e15bb2ac9ac5c
View file https://github.com/pesca/TypeScript/blob/688eabca974251913103ee9ade17e5fec8f2d581/tests/baselines/reference/functionTypeArgumentArityErrors.errors.txt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/28366/{{ revealButtonHref }}
tests/baselines/reference/functionTypeArgumentArityErrors.jshttps://github.com/microsoft/TypeScript/pull/28366/files#diff-31a8f07250f7146ad40d7c8d20b03d54fc055c7ab1312e9dde211a36dd9c2218
View file https://github.com/pesca/TypeScript/blob/688eabca974251913103ee9ade17e5fec8f2d581/tests/baselines/reference/functionTypeArgumentArityErrors.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/28366/{{ revealButtonHref }}
tests/baselines/reference/functionTypeArgumentArityErrors.symbolshttps://github.com/microsoft/TypeScript/pull/28366/files#diff-1a08f37d7ffa87467bc3b739c0dd9a4309dd1964c71ddfa342bd7589ef9c00c0
View file https://github.com/pesca/TypeScript/blob/688eabca974251913103ee9ade17e5fec8f2d581/tests/baselines/reference/functionTypeArgumentArityErrors.symbols
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/28366/{{ revealButtonHref }}
tests/baselines/reference/functionTypeArgumentArityErrors.typeshttps://github.com/microsoft/TypeScript/pull/28366/files#diff-49013ad438f4132d2f5707697da44758518a137925938adb88514fac20324eec
View file https://github.com/pesca/TypeScript/blob/688eabca974251913103ee9ade17e5fec8f2d581/tests/baselines/reference/functionTypeArgumentArityErrors.types
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/28366/{{ revealButtonHref }}
tests/baselines/reference/newMap.errors.txthttps://github.com/microsoft/TypeScript/pull/28366/files#diff-4dce6e536b43d527ef65cc77e05c94a4018448ef0030642bc577ec9d5f21a7d5
View file https://github.com/pesca/TypeScript/blob/688eabca974251913103ee9ade17e5fec8f2d581/tests/baselines/reference/newMap.errors.txt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/28366/{{ revealButtonHref }}
tests/baselines/reference/overloadResolution.errors.txthttps://github.com/microsoft/TypeScript/pull/28366/files#diff-af740c14dd8d631e29219725f472986d0c493f321534d002dab4859edebf746f
View file https://github.com/pesca/TypeScript/blob/688eabca974251913103ee9ade17e5fec8f2d581/tests/baselines/reference/overloadResolution.errors.txt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/28366/{{ revealButtonHref }}
https://github.com/microsoft/TypeScript/pull/28366/files#diff-af740c14dd8d631e29219725f472986d0c493f321534d002dab4859edebf746f
https://github.com/microsoft/TypeScript/pull/28366/files#diff-af740c14dd8d631e29219725f472986d0c493f321534d002dab4859edebf746f
https://github.com/microsoft/TypeScript/pull/28366/files#diff-af740c14dd8d631e29219725f472986d0c493f321534d002dab4859edebf746f
tests/baselines/reference/overloadResolutionConstructors.errors.txthttps://github.com/microsoft/TypeScript/pull/28366/files#diff-60310a948a3a0c7f1182ccacc4c00097f328485532894aaec05efd60d8ebb3f7
View file https://github.com/pesca/TypeScript/blob/688eabca974251913103ee9ade17e5fec8f2d581/tests/baselines/reference/overloadResolutionConstructors.errors.txt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/28366/{{ revealButtonHref }}
https://github.com/microsoft/TypeScript/pull/28366/files#diff-60310a948a3a0c7f1182ccacc4c00097f328485532894aaec05efd60d8ebb3f7
https://github.com/microsoft/TypeScript/pull/28366/files#diff-60310a948a3a0c7f1182ccacc4c00097f328485532894aaec05efd60d8ebb3f7
https://github.com/microsoft/TypeScript/pull/28366/files#diff-60310a948a3a0c7f1182ccacc4c00097f328485532894aaec05efd60d8ebb3f7
tests/baselines/reference/overloadsAndTypeArgumentArityErrors.errors.txthttps://github.com/microsoft/TypeScript/pull/28366/files#diff-978ed09544090024ea6632dbd8402b2c706c8b14b2157408385828b725d5ab7a
View file https://github.com/pesca/TypeScript/blob/688eabca974251913103ee9ade17e5fec8f2d581/tests/baselines/reference/overloadsAndTypeArgumentArityErrors.errors.txt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/28366/{{ revealButtonHref }}
https://github.com/microsoft/TypeScript/pull/28366/files#diff-978ed09544090024ea6632dbd8402b2c706c8b14b2157408385828b725d5ab7a
https://github.com/microsoft/TypeScript/pull/28366/files#diff-978ed09544090024ea6632dbd8402b2c706c8b14b2157408385828b725d5ab7a
tests/cases/compiler/functionTypeArgumentArityErrors.tshttps://github.com/microsoft/TypeScript/pull/28366/files#diff-4cf2583955e0e516dbb2f64b3a6e42080f5300c123e3dd906dccc0c5c986326a
View file https://github.com/pesca/TypeScript/blob/688eabca974251913103ee9ade17e5fec8f2d581/tests/cases/compiler/functionTypeArgumentArityErrors.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/28366/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.