| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:8d9e93ef-a8d6-821d-eca4-c742e473a651 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A4F8:1EC9BC:16E9A8:1DFE4C:6B00C975 |
| html-safe-nonce | a4be538e6ac7ebc5236f96c7e2f6bab22508cc019733a0eac7c26b5df574a72a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNEY4OjFFQzlCQzoxNkU5QTg6MURGRTRDOjZCMDBDOTc1IiwidmlzaXRvcl9pZCI6IjMyMTE5MjU5ODkxMzEwNzgwMDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | c37ad8b96785f957cb289497f819c4860afe4aba7c68a23c6a1e44519ab687b1 |
| hovercard-subject-tag | pull_request:227448222 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/28270/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7fc795c94a6dac8b81bfceea6688eb8b1de91f8490b2e136dcdf9ee2132231db/microsoft/TypeScript/pull/28270 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7fc795c94a6dac8b81bfceea6688eb8b1de91f8490b2e136dcdf9ee2132231db/microsoft/TypeScript/pull/28270 |
| og:image:alt | Fixes #6955
I made a few comments in that issue about being unclear about how the whole PR process works,
And it seems I broke 5 tests,
I assume it's because they are expecting the previous ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | AnyhowStep |
| hostname | github.com |
| expected-hostname | github.com |
| None | 98dc00e171c204462a6f367482a0f8c3c6b5dbca99cd7390e82d2df49ce096e4 |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ef013399cf0a3c324bea644a685d7c1e0f06b5b7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/28270#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F28270 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F28270 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/28270 |
| Reload | https://github.com/microsoft/TypeScript/pull/28270 |
| Reload | https://github.com/microsoft/TypeScript/pull/28270 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests307 (307) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Ryan Cavanaugh (RyanCavanaugh) | https://github.com/RyanCavanaugh |
| microsoft:master | https://github.com/microsoft/TypeScript/tree/master |
| AnyhowStep:json-parse-reviver-stringify-replacer-better-declaration | https://github.com/AnyhowStep/TypeScript/tree/json-parse-reviver-stringify-replacer-better-declaration |
| Conversation | https://github.com/microsoft/TypeScript/pull/28270 |
| Commits3 (3) | https://github.com/microsoft/TypeScript/pull/28270/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/28270/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/28270/files |
| JSON.parse(), JSON.stringify() more specific declarations for #6955 | https://github.com/microsoft/TypeScript/pull/28270#top |
| Ryan Cavanaugh (RyanCavanaugh) | https://github.com/RyanCavanaugh |
| microsoft:master | https://github.com/microsoft/TypeScript/tree/master |
| AnyhowStep:json-parse-reviver-stringify-replacer-better-declaration | https://github.com/AnyhowStep/TypeScript/tree/json-parse-reviver-stringify-replacer-better-declaration |
|
| https://github.com/AnyhowStep |
| AnyhowStep | https://github.com/AnyhowStep |
| Oct 31, 2018 | https://github.com/microsoft/TypeScript/pull/28270#issue-376168027 |
| #6955 | https://github.com/microsoft/TypeScript/issues/6955 |
| https://user-images.githubusercontent.com/5655961/47819565-48d73700-dd31-11e8-96cd-8f70bf7498fd.png |
| https://user-images.githubusercontent.com/5655961/47819878-2a257000-dd32-11e8-96ce-6382a0596fda.png |
| https://user-images.githubusercontent.com/5655961/47819859-1e39ae00-dd32-11e8-95d0-9b382616be4f.png |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/28270 |
| AnyhowStep | https://github.com/AnyhowStep |
| October 31, 2018 17:00 | https://github.com/microsoft/TypeScript/pull/28270#commits-pushed-01e7182 |
|
| https://github.com/AnyhowStep |
| Fixes | https://github.com/microsoft/TypeScript/pull/28270/commits/01e71820fc62bcc31987f4a8912ed3fd023bd1dd |
| microsoft#6955 | https://github.com/microsoft/TypeScript/issues/6955 |
| 01e7182 | https://github.com/microsoft/TypeScript/pull/28270/commits/01e71820fc62bcc31987f4a8912ed3fd023bd1dd |
|
| https://github.com/AnyhowStep |
| Update baselines | https://github.com/microsoft/TypeScript/pull/28270/commits/e3ee7ae997f4cf4b1aa9e724739078d467f0a3fb |
| e3ee7ae | https://github.com/microsoft/TypeScript/pull/28270/commits/e3ee7ae997f4cf4b1aa9e724739078d467f0a3fb |
| https://github.com/msftclas |
| Microsoft Contribution License Agreements (msftclas) | https://github.com/msftclas |
| Oct 31, 2018 | https://github.com/microsoft/TypeScript/pull/28270#issuecomment-434854780 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/28270 |
| https://cla.opensource.microsoft.com/Microsoft/TypeScript?pullRequest=28270 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/28270 |
| https://github.com/AnyhowStep |
| AnyhowStep | https://github.com/AnyhowStep |
| Nov 1, 2018 | https://github.com/microsoft/TypeScript/pull/28270#event-1940772740 |
| https://github.com/sheetalkamat |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| November 2, 2018 19:24 | https://github.com/microsoft/TypeScript/pull/28270#event-1943733476 |
| https://github.com/dalen |
| Erik Dalén (dalen) | https://github.com/dalen |
| Nov 8, 2018 | https://github.com/microsoft/TypeScript/pull/28270#issuecomment-437126981 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/28270 |
| https://github.com/AnyhowStep |
| AnyhowStep | https://github.com/AnyhowStep |
| Nov 8, 2018 | https://github.com/microsoft/TypeScript/pull/28270#issuecomment-437172424 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/28270 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/28270 |
| https://github.com/DanielRosenwasser |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
|
Nov 12, 2018
| https://github.com/microsoft/TypeScript/pull/28270#pullrequestreview-174131424 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/28270/files/e3ee7ae997f4cf4b1aa9e724739078d467f0a3fb |
| lib/lib.es5.d.ts | https://github.com/microsoft/TypeScript/pull/28270/files/e3ee7ae997f4cf4b1aa9e724739078d467f0a3fb#diff-4543c62dcf560451d352906704dcf2c1d53af354414ade9d50b92f25f74e637e |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Nov 12, 2018 | https://github.com/microsoft/TypeScript/pull/28270#discussion_r232842706 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/28270 |
|
| https://github.com/AnyhowStep |
| Removed stray whitespace | https://github.com/microsoft/TypeScript/pull/28270/commits/dd3ed0286885ff6e6dc0f8211f9281667387cf90 |
|
| https://github.com/microsoft/TypeScript/commit/dd3ed0286885ff6e6dc0f8211f9281667387cf90#comments |
| dd3ed02 | https://github.com/microsoft/TypeScript/pull/28270/commits/dd3ed0286885ff6e6dc0f8211f9281667387cf90 |
| https://github.com/sheetalkamat |
| Sheetal Nandi (sheetalkamat) | https://github.com/sheetalkamat |
|
Nov 13, 2018
| https://github.com/microsoft/TypeScript/pull/28270#pullrequestreview-174497304 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/28270/files/dd3ed0286885ff6e6dc0f8211f9281667387cf90 |
| https://github.com/ikokostya |
| ikokostya | https://github.com/ikokostya |
|
Nov 21, 2018
| https://github.com/microsoft/TypeScript/pull/28270#ref-issue-383056712 |
|
JSON.stringify() type does not include this type for replacer function
#28632
| https://github.com/microsoft/TypeScript/issues/28632 |
| https://github.com/RyanCavanaugh |
| Ryan Cavanaugh (RyanCavanaugh) | https://github.com/RyanCavanaugh |
| Jan 24, 2019 | https://github.com/microsoft/TypeScript/pull/28270#event-2095937852 |
| https://github.com/RyanCavanaugh |
| Ryan Cavanaugh (RyanCavanaugh) | https://github.com/RyanCavanaugh |
|
Jan 24, 2019
| https://github.com/microsoft/TypeScript/pull/28270#pullrequestreview-196303819 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/28270/files/dd3ed0286885ff6e6dc0f8211f9281667387cf90 |
| Ryan Cavanaugh (RyanCavanaugh) | https://github.com/RyanCavanaugh |
| https://github.com/microsoft/TypeScript/pull/28270#pullrequestreview-196303819 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/28270 |
| https://github.com/RyanCavanaugh |
| Ryan Cavanaugh (RyanCavanaugh) | https://github.com/RyanCavanaugh |
| Feb 1, 2019 | https://github.com/microsoft/TypeScript/pull/28270#issuecomment-459881856 |
| TypeScript Bot (@typescript-bot) | https://github.com/typescript-bot |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/28270 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Feb 1, 2019 | https://github.com/microsoft/TypeScript/pull/28270#issuecomment-459881871 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/28270 |
| Ryan Cavanaugh (@RyanCavanaugh) | https://github.com/RyanCavanaugh |
| dd3ed02 | https://github.com/microsoft/TypeScript/commit/dd3ed0286885ff6e6dc0f8211f9281667387cf90 |
| here | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=21850 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/28270 |
| https://github.com/RyanCavanaugh |
| Ryan Cavanaugh (RyanCavanaugh) | https://github.com/RyanCavanaugh |
| Feb 2, 2019 | https://github.com/microsoft/TypeScript/pull/28270#issuecomment-459995544 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/28270 |
| https://github.com/RyanCavanaugh |
| Ryan Cavanaugh (RyanCavanaugh) | https://github.com/RyanCavanaugh |
| 0a041ee | https://github.com/microsoft/TypeScript/commit/0a041ee53641ea1916a9f15ad9cd57368d1dc1af |
| Feb 2, 2019 | https://github.com/microsoft/TypeScript/pull/28270#event-2113999638 |
| https://github.com/jack-williams |
| Jack Williams (jack-williams) | https://github.com/jack-williams |
|
Feb 3, 2019
| https://github.com/microsoft/TypeScript/pull/28270#ref-pullrequest-406107069 |
|
Fix build break: Update baselines for types affected by JSON change
#29712
| https://github.com/microsoft/TypeScript/pull/29712 |
| https://github.com/j-oliveras |
| Jordi Oliveras Rovira (j-oliveras) | https://github.com/j-oliveras |
|
Feb 4, 2019
| https://github.com/microsoft/TypeScript/pull/28270#ref-pullrequest-406353498 |
|
🤖 User test baselines have changed
#29727
| https://github.com/microsoft/TypeScript/pull/29727 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Oct 21, 2025 | https://github.com/microsoft/TypeScript/pull/28270#event-20415837895 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F28270 |
|
| https://github.com/DanielRosenwasser |
|
Daniel Rosenwasser (DanielRosenwasser)
| https://github.com/DanielRosenwasser |
|
| https://github.com/microsoft/TypeScript/pull/28270/files/e3ee7ae997f4cf4b1aa9e724739078d467f0a3fb |
|
| https://github.com/RyanCavanaugh |
|
Ryan Cavanaugh (RyanCavanaugh)
| https://github.com/RyanCavanaugh |
|
| https://github.com/microsoft/TypeScript/pull/28270/files/dd3ed0286885ff6e6dc0f8211f9281667387cf90 |
|
| https://github.com/sheetalkamat |
|
Sheetal Nandi (sheetalkamat)
| https://github.com/sheetalkamat |
|
| https://github.com/microsoft/TypeScript/pull/28270/files/dd3ed0286885ff6e6dc0f8211f9281667387cf90 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/28270 |
|
| https://github.com/RyanCavanaugh |
|
Ryan Cavanaugh (RyanCavanaugh)
| https://github.com/RyanCavanaugh |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/28270 |
|
| https://github.com/AnyhowStep |
|
| https://github.com/msftclas |
|
| https://github.com/dalen |
|
| https://github.com/RyanCavanaugh |
|
| https://github.com/typescript-bot |
|
| https://github.com/DanielRosenwasser |
|
| https://github.com/sheetalkamat |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |