René's URL Explorer Experiment


Title: Fix performance regression when reusing old state by ajafff · Pull Request #28028 · microsoft/TypeScript · GitHub

Open Graph Title: Fix performance regression when reusing old state by ajafff · Pull Request #28028 · microsoft/TypeScript

X Title: Fix performance regression when reusing old state by ajafff · Pull Request #28028 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Fix performance regression when reusing old state by ajafff · Pull Request #28028 · microsoft/TypeScript

Open Graph Description: Fixes: #28025 This (hopefully) fixes the performance regression reported in #28025. moduleNameResolvesToAmbientModuleInNonModifiedFile may be executed for each import (or type reference directive) ...

X Description: Fixes: #28025 This (hopefully) fixes the performance regression reported in #28025. moduleNameResolvesToAmbientModuleInNonModifiedFile may be executed for each import (or type reference directive) ...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/28028

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8ac0eaed-e930-051e-0ad4-4aaf3bc4f5a1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAC78:14700E:154853F:1AFEF82:6B012DB9
html-safe-noncea129ad46c3b4aff9a1b73eb6b703ea86dcd20257a3d7793ce50fd8e22e164212
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzc4OjE0NzAwRToxNTQ4NTNGOjFBRkVGODI6NkIwMTJEQjkiLCJ2aXNpdG9yX2lkIjoiMjA1MDg5NjI1MDk2NjYyNDU3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac6740980ee47f8b5d8fd4dbf73385984910fe62edeea5b835f3cfd8045a9e3099
hovercard-subject-tagpull_request:224552623
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/28028/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f90731b3b649c572867dcbbeb1ee76d4a3dc8a187bf65febc8c417f6d3a0e143/microsoft/TypeScript/pull/28028
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f90731b3b649c572867dcbbeb1ee76d4a3dc8a187bf65febc8c417f6d3a0e143/microsoft/TypeScript/pull/28028
og:image:altFixes: #28025 This (hopefully) fixes the performance regression reported in #28025. moduleNameResolvesToAmbientModuleInNonModifiedFile may be executed for each import (or type reference directive) ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameajafff
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/28028#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F28028
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F28028
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/28028
Reloadhttps://github.com/microsoft/TypeScript/pull/28028
Reloadhttps://github.com/microsoft/TypeScript/pull/28028
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests311 (311)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
ajafff:optimize-resolve-reusing-old-statehttps://github.com/ajafff/TypeScript/tree/optimize-resolve-reusing-old-state
Conversationhttps://github.com/microsoft/TypeScript/pull/28028
Commits2 (2)https://github.com/microsoft/TypeScript/pull/28028/commits
Checkshttps://github.com/microsoft/TypeScript/pull/28028/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/28028/files
Fix performance regression when reusing old statehttps://github.com/microsoft/TypeScript/pull/28028#top
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
ajafff:optimize-resolve-reusing-old-statehttps://github.com/ajafff/TypeScript/tree/optimize-resolve-reusing-old-state
https://github.com/ajafff
Klaus Meinhardt (ajafff)https://github.com/ajafff
Oct 21, 2018https://github.com/microsoft/TypeScript/pull/28028#issue-372331993
#28025https://github.com/microsoft/TypeScript/issues/28025
#28025https://github.com/microsoft/TypeScript/issues/28025
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/28028
https://github.com/ajafff
Fix performance regression when reusing old statehttps://github.com/microsoft/TypeScript/pull/28028/commits/ea0c7eb3ce23cec6f60dcf4b4c0af208e61ba29a
ea0c7ebhttps://github.com/microsoft/TypeScript/pull/28028/commits/ea0c7eb3ce23cec6f60dcf4b4c0af208e61ba29a
microsoft#28025https://github.com/microsoft/TypeScript/issues/28025
https://github.com/ajafff
Klaus Meinhardt (ajafff)https://github.com/ajafff
Oct 21, 2018 https://github.com/microsoft/TypeScript/pull/28028#ref-issue-372315717
Building performance is slowdown #28025 https://github.com/microsoft/TypeScript/issues/28025
https://github.com/ajafff
Klaus Meinhardt (ajafff)https://github.com/ajafff
Oct 21, 2018 https://github.com/microsoft/TypeScript/pull/28028#pullrequestreview-166791845
View reviewed changes https://github.com/microsoft/TypeScript/pull/28028/files/ea0c7eb3ce23cec6f60dcf4b4c0af208e61ba29a
src/compiler/program.tshttps://github.com/microsoft/TypeScript/pull/28028/files/ea0c7eb3ce23cec6f60dcf4b4c0af208e61ba29a#diff-dbfa0e7f632eca196a5ee0e08e00743c46c03799e2704206cfccc065bb6f9e3a
Klaus Meinhardt (ajafff)https://github.com/ajafff
Oct 21, 2018https://github.com/microsoft/TypeScript/pull/28028#discussion_r226869162
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/28028
https://github.com/ajafff
use Map instead of Arrayhttps://github.com/microsoft/TypeScript/pull/28028/commits/63a8cb6933d9a78dde7f5e5df7b01417a812968c
63a8cb6https://github.com/microsoft/TypeScript/pull/28028/commits/63a8cb6933d9a78dde7f5e5df7b01417a812968c
https://github.com/ajafff
Klaus Meinhardt (ajafff)https://github.com/ajafff
Oct 21, 2018https://github.com/microsoft/TypeScript/pull/28028#issuecomment-431690103
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/28028
https://github.com/thekiba
Reactive Fox (thekiba)https://github.com/thekiba
Oct 22, 2018https://github.com/microsoft/TypeScript/pull/28028#issuecomment-431805937
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/28028
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/28028
https://github.com/obenjiro
Alexey Okhrimenko (obenjiro)https://github.com/obenjiro
Oct 22, 2018https://github.com/microsoft/TypeScript/pull/28028#issuecomment-431819425
Ryan Cavanaugh (@RyanCavanaugh)https://github.com/RyanCavanaugh
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/28028
https://github.com/ajafff
Klaus Meinhardt (ajafff)https://github.com/ajafff
Oct 22, 2018https://github.com/microsoft/TypeScript/pull/28028#issuecomment-431842771
Reactive Fox (@thekiba)https://github.com/thekiba
Sheetal Nandi (@sheetalkamat)https://github.com/sheetalkamat
Ryan Cavanaugh (@RyanCavanaugh)https://github.com/RyanCavanaugh
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/28028
https://github.com/sheetalkamat
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
Oct 22, 2018 https://github.com/microsoft/TypeScript/pull/28028#pullrequestreview-167006040
View reviewed changes https://github.com/microsoft/TypeScript/pull/28028/files/63a8cb6933d9a78dde7f5e5df7b01417a812968c
src/compiler/program.tshttps://github.com/microsoft/TypeScript/pull/28028/files/63a8cb6933d9a78dde7f5e5df7b01417a812968c#diff-dbfa0e7f632eca196a5ee0e08e00743c46c03799e2704206cfccc065bb6f9e3a
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
Oct 22, 2018https://github.com/microsoft/TypeScript/pull/28028#discussion_r227051710
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/28028
Klaus Meinhardt (ajafff)https://github.com/ajafff
Oct 22, 2018https://github.com/microsoft/TypeScript/pull/28028#discussion_r227063544
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/28028
src/compiler/program.tshttps://github.com/microsoft/TypeScript/pull/28028/files/63a8cb6933d9a78dde7f5e5df7b01417a812968c#diff-dbfa0e7f632eca196a5ee0e08e00743c46c03799e2704206cfccc065bb6f9e3a
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
Oct 22, 2018https://github.com/microsoft/TypeScript/pull/28028#discussion_r227051974
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/28028
Klaus Meinhardt (ajafff)https://github.com/ajafff
Oct 22, 2018https://github.com/microsoft/TypeScript/pull/28028#discussion_r227064584
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/28028
v7.rc.0 serving 2x - 3x slower than stable versions on my projects angular/angular-cli#12432 https://github.com/angular/angular-cli/issues/12432
v7.0.0 bugs and 4/5x slower serve & compile AOT angular/angular-cli#12646 https://github.com/angular/angular-cli/issues/12646
https://github.com/filipesilva
Filipe Silva (filipesilva)https://github.com/filipesilva
Oct 25, 2018 https://github.com/microsoft/TypeScript/pull/28028#ref-issue-372915108
@ngtools/webpack / ngc - 4x slower aot compilation from ng6 to ng7 angular/angular#26674 https://github.com/angular/angular/issues/26674
https://github.com/alfaproject
João Dias (alfaproject)https://github.com/alfaproject
Oct 25, 2018https://github.com/microsoft/TypeScript/pull/28028#issuecomment-432983549
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/28028
Ryan Cavanaugh (@RyanCavanaugh)https://github.com/RyanCavanaugh
Sheetal Nandi (@sheetalkamat)https://github.com/sheetalkamat
Klaus Meinhardt (@ajafff)https://github.com/ajafff
Sheetal Nandi (@sheetalkamat)https://github.com/sheetalkamat
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/28028
https://github.com/sheetalkamat
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
Oct 25, 2018 https://github.com/microsoft/TypeScript/pull/28028#pullrequestreview-168517999
View reviewed changes https://github.com/microsoft/TypeScript/pull/28028/files/63a8cb6933d9a78dde7f5e5df7b01417a812968c
https://github.com/sheetalkamat
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
539b9a6https://github.com/microsoft/TypeScript/commit/539b9a6d50de9cb71b3db380786fe86b798c9ca4
Oct 25, 2018https://github.com/microsoft/TypeScript/pull/28028#event-1926983615
https://github.com/filipesilva
Filipe Silva (filipesilva)https://github.com/filipesilva
Nov 1, 2018https://github.com/microsoft/TypeScript/pull/28028#issuecomment-435024218
Sheetal Nandi (@sheetalkamat)https://github.com/sheetalkamat
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/28028
https://github.com/ajafff
Klaus Meinhardt (ajafff)https://github.com/ajafff
Nov 1, 2018 https://github.com/microsoft/TypeScript/pull/28028#ref-pullrequest-376375545
Fix performance regression when reusing old state (#28028) #28282 https://github.com/microsoft/TypeScript/pull/28282
https://github.com/ajafff
Klaus Meinhardt (ajafff)https://github.com/ajafff
November 1, 2018 12:39https://github.com/microsoft/TypeScript/pull/28028#event-1940393011
https://github.com/ajafff
Klaus Meinhardt (ajafff)https://github.com/ajafff
Nov 1, 2018https://github.com/microsoft/TypeScript/pull/28028#issuecomment-435028330
#28282https://github.com/microsoft/TypeScript/pull/28282
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/28028
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Nov 1, 2018 https://github.com/microsoft/TypeScript/pull/28028#ref-commit-ec320de
https://github.com/DanielRosenwasser
Merge pull requesthttps://github.com/microsoft/TypeScript/commit/ec320deaccda8aac94c8aaccd07cec67b80e12a1
#28282https://github.com/microsoft/TypeScript/pull/28282
from ajafff/backport-perf-regressionhttps://github.com/microsoft/TypeScript/commit/ec320deaccda8aac94c8aaccd07cec67b80e12a1
ec320dehttps://github.com/microsoft/TypeScript/commit/ec320deaccda8aac94c8aaccd07cec67b80e12a1
#28028https://github.com/microsoft/TypeScript/pull/28028
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Nov 1, 2018https://github.com/microsoft/TypeScript/pull/28028#issuecomment-435185543
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/28028
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/28028
Bump @angular/cli from 7.0.3 to 7.0.4 BioWareRu/BioEngine.BRC.Admin#41 https://github.com/BioWareRu/BioEngine.BRC.Admin/pull/41
Update @angular/cli requirement from 7.0.2 to 7.0.4 donmahallem/ng2-pihole#38 https://github.com/donmahallem/ng2-pihole/pull/38
Bump @angular-devkit/core from 0.7.5 to 7.0.4 in /ui OpenEMS/openems#132 https://github.com/OpenEMS/openems/pull/132
Bump @angular/cli from 7.0.3 to 7.0.4 in /frontend pombase/website#1008 https://github.com/pombase/website/pull/1008
Bump @angular/cli from 6.2.5 to 7.0.4 hmcts/ccd-case-management-web#391 https://github.com/hmcts/ccd-case-management-web/pull/391
Bump @angular/cli from 6.2.7 to 7.0.4 hmcts/ccd-case-ui-toolkit#120 https://github.com/hmcts/ccd-case-ui-toolkit/pull/120
https://github.com/filipesilva
Filipe Silva (filipesilva)https://github.com/filipesilva
Dec 27, 2018 https://github.com/microsoft/TypeScript/pull/28028#ref-issue-238293894
Build with "ng -prod" is extremely slow angular/angular-cli#6795 https://github.com/angular/angular-cli/issues/6795
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/28028#event-20415828135
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F28028
https://github.com/sheetalkamat
Sheetal Nandi (sheetalkamat) https://github.com/sheetalkamat
https://github.com/microsoft/TypeScript/pull/28028/files/63a8cb6933d9a78dde7f5e5df7b01417a812968c
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/28028
Building performance is slowdown https://github.com/microsoft/TypeScript/issues/28025
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/28028
https://github.com/ajafff
https://github.com/thekiba
https://github.com/obenjiro
https://github.com/alfaproject
https://github.com/filipesilva
https://github.com/DanielRosenwasser
https://github.com/sheetalkamat
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.