| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d9d65e99-460c-f17a-e8e7-e52c88fc8f4d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B4A4:3E4205:110DBCE:16D2221:6B011B81 |
| html-safe-nonce | 0ce727360802cb7155879b8b53e71b287b0fae348e976497141cf03a712a1ee9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNEE0OjNFNDIwNToxMTBEQkNFOjE2RDIyMjE6NkIwMTFCODEiLCJ2aXNpdG9yX2lkIjoiODkzNTU5NjgwNDQ3NzYyMzE2OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 0b57041371fbc8aa97c9b4caaba4c85d9def76f31fe3e6747dadacbf795dc0e7 |
| hovercard-subject-tag | pull_request:223447520 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/27932/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/1b5872595db06c98286a1601adb963b2a12e62db15615d0b90cac73459465567/microsoft/TypeScript/pull/27932 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1b5872595db06c98286a1601adb963b2a12e62db15615d0b90cac73459465567/microsoft/TypeScript/pull/27932 |
| og:image:alt | Inspired by looking into #27014
Fixes #26933
Steals from #27589
This adds assignability rules for relating types when the target is a conditional type. We only check for conditional type target ass... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | weswigham |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/27932#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F27932 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F27932 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/27932 |
| Reload | https://github.com/microsoft/TypeScript/pull/27932 |
| Reload | https://github.com/microsoft/TypeScript/pull/27932 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests310 (310) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| microsoft:main | https://github.com/microsoft/TypeScript/tree/main |
| weswigham:infer-conditional-class-this | https://github.com/weswigham/TypeScript/tree/infer-conditional-class-this |
| Conversation | https://github.com/microsoft/TypeScript/pull/27932 |
| Commits4 (4) | https://github.com/microsoft/TypeScript/pull/27932/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/27932/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/27932/files |
| Add assignability rules for when the target is a conditional type | https://github.com/microsoft/TypeScript/pull/27932#top |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| microsoft:main | https://github.com/microsoft/TypeScript/tree/main |
| weswigham:infer-conditional-class-this | https://github.com/weswigham/TypeScript/tree/infer-conditional-class-this |
|
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Oct 17, 2018 | https://github.com/microsoft/TypeScript/pull/27932#issue-370868491 |
| #27014 | https://github.com/microsoft/TypeScript/issues/27014 |
| #26933 | https://github.com/microsoft/TypeScript/issues/26933 |
| #27589 | https://github.com/microsoft/TypeScript/pull/27589 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/27932 |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Ryan Cavanaugh (RyanCavanaugh) | https://github.com/RyanCavanaugh |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| October 17, 2018 02:08 | https://github.com/microsoft/TypeScript/pull/27932#event-1908360515 |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| October 16, 2018 19:09 | https://github.com/microsoft/TypeScript/pull/27932#commits-pushed-05ac44f |
|
| https://github.com/weswigham |
| Add assignability rules for when the target is a conditional type | https://github.com/microsoft/TypeScript/pull/27932/commits/05ac44f26cfcc1e4415c25d446e858ed65bd6c31 |
| 05ac44f | https://github.com/microsoft/TypeScript/pull/27932/commits/05ac44f26cfcc1e4415c25d446e858ed65bd6c31 |
|
| https://github.com/weswigham |
| Slightly improve test, add comment explaining situation | https://github.com/microsoft/TypeScript/pull/27932/commits/17e215c3caa7d3166928ccb5591d356c02562029 |
| 17e215c | https://github.com/microsoft/TypeScript/pull/27932/commits/17e215c3caa7d3166928ccb5591d356c02562029 |
|
| https://github.com/weswigham |
| Err on the safe side | https://github.com/microsoft/TypeScript/pull/27932/commits/8577f7ddfc02f47e3c1d3868b779497d2403513b |
| 8577f7d | https://github.com/microsoft/TypeScript/pull/27932/commits/8577f7ddfc02f47e3c1d3868b779497d2403513b |
|
| https://github.com/weswigham |
| Stronger guarantees on edge case handling, stolen tests from | https://github.com/microsoft/TypeScript/pull/27932/commits/f590103e3c5f8c1b30980edd9cc210b9bd4ce1be |
| microsof… | https://github.com/microsoft/TypeScript/pull/27589 |
| f590103 | https://github.com/microsoft/TypeScript/pull/27932/commits/f590103e3c5f8c1b30980edd9cc210b9bd4ce1be |
| …t#27589 | https://github.com/microsoft/TypeScript/pull/27589 |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| force-pushed | https://github.com/microsoft/TypeScript/compare/7652906dbdc08a39895d8a1e23b35d8f5d54f56f..f590103e3c5f8c1b30980edd9cc210b9bd4ce1be |
| 7652906 | https://github.com/microsoft/TypeScript/commit/7652906dbdc08a39895d8a1e23b35d8f5d54f56f |
| f590103 | https://github.com/microsoft/TypeScript/commit/f590103e3c5f8c1b30980edd9cc210b9bd4ce1be |
|
Compare
| https://github.com/microsoft/TypeScript/compare/7652906dbdc08a39895d8a1e23b35d8f5d54f56f..f590103e3c5f8c1b30980edd9cc210b9bd4ce1be |
| October 17, 2018 02:10 | https://github.com/microsoft/TypeScript/pull/27932#event-1908362396 |
| https://github.com/jack-williams |
| Jack Williams (jack-williams) | https://github.com/jack-williams |
| Oct 23, 2018 | https://github.com/microsoft/TypeScript/pull/27932#issuecomment-432036232 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/27932 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/27932 |
|
Nested Exclude has unexpected behavior
#28824
| https://github.com/microsoft/TypeScript/issues/28824 |
|
Type x is not assignable to {conditional return type y}
#28917
| https://github.com/microsoft/TypeScript/issues/28917 |
| https://github.com/RyanCavanaugh |
| Ryan Cavanaugh (RyanCavanaugh) | https://github.com/RyanCavanaugh |
|
Jan 24, 2019
| https://github.com/microsoft/TypeScript/pull/27932#ref-pullrequest-367519348 |
|
Add rule that a type is assignable to A extends B ? C : D if it is assignable to both C and D.
#27589
| https://github.com/microsoft/TypeScript/pull/27589 |
| https://github.com/RyanCavanaugh |
| Ryan Cavanaugh (RyanCavanaugh) | https://github.com/RyanCavanaugh |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Jan 24, 2019 | https://github.com/microsoft/TypeScript/pull/27932#event-2095906021 |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
|
Mar 29, 2019
| https://github.com/microsoft/TypeScript/pull/27932#ref-pullrequest-426761912 |
|
Add missing relationship allowing a type to be assignable to a conditional when assignable to both branches
#30639
| https://github.com/microsoft/TypeScript/pull/30639 |
| https://github.com/RyanCavanaugh |
| Ryan Cavanaugh (RyanCavanaugh) | https://github.com/RyanCavanaugh |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| Apr 30, 2019 | https://github.com/microsoft/TypeScript/pull/27932#event-2309909723 |
| https://github.com/jablko |
| Jack Bates (jablko) | https://github.com/jablko |
|
Dec 18, 2019
| https://github.com/microsoft/TypeScript/pull/27932#ref-pullrequest-539382702 |
|
Type comparison when conditional type is target
#35741
| https://github.com/microsoft/TypeScript/pull/35741 |
| https://github.com/dgreensp |
| David Greenspan (dgreensp) | https://github.com/dgreensp |
| Jan 8, 2020 | https://github.com/microsoft/TypeScript/pull/27932#issuecomment-572275358 |
| #26945 | https://github.com/microsoft/TypeScript/issues/26945 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/27932 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
|
Experiment
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3AExperiment |
| Feb 1, 2020 | https://github.com/microsoft/TypeScript/pull/27932#event-2998900039 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
|
Author: Team
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22 |
| Feb 1, 2020 | https://github.com/microsoft/TypeScript/pull/27932#event-2998900146 |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
|
Jul 8, 2020
| https://github.com/microsoft/TypeScript/pull/27932#ref-issue-382534540 |
|
Props requiring casting on complex type (and defaultProps not settable)
#28614
| https://github.com/microsoft/TypeScript/issues/28614 |
| https://github.com/andrewbranch |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
|
Sep 25, 2020
| https://github.com/microsoft/TypeScript/pull/27932#ref-issue-708013301 |
|
(Indirect) inference of array element type in callback function type does not work
#40743
| https://github.com/microsoft/TypeScript/issues/40743 |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
|
Oct 22, 2020
| https://github.com/microsoft/TypeScript/pull/27932#ref-issue-371926132 |
|
Can't use type aliases or conditional types resolving to Promise for async/await return types
#27987
| https://github.com/microsoft/TypeScript/issues/27987 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| May 24, 2022 | https://github.com/microsoft/TypeScript/pull/27932#issuecomment-1136486809 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/27932 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| May 24, 2022 | https://github.com/microsoft/TypeScript/pull/27932#event-6672691633 |
| https://github.com/RyanCavanaugh |
| Ryan Cavanaugh (RyanCavanaugh) | https://github.com/RyanCavanaugh |
|
Sep 20, 2022
| https://github.com/microsoft/TypeScript/pull/27932#ref-issue-1376937305 |
|
Class method with conditional return type cannot return types common to both conditional branches when the class also has an interface
#50822
| https://github.com/microsoft/TypeScript/issues/50822 |
| https://github.com/jcalz |
| Joe Calzaretta (jcalz) | https://github.com/jcalz |
|
Sep 2, 2025
| https://github.com/microsoft/TypeScript/pull/27932#ref-issue-3371687215 |
|
Key in mapped type not traversed when there's a something-with-generics extends clause in it
#62370
| https://github.com/microsoft/TypeScript/issues/62370 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Oct 21, 2025 | https://github.com/microsoft/TypeScript/pull/27932#event-20415825047 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F27932 |
|
| https://github.com/ahejlsberg |
|
Anders Hejlsberg (ahejlsberg)
| https://github.com/ahejlsberg |
|
| https://github.com/RyanCavanaugh |
|
Ryan Cavanaugh (RyanCavanaugh)
| https://github.com/RyanCavanaugh |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/27932 |
|
| https://github.com/weswigham |
|
Wesley Wigham (weswigham)
| https://github.com/weswigham |
|
Author: Team
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22 |
|
Experiment
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3AExperiment |
|
T should be assignable to A extends B ? C : D if it is assignable to both C and D
| https://github.com/microsoft/TypeScript/issues/26933 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/27932 |
|
| https://github.com/weswigham |
|
| https://github.com/jack-williams |
|
| https://github.com/dgreensp |
|
| https://github.com/sandersn |
|
| https://github.com/typescript-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |