René's URL Explorer Experiment


Title: Fix non-toplevel prototype assignment by sandersn · Pull Request #27096 · microsoft/TypeScript · GitHub

Open Graph Title: Fix non-toplevel prototype assignment by sandersn · Pull Request #27096 · microsoft/TypeScript

X Title: Fix non-toplevel prototype assignment by sandersn · Pull Request #27096 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Fix non-toplevel prototype assignment by sandersn · Pull Request #27096 · microsoft/TypeScript

Open Graph Description: #26925 didn't fix prototype assignment when not at the toplevel. The binder was using the wrong node to lookup the containing class type for prototype assignment, so it incorrectly put the prot...

X Description: #26925 didn't fix prototype assignment when not at the toplevel. The binder was using the wrong node to lookup the containing class type for prototype assignment, so it incorrectly put the ...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/27096

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e3289a58-61aa-b0d3-ca45-b7c0cdfaaa42
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB35A:29FFA9:3082D9E:3D6BF96:6B01C553
html-safe-noncedeb878c9230086da0c50d9ec3f88d339a04f86114b546f1c4a3af0c85e00688b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMzVBOjI5RkZBOTozMDgyRDlFOjNENkJGOTY6NkIwMUM1NTMiLCJ2aXNpdG9yX2lkIjoiMTIyNzczMjg5MTczNjMyNzUwNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3d1c528331846881a5b19de2f2b578a8a11329a58e598383a8bd6b91d588de9f
hovercard-subject-tagpull_request:215658604
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/27096/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a4e8e1c0e3d8d51f44cbd0fde593e8967946282183e4a4564ec1223142cef7f4/microsoft/TypeScript/pull/27096
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a4e8e1c0e3d8d51f44cbd0fde593e8967946282183e4a4564ec1223142cef7f4/microsoft/TypeScript/pull/27096
og:image:alt#26925 didn't fix prototype assignment when not at the toplevel. The binder was using the wrong node to lookup the containing class type for prototype assignment, so it incorrectly put the prot...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesandersn
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/27096#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F27096
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F27096
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/27096
Reloadhttps://github.com/microsoft/TypeScript/pull/27096
Reloadhttps://github.com/microsoft/TypeScript/pull/27096
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
js/fix-non-toplevel-prototype-assignmenthttps://github.com/microsoft/TypeScript/tree/js/fix-non-toplevel-prototype-assignment
Conversationhttps://github.com/microsoft/TypeScript/pull/27096
Commits2 (2)https://github.com/microsoft/TypeScript/pull/27096/commits
Checkshttps://github.com/microsoft/TypeScript/pull/27096/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/27096/files
Fix non-toplevel prototype assignmenthttps://github.com/microsoft/TypeScript/pull/27096#top
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
js/fix-non-toplevel-prototype-assignmenthttps://github.com/microsoft/TypeScript/tree/js/fix-non-toplevel-prototype-assignment
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Sep 14, 2018https://github.com/microsoft/TypeScript/pull/27096#issue-360387142
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/27096
#26925https://github.com/microsoft/TypeScript/pull/26925
#26923https://github.com/microsoft/TypeScript/issues/26923
#27095https://github.com/microsoft/TypeScript/issues/27095
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/27096
https://github.com/sandersn
Fix non-toplevel prototype assignmenthttps://github.com/microsoft/TypeScript/pull/27096/commits/69f9f9b83d4fbe808766566c97b762ff4964f347
69f9f9bhttps://github.com/microsoft/TypeScript/pull/27096/commits/69f9f9b83d4fbe808766566c97b762ff4964f347
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Sep 14, 2018 https://github.com/microsoft/TypeScript/pull/27096#pullrequestreview-155586009
View reviewed changes https://github.com/microsoft/TypeScript/pull/27096/files/69f9f9b83d4fbe808766566c97b762ff4964f347
src/compiler/binder.tshttps://github.com/microsoft/TypeScript/pull/27096/files/69f9f9b83d4fbe808766566c97b762ff4964f347#diff-9ad14a2e2e66533cd0c3f02ecf01f7e6bc9d60cdf2e125df2a14ce0713222898
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Sep 14, 2018https://github.com/microsoft/TypeScript/pull/27096#discussion_r217783314
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/27096
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
September 14, 2018 17:17https://github.com/microsoft/TypeScript/pull/27096#event-1846624579
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
Sep 14, 2018 https://github.com/microsoft/TypeScript/pull/27096#pullrequestreview-155598646
View reviewed changes https://github.com/microsoft/TypeScript/pull/27096/files/69f9f9b83d4fbe808766566c97b762ff4964f347
tests/cases/conformance/salsa/typeFromPrototypeAssignment2.tshttps://github.com/microsoft/TypeScript/pull/27096/files/69f9f9b83d4fbe808766566c97b762ff4964f347#diff-0f3c2c0db5bb5a40d25ffefae466977bda74de358ef071798c20dcea4bf9260e
Deleted user (ghost)https://github.com/ghost
Sep 14, 2018https://github.com/microsoft/TypeScript/pull/27096#discussion_r217793058
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/27096
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Sep 16, 2018https://github.com/microsoft/TypeScript/pull/27096#discussion_r217930615
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/27096
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
Sep 14, 2018 https://github.com/microsoft/TypeScript/pull/27096#pullrequestreview-155598690
View reviewed changes https://github.com/microsoft/TypeScript/pull/27096/files/69f9f9b83d4fbe808766566c97b762ff4964f347
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/27096/files/69f9f9b83d4fbe808766566c97b762ff4964f347#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Deleted user (ghost)https://github.com/ghost
Sep 14, 2018https://github.com/microsoft/TypeScript/pull/27096#discussion_r217793087
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/27096
https://github.com/sandersn
Refactor per PR suggestionhttps://github.com/microsoft/TypeScript/pull/27096/commits/a9d76b98304b0e257c247b4ef7993d32e30e05bb
a9d76b9https://github.com/microsoft/TypeScript/pull/27096/commits/a9d76b98304b0e257c247b4ef7993d32e30e05bb
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Sep 17, 2018 https://github.com/microsoft/TypeScript/pull/27096#ref-pullrequest-360870812
🤖 User test baselines have changed #27141 https://github.com/microsoft/TypeScript/pull/27141
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
Sep 17, 2018 https://github.com/microsoft/TypeScript/pull/27096#pullrequestreview-156020455
View reviewed changes https://github.com/microsoft/TypeScript/pull/27096/files/a9d76b98304b0e257c247b4ef7993d32e30e05bb
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
c9f1902https://github.com/microsoft/TypeScript/commit/c9f190283ed2f671c519e0e8af410bee6958c472
Sep 17, 2018https://github.com/microsoft/TypeScript/pull/27096#event-1850722445
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
September 17, 2018 20:07https://github.com/microsoft/TypeScript/pull/27096#event-1850722568
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/27096#event-20415797403
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/27096#event-20415798209
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F27096
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh) https://github.com/RyanCavanaugh
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/27096
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
This-type fix for prototypes only works at top-level https://github.com/microsoft/TypeScript/issues/27095
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/27096
https://github.com/sandersn
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.