| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e3289a58-61aa-b0d3-ca45-b7c0cdfaaa42 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B35A:29FFA9:3082D9E:3D6BF96:6B01C553 |
| html-safe-nonce | deb878c9230086da0c50d9ec3f88d339a04f86114b546f1c4a3af0c85e00688b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMzVBOjI5RkZBOTozMDgyRDlFOjNENkJGOTY6NkIwMUM1NTMiLCJ2aXNpdG9yX2lkIjoiMTIyNzczMjg5MTczNjMyNzUwNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3d1c528331846881a5b19de2f2b578a8a11329a58e598383a8bd6b91d588de9f |
| hovercard-subject-tag | pull_request:215658604 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/27096/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a4e8e1c0e3d8d51f44cbd0fde593e8967946282183e4a4564ec1223142cef7f4/microsoft/TypeScript/pull/27096 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a4e8e1c0e3d8d51f44cbd0fde593e8967946282183e4a4564ec1223142cef7f4/microsoft/TypeScript/pull/27096 |
| og:image:alt | #26925 didn't fix prototype assignment when not at the toplevel. The binder was using the wrong node to lookup the containing class type for prototype assignment, so it incorrectly put the prot... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sandersn |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/27096#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F27096 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F27096 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/27096 |
| Reload | https://github.com/microsoft/TypeScript/pull/27096 |
| Reload | https://github.com/microsoft/TypeScript/pull/27096 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests312 (312) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| master | https://github.com/microsoft/TypeScript/tree/master |
| js/fix-non-toplevel-prototype-assignment | https://github.com/microsoft/TypeScript/tree/js/fix-non-toplevel-prototype-assignment |
| Conversation | https://github.com/microsoft/TypeScript/pull/27096 |
| Commits2 (2) | https://github.com/microsoft/TypeScript/pull/27096/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/27096/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/27096/files |
| Fix non-toplevel prototype assignment | https://github.com/microsoft/TypeScript/pull/27096#top |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| master | https://github.com/microsoft/TypeScript/tree/master |
| js/fix-non-toplevel-prototype-assignment | https://github.com/microsoft/TypeScript/tree/js/fix-non-toplevel-prototype-assignment |
|
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Sep 14, 2018 | https://github.com/microsoft/TypeScript/pull/27096#issue-360387142 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/27096 |
| #26925 | https://github.com/microsoft/TypeScript/pull/26925 |
| #26923 | https://github.com/microsoft/TypeScript/issues/26923 |
| #27095 | https://github.com/microsoft/TypeScript/issues/27095 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/27096 |
|
| https://github.com/sandersn |
| Fix non-toplevel prototype assignment | https://github.com/microsoft/TypeScript/pull/27096/commits/69f9f9b83d4fbe808766566c97b762ff4964f347 |
| 69f9f9b | https://github.com/microsoft/TypeScript/pull/27096/commits/69f9f9b83d4fbe808766566c97b762ff4964f347 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
|
Sep 14, 2018
| https://github.com/microsoft/TypeScript/pull/27096#pullrequestreview-155586009 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/27096/files/69f9f9b83d4fbe808766566c97b762ff4964f347 |
| src/compiler/binder.ts | https://github.com/microsoft/TypeScript/pull/27096/files/69f9f9b83d4fbe808766566c97b762ff4964f347#diff-9ad14a2e2e66533cd0c3f02ecf01f7e6bc9d60cdf2e125df2a14ce0713222898 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Sep 14, 2018 | https://github.com/microsoft/TypeScript/pull/27096#discussion_r217783314 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/27096 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Ryan Cavanaugh (RyanCavanaugh) | https://github.com/RyanCavanaugh |
| September 14, 2018 17:17 | https://github.com/microsoft/TypeScript/pull/27096#event-1846624579 |
| https://github.com/ghost |
| Deleted user (ghost) | https://github.com/ghost |
|
Sep 14, 2018
| https://github.com/microsoft/TypeScript/pull/27096#pullrequestreview-155598646 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/27096/files/69f9f9b83d4fbe808766566c97b762ff4964f347 |
| tests/cases/conformance/salsa/typeFromPrototypeAssignment2.ts | https://github.com/microsoft/TypeScript/pull/27096/files/69f9f9b83d4fbe808766566c97b762ff4964f347#diff-0f3c2c0db5bb5a40d25ffefae466977bda74de358ef071798c20dcea4bf9260e |
| Deleted user (ghost) | https://github.com/ghost |
| Sep 14, 2018 | https://github.com/microsoft/TypeScript/pull/27096#discussion_r217793058 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/27096 |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Sep 16, 2018 | https://github.com/microsoft/TypeScript/pull/27096#discussion_r217930615 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/27096 |
| https://github.com/ghost |
| Deleted user (ghost) | https://github.com/ghost |
|
Sep 14, 2018
| https://github.com/microsoft/TypeScript/pull/27096#pullrequestreview-155598690 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/27096/files/69f9f9b83d4fbe808766566c97b762ff4964f347 |
| src/compiler/checker.ts | https://github.com/microsoft/TypeScript/pull/27096/files/69f9f9b83d4fbe808766566c97b762ff4964f347#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8 |
| Deleted user (ghost) | https://github.com/ghost |
| Sep 14, 2018 | https://github.com/microsoft/TypeScript/pull/27096#discussion_r217793087 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/27096 |
|
| https://github.com/sandersn |
| Refactor per PR suggestion | https://github.com/microsoft/TypeScript/pull/27096/commits/a9d76b98304b0e257c247b4ef7993d32e30e05bb |
| a9d76b9 | https://github.com/microsoft/TypeScript/pull/27096/commits/a9d76b98304b0e257c247b4ef7993d32e30e05bb |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
|
Sep 17, 2018
| https://github.com/microsoft/TypeScript/pull/27096#ref-pullrequest-360870812 |
|
🤖 User test baselines have changed
#27141
| https://github.com/microsoft/TypeScript/pull/27141 |
| https://github.com/ghost |
| Deleted user (ghost) | https://github.com/ghost |
|
Sep 17, 2018
| https://github.com/microsoft/TypeScript/pull/27096#pullrequestreview-156020455 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/27096/files/a9d76b98304b0e257c247b4ef7993d32e30e05bb |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| c9f1902 | https://github.com/microsoft/TypeScript/commit/c9f190283ed2f671c519e0e8af410bee6958c472 |
| Sep 17, 2018 | https://github.com/microsoft/TypeScript/pull/27096#event-1850722445 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| September 17, 2018 20:07 | https://github.com/microsoft/TypeScript/pull/27096#event-1850722568 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Oct 21, 2025 | https://github.com/microsoft/TypeScript/pull/27096#event-20415797403 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Oct 21, 2025 | https://github.com/microsoft/TypeScript/pull/27096#event-20415798209 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F27096 |
|
| https://github.com/RyanCavanaugh |
|
Ryan Cavanaugh (RyanCavanaugh)
| https://github.com/RyanCavanaugh |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/27096 |
|
| https://github.com/sandersn |
|
Nathan Shively-Sanders (sandersn)
| https://github.com/sandersn |
|
This-type fix for prototypes only works at top-level
| https://github.com/microsoft/TypeScript/issues/27095 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/27096 |
|
| https://github.com/sandersn |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |