René's URL Explorer Experiment


Title: Go back to old narrowing algorithm but don't narrow in cases like #26130 by mattmccutchen · Pull Request #26425 · microsoft/TypeScript · GitHub

Open Graph Title: Go back to old narrowing algorithm but don't narrow in cases like #26130 by mattmccutchen · Pull Request #26425 · microsoft/TypeScript

X Title: Go back to old narrowing algorithm but don't narrow in cases like #26130 by mattmccutchen · Pull Request #26425 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Go back to old narrowing algorithm but don't narrow in cases like #26130 by mattmccutchen · Pull Request #26425 · microsoft/TypeScript

Open Graph Description: Fixes #26405.

X Description: Fixes #26405.

Opengraph URL: https://github.com/microsoft/TypeScript/pull/26425

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f8ee99f3-f02c-7337-48af-deaa0fab7133
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8C10:EA06E:2F509D7:3C2C2CC:6B01A9E0
html-safe-nonceb58be8df537c898c20afedb97e49003eb98275c9d5ba728b0480908a3728efa1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzEwOkVBMDZFOjJGNTA5RDc6M0MyQzJDQzo2QjAxQTlFMCIsInZpc2l0b3JfaWQiOiIyNDYzMjA4OTMzNDAyMTkyMzUyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac33e6dd989cff67066b3754b77cc2e222c263e7e7c1f6034c29c722d0ea80cbe9
hovercard-subject-tagpull_request:208109737
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/26425/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5e33ed4ccbfe39cf4a779926ed4eeb8b533e4141928d7e07794a3c4ebeab3073/microsoft/TypeScript/pull/26425
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5e33ed4ccbfe39cf4a779926ed4eeb8b533e4141928d7e07794a3c4ebeab3073/microsoft/TypeScript/pull/26425
og:image:altFixes #26405.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemattmccutchen
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/26425#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F26425
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F26425
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/26425
Reloadhttps://github.com/microsoft/TypeScript/pull/26425
Reloadhttps://github.com/microsoft/TypeScript/pull/26425
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
mattmccutchen:issue-26405https://github.com/mattmccutchen/TypeScript/tree/issue-26405
Conversationhttps://github.com/microsoft/TypeScript/pull/26425
Commits1 (1)https://github.com/microsoft/TypeScript/pull/26425/commits
Checkshttps://github.com/microsoft/TypeScript/pull/26425/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/26425/files
Go back to old narrowing algorithm but don't narrow in cases like #26130https://github.com/microsoft/TypeScript/pull/26425#top
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
mattmccutchen:issue-26405https://github.com/mattmccutchen/TypeScript/tree/issue-26405
https://github.com/mattmccutchen
Matt McCutchen (mattmccutchen)https://github.com/mattmccutchen
Aug 13, 2018https://github.com/microsoft/TypeScript/pull/26425#issue-350201433
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/26425
#26405https://github.com/microsoft/TypeScript/issues/26405
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/26425
https://github.com/mattmccutchen
Matt McCutchen (mattmccutchen)https://github.com/mattmccutchen
Aug 13, 2018 https://github.com/microsoft/TypeScript/pull/26425#ref-issue-349902313
Narrowing on assignment does not remove weak types #26405 https://github.com/microsoft/TypeScript/issues/26405
https://github.com/ctrlaltvikas
Vikas Kumar Yadav (ctrlaltvikas)https://github.com/ctrlaltvikas
Aug 16, 2018 https://github.com/microsoft/TypeScript/pull/26425#pullrequestreview-147013446
View reviewed changes https://github.com/microsoft/TypeScript/pull/26425/files
https://github.com/mattmccutchen
Go back to the old narrowing algorithm (prehttps://github.com/microsoft/TypeScript/pull/26425/commits/cc1c2ab6b2c2165b393b8aa3397e3a7a11b8f33b
microsoft#26143https://github.com/microsoft/TypeScript/pull/26143
) and avoidhttps://github.com/microsoft/TypeScript/pull/26425/commits/cc1c2ab6b2c2165b393b8aa3397e3a7a11b8f33b
…https://github.com/microsoft/TypeScript/issues/26130
cc1c2abhttps://github.com/microsoft/TypeScript/pull/26425/commits/cc1c2ab6b2c2165b393b8aa3397e3a7a11b8f33b
…microsoft#26130https://github.com/microsoft/TypeScript/issues/26130
microsoft#26405https://github.com/microsoft/TypeScript/issues/26405
https://github.com/mattmccutchen
Matt McCutchen (mattmccutchen)https://github.com/mattmccutchen
force-pushedhttps://github.com/microsoft/TypeScript/compare/c4b13fd2729434e20b1a50215b2530f500ff4be7..cc1c2ab6b2c2165b393b8aa3397e3a7a11b8f33b
c4b13fdhttps://github.com/microsoft/TypeScript/commit/c4b13fd2729434e20b1a50215b2530f500ff4be7
cc1c2abhttps://github.com/microsoft/TypeScript/commit/cc1c2ab6b2c2165b393b8aa3397e3a7a11b8f33b
Compare https://github.com/microsoft/TypeScript/compare/c4b13fd2729434e20b1a50215b2530f500ff4be7..cc1c2ab6b2c2165b393b8aa3397e3a7a11b8f33b
August 18, 2018 01:38https://github.com/microsoft/TypeScript/pull/26425#event-1795795633
https://github.com/mattmccutchen
Matt McCutchen (mattmccutchen)https://github.com/mattmccutchen
Aug 18, 2018https://github.com/microsoft/TypeScript/pull/26425#event-1795795885
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Aug 20, 2018 https://github.com/microsoft/TypeScript/pull/26425#pullrequestreview-147811718
View reviewed changes https://github.com/microsoft/TypeScript/pull/26425/files/cc1c2ab6b2c2165b393b8aa3397e3a7a11b8f33b
Wesley Wigham (weswigham)https://github.com/weswigham
https://github.com/microsoft/TypeScript/pull/26425#pullrequestreview-147811718
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Ryan Cavanaugh (@RyanCavanaugh)https://github.com/RyanCavanaugh
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/26425
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
103f894https://github.com/microsoft/TypeScript/commit/103f894d38f2f3220df046f31269e7885ae9e76b
Aug 20, 2018https://github.com/microsoft/TypeScript/pull/26425#event-1798826909
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/26425#event-20415770141
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F26425
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
https://github.com/microsoft/TypeScript/pull/26425/files/cc1c2ab6b2c2165b393b8aa3397e3a7a11b8f33b
https://github.com/ctrlaltvikas
Vikas Kumar Yadav (ctrlaltvikas) https://github.com/ctrlaltvikas
https://github.com/microsoft/TypeScript/pull/26425/files/c4b13fd2729434e20b1a50215b2530f500ff4be7
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/26425
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/26425
https://github.com/mattmccutchen
https://github.com/weswigham
https://github.com/ctrlaltvikas
https://github.com/ahejlsberg
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.