René's URL Explorer Experiment


Title: Fix circular return type issue by ahejlsberg · Pull Request #26236 · microsoft/TypeScript · GitHub

Open Graph Title: Fix circular return type issue by ahejlsberg · Pull Request #26236 · microsoft/TypeScript

X Title: Fix circular return type issue by ahejlsberg · Pull Request #26236 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Fix circular return type issue by ahejlsberg · Pull Request #26236 · microsoft/TypeScript

Open Graph Description: With this PR we consistently defer resolving signature return types such that our circularity detection logic can properly catch circular references in return types. This PR also consolidates a bun...

X Description: With this PR we consistently defer resolving signature return types such that our circularity detection logic can properly catch circular references in return types. This PR also consolidates a bun...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/26236

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ac90ff61-81a8-b685-4276-32acec008941
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA066:2463BD:2A28CF0:35D756A:6B019B09
html-safe-noncee9797d480b24ece63f8f5c7d954b93422ea3887656412fc9f5a43347260f40cb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDY2OjI0NjNCRDoyQTI4Q0YwOjM1RDc1NkE6NkIwMTlCMDkiLCJ2aXNpdG9yX2lkIjoiNjE4NjQwOTE4NDg2MzU1ODQwOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac98a5389add9396b70142a68ac0303dc95451d3615d5f7c24f78d725777a52a0f
hovercard-subject-tagpull_request:206462245
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/26236/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f4b0f0723b391767b2512ebceace7f8b15682687182ff9e5e8d08d2208bcc61f/microsoft/TypeScript/pull/26236
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f4b0f0723b391767b2512ebceace7f8b15682687182ff9e5e8d08d2208bcc61f/microsoft/TypeScript/pull/26236
og:image:altWith this PR we consistently defer resolving signature return types such that our circularity detection logic can properly catch circular references in return types. This PR also consolidates a bun...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameahejlsberg
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/26236#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F26236
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F26236
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/26236
Reloadhttps://github.com/microsoft/TypeScript/pull/26236
Reloadhttps://github.com/microsoft/TypeScript/pull/26236
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
masterhttps://github.com/microsoft/TypeScript/tree/master
fixCircularReturnTypehttps://github.com/microsoft/TypeScript/tree/fixCircularReturnType
Conversationhttps://github.com/microsoft/TypeScript/pull/26236
Commits12 (12)https://github.com/microsoft/TypeScript/pull/26236/commits
Checkshttps://github.com/microsoft/TypeScript/pull/26236/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/26236/files
Fix circular return type issuehttps://github.com/microsoft/TypeScript/pull/26236#top
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
masterhttps://github.com/microsoft/TypeScript/tree/master
fixCircularReturnTypehttps://github.com/microsoft/TypeScript/tree/fixCircularReturnType
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Aug 6, 2018https://github.com/microsoft/TypeScript/pull/26236#issue-348008716
#26104https://github.com/microsoft/TypeScript/issues/26104
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/26236
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
August 3, 2018 14:03https://github.com/microsoft/TypeScript/pull/26236#commits-pushed-e4443bb
https://github.com/ahejlsberg
Properly catch and error on circular function return typeshttps://github.com/microsoft/TypeScript/pull/26236/commits/e4443bb993929de9b94c779ebdba045e88aac858
e4443bbhttps://github.com/microsoft/TypeScript/pull/26236/commits/e4443bb993929de9b94c779ebdba045e88aac858
https://github.com/ahejlsberg
Accept new baselineshttps://github.com/microsoft/TypeScript/pull/26236/commits/a75fe5194e1f04944ece146d9cb7ec0d538ec771
a75fe51https://github.com/microsoft/TypeScript/pull/26236/commits/a75fe5194e1f04944ece146d9cb7ec0d538ec771
https://github.com/ahejlsberg
Erase type parameters when fetching return type from JSDochttps://github.com/microsoft/TypeScript/pull/26236/commits/539775779e00117cf9e94c004beddf82311bbe54
@typehttps://github.com/type
taghttps://github.com/microsoft/TypeScript/pull/26236/commits/539775779e00117cf9e94c004beddf82311bbe54
5397757https://github.com/microsoft/TypeScript/pull/26236/commits/539775779e00117cf9e94c004beddf82311bbe54
https://github.com/ahejlsberg
Ensure type parameters are erased in contextual signature fromhttps://github.com/microsoft/TypeScript/pull/26236/commits/ee721225aeb3753a9522785f6ecf9d95a6f27346
@typehttps://github.com/type
taghttps://github.com/microsoft/TypeScript/pull/26236/commits/ee721225aeb3753a9522785f6ecf9d95a6f27346
ee72122https://github.com/microsoft/TypeScript/pull/26236/commits/ee721225aeb3753a9522785f6ecf9d95a6f27346
https://github.com/ahejlsberg
Accept new baselineshttps://github.com/microsoft/TypeScript/pull/26236/commits/faed2d2c3344f8ad6a693dc3e4c03a4bf86d05bd
faed2d2https://github.com/microsoft/TypeScript/pull/26236/commits/faed2d2c3344f8ad6a693dc3e4c03a4bf86d05bd
https://github.com/ahejlsberg
Clean up return type checking logichttps://github.com/microsoft/TypeScript/pull/26236/commits/ab7defa5eae51b3c1bc5c125f05024aee0316ec5
ab7defahttps://github.com/microsoft/TypeScript/pull/26236/commits/ab7defa5eae51b3c1bc5c125f05024aee0316ec5
https://github.com/ahejlsberg
Accept new baselineshttps://github.com/microsoft/TypeScript/pull/26236/commits/c367b91da73025bd92e1278e006972b3e9b98571
c367b91https://github.com/microsoft/TypeScript/pull/26236/commits/c367b91da73025bd92e1278e006972b3e9b98571
https://github.com/ahejlsberg
Use getReturnTypeFromAnnotation instead of ad hoc checkshttps://github.com/microsoft/TypeScript/pull/26236/commits/dc34c5e7196ff4d4b6bfffb80e46814d444742dd
dc34c5ehttps://github.com/microsoft/TypeScript/pull/26236/commits/dc34c5e7196ff4d4b6bfffb80e46814d444742dd
https://github.com/ahejlsberg
Add regression testshttps://github.com/microsoft/TypeScript/pull/26236/commits/efdbbd1cf3b1009a13755bfc97c518243c71ae50
efdbbd1https://github.com/microsoft/TypeScript/pull/26236/commits/efdbbd1cf3b1009a13755bfc97c518243c71ae50
https://github.com/ahejlsberg
Accept new baselineshttps://github.com/microsoft/TypeScript/pull/26236/commits/9c3dc96dc1d9b6d1b3b388c1604ff5185a794959
9c3dc96https://github.com/microsoft/TypeScript/pull/26236/commits/9c3dc96dc1d9b6d1b3b388c1604ff5185a794959
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
August 6, 2018 17:11https://github.com/microsoft/TypeScript/pull/26236#event-1773413539
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
August 6, 2018 10:42https://github.com/microsoft/TypeScript/pull/26236#commits-pushed-6a17f4d
https://github.com/ahejlsberg
Merge branch 'master' into fixCircularReturnTypehttps://github.com/microsoft/TypeScript/pull/26236/commits/6a17f4d16201d9faae6022ddaa00f8acc290d92d
6a17f4dhttps://github.com/microsoft/TypeScript/pull/26236/commits/6a17f4d16201d9faae6022ddaa00f8acc290d92d
https://github.com/ahejlsberg
Merge branch 'master' into fixCircularReturnTypehttps://github.com/microsoft/TypeScript/pull/26236/commits/cfa29ae2faf5944da252d1fb7b8a5bae2f06fe71
cfa29aehttps://github.com/microsoft/TypeScript/pull/26236/commits/cfa29ae2faf5944da252d1fb7b8a5bae2f06fe71
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Aug 6, 2018 https://github.com/microsoft/TypeScript/pull/26236#pullrequestreview-143704282
View reviewed changes https://github.com/microsoft/TypeScript/pull/26236/files/cfa29ae2faf5944da252d1fb7b8a5bae2f06fe71
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
eeb19c1https://github.com/microsoft/TypeScript/commit/eeb19c1e228e26d3d85633d8ac338e43d1535063
Aug 6, 2018https://github.com/microsoft/TypeScript/pull/26236#event-1774067359
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
August 6, 2018 23:38https://github.com/microsoft/TypeScript/pull/26236#event-1774067539
🤖 User test baselines have changed #26256 https://github.com/microsoft/TypeScript/pull/26256
In JS, extra circular reference errors when referring to a missing property on module #26268 https://github.com/microsoft/TypeScript/issues/26268
https://github.com/masterkidan
Mukundan Kidambi (masterkidan)https://github.com/masterkidan
Jan 24, 2019 https://github.com/microsoft/TypeScript/pull/26236#ref-issue-402875347
DeepReadonly type fails to compile on typescript 3.1.1+ #29566 https://github.com/microsoft/TypeScript/issues/29566
In JS, @type tag doesn't apply generic type to initialiser #42060 https://github.com/microsoft/TypeScript/issues/42060
Do not erase signatures in getSignatureOfTypeTag #43688 https://github.com/microsoft/TypeScript/pull/43688
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/26236#event-20415761733
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F26236
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
https://github.com/microsoft/TypeScript/pull/26236/files/cfa29ae2faf5944da252d1fb7b8a5bae2f06fe71
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh) https://github.com/RyanCavanaugh
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/26236
Type alias circular reference does not error and causes implicit any https://github.com/microsoft/TypeScript/issues/26104
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/26236
https://github.com/ahejlsberg
https://github.com/sandersn
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.