| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:ac90ff61-81a8-b685-4276-32acec008941 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A066:2463BD:2A28CF0:35D756A:6B019B09 |
| html-safe-nonce | e9797d480b24ece63f8f5c7d954b93422ea3887656412fc9f5a43347260f40cb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDY2OjI0NjNCRDoyQTI4Q0YwOjM1RDc1NkE6NkIwMTlCMDkiLCJ2aXNpdG9yX2lkIjoiNjE4NjQwOTE4NDg2MzU1ODQwOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 98a5389add9396b70142a68ac0303dc95451d3615d5f7c24f78d725777a52a0f |
| hovercard-subject-tag | pull_request:206462245 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/26236/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f4b0f0723b391767b2512ebceace7f8b15682687182ff9e5e8d08d2208bcc61f/microsoft/TypeScript/pull/26236 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f4b0f0723b391767b2512ebceace7f8b15682687182ff9e5e8d08d2208bcc61f/microsoft/TypeScript/pull/26236 |
| og:image:alt | With this PR we consistently defer resolving signature return types such that our circularity detection logic can properly catch circular references in return types.
This PR also consolidates a bun... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ahejlsberg |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/26236#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F26236 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F26236 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/26236 |
| Reload | https://github.com/microsoft/TypeScript/pull/26236 |
| Reload | https://github.com/microsoft/TypeScript/pull/26236 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests312 (312) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| master | https://github.com/microsoft/TypeScript/tree/master |
| fixCircularReturnType | https://github.com/microsoft/TypeScript/tree/fixCircularReturnType |
| Conversation | https://github.com/microsoft/TypeScript/pull/26236 |
| Commits12 (12) | https://github.com/microsoft/TypeScript/pull/26236/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/26236/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/26236/files |
| Fix circular return type issue | https://github.com/microsoft/TypeScript/pull/26236#top |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| master | https://github.com/microsoft/TypeScript/tree/master |
| fixCircularReturnType | https://github.com/microsoft/TypeScript/tree/fixCircularReturnType |
|
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| Aug 6, 2018 | https://github.com/microsoft/TypeScript/pull/26236#issue-348008716 |
| #26104 | https://github.com/microsoft/TypeScript/issues/26104 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/26236 |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| August 3, 2018 14:03 | https://github.com/microsoft/TypeScript/pull/26236#commits-pushed-e4443bb |
|
| https://github.com/ahejlsberg |
| Properly catch and error on circular function return types | https://github.com/microsoft/TypeScript/pull/26236/commits/e4443bb993929de9b94c779ebdba045e88aac858 |
| e4443bb | https://github.com/microsoft/TypeScript/pull/26236/commits/e4443bb993929de9b94c779ebdba045e88aac858 |
|
| https://github.com/ahejlsberg |
| Accept new baselines | https://github.com/microsoft/TypeScript/pull/26236/commits/a75fe5194e1f04944ece146d9cb7ec0d538ec771 |
| a75fe51 | https://github.com/microsoft/TypeScript/pull/26236/commits/a75fe5194e1f04944ece146d9cb7ec0d538ec771 |
|
| https://github.com/ahejlsberg |
| Erase type parameters when fetching return type from JSDoc | https://github.com/microsoft/TypeScript/pull/26236/commits/539775779e00117cf9e94c004beddf82311bbe54 |
| @type | https://github.com/type |
| tag | https://github.com/microsoft/TypeScript/pull/26236/commits/539775779e00117cf9e94c004beddf82311bbe54 |
| 5397757 | https://github.com/microsoft/TypeScript/pull/26236/commits/539775779e00117cf9e94c004beddf82311bbe54 |
|
| https://github.com/ahejlsberg |
| Ensure type parameters are erased in contextual signature from | https://github.com/microsoft/TypeScript/pull/26236/commits/ee721225aeb3753a9522785f6ecf9d95a6f27346 |
| @type | https://github.com/type |
| tag | https://github.com/microsoft/TypeScript/pull/26236/commits/ee721225aeb3753a9522785f6ecf9d95a6f27346 |
| ee72122 | https://github.com/microsoft/TypeScript/pull/26236/commits/ee721225aeb3753a9522785f6ecf9d95a6f27346 |
|
| https://github.com/ahejlsberg |
| Accept new baselines | https://github.com/microsoft/TypeScript/pull/26236/commits/faed2d2c3344f8ad6a693dc3e4c03a4bf86d05bd |
| faed2d2 | https://github.com/microsoft/TypeScript/pull/26236/commits/faed2d2c3344f8ad6a693dc3e4c03a4bf86d05bd |
|
| https://github.com/ahejlsberg |
| Clean up return type checking logic | https://github.com/microsoft/TypeScript/pull/26236/commits/ab7defa5eae51b3c1bc5c125f05024aee0316ec5 |
| ab7defa | https://github.com/microsoft/TypeScript/pull/26236/commits/ab7defa5eae51b3c1bc5c125f05024aee0316ec5 |
|
| https://github.com/ahejlsberg |
| Accept new baselines | https://github.com/microsoft/TypeScript/pull/26236/commits/c367b91da73025bd92e1278e006972b3e9b98571 |
| c367b91 | https://github.com/microsoft/TypeScript/pull/26236/commits/c367b91da73025bd92e1278e006972b3e9b98571 |
|
| https://github.com/ahejlsberg |
| Use getReturnTypeFromAnnotation instead of ad hoc checks | https://github.com/microsoft/TypeScript/pull/26236/commits/dc34c5e7196ff4d4b6bfffb80e46814d444742dd |
| dc34c5e | https://github.com/microsoft/TypeScript/pull/26236/commits/dc34c5e7196ff4d4b6bfffb80e46814d444742dd |
|
| https://github.com/ahejlsberg |
| Add regression tests | https://github.com/microsoft/TypeScript/pull/26236/commits/efdbbd1cf3b1009a13755bfc97c518243c71ae50 |
| efdbbd1 | https://github.com/microsoft/TypeScript/pull/26236/commits/efdbbd1cf3b1009a13755bfc97c518243c71ae50 |
|
| https://github.com/ahejlsberg |
| Accept new baselines | https://github.com/microsoft/TypeScript/pull/26236/commits/9c3dc96dc1d9b6d1b3b388c1604ff5185a794959 |
| 9c3dc96 | https://github.com/microsoft/TypeScript/pull/26236/commits/9c3dc96dc1d9b6d1b3b388c1604ff5185a794959 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| Ryan Cavanaugh (RyanCavanaugh) | https://github.com/RyanCavanaugh |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| August 6, 2018 17:11 | https://github.com/microsoft/TypeScript/pull/26236#event-1773413539 |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| August 6, 2018 10:42 | https://github.com/microsoft/TypeScript/pull/26236#commits-pushed-6a17f4d |
|
| https://github.com/ahejlsberg |
| Merge branch 'master' into fixCircularReturnType | https://github.com/microsoft/TypeScript/pull/26236/commits/6a17f4d16201d9faae6022ddaa00f8acc290d92d |
| 6a17f4d | https://github.com/microsoft/TypeScript/pull/26236/commits/6a17f4d16201d9faae6022ddaa00f8acc290d92d |
|
| https://github.com/ahejlsberg |
| Merge branch 'master' into fixCircularReturnType | https://github.com/microsoft/TypeScript/pull/26236/commits/cfa29ae2faf5944da252d1fb7b8a5bae2f06fe71 |
| cfa29ae | https://github.com/microsoft/TypeScript/pull/26236/commits/cfa29ae2faf5944da252d1fb7b8a5bae2f06fe71 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
|
Aug 6, 2018
| https://github.com/microsoft/TypeScript/pull/26236#pullrequestreview-143704282 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/26236/files/cfa29ae2faf5944da252d1fb7b8a5bae2f06fe71 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| eeb19c1 | https://github.com/microsoft/TypeScript/commit/eeb19c1e228e26d3d85633d8ac338e43d1535063 |
| Aug 6, 2018 | https://github.com/microsoft/TypeScript/pull/26236#event-1774067359 |
| https://github.com/ahejlsberg |
| Anders Hejlsberg (ahejlsberg) | https://github.com/ahejlsberg |
| August 6, 2018 23:38 | https://github.com/microsoft/TypeScript/pull/26236#event-1774067539 |
|
🤖 User test baselines have changed
#26256
| https://github.com/microsoft/TypeScript/pull/26256 |
|
In JS, extra circular reference errors when referring to a missing property on module
#26268
| https://github.com/microsoft/TypeScript/issues/26268 |
| https://github.com/masterkidan |
| Mukundan Kidambi (masterkidan) | https://github.com/masterkidan |
|
Jan 24, 2019
| https://github.com/microsoft/TypeScript/pull/26236#ref-issue-402875347 |
|
DeepReadonly type fails to compile on typescript 3.1.1+
#29566
| https://github.com/microsoft/TypeScript/issues/29566 |
|
In JS, @type tag doesn't apply generic type to initialiser
#42060
| https://github.com/microsoft/TypeScript/issues/42060 |
|
Do not erase signatures in getSignatureOfTypeTag
#43688
| https://github.com/microsoft/TypeScript/pull/43688 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Oct 21, 2025 | https://github.com/microsoft/TypeScript/pull/26236#event-20415761733 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F26236 |
|
| https://github.com/sandersn |
|
Nathan Shively-Sanders (sandersn)
| https://github.com/sandersn |
|
| https://github.com/microsoft/TypeScript/pull/26236/files/cfa29ae2faf5944da252d1fb7b8a5bae2f06fe71 |
|
| https://github.com/RyanCavanaugh |
|
Ryan Cavanaugh (RyanCavanaugh)
| https://github.com/RyanCavanaugh |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/26236 |
|
Type alias circular reference does not error and causes implicit any
| https://github.com/microsoft/TypeScript/issues/26104 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/26236 |
|
| https://github.com/ahejlsberg |
|
| https://github.com/sandersn |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |