René's URL Explorer Experiment


Title: Call toPath on sourceRoot to ensure it is always absolute by weswigham · Pull Request #25838 · microsoft/TypeScript · GitHub

Open Graph Title: Call toPath on sourceRoot to ensure it is always absolute by weswigham · Pull Request #25838 · microsoft/TypeScript

X Title: Call toPath on sourceRoot to ensure it is always absolute by weswigham · Pull Request #25838 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Call toPath on sourceRoot to ensure it is always absolute by weswigham · Pull Request #25838 · microsoft/TypeScript

Open Graph Description: Fixes #25322

X Description: Fixes #25322

Opengraph URL: https://github.com/microsoft/TypeScript/pull/25838

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:55ccd297-e533-3acb-9876-93b80ef69f7c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC530:2E7EBB:2A38756:356639C:6B019F28
html-safe-nonce63f499448d0feb88b727257e4ba88c776c86c245ef2aab8ca09e9301a6fd7728
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTMwOjJFN0VCQjoyQTM4NzU2OjM1NjYzOUM6NkIwMTlGMjgiLCJ2aXNpdG9yX2lkIjoiNTU2Mzk3ODQ5NTY0NzkxNTgxNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac353530dbb24471596cd239fc69ddd655bf26a252328dc760c6a6e3929620f68c
hovercard-subject-tagpull_request:202951440
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/25838/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/995936c0052a56e6a8ddc501ea489139a28915bcd27f9c8f22b17b5938251e9b/microsoft/TypeScript/pull/25838
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/995936c0052a56e6a8ddc501ea489139a28915bcd27f9c8f22b17b5938251e9b/microsoft/TypeScript/pull/25838
og:image:altFixes #25322
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameweswigham
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/25838#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F25838
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F25838
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/25838
Reloadhttps://github.com/microsoft/TypeScript/pull/25838
Reloadhttps://github.com/microsoft/TypeScript/pull/25838
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
weswigham:handle-relative-sourceRoothttps://github.com/weswigham/TypeScript/tree/handle-relative-sourceRoot
Conversationhttps://github.com/microsoft/TypeScript/pull/25838
Commits2 (2)https://github.com/microsoft/TypeScript/pull/25838/commits
Checkshttps://github.com/microsoft/TypeScript/pull/25838/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/25838/files
Call toPath on sourceRoot to ensure it is always absolutehttps://github.com/microsoft/TypeScript/pull/25838#top
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
weswigham:handle-relative-sourceRoothttps://github.com/weswigham/TypeScript/tree/handle-relative-sourceRoot
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Jul 20, 2018https://github.com/microsoft/TypeScript/pull/25838#issue-343241183
#25322https://github.com/microsoft/TypeScript/issues/25322
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/25838
https://github.com/weswigham
Call toPath on sourceRoot to ensure it is always absolutehttps://github.com/microsoft/TypeScript/pull/25838/commits/d2d315705d4e968043ec6bf0c75b128dba7e5c7d
d2d3157https://github.com/microsoft/TypeScript/pull/25838/commits/d2d315705d4e968043ec6bf0c75b128dba7e5c7d
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
July 20, 2018 20:41https://github.com/microsoft/TypeScript/pull/25838#event-1745643687
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
Jul 20, 2018 https://github.com/microsoft/TypeScript/pull/25838#pullrequestreview-139220981
View reviewed changes https://github.com/microsoft/TypeScript/pull/25838/files/d2d315705d4e968043ec6bf0c75b128dba7e5c7d
tests/cases/fourslash/server/declarationMapsGoToDefinitionRelativeSourceRoot.tshttps://github.com/microsoft/TypeScript/pull/25838/files/d2d315705d4e968043ec6bf0c75b128dba7e5c7d#diff-fc0dab4a1456efc2810d6b074ff598083ab4b6b9f1339e3eb2d747a6b4577c39
Deleted user (ghost)https://github.com/ghost
Jul 20, 2018https://github.com/microsoft/TypeScript/pull/25838#discussion_r204177577
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/25838
Wesley Wigham (weswigham)https://github.com/weswigham
Jul 20, 2018https://github.com/microsoft/TypeScript/pull/25838#discussion_r204177729
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/25838
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/25838
https://github.com/sheetalkamat
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
Jul 20, 2018 https://github.com/microsoft/TypeScript/pull/25838#pullrequestreview-139227962
View reviewed changes https://github.com/microsoft/TypeScript/pull/25838/files/d2d315705d4e968043ec6bf0c75b128dba7e5c7d
src/compiler/sourcemapDecoder.tshttps://github.com/microsoft/TypeScript/pull/25838/files/d2d315705d4e968043ec6bf0c75b128dba7e5c7d#diff-af5251fca4cf4afa36cda6e8a14cb71622951696b3de04dcecd4c183aff9a8e1
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
Jul 20, 2018https://github.com/microsoft/TypeScript/pull/25838#discussion_r204183485
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/25838
Wesley Wigham (weswigham)https://github.com/weswigham
Jul 21, 2018https://github.com/microsoft/TypeScript/pull/25838#discussion_r204194400
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/25838
https://github.com/weswigham
Leave canonicalization to avoid a Path/string unionhttps://github.com/microsoft/TypeScript/pull/25838/commits/3c02e24a2a7ca8a7f79a5c603d0402e3c4777e21
3c02e24https://github.com/microsoft/TypeScript/pull/25838/commits/3c02e24a2a7ca8a7f79a5c603d0402e3c4777e21
https://github.com/sheetalkamat
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
Jul 24, 2018 https://github.com/microsoft/TypeScript/pull/25838#pullrequestreview-140019377
View reviewed changes https://github.com/microsoft/TypeScript/pull/25838/files/3c02e24a2a7ca8a7f79a5c603d0402e3c4777e21
src/compiler/sourcemapDecoder.tshttps://github.com/microsoft/TypeScript/pull/25838/files/3c02e24a2a7ca8a7f79a5c603d0402e3c4777e21#diff-af5251fca4cf4afa36cda6e8a14cb71622951696b3de04dcecd4c183aff9a8e1
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
Jul 24, 2018https://github.com/microsoft/TypeScript/pull/25838#discussion_r204862153
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/25838
Wesley Wigham (weswigham)https://github.com/weswigham
Jul 24, 2018https://github.com/microsoft/TypeScript/pull/25838#discussion_r204897971
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/25838
https://github.com/sheetalkamat
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
Jul 24, 2018 https://github.com/microsoft/TypeScript/pull/25838#pullrequestreview-140077431
View reviewed changes https://github.com/microsoft/TypeScript/pull/25838/files/3c02e24a2a7ca8a7f79a5c603d0402e3c4777e21
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Jul 24, 2018https://github.com/microsoft/TypeScript/pull/25838#issuecomment-407552447
Wesley Wigham (@weswigham)https://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/25838
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
797d8bdhttps://github.com/microsoft/TypeScript/commit/797d8bd07b3c563ef43db56a679b1b6263a0a19b
Jul 24, 2018https://github.com/microsoft/TypeScript/pull/25838#event-1751209534
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
July 24, 2018 21:14https://github.com/microsoft/TypeScript/pull/25838#event-1751209673
Wesley Wigham (weswigham)https://github.com/weswigham
Jul 24, 2018 https://github.com/microsoft/TypeScript/pull/25838#ref-commit-0e4db07
https://github.com/weswigham
Call toPath on sourceRoot to ensure it is always absolute (https://github.com/weswigham/TypeScript/commit/0e4db0758bbe0dff93307d90c75cbe1cd4c0b0cc
microsoft#…https://github.com/microsoft/TypeScript/pull/25838
0e4db07https://github.com/weswigham/TypeScript/commit/0e4db0758bbe0dff93307d90c75cbe1cd4c0b0cc
…25838https://github.com/microsoft/TypeScript/pull/25838
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Jul 24, 2018 https://github.com/microsoft/TypeScript/pull/25838#ref-pullrequest-344207138
Call toPath on sourceRoot to ensure it is always absolute (#25838) #25904 https://github.com/microsoft/TypeScript/pull/25904
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Jul 24, 2018 https://github.com/microsoft/TypeScript/pull/25838#ref-commit-fe3bb58
https://github.com/mhegazy
Merge pull requesthttps://github.com/microsoft/TypeScript/commit/fe3bb5888ccc60e710ad0fd3eaab03d96524c8b0
#25904https://github.com/microsoft/TypeScript/pull/25904
from weswigham/port-25838https://github.com/microsoft/TypeScript/commit/fe3bb5888ccc60e710ad0fd3eaab03d96524c8b0
fe3bb58https://github.com/microsoft/TypeScript/commit/fe3bb5888ccc60e710ad0fd3eaab03d96524c8b0
#25838https://github.com/microsoft/TypeScript/pull/25838
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/25838#event-20415744286
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Wesley Wigham (weswigham)https://github.com/weswigham
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/25838#event-20415744897
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F25838
https://github.com/sheetalkamat
Sheetal Nandi (sheetalkamat) https://github.com/sheetalkamat
https://github.com/microsoft/TypeScript/pull/25838/files/3c02e24a2a7ca8a7f79a5c603d0402e3c4777e21
https://github.com/mhegazy
Mohamed Hegazy (mhegazy) https://github.com/mhegazy
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/25838
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/25838
https://github.com/weswigham
https://github.com/mhegazy
https://github.com/sheetalkamat
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.