René's URL Explorer Experiment


Title: Excess property understands conditional types by sandersn · Pull Request #25584 · microsoft/TypeScript · GitHub

Open Graph Title: Excess property understands conditional types by sandersn · Pull Request #25584 · microsoft/TypeScript

X Title: Excess property understands conditional types by sandersn · Pull Request #25584 · microsoft/TypeScript

Description: Previously it did not, causing misleading excess property errors. Note that assignability errors with conditional types are still usually confusing. This PR doesn't address that. Also, make sure that exact matches in getSpellingSuggestion are skipped. Fixes #25564

Open Graph Description: Previously it did not, causing misleading excess property errors. Note that assignability errors with conditional types are still usually confusing. This PR doesn't address that. Also, make sur...

X Description: Previously it did not, causing misleading excess property errors. Note that assignability errors with conditional types are still usually confusing. This PR doesn't address that. Also, make...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/25584

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:58df05a7-4719-7e19-9f68-862863fdd5aa
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9A7E:2D2F2F:260AFE1:308F5B7:6B0181A0
html-safe-noncefbb15442fb2e71a0a78979b28b19552d8440eb4fc3fc96598a9757dc23d6039b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTdFOjJEMkYyRjoyNjBBRkUxOjMwOEY1Qjc6NkIwMTgxQTAiLCJ2aXNpdG9yX2lkIjoiMTY0MjM0NzgwMDE3MzgzODc1MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac196cd3ca76f401191cb7e7599a3ffd2e8ca3a180676d48e1f4a2de7f6ffe7ca8
hovercard-subject-tagpull_request:200772956
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/microsoft/TypeScript/pull/25584/files
twitter:imagehttps://avatars.githubusercontent.com/u/293473?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/293473?s=400&v=4
og:image:altPreviously it did not, causing misleading excess property errors. Note that assignability errors with conditional types are still usually confusing. This PR doesn't address that. Also, make sur...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/25584/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F25584%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F25584%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/25584/files
Reloadhttps://github.com/microsoft/TypeScript/pull/25584/files
Reloadhttps://github.com/microsoft/TypeScript/pull/25584/files
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fmicrosoft%2FTypeScript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmicrosoft%2FTypeScript%2Fissues%2Fnew%2Fchoose
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
excess-property-understands-conditionalshttps://github.com/microsoft/TypeScript/tree/excess-property-understands-conditionals
Conversation 0 https://github.com/microsoft/TypeScript/pull/25584
Commits 1 https://github.com/microsoft/TypeScript/pull/25584/commits
Checks 0 https://github.com/microsoft/TypeScript/pull/25584/checks
Files changed https://github.com/microsoft/TypeScript/pull/25584/files
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/25584/files
Excess property understands conditional types https://github.com/microsoft/TypeScript/pull/25584/files#top
Show all changes 1 commit https://github.com/microsoft/TypeScript/pull/25584/files
ff969a4 Excess property understands conditional types sandersn Jul 11, 2018 https://github.com/microsoft/TypeScript/pull/25584/commits/ff969a44d3709f4e561996018730d6a35b263908
Clear filters https://github.com/microsoft/TypeScript/pull/25584/files
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/25584/files
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/25584/files
checker.ts https://github.com/microsoft/TypeScript/pull/25584/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
core.ts https://github.com/microsoft/TypeScript/pull/25584/files#diff-8eee8edc4cdf82aaa3b0c0ba3c8c74fa80ac6d5214540a460c49fb2ee1031b25
conditionalTypesExcessProperties.errors.txt https://github.com/microsoft/TypeScript/pull/25584/files#diff-78dac4fa898dacf1757205ceacbfa0bfb1ea3337870cdf900d50efbeaf04d861
conditionalTypesExcessProperties.js https://github.com/microsoft/TypeScript/pull/25584/files#diff-50eec5890012e07cfff383a8a5b5867b7190aeb6a772386fdb486613a9db57ae
conditionalTypesExcessProperties.symbols https://github.com/microsoft/TypeScript/pull/25584/files#diff-1f0a75b646fa0ffc07658ee9ea4bb5955dd64cd8b58f5fd28524b50d71753613
conditionalTypesExcessProperties.types https://github.com/microsoft/TypeScript/pull/25584/files#diff-26ea7944ae178bfe836712162ceeeaff8982c4975e86a62e9b17e865d55e2f24
conditionalTypesExcessProperties.ts https://github.com/microsoft/TypeScript/pull/25584/files#diff-9c013acdae8a0a9b1782df1d75e28a19103790a8c729dbdd281db3dc2af0de99
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/25584/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
View file https://github.com/microsoft/TypeScript/blob/ff969a44d3709f4e561996018730d6a35b263908/src/compiler/checker.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/25584/{{ revealButtonHref }}
https://github.com/microsoft/TypeScript/pull/25584/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
https://github.com/microsoft/TypeScript/pull/25584/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
https://github.com/microsoft/TypeScript/pull/25584/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
src/compiler/core.tshttps://github.com/microsoft/TypeScript/pull/25584/files#diff-8eee8edc4cdf82aaa3b0c0ba3c8c74fa80ac6d5214540a460c49fb2ee1031b25
View file https://github.com/microsoft/TypeScript/blob/ff969a44d3709f4e561996018730d6a35b263908/src/compiler/core.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/25584/{{ revealButtonHref }}
https://github.com/microsoft/TypeScript/pull/25584/files#diff-8eee8edc4cdf82aaa3b0c0ba3c8c74fa80ac6d5214540a460c49fb2ee1031b25
https://github.com/microsoft/TypeScript/pull/25584/files#diff-8eee8edc4cdf82aaa3b0c0ba3c8c74fa80ac6d5214540a460c49fb2ee1031b25
tests/baselines/reference/conditionalTypesExcessProperties.errors.txthttps://github.com/microsoft/TypeScript/pull/25584/files#diff-78dac4fa898dacf1757205ceacbfa0bfb1ea3337870cdf900d50efbeaf04d861
View file https://github.com/microsoft/TypeScript/blob/ff969a44d3709f4e561996018730d6a35b263908/tests/baselines/reference/conditionalTypesExcessProperties.errors.txt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/25584/{{ revealButtonHref }}
tests/baselines/reference/conditionalTypesExcessProperties.jshttps://github.com/microsoft/TypeScript/pull/25584/files#diff-50eec5890012e07cfff383a8a5b5867b7190aeb6a772386fdb486613a9db57ae
View file https://github.com/microsoft/TypeScript/blob/ff969a44d3709f4e561996018730d6a35b263908/tests/baselines/reference/conditionalTypesExcessProperties.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/25584/{{ revealButtonHref }}
tests/baselines/reference/conditionalTypesExcessProperties.symbolshttps://github.com/microsoft/TypeScript/pull/25584/files#diff-1f0a75b646fa0ffc07658ee9ea4bb5955dd64cd8b58f5fd28524b50d71753613
View file https://github.com/microsoft/TypeScript/blob/ff969a44d3709f4e561996018730d6a35b263908/tests/baselines/reference/conditionalTypesExcessProperties.symbols
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/25584/{{ revealButtonHref }}
tests/baselines/reference/conditionalTypesExcessProperties.typeshttps://github.com/microsoft/TypeScript/pull/25584/files#diff-26ea7944ae178bfe836712162ceeeaff8982c4975e86a62e9b17e865d55e2f24
View file https://github.com/microsoft/TypeScript/blob/ff969a44d3709f4e561996018730d6a35b263908/tests/baselines/reference/conditionalTypesExcessProperties.types
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/25584/{{ revealButtonHref }}
tests/cases/conformance/types/conditional/conditionalTypesExcessProperties.tshttps://github.com/microsoft/TypeScript/pull/25584/files#diff-9c013acdae8a0a9b1782df1d75e28a19103790a8c729dbdd281db3dc2af0de99
View file https://github.com/microsoft/TypeScript/blob/ff969a44d3709f4e561996018730d6a35b263908/tests/cases/conformance/types/conditional/conditionalTypesExcessProperties.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/25584/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.