René's URL Explorer Experiment


Title: Fix crash when binding jsdoc-style inner namepaths by sandersn · Pull Request #25106 · microsoft/TypeScript · GitHub

Open Graph Title: Fix crash when binding jsdoc-style inner namepaths by sandersn · Pull Request #25106 · microsoft/TypeScript

X Title: Fix crash when binding jsdoc-style inner namepaths by sandersn · Pull Request #25106 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Fix crash when binding jsdoc-style inner namepaths by sandersn · Pull Request #25106 · microsoft/TypeScript

Open Graph Description: getNameOfDeclaration actually doesn't handle all declarations, only those that produce names that could be reasonably used as an identifier. Until now, getDeclarationIdentifier assumed that ge...

X Description: getNameOfDeclaration actually doesn't handle all declarations, only those that produce names that could be reasonably used as an identifier. Until now, getDeclarationIdentifier assumed tha...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/25106

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5a3b72a4-2b45-6d42-bfe9-5cbeaf7cfe7a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA52C:313081:CBFFF:10E046:6B018286
html-safe-noncee67042b2076d06109a4c5ff126815a6f45696a06a3d36cb56956f5fc6db74be1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTJDOjMxMzA4MTpDQkZGRjoxMEUwNDY6NkIwMTgyODYiLCJ2aXNpdG9yX2lkIjoiNzg4NDA3Njk5NTIzODI2NTQ3OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9d97f1a2d2b3370a0f26ba447a6ed0f5f7901a2c349cc57466be7d3f6db28d3f
hovercard-subject-tagpull_request:196267981
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/25106/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/30069af754ddd893eb05d2d50978a9101bb1c1d9da68f8d26ed2471eb381eaa8/microsoft/TypeScript/pull/25106
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/30069af754ddd893eb05d2d50978a9101bb1c1d9da68f8d26ed2471eb381eaa8/microsoft/TypeScript/pull/25106
og:image:altgetNameOfDeclaration actually doesn't handle all declarations, only those that produce names that could be reasonably used as an identifier. Until now, getDeclarationIdentifier assumed that ge...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesandersn
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/25106#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F25106
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F25106
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/25106
Reloadhttps://github.com/microsoft/TypeScript/pull/25106
Reloadhttps://github.com/microsoft/TypeScript/pull/25106
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
fix-crash-when-binding-inner-namepathshttps://github.com/microsoft/TypeScript/tree/fix-crash-when-binding-inner-namepaths
Conversationhttps://github.com/microsoft/TypeScript/pull/25106
Commits4 (4)https://github.com/microsoft/TypeScript/pull/25106/commits
Checkshttps://github.com/microsoft/TypeScript/pull/25106/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/25106/files
Fix crash when binding jsdoc-style inner namepathshttps://github.com/microsoft/TypeScript/pull/25106#top
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
fix-crash-when-binding-inner-namepathshttps://github.com/microsoft/TypeScript/tree/fix-crash-when-binding-inner-namepaths
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jun 20, 2018https://github.com/microsoft/TypeScript/pull/25106#issue-334243911
#25104https://github.com/microsoft/TypeScript/issues/25104
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/25106
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
June 20, 2018 13:39https://github.com/microsoft/TypeScript/pull/25106#commits-pushed-3b92eb5
https://github.com/sandersn
getDeclarationIdentifier handles undefined namehttps://github.com/microsoft/TypeScript/pull/25106/commits/3b92eb515519cd1e013e4cf351df1b7baa93ab9a
3b92eb5https://github.com/microsoft/TypeScript/pull/25106/commits/3b92eb515519cd1e013e4cf351df1b7baa93ab9a
https://github.com/sandersn
Add test and baselineshttps://github.com/microsoft/TypeScript/pull/25106/commits/8bc41fc7e6317b2267bd8efe0ff05d1046f48f69
8bc41fchttps://github.com/microsoft/TypeScript/pull/25106/commits/8bc41fc7e6317b2267bd8efe0ff05d1046f48f69
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
June 20, 2018 20:49https://github.com/microsoft/TypeScript/pull/25106#event-1692186275
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Jun 20, 2018 https://github.com/microsoft/TypeScript/pull/25106#pullrequestreview-130585341
View reviewed changes https://github.com/microsoft/TypeScript/pull/25106/files/8bc41fc7e6317b2267bd8efe0ff05d1046f48f69
src/compiler/utilities.tshttps://github.com/microsoft/TypeScript/pull/25106/files/8bc41fc7e6317b2267bd8efe0ff05d1046f48f69#diff-1516c8349f7a625a2e4a2aa60f6bbe84e4b1a499128e8705d3087d893e01d367
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Jun 20, 2018https://github.com/microsoft/TypeScript/pull/25106#discussion_r196939545
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/25106
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jun 20, 2018https://github.com/microsoft/TypeScript/pull/25106#discussion_r196970600
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/25106
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
June 21, 2018 09:33https://github.com/microsoft/TypeScript/pull/25106#commits-pushed-a1d6217
https://github.com/sandersn
getNameOfDeclaration can return undefinedhttps://github.com/microsoft/TypeScript/pull/25106/commits/a1d6217afa00172eabc5bd3036f34c670a163e5e
a1d6217https://github.com/microsoft/TypeScript/pull/25106/commits/a1d6217afa00172eabc5bd3036f34c670a163e5e
https://github.com/sandersn
Fix linthttps://github.com/microsoft/TypeScript/pull/25106/commits/ddb60c7a5d8ad040af6c16e385d4fc55c8a8ab6d
ddb60c7https://github.com/microsoft/TypeScript/pull/25106/commits/ddb60c7a5d8ad040af6c16e385d4fc55c8a8ab6d
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jun 21, 2018 https://github.com/microsoft/TypeScript/pull/25106#pullrequestreview-130899402
View reviewed changes https://github.com/microsoft/TypeScript/pull/25106/files/ddb60c7a5d8ad040af6c16e385d4fc55c8a8ab6d
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/25106/files/ddb60c7a5d8ad040af6c16e385d4fc55c8a8ab6d#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jun 21, 2018https://github.com/microsoft/TypeScript/pull/25106#discussion_r197201038
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/25106
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Jun 21, 2018 https://github.com/microsoft/TypeScript/pull/25106#pullrequestreview-130901699
View reviewed changes https://github.com/microsoft/TypeScript/pull/25106/files/ddb60c7a5d8ad040af6c16e385d4fc55c8a8ab6d
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
43d0794https://github.com/microsoft/TypeScript/commit/43d0794ba355efb8fe257ef5fffc1db186c37cd0
Jun 21, 2018https://github.com/microsoft/TypeScript/pull/25106#event-1694184393
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
June 21, 2018 17:01https://github.com/microsoft/TypeScript/pull/25106#event-1694184504
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
Jun 21, 2018 https://github.com/microsoft/TypeScript/pull/25106#pullrequestreview-130913631
View reviewed changes https://github.com/microsoft/TypeScript/pull/25106/files/ddb60c7a5d8ad040af6c16e385d4fc55c8a8ab6d
Deleted user (ghost)https://github.com/ghost
https://github.com/microsoft/TypeScript/pull/25106#pullrequestreview-130913631
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/25106
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/25106#event-20415710543
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Oct 21, 2025https://github.com/microsoft/TypeScript/pull/25106#event-20415711164
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F25106
https://github.com/sheetalkamat
Sheetal Nandi (sheetalkamat) https://github.com/sheetalkamat
https://github.com/mhegazy
Mohamed Hegazy (mhegazy) https://github.com/mhegazy
https://github.com/microsoft/TypeScript/pull/25106/files/ddb60c7a5d8ad040af6c16e385d4fc55c8a8ab6d
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/25106
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/25106
https://github.com/sandersn
https://github.com/mhegazy
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.