René's URL Explorer Experiment


Title: Share code between getCompletionsAtPosition and getCompletionEntryDetails. by CyrusNajmabadi · Pull Request #2475 · microsoft/TypeScript · GitHub

Open Graph Title: Share code between getCompletionsAtPosition and getCompletionEntryDetails. by CyrusNajmabadi · Pull Request #2475 · microsoft/TypeScript

X Title: Share code between getCompletionsAtPosition and getCompletionEntryDetails. by CyrusNajmabadi · Pull Request #2475 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Share code between getCompletionsAtPosition and getCompletionEntryDetails. by CyrusNajmabadi · Pull Request #2475 · microsoft/TypeScript

Open Graph Description: Previously, the completion item code in teh LS did something fairly unsafe. it would cache information about symbols from a previous version of the 'program' (and typechecker), and then at...

X Description: Previously, the completion item code in teh LS did something fairly unsafe. it would cache information about symbols from a previous version of the 'program' (and typechecker), and...

Mail addresses
notifications@github.com

Opengraph URL: https://github.com/microsoft/TypeScript/pull/2475

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:62cc9872-f2d6-1e6b-3f5d-582967a14964
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE376:4BB79:1087E3D:151F06E:6B011876
html-safe-nonce1f1767bbe124729ab221e9d7da80a4d77c8d528e88d7c3780914c24db3e668af
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzc2OjRCQjc5OjEwODdFM0Q6MTUxRjA2RTo2QjAxMTg3NiIsInZpc2l0b3JfaWQiOiI5MDQ5OTA2Nzk2NDE5OTQ2NjE0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac96bf7caa64887a1106d5752b5b247440098100374be9ed096df2f23fe6c10a18
hovercard-subject-tagpull_request:31797438
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/2475/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/942d2a64eaa9f19490da630585723de65b6bd490de1a0391c14a66eb40c4428d/microsoft/TypeScript/pull/2475
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/942d2a64eaa9f19490da630585723de65b6bd490de1a0391c14a66eb40c4428d/microsoft/TypeScript/pull/2475
og:image:altPreviously, the completion item code in teh LS did something fairly unsafe. it would cache information about symbols from a previous version of the 'program' (and typechecker), and then at...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameCyrusNajmabadi
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/2475#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F2475
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F2475
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/2475
Reloadhttps://github.com/microsoft/TypeScript/pull/2475
Reloadhttps://github.com/microsoft/TypeScript/pull/2475
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests310 (310)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Cyrus Najmabadi (CyrusNajmabadi)https://github.com/CyrusNajmabadi
masterhttps://github.com/microsoft/TypeScript/tree/master
completionEntryDetailshttps://github.com/microsoft/TypeScript/tree/completionEntryDetails
Conversationhttps://github.com/microsoft/TypeScript/pull/2475
Commits13 (13)https://github.com/microsoft/TypeScript/pull/2475/commits
Checkshttps://github.com/microsoft/TypeScript/pull/2475/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/2475/files
Share code between getCompletionsAtPosition and getCompletionEntryDetails.https://github.com/microsoft/TypeScript/pull/2475#top
Cyrus Najmabadi (CyrusNajmabadi)https://github.com/CyrusNajmabadi
masterhttps://github.com/microsoft/TypeScript/tree/master
completionEntryDetailshttps://github.com/microsoft/TypeScript/tree/completionEntryDetails
https://github.com/CyrusNajmabadi
Cyrus Najmabadi (CyrusNajmabadi)https://github.com/CyrusNajmabadi
Mar 24, 2015https://github.com/microsoft/TypeScript/pull/2475#issue-63903161
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/2475
Cyrus Najmabadi (CyrusNajmabadi)https://github.com/CyrusNajmabadi
March 23, 2015 20:56https://github.com/microsoft/TypeScript/pull/2475#commits-pushed-bce9b5a
https://github.com/CyrusNajmabadi
Break out completion symbol collection into its own function.https://github.com/microsoft/TypeScript/pull/2475/commits/bce9b5ab5ab20b3d385fd734e53445b6f25e6426
bce9b5ahttps://github.com/microsoft/TypeScript/pull/2475/commits/bce9b5ab5ab20b3d385fd734e53445b6f25e6426
https://github.com/CyrusNajmabadi
Use the same logic for completion entry details that we do for gettin…https://github.com/microsoft/TypeScript/pull/2475/commits/a1cbfdf01d62f6fa39cc1951026b9fe868eefada
a1cbfdfhttps://github.com/microsoft/TypeScript/pull/2475/commits/a1cbfdf01d62f6fa39cc1951026b9fe868eefada
https://github.com/CyrusNajmabadi
Remove the active completion session.https://github.com/microsoft/TypeScript/pull/2475/commits/66b3fae09a2be47ed0aaa4c052cc1b2ea9a875ed
66b3faehttps://github.com/microsoft/TypeScript/pull/2475/commits/66b3fae09a2be47ed0aaa4c052cc1b2ea9a875ed
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
Mar 24, 2015https://github.com/microsoft/TypeScript/pull/2475#event-263122710
DanielRosenwasserhttps://github.com/DanielRosenwasser
Mar 24, 2015 https://github.com/microsoft/TypeScript/pull/2475#discussion-diff-27003432
View reviewed changes https://github.com/microsoft/TypeScript/pull/2475/files/66b3fae09a2be47ed0aaa4c052cc1b2ea9a875ed#diff-2dc319893c8723737436e91a4ec39b69623ee0bbeebf0b260778015d79d97632
src/services/services.tshttps://github.com/microsoft/TypeScript/pull/2475/files#diff-2dc319893c8723737436e91a4ec39b69623ee0bbeebf0b260778015d79d97632
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Mar 24, 2015https://github.com/microsoft/TypeScript/pull/2475#discussion_r27003432
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/2475
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Mar 24, 2015https://github.com/microsoft/TypeScript/pull/2475#discussion_r27003441
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/2475
Cyrus Najmabadi (CyrusNajmabadi)https://github.com/CyrusNajmabadi
Mar 24, 2015https://github.com/microsoft/TypeScript/pull/2475#discussion_r27004127
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/2475
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Mar 24, 2015 https://github.com/microsoft/TypeScript/pull/2475#ref-issue-60430810
Completion item info often reports types as 'any' when quickinfo on the completed item reports otherwise #2278 https://github.com/microsoft/TypeScript/issues/2278
https://github.com/CyrusNajmabadi
CR feedback.https://github.com/microsoft/TypeScript/pull/2475/commits/2af1b92239b06afe2d84400050076d94ef1c5e5a
2af1b92https://github.com/microsoft/TypeScript/pull/2475/commits/2af1b92239b06afe2d84400050076d94ef1c5e5a
DanielRosenwasserhttps://github.com/DanielRosenwasser
Mar 24, 2015 https://github.com/microsoft/TypeScript/pull/2475#discussion-diff-27006460
View reviewed changes https://github.com/microsoft/TypeScript/pull/2475/files/2af1b92239b06afe2d84400050076d94ef1c5e5a#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/2475/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Mar 24, 2015https://github.com/microsoft/TypeScript/pull/2475#discussion_r27006460
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/2475
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Mar 24, 2015https://github.com/microsoft/TypeScript/pull/2475#discussion_r27006468
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/2475
Cyrus Najmabadi (CyrusNajmabadi)https://github.com/CyrusNajmabadi
Mar 24, 2015https://github.com/microsoft/TypeScript/pull/2475#discussion_r27006493
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/2475
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Mar 24, 2015https://github.com/microsoft/TypeScript/pull/2475#discussion_r27069438
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/2475
Cyrus Najmabadi (CyrusNajmabadi)https://github.com/CyrusNajmabadi
Mar 24, 2015https://github.com/microsoft/TypeScript/pull/2475#discussion_r27071985
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/2475
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Mar 24, 2015https://github.com/microsoft/TypeScript/pull/2475#discussion_r27074467
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/2475
Cyrus Najmabadi (CyrusNajmabadi)https://github.com/CyrusNajmabadi
Mar 24, 2015https://github.com/microsoft/TypeScript/pull/2475#discussion_r27075400
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/2475
https://github.com/CyrusNajmabadi
Use an output format for quickinfo that more closely matches the orig…https://github.com/microsoft/TypeScript/pull/2475/commits/eed6f0decabf72547c240583c439fbb3448ffca4
eed6f0dhttps://github.com/microsoft/TypeScript/pull/2475/commits/eed6f0decabf72547c240583c439fbb3448ffca4
DanielRosenwasserhttps://github.com/DanielRosenwasser
Mar 24, 2015 https://github.com/microsoft/TypeScript/pull/2475#discussion-diff-27006886
View reviewed changes https://github.com/microsoft/TypeScript/pull/2475/files/2af1b92239b06afe2d84400050076d94ef1c5e5a#diff-2dc319893c8723737436e91a4ec39b69623ee0bbeebf0b260778015d79d97632
src/services/services.tshttps://github.com/microsoft/TypeScript/pull/2475/files#diff-2dc319893c8723737436e91a4ec39b69623ee0bbeebf0b260778015d79d97632
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Mar 24, 2015https://github.com/microsoft/TypeScript/pull/2475#discussion_r27006886
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/2475
https://github.com/CyrusNajmabadi
CR feedback.https://github.com/microsoft/TypeScript/pull/2475/commits/c459bb7ce9eb88bb1918adf862330418ddb36e57
c459bb7https://github.com/microsoft/TypeScript/pull/2475/commits/c459bb7ce9eb88bb1918adf862330418ddb36e57
DanielRosenwasserhttps://github.com/DanielRosenwasser
Mar 24, 2015 https://github.com/microsoft/TypeScript/pull/2475#discussion-diff-27007308
View reviewed changes https://github.com/microsoft/TypeScript/pull/2475/files/2af1b92239b06afe2d84400050076d94ef1c5e5a#diff-2dc319893c8723737436e91a4ec39b69623ee0bbeebf0b260778015d79d97632
src/services/services.tshttps://github.com/microsoft/TypeScript/pull/2475/files#diff-2dc319893c8723737436e91a4ec39b69623ee0bbeebf0b260778015d79d97632
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Mar 24, 2015https://github.com/microsoft/TypeScript/pull/2475#discussion_r27007308
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/2475
Cyrus Najmabadi (CyrusNajmabadi)https://github.com/CyrusNajmabadi
Mar 24, 2015https://github.com/microsoft/TypeScript/pull/2475#discussion_r27007585
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#2475https://github.com/microsoft/TypeScript/pull/2475
/pull/2475https://github.com/microsoft/TypeScript/pull/2475
/pull/2475https://github.com/microsoft/TypeScript/pull/2475
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/2475
https://github.com/CyrusNajmabadi
CR feedback.https://github.com/microsoft/TypeScript/pull/2475/commits/4802b4b2d60df72426a42371c0fb4ee019114434
4802b4bhttps://github.com/microsoft/TypeScript/pull/2475/commits/4802b4b2d60df72426a42371c0fb4ee019114434
DanielRosenwasserhttps://github.com/DanielRosenwasser
Mar 24, 2015 https://github.com/microsoft/TypeScript/pull/2475#discussion-diff-27008503
View reviewed changes https://github.com/microsoft/TypeScript/pull/2475/files/4802b4b2d60df72426a42371c0fb4ee019114434#diff-2dc319893c8723737436e91a4ec39b69623ee0bbeebf0b260778015d79d97632
src/services/services.tshttps://github.com/microsoft/TypeScript/pull/2475/files#diff-2dc319893c8723737436e91a4ec39b69623ee0bbeebf0b260778015d79d97632
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Mar 24, 2015https://github.com/microsoft/TypeScript/pull/2475#discussion_r27008503
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/2475
https://github.com/CyrusNajmabadi
PR feedback.https://github.com/microsoft/TypeScript/pull/2475/commits/a5bd9196f26b89de27aff450130efa6cba70f39b
a5bd919https://github.com/microsoft/TypeScript/pull/2475/commits/a5bd9196f26b89de27aff450130efa6cba70f39b
DanielRosenwasserhttps://github.com/DanielRosenwasser
Mar 24, 2015 https://github.com/microsoft/TypeScript/pull/2475#discussion-diff-27009107
View reviewed changes https://github.com/microsoft/TypeScript/pull/2475/files/4802b4b2d60df72426a42371c0fb4ee019114434#diff-2dc319893c8723737436e91a4ec39b69623ee0bbeebf0b260778015d79d97632
src/services/services.tshttps://github.com/microsoft/TypeScript/pull/2475/files#diff-2dc319893c8723737436e91a4ec39b69623ee0bbeebf0b260778015d79d97632
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Mar 24, 2015https://github.com/microsoft/TypeScript/pull/2475#discussion_r27009107
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/2475
https://github.com/CyrusNajmabadi
Cyrus Najmabadi (CyrusNajmabadi)https://github.com/CyrusNajmabadi
Mar 24, 2015https://github.com/microsoft/TypeScript/pull/2475#event-263310957
https://github.com/CyrusNajmabadi
PR feedback.https://github.com/microsoft/TypeScript/pull/2475/commits/8d55fe00dd431f765e5edbe084e50d56a53d4a3c
8d55fe0https://github.com/microsoft/TypeScript/pull/2475/commits/8d55fe00dd431f765e5edbe084e50d56a53d4a3c
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Mar 24, 2015https://github.com/microsoft/TypeScript/pull/2475#issuecomment-85682213
Mohamed Hegazy (@mhegazy)https://github.com/mhegazy
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/2475
Cyrus Najmabadi (CyrusNajmabadi)https://github.com/CyrusNajmabadi
March 24, 2015 14:55https://github.com/microsoft/TypeScript/pull/2475#commits-pushed-614b106
https://github.com/CyrusNajmabadi
Merge branch 'master' into completionEntryDetailshttps://github.com/microsoft/TypeScript/pull/2475/commits/614b1066dc55faea53b4bb82d856536982af040e
614b106https://github.com/microsoft/TypeScript/pull/2475/commits/614b1066dc55faea53b4bb82d856536982af040e
https://github.com/CyrusNajmabadi
Don't bother with a predicate. It doesn't provide enough of a perf sa…https://github.com/microsoft/TypeScript/pull/2475/commits/63278ca037d722611d644f460fd764a06e3dd2b3
https://github.com/microsoft/TypeScript/commit/63278ca037d722611d644f460fd764a06e3dd2b3#comments
63278cahttps://github.com/microsoft/TypeScript/pull/2475/commits/63278ca037d722611d644f460fd764a06e3dd2b3
https://github.com/CyrusNajmabadi
PR feedback.https://github.com/microsoft/TypeScript/pull/2475/commits/e26c260822e498aaa49e90d44cff17cc2326ad9a
e26c260https://github.com/microsoft/TypeScript/pull/2475/commits/e26c260822e498aaa49e90d44cff17cc2326ad9a
DanielRosenwasserhttps://github.com/DanielRosenwasser
Mar 24, 2015 https://github.com/microsoft/TypeScript/pull/2475#discussion-diff-27084436
View reviewed changes https://github.com/microsoft/TypeScript/pull/2475/files/e26c260822e498aaa49e90d44cff17cc2326ad9a#diff-2dc319893c8723737436e91a4ec39b69623ee0bbeebf0b260778015d79d97632
src/services/services.tshttps://github.com/microsoft/TypeScript/pull/2475/files#diff-2dc319893c8723737436e91a4ec39b69623ee0bbeebf0b260778015d79d97632
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Mar 24, 2015https://github.com/microsoft/TypeScript/pull/2475#discussion_r27084436
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/2475
https://github.com/CyrusNajmabadi
PR feedback.https://github.com/microsoft/TypeScript/pull/2475/commits/69ff9b3c1348ec330c639de03fca986adf483313
69ff9b3https://github.com/microsoft/TypeScript/pull/2475/commits/69ff9b3c1348ec330c639de03fca986adf483313
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F2475
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/2475
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/2475
https://github.com/CyrusNajmabadi
https://github.com/DanielRosenwasser
https://github.com/jamesmanning
https://github.com/yuit
https://github.com/mhegazy
https://github.com/msftclas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.