René's URL Explorer Experiment


Title: Fix merge lexical environment to *always* respect prologue statements by weswigham · Pull Request #24602 · microsoft/TypeScript · GitHub

Open Graph Title: Fix merge lexical environment to *always* respect prologue statements by weswigham · Pull Request #24602 · microsoft/TypeScript

X Title: Fix merge lexical environment to *always* respect prologue statements by weswigham · Pull Request #24602 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Fix merge lexical environment to *always* respect prologue statements by weswigham · Pull Request #24602 · microsoft/TypeScript

Open Graph Description: Fixes #24582 mergeLexicalEnvironment only called prependStatements when statements wasn't a node array. Specifically in the case of destructuring assignments, it seems like it was an array inst...

X Description: Fixes #24582 mergeLexicalEnvironment only called prependStatements when statements wasn't a node array. Specifically in the case of destructuring assignments, it seems like it was an array ...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/24602

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:68d15419-60c5-257b-6ca1-85a07b5172c8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA282:A99C2:2B7A9AA:374CA97:6B0199A4
html-safe-nonce6b7d58a6d728e7ecbe6c6c7945fdfd9d8f5c34147796e3997e5733f5d2593e5c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMjgyOkE5OUMyOjJCN0E5QUE6Mzc0Q0E5Nzo2QjAxOTlBNCIsInZpc2l0b3JfaWQiOiI0MDQ2NzExNTc4MTMxNzk4NDM2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac309d5e28c0fb630f1bd3f331253a16710b69bfba229cbb5ea83f60dd4d71119f
hovercard-subject-tagpull_request:192154839
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/24602/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1950c93c2ef2285261c4cfc04aa6f589894ee265589701ab62d89df317e689cb/microsoft/TypeScript/pull/24602
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1950c93c2ef2285261c4cfc04aa6f589894ee265589701ab62d89df317e689cb/microsoft/TypeScript/pull/24602
og:image:altFixes #24582 mergeLexicalEnvironment only called prependStatements when statements wasn't a node array. Specifically in the case of destructuring assignments, it seems like it was an array inst...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameweswigham
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/24602#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F24602
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F24602
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/24602
Reloadhttps://github.com/microsoft/TypeScript/pull/24602
Reloadhttps://github.com/microsoft/TypeScript/pull/24602
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
weswigham:more-prolog-location-fixeshttps://github.com/weswigham/TypeScript/tree/more-prolog-location-fixes
Conversationhttps://github.com/microsoft/TypeScript/pull/24602
Commits1 (1)https://github.com/microsoft/TypeScript/pull/24602/commits
Checkshttps://github.com/microsoft/TypeScript/pull/24602/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/24602/files
Fix merge lexical environment to *always* respect prologue statementshttps://github.com/microsoft/TypeScript/pull/24602#top
Wesley Wigham (weswigham)https://github.com/weswigham
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
weswigham:more-prolog-location-fixeshttps://github.com/weswigham/TypeScript/tree/more-prolog-location-fixes
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Jun 1, 2018https://github.com/microsoft/TypeScript/pull/24602#issue-328676463
#24582https://github.com/microsoft/TypeScript/issues/24582
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/24602
https://github.com/weswigham
Fix merge lexical environment to *always* respect prologue statementshttps://github.com/microsoft/TypeScript/pull/24602/commits/b800a5a670a36467f20db9fb79a79bbbf32d7eef
b800a5ahttps://github.com/microsoft/TypeScript/pull/24602/commits/b800a5a670a36467f20db9fb79a79bbbf32d7eef
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
June 1, 2018 22:16https://github.com/microsoft/TypeScript/pull/24602#event-1659285472
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Jun 2, 2018 https://github.com/microsoft/TypeScript/pull/24602#pullrequestreview-125379258
View reviewed changes https://github.com/microsoft/TypeScript/pull/24602/files/b800a5a670a36467f20db9fb79a79bbbf32d7eef
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Jun 2, 2018https://github.com/microsoft/TypeScript/pull/24602#issuecomment-394123754
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/24602
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
779fa98https://github.com/microsoft/TypeScript/commit/779fa9847515d6504b7686132feaca55e67303e3
Jun 4, 2018https://github.com/microsoft/TypeScript/pull/24602#event-1661875857
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
June 4, 2018 17:34https://github.com/microsoft/TypeScript/pull/24602#event-1661875969
Wesley Wigham (weswigham)https://github.com/weswigham
Jun 4, 2018 https://github.com/microsoft/TypeScript/pull/24602#ref-commit-9898b7c
https://github.com/weswigham
Fix merge lexical environment to *always* respect prologue statements (https://github.com/weswigham/TypeScript/commit/9898b7c9e984a5e2ac3f4a8694b6897dacbc4d5c
…https://github.com/microsoft/TypeScript/pull/24602
9898b7chttps://github.com/weswigham/TypeScript/commit/9898b7c9e984a5e2ac3f4a8694b6897dacbc4d5c
…microsoft#24602https://github.com/microsoft/TypeScript/pull/24602
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Jun 4, 2018 https://github.com/microsoft/TypeScript/pull/24602#ref-pullrequest-329150809
Fix merge lexical environment to *always* respect prologue statements (#24602) #24654 https://github.com/microsoft/TypeScript/pull/24654
Wesley Wigham (weswigham)https://github.com/weswigham
Jun 4, 2018 https://github.com/microsoft/TypeScript/pull/24602#ref-commit-be50eea
https://github.com/weswigham
Fix merge lexical environment to *always* respect prologue statements (https://github.com/microsoft/TypeScript/commit/be50eea00c02bae63384fee4850fa7821813dd49
…https://github.com/microsoft/TypeScript/pull/24602
be50eeahttps://github.com/microsoft/TypeScript/commit/be50eea00c02bae63384fee4850fa7821813dd49
…#24602https://github.com/microsoft/TypeScript/pull/24602
#24654https://github.com/microsoft/TypeScript/pull/24654
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Aug 3, 2018https://github.com/microsoft/TypeScript/pull/24602#event-1770872760
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F24602
https://github.com/mhegazy
Mohamed Hegazy (mhegazy) https://github.com/mhegazy
https://github.com/microsoft/TypeScript/pull/24602/files/b800a5a670a36467f20db9fb79a79bbbf32d7eef
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/24602
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/24602
https://github.com/weswigham
https://github.com/mhegazy
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.