René's URL Explorer Experiment


Title: Optimize intersections of unions of unit types by ahejlsberg · Pull Request #24137 · microsoft/TypeScript · GitHub

Open Graph Title: Optimize intersections of unions of unit types by ahejlsberg · Pull Request #24137 · microsoft/TypeScript

X Title: Optimize intersections of unions of unit types by ahejlsberg · Pull Request #24137 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Optimize intersections of unions of unit types by ahejlsberg · Pull Request #24137 · microsoft/TypeScript

Open Graph Description: This PR optimizes creation of intersection types containing unions of unit types. Such types occur for example when obtaining keyof X where X is large union of object types with many properties. Fi...

X Description: This PR optimizes creation of intersection types containing unions of unit types. Such types occur for example when obtaining keyof X where X is large union of object types with many properties. Fi...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/24137

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:660e0a0c-3624-7830-0c1c-fe0705805bf6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCEF8:A99C2:1198FA6:168C8FD:6B0107F3
html-safe-nonce60dc865b62d96c4f91540f2e487366e7d8165b8a677915c64f12440f6ab7de94
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRUY4OkE5OUMyOjExOThGQTY6MTY4QzhGRDo2QjAxMDdGMyIsInZpc2l0b3JfaWQiOiIzNDAyNzY1NjA2NzI5MDkxMDU5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace384291ce0d6e784368599978045aa04db4dca2b3d55a018196b1a7080ddf6b5
hovercard-subject-tagpull_request:188236424
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/24137/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3b33ee29d076989a36ba802031356cde839bade04f79dc2fa9e40aeaf2bf53b7/microsoft/TypeScript/pull/24137
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3b33ee29d076989a36ba802031356cde839bade04f79dc2fa9e40aeaf2bf53b7/microsoft/TypeScript/pull/24137
og:image:altThis PR optimizes creation of intersection types containing unions of unit types. Such types occur for example when obtaining keyof X where X is large union of object types with many properties. Fi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameahejlsberg
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/24137#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F24137
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F24137
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/24137
Reloadhttps://github.com/microsoft/TypeScript/pull/24137
Reloadhttps://github.com/microsoft/TypeScript/pull/24137
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
masterhttps://github.com/microsoft/TypeScript/tree/master
fix23977https://github.com/microsoft/TypeScript/tree/fix23977
Conversationhttps://github.com/microsoft/TypeScript/pull/24137
Commits4 (4)https://github.com/microsoft/TypeScript/pull/24137/commits
Checkshttps://github.com/microsoft/TypeScript/pull/24137/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/24137/files
Optimize intersections of unions of unit typeshttps://github.com/microsoft/TypeScript/pull/24137#top
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
masterhttps://github.com/microsoft/TypeScript/tree/master
fix23977https://github.com/microsoft/TypeScript/tree/fix23977
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
May 15, 2018https://github.com/microsoft/TypeScript/pull/24137#issue-323358467
#23977https://github.com/microsoft/TypeScript/issues/23977
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/24137
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
May 15, 2018 12:24https://github.com/microsoft/TypeScript/pull/24137#commits-pushed-426a63e
https://github.com/ahejlsberg
Optimize intersections of unions of unit typeshttps://github.com/microsoft/TypeScript/pull/24137/commits/426a63e8b6a98b2f6ff7eeddf98f0653582c744f
426a63ehttps://github.com/microsoft/TypeScript/pull/24137/commits/426a63e8b6a98b2f6ff7eeddf98f0653582c744f
https://github.com/ahejlsberg
Add regression testhttps://github.com/microsoft/TypeScript/pull/24137/commits/1c3dbd4f4b135f4153891f56482eeb111c3fa555
1c3dbd4https://github.com/microsoft/TypeScript/pull/24137/commits/1c3dbd4f4b135f4153891f56482eeb111c3fa555
https://github.com/ahejlsberg
Accept new baselineshttps://github.com/microsoft/TypeScript/pull/24137/commits/8b6e85347d4d8c9e84261107981665c6688d1dbf
8b6e853https://github.com/microsoft/TypeScript/pull/24137/commits/8b6e85347d4d8c9e84261107981665c6688d1dbf
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
May 15, 2018 https://github.com/microsoft/TypeScript/pull/24137#ref-pullrequest-321389136
Introduce introspecing fast path for keyof intersection distribution #23986 https://github.com/microsoft/TypeScript/pull/23986
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Wesley Wigham (weswigham)https://github.com/weswigham
May 15, 2018 19:51https://github.com/microsoft/TypeScript/pull/24137#event-1628068738
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
May 15, 2018 https://github.com/microsoft/TypeScript/pull/24137#pullrequestreview-120398413
View reviewed changes https://github.com/microsoft/TypeScript/pull/24137/files/8b6e85347d4d8c9e84261107981665c6688d1dbf
Wesley Wigham (weswigham)https://github.com/weswigham
https://github.com/microsoft/TypeScript/pull/24137#pullrequestreview-120398413
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/24137
src/compiler/types.tshttps://github.com/microsoft/TypeScript/pull/24137/files/8b6e85347d4d8c9e84261107981665c6688d1dbf#diff-e9fd483341eea176a38fbd370590e1dc65ce2d9bf70bfd317c5407f04dba9560
Wesley Wigham (weswigham)https://github.com/weswigham
May 15, 2018https://github.com/microsoft/TypeScript/pull/24137#discussion_r188422732
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/24137
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/24137
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
May 16, 2018https://github.com/microsoft/TypeScript/pull/24137#discussion_r188695127
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/24137
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/24137/files/8b6e85347d4d8c9e84261107981665c6688d1dbf#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Wesley Wigham (weswigham)https://github.com/weswigham
May 15, 2018https://github.com/microsoft/TypeScript/pull/24137#discussion_r188425199
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/24137
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/24137/files/8b6e85347d4d8c9e84261107981665c6688d1dbf#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Wesley Wigham (weswigham)https://github.com/weswigham
May 15, 2018https://github.com/microsoft/TypeScript/pull/24137#discussion_r188430477
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/24137
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
May 16, 2018https://github.com/microsoft/TypeScript/pull/24137#discussion_r188695559
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/24137
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
May 15, 2018https://github.com/microsoft/TypeScript/pull/24137#issuecomment-389316770
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/24137
does have this problemhttps://user-images.githubusercontent.com/2932786/40084178-257dc0aa-584b-11e8-8a0b-d49baecdb96f.png
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/24137
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
May 16, 2018https://github.com/microsoft/TypeScript/pull/24137#issuecomment-389591583
Wesley Wigham (@weswigham)https://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/24137
https://github.com/ahejlsberg
Properly handle edge caseshttps://github.com/microsoft/TypeScript/pull/24137/commits/027829fbcd0a84172ab4a36d60a0ac915ca7ea09
027829fhttps://github.com/microsoft/TypeScript/pull/24137/commits/027829fbcd0a84172ab4a36d60a0ac915ca7ea09
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
May 17, 2018https://github.com/microsoft/TypeScript/pull/24137#issuecomment-389987940
Mohamed Hegazy (@mhegazy)https://github.com/mhegazy
Wesley Wigham (@weswigham)https://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/24137
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 17, 2018https://github.com/microsoft/TypeScript/pull/24137#issuecomment-389991894
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/24137
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
3fc3df3https://github.com/microsoft/TypeScript/commit/3fc3df3c3a90e318c83c4ef44659def92aa5b42a
May 17, 2018https://github.com/microsoft/TypeScript/pull/24137#event-1632865713
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
May 17, 2018 20:15https://github.com/microsoft/TypeScript/pull/24137#event-1632866041
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
May 17, 2018 https://github.com/microsoft/TypeScript/pull/24137#ref-issue-324186174
indexing with T extends keyof causes OOM if keyof has a number #24223 https://github.com/microsoft/TypeScript/issues/24223
Matt McCutchen (mattmccutchen)https://github.com/mattmccutchen
Jul 17, 2018 https://github.com/microsoft/TypeScript/pull/24137#ref-commit-9e7eedf
https://github.com/mattmccutchen
Smarter algorithm to distribute intersections of unions.https://github.com/mattmccutchen/TypeScript/commit/9e7eedfa018574d2e800584b01a495141bce158b
9e7eedfhttps://github.com/mattmccutchen/TypeScript/commit/9e7eedfa018574d2e800584b01a495141bce158b
microsoft#24137https://github.com/microsoft/TypeScript/pull/24137
3fc3df3https://github.com/mattmccutchen/TypeScript/commit/3fc3df3c3a90e318c83c4ef44659def92aa5b42a
3fc727bhttps://github.com/mattmccutchen/TypeScript/commit/3fc727b2564d1f03e63a671fbffe56368ea9320f
microsoft#24223https://github.com/microsoft/TypeScript/issues/24223
https://github.com/mattmccutchen
Matt McCutchen (mattmccutchen)https://github.com/mattmccutchen
Jul 17, 2018 https://github.com/microsoft/TypeScript/pull/24137#ref-pullrequest-342004816
Smarter algorithm to distribute intersections of unions. #25728 https://github.com/microsoft/TypeScript/pull/25728
Matt McCutchen (mattmccutchen)https://github.com/mattmccutchen
Jul 19, 2018 https://github.com/microsoft/TypeScript/pull/24137#ref-commit-230c842
https://github.com/mattmccutchen
Smarter algorithm to distribute intersections of unions.https://github.com/mattmccutchen/TypeScript/commit/230c8423dce4fa597bc0fb37db92a632e4af8c98
230c842https://github.com/mattmccutchen/TypeScript/commit/230c8423dce4fa597bc0fb37db92a632e4af8c98
microsoft#24137https://github.com/microsoft/TypeScript/pull/24137
3fc3df3https://github.com/mattmccutchen/TypeScript/commit/3fc3df3c3a90e318c83c4ef44659def92aa5b42a
3fc727bhttps://github.com/mattmccutchen/TypeScript/commit/3fc727b2564d1f03e63a671fbffe56368ea9320f
microsoft#24223https://github.com/microsoft/TypeScript/issues/24223
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jul 31, 2018https://github.com/microsoft/TypeScript/pull/24137#event-1763327751
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F24137
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
https://github.com/microsoft/TypeScript/pull/24137/files/8b6e85347d4d8c9e84261107981665c6688d1dbf
https://github.com/mhegazy
Mohamed Hegazy (mhegazy) https://github.com/mhegazy
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/24137
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/24137
https://github.com/ahejlsberg
https://github.com/weswigham
https://github.com/mhegazy
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.