René's URL Explorer Experiment


Title: Don't add a suggestion to convert to an es6 module if no commonjs import/export appears at top-level. · Pull Request #24101 · microsoft/TypeScript · GitHub

Open Graph Title: Don't add a suggestion to convert to an es6 module if no commonjs import/export appears at top-level. · Pull Request #24101 · microsoft/TypeScript

X Title: Don't add a suggestion to convert to an es6 module if no commonjs import/export appears at top-level. · Pull Request #24101 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Don't add a suggestion to convert to an es6 module if no commonjs import/export appears at top-level. · Pull Request #24101 · microsoft/TypeScript

Open Graph Description: This code fix doesn't work for non-top-level imports/exports, so better to not add a suggestion diagnostic in that case.

X Description: This code fix doesn't work for non-top-level imports/exports, so better to not add a suggestion diagnostic in that case.

Opengraph URL: https://github.com/microsoft/TypeScript/pull/24101

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a6e85da6-4323-c1bd-d0a6-7660cbdb9fbf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBDB4:928E2:F5FB66:148F169:6B010DD4
html-safe-nonce337416571f0cfc909f0854af769f56194190168d2dad0e2f4b716807d0158655
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCREI0OjkyOEUyOkY1RkI2NjoxNDhGMTY5OjZCMDEwREQ0IiwidmlzaXRvcl9pZCI6IjI2MTUyNDUxMTA2MTg2ODg5ODAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0ccdd9bb6d31c256e48a007ae5e7766c8bdb7f52244ca2cdc3ceb7cfcb5aae93
hovercard-subject-tagpull_request:187914958
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/24101/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9589e7e292809fe48e8954af58b3784b159d8bf7b3a858752d460771ca5b60c9/microsoft/TypeScript/pull/24101
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9589e7e292809fe48e8954af58b3784b159d8bf7b3a858752d460771ca5b60c9/microsoft/TypeScript/pull/24101
og:image:altThis code fix doesn't work for non-top-level imports/exports, so better to not add a suggestion diagnostic in that case.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/24101#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F24101
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F24101
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/24101
Reloadhttps://github.com/microsoft/TypeScript/pull/24101
Reloadhttps://github.com/microsoft/TypeScript/pull/24101
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests310 (310)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
masterhttps://github.com/microsoft/TypeScript/tree/master
convertToEs6Module_notAtTopLevelhttps://github.com/microsoft/TypeScript/tree/convertToEs6Module_notAtTopLevel
Conversationhttps://github.com/microsoft/TypeScript/pull/24101
Commits1 (1)https://github.com/microsoft/TypeScript/pull/24101/commits
Checkshttps://github.com/microsoft/TypeScript/pull/24101/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/24101/files
Don't add a suggestion to convert to an es6 module if no commonjs import/export appears at top-level.https://github.com/microsoft/TypeScript/pull/24101#top
masterhttps://github.com/microsoft/TypeScript/tree/master
convertToEs6Module_notAtTopLevelhttps://github.com/microsoft/TypeScript/tree/convertToEs6Module_notAtTopLevel
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
May 14, 2018https://github.com/microsoft/TypeScript/pull/24101#issue-322933320
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/24101
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 14, 2018 18:38https://github.com/microsoft/TypeScript/pull/24101#event-1625522925
Don't add a suggestion to convert to an es6 module if no commonjs imp…https://github.com/microsoft/TypeScript/pull/24101/commits/a42afdf4f8cc429edcb622c6c669f87fbc990868
a42afdfhttps://github.com/microsoft/TypeScript/pull/24101/commits/a42afdf4f8cc429edcb622c6c669f87fbc990868
force-pushedhttps://github.com/microsoft/TypeScript/compare/4b1e90bc0b0b60ffb349512b5b159cda4ed77c8e..a42afdf4f8cc429edcb622c6c669f87fbc990868
4b1e90bhttps://github.com/microsoft/TypeScript/commit/4b1e90bc0b0b60ffb349512b5b159cda4ed77c8e
a42afdfhttps://github.com/microsoft/TypeScript/commit/a42afdf4f8cc429edcb622c6c669f87fbc990868
Compare https://github.com/microsoft/TypeScript/compare/4b1e90bc0b0b60ffb349512b5b159cda4ed77c8e..a42afdf4f8cc429edcb622c6c669f87fbc990868
May 14, 2018 18:39https://github.com/microsoft/TypeScript/pull/24101#event-1625524667
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 14, 2018 https://github.com/microsoft/TypeScript/pull/24101#pullrequestreview-119961467
View reviewed changes https://github.com/microsoft/TypeScript/pull/24101/files/a42afdf4f8cc429edcb622c6c669f87fbc990868
7e3af08https://github.com/microsoft/TypeScript/commit/7e3af08a097c024ddbc6c2af1e0ff31d2a8b742c
May 14, 2018https://github.com/microsoft/TypeScript/pull/24101#event-1625568875
May 14, 2018 19:00https://github.com/microsoft/TypeScript/pull/24101#event-1625568935
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 16, 2018 https://github.com/microsoft/TypeScript/pull/24101#ref-commit-18670da
https://github.com/sandersn
Don't add a suggestion to convert to an es6 module if no commonjs imp…https://github.com/microsoft/TypeScript/commit/18670da4a3e41544a066efc71395f56522e1b1fd
18670dahttps://github.com/microsoft/TypeScript/commit/18670da4a3e41544a066efc71395f56522e1b1fd
#24101https://github.com/microsoft/TypeScript/pull/24101
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 21, 2018 https://github.com/microsoft/TypeScript/pull/24101#ref-issue-325014455
"Convert to ES6 module" not working with IIFE pattern #24297 https://github.com/microsoft/TypeScript/issues/24297
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jul 31, 2018https://github.com/microsoft/TypeScript/pull/24101#event-1763327453
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F24101
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/24101
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/24101
https://github.com/mhegazy
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.