René's URL Explorer Experiment


Title: Fix find-all-refs for import("mod").Foo where Foo is a typedef · Pull Request #23881 · microsoft/TypeScript · GitHub

Open Graph Title: Fix find-all-refs for import("mod").Foo where Foo is a typedef · Pull Request #23881 · microsoft/TypeScript

X Title: Fix find-all-refs for import("mod").Foo where Foo is a typedef · Pull Request #23881 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Fix find-all-refs for import("mod").Foo where Foo is a typedef · Pull Request #23881 · microsoft/TypeScript

Open Graph Description: Fixes #23863 Needed to fix a few bugs: Previously the import tracker was just ignoring ImportType nodes -- added a Debug.assertNever to prevent this from happening in the future. We need to consi...

X Description: Fixes #23863 Needed to fix a few bugs: Previously the import tracker was just ignoring ImportType nodes -- added a Debug.assertNever to prevent this from happening in the future. We need to consi...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/23881

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6f972ccd-e728-38cc-6b6a-adb1f46e0162
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idED12:34CAB:2BA3FEE:37CC587:6B01BB64
html-safe-nonce422fded597c6e675f65b42fe507e7327b1e3024b72b5d79d7f749a61956881a2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDEyOjM0Q0FCOjJCQTNGRUU6MzdDQzU4Nzo2QjAxQkI2NCIsInZpc2l0b3JfaWQiOiI2NjA5MjExNjgzOTQ2NzQwNTgwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf2f14ddda77ccad537dc8a5ed827c7dbb0cce8e9faf72c8bff38f23784fb2087
hovercard-subject-tagpull_request:185858641
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/23881/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e395cb8beb40d197c10e2835ded8dbc56bb4ff9e4cc31dd366815505de07ee21/microsoft/TypeScript/pull/23881
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e395cb8beb40d197c10e2835ded8dbc56bb4ff9e4cc31dd366815505de07ee21/microsoft/TypeScript/pull/23881
og:image:altFixes #23863 Needed to fix a few bugs: Previously the import tracker was just ignoring ImportType nodes -- added a Debug.assertNever to prevent this from happening in the future. We need to consi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/23881#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F23881
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F23881
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/23881
Reloadhttps://github.com/microsoft/TypeScript/pull/23881
Reloadhttps://github.com/microsoft/TypeScript/pull/23881
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
masterhttps://github.com/microsoft/TypeScript/tree/master
findAllRefsTypedef_importTypehttps://github.com/microsoft/TypeScript/tree/findAllRefsTypedef_importType
Conversationhttps://github.com/microsoft/TypeScript/pull/23881
Commits3 (3)https://github.com/microsoft/TypeScript/pull/23881/commits
Checkshttps://github.com/microsoft/TypeScript/pull/23881/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/23881/files
Fix find-all-refs for import("mod").Foo where Foo is a typedefhttps://github.com/microsoft/TypeScript/pull/23881#top
masterhttps://github.com/microsoft/TypeScript/tree/master
findAllRefsTypedef_importTypehttps://github.com/microsoft/TypeScript/tree/findAllRefsTypedef_importType
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
May 3, 2018https://github.com/microsoft/TypeScript/pull/23881#issue-320106961
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23881
#23863https://github.com/microsoft/TypeScript/issues/23863
Always export typedefs #23723https://github.com/microsoft/TypeScript/pull/23723
#23879https://github.com/microsoft/TypeScript/issues/23879
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23881
Fix find-all-refs for import("mod").Foo where Foo is a typedefhttps://github.com/microsoft/TypeScript/pull/23881/commits/4a4ddaab97710d14454dc22bf2465565521e70d4
4a4ddaahttps://github.com/microsoft/TypeScript/pull/23881/commits/4a4ddaab97710d14454dc22bf2465565521e70d4
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
Wesley Wigham (weswigham)https://github.com/weswigham
May 3, 2018 22:54https://github.com/microsoft/TypeScript/pull/23881#event-1608836827
May 3, 2018 https://github.com/microsoft/TypeScript/pull/23881#ref-issue-320105070
Find-all-references should detect import types #23879 https://github.com/microsoft/TypeScript/issues/23879
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
May 3, 2018https://github.com/microsoft/TypeScript/pull/23881#issuecomment-386462788
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23881
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
May 3, 2018 https://github.com/microsoft/TypeScript/pull/23881#pullrequestreview-117458886
View reviewed changes https://github.com/microsoft/TypeScript/pull/23881/files/4a4ddaab97710d14454dc22bf2465565521e70d4
src/services/utilities.tshttps://github.com/microsoft/TypeScript/pull/23881/files/4a4ddaab97710d14454dc22bf2465565521e70d4#diff-e7a6c6ac3d7aec62fd1afbb66b41e8d35663c7c9555b0668d1e14f0221f51459
Wesley Wigham (weswigham)https://github.com/weswigham
May 3, 2018https://github.com/microsoft/TypeScript/pull/23881#discussion_r185959958
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23881
Deleted user (ghost)https://github.com/ghost
May 4, 2018https://github.com/microsoft/TypeScript/pull/23881#discussion_r186114689
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23881
Wesley Wigham (weswigham)https://github.com/weswigham
May 4, 2018https://github.com/microsoft/TypeScript/pull/23881#discussion_r186139249
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23881
Deleted user (ghost)https://github.com/ghost
May 4, 2018https://github.com/microsoft/TypeScript/pull/23881#discussion_r186140339
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23881
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
May 4, 2018https://github.com/microsoft/TypeScript/pull/23881#discussion_r186149933
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23881
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
May 3, 2018 https://github.com/microsoft/TypeScript/pull/23881#pullrequestreview-117459235
View reviewed changes https://github.com/microsoft/TypeScript/pull/23881/files/4a4ddaab97710d14454dc22bf2465565521e70d4
src/services/importTracker.tshttps://github.com/microsoft/TypeScript/pull/23881/files/4a4ddaab97710d14454dc22bf2465565521e70d4#diff-f387d60b82998b595e258aecc53af7dce8e2e31c3df9d1a5d51e89e28782b24c
Wesley Wigham (weswigham)https://github.com/weswigham
May 3, 2018https://github.com/microsoft/TypeScript/pull/23881#discussion_r185960242
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23881
May 4, 2018 08:15https://github.com/microsoft/TypeScript/pull/23881#commits-pushed-e9cbf29
Add Debug.assertNever messagehttps://github.com/microsoft/TypeScript/pull/23881/commits/e9cbf2990368ff37ad8bc068797e67057f153cb1
e9cbf29https://github.com/microsoft/TypeScript/pull/23881/commits/e9cbf2990368ff37ad8bc068797e67057f153cb1
Ensure SemanticMeaning is matchedhttps://github.com/microsoft/TypeScript/pull/23881/commits/b16bf32b9f500a81ca4861ec99ae7a4eddd545c4
b16bf32https://github.com/microsoft/TypeScript/pull/23881/commits/b16bf32b9f500a81ca4861ec99ae7a4eddd545c4
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
May 4, 2018 https://github.com/microsoft/TypeScript/pull/23881#pullrequestreview-117724388
View reviewed changes https://github.com/microsoft/TypeScript/pull/23881/files/b16bf32b9f500a81ca4861ec99ae7a4eddd545c4
https://github.com/sheetalkamat
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
May 4, 2018 https://github.com/microsoft/TypeScript/pull/23881#pullrequestreview-117732781
View reviewed changes https://github.com/microsoft/TypeScript/pull/23881/files/b16bf32b9f500a81ca4861ec99ae7a4eddd545c4
df9e262https://github.com/microsoft/TypeScript/commit/df9e2621d277a3eec4e824e7065d9440d66be3b4
May 4, 2018https://github.com/microsoft/TypeScript/pull/23881#event-1610759355
May 4, 2018 20:32https://github.com/microsoft/TypeScript/pull/23881#event-1610759652
Replace verify.rangesReferenceEachOther with verify.singleReferenceGroup #23933 https://github.com/microsoft/TypeScript/pull/23933
Improvements to find-all-references for import types #23998 https://github.com/microsoft/TypeScript/pull/23998
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jul 31, 2018https://github.com/microsoft/TypeScript/pull/23881#event-1763325528
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F23881
https://github.com/sandersn
Nathan Shively-Sanders (sandersn) https://github.com/sandersn
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23881
In JS, typedef rename and find-all-refs doesn't work across files https://github.com/microsoft/TypeScript/issues/23863
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23881
https://github.com/weswigham
https://github.com/sheetalkamat
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.