René's URL Explorer Experiment


Title: Always export typedefs by sandersn · Pull Request #23723 · microsoft/TypeScript · GitHub

Open Graph Title: Always export typedefs by sandersn · Pull Request #23723 · microsoft/TypeScript

X Title: Always export typedefs by sandersn · Pull Request #23723 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Always export typedefs by sandersn · Pull Request #23723 · microsoft/TypeScript

Open Graph Description: This actually just required deleting a check in declareModuleMembers and checking for external AND commonjs modules in a couple of places. However, while experimenting with this feature, I discover...

X Description: This actually just required deleting a check in declareModuleMembers and checking for external AND commonjs modules in a couple of places. However, while experimenting with this feature, I discover...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/23723

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:16513251-b68d-dd6c-62a1-e9279ea653ca
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA734:3A4875:28099E5:3563508:6B01B1C3
html-safe-noncee4139a5863e28a099e1856d15001b94f8d3df3f5e17b35c449997a4e8bbf60b7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNzM0OjNBNDg3NToyODA5OUU1OjM1NjM1MDg6NkIwMUIxQzMiLCJ2aXNpdG9yX2lkIjoiNDcyMzg5NDI2Mjk2NzEzNjMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac03f0740d75d72c032a6d534b174c7aae7fbb18f9386f665253ea218aba8748e4
hovercard-subject-tagpull_request:184463694
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/23723/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/32580e196f1c27d9d7e923723252e5cd584a7efe3e55891d27c66e52d91d98a1/microsoft/TypeScript/pull/23723
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/32580e196f1c27d9d7e923723252e5cd584a7efe3e55891d27c66e52d91d98a1/microsoft/TypeScript/pull/23723
og:image:altThis actually just required deleting a check in declareModuleMembers and checking for external AND commonjs modules in a couple of places. However, while experimenting with this feature, I discover...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesandersn
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/23723#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F23723
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F23723
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/23723
Reloadhttps://github.com/microsoft/TypeScript/pull/23723
Reloadhttps://github.com/microsoft/TypeScript/pull/23723
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
js/always-export-typedefshttps://github.com/microsoft/TypeScript/tree/js/always-export-typedefs
Conversationhttps://github.com/microsoft/TypeScript/pull/23723
Commits7 (7)https://github.com/microsoft/TypeScript/pull/23723/commits
Checkshttps://github.com/microsoft/TypeScript/pull/23723/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/23723/files
Always export typedefshttps://github.com/microsoft/TypeScript/pull/23723#top
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
js/always-export-typedefshttps://github.com/microsoft/TypeScript/tree/js/always-export-typedefs
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Apr 26, 2018https://github.com/microsoft/TypeScript/pull/23723#issue-318196138
#23692https://github.com/microsoft/TypeScript/issues/23692
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23723
https://github.com/sandersn
Always export typedefshttps://github.com/microsoft/TypeScript/pull/23723/commits/43d7b9a2fad31fa4d038cc02c3f4d1d75e38c4f6
43d7b9ahttps://github.com/microsoft/TypeScript/pull/23723/commits/43d7b9a2fad31fa4d038cc02c3f4d1d75e38c4f6
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Wesley Wigham (weswigham)https://github.com/weswigham
April 26, 2018 21:04https://github.com/microsoft/TypeScript/pull/23723#event-1597519334
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Apr 26, 2018 https://github.com/microsoft/TypeScript/pull/23723#pullrequestreview-115784715
View reviewed changes https://github.com/microsoft/TypeScript/pull/23723/files/43d7b9a2fad31fa4d038cc02c3f4d1d75e38c4f6
src/compiler/parser.tshttps://github.com/microsoft/TypeScript/pull/23723/files/43d7b9a2fad31fa4d038cc02c3f4d1d75e38c4f6#diff-12a6724be007eb1a19d80018c7a63bbc73525ca793a9b3e5da49a4e86bbf457c
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Apr 26, 2018https://github.com/microsoft/TypeScript/pull/23723#discussion_r184561342
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23723
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Apr 27, 2018https://github.com/microsoft/TypeScript/pull/23723#discussion_r184728711
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23723
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
April 27, 2018 08:44https://github.com/microsoft/TypeScript/pull/23723#commits-pushed-ccc7d6f
https://github.com/sandersn
Merge branch 'master' into js/always-export-typedefshttps://github.com/microsoft/TypeScript/pull/23723/commits/ccc7d6ffd8fd3c37dceeacb05a878c3e1cee9938
ccc7d6fhttps://github.com/microsoft/TypeScript/pull/23723/commits/ccc7d6ffd8fd3c37dceeacb05a878c3e1cee9938
https://github.com/sandersn
Post-bind typedef instead of pre-checking for commonjshttps://github.com/microsoft/TypeScript/pull/23723/commits/539afc0bf023d4a338cff99ed3f6b8065f3a5b03
539afc0https://github.com/microsoft/TypeScript/pull/23723/commits/539afc0bf023d4a338cff99ed3f6b8065f3a5b03
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Apr 27, 2018https://github.com/microsoft/TypeScript/pull/23723#issuecomment-385035037
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23723
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Apr 27, 2018 https://github.com/microsoft/TypeScript/pull/23723#pullrequestreview-116018740
View reviewed changes https://github.com/microsoft/TypeScript/pull/23723/files/539afc0bf023d4a338cff99ed3f6b8065f3a5b03
Wesley Wigham (weswigham)https://github.com/weswigham
https://github.com/microsoft/TypeScript/pull/23723#pullrequestreview-116018740
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23723
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Apr 27, 2018https://github.com/microsoft/TypeScript/pull/23723#issuecomment-385091095
Wesley Wigham (@weswigham)https://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23723
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Apr 27, 2018https://github.com/microsoft/TypeScript/pull/23723#issuecomment-385114253
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23723
Wesley Wigham (@weswigham)https://github.com/weswigham
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23723
https://github.com/sandersn
Duplicate identifier errorshttps://github.com/microsoft/TypeScript/pull/23723/commits/777b5a089b88d1c2501d55a1393ed2a62d72fd1a
777b5a0https://github.com/microsoft/TypeScript/pull/23723/commits/777b5a089b88d1c2501d55a1393ed2a62d72fd1a
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Apr 27, 2018https://github.com/microsoft/TypeScript/pull/23723#issuecomment-385116000
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23723
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Apr 27, 2018https://github.com/microsoft/TypeScript/pull/23723#issuecomment-385116107
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23723
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Apr 27, 2018https://github.com/microsoft/TypeScript/pull/23723#issuecomment-385116243
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23723
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23723
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Apr 28, 2018https://github.com/microsoft/TypeScript/pull/23723#issuecomment-385127830
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23723
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Apr 30, 2018 https://github.com/microsoft/TypeScript/pull/23723#pullrequestreview-116403663
View reviewed changes https://github.com/microsoft/TypeScript/pull/23723/files/777b5a089b88d1c2501d55a1393ed2a62d72fd1a
https://github.com/sandersn
Fix class type reference resolution+update baselineshttps://github.com/microsoft/TypeScript/pull/23723/commits/0f797a1e4e4680c8980ebdcd4a7be3916706dce4
0f797a1https://github.com/microsoft/TypeScript/pull/23723/commits/0f797a1e4e4680c8980ebdcd4a7be3916706dce4
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Apr 30, 2018 https://github.com/microsoft/TypeScript/pull/23723#pullrequestreview-116411766
View reviewed changes https://github.com/microsoft/TypeScript/pull/23723/files/0f797a1e4e4680c8980ebdcd4a7be3916706dce4
src/compiler/binder.tshttps://github.com/microsoft/TypeScript/pull/23723/files/0f797a1e4e4680c8980ebdcd4a7be3916706dce4#diff-9ad14a2e2e66533cd0c3f02ecf01f7e6bc9d60cdf2e125df2a14ce0713222898
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Apr 30, 2018https://github.com/microsoft/TypeScript/pull/23723#discussion_r185089304
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23723
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Apr 30, 2018https://github.com/microsoft/TypeScript/pull/23723#discussion_r185092083
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23723
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Apr 30, 2018https://github.com/microsoft/TypeScript/pull/23723#discussion_r185092838
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23723
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
April 30, 2018 13:09https://github.com/microsoft/TypeScript/pull/23723#commits-pushed-f733b21
https://github.com/sandersn
Move to a type-based check for duplicate identifiershttps://github.com/microsoft/TypeScript/pull/23723/commits/f733b21a460e7c29042f6f266d046fe76dba59ae
f733b21https://github.com/microsoft/TypeScript/pull/23723/commits/f733b21a460e7c29042f6f266d046fe76dba59ae
https://github.com/sandersn
Merge branch 'master' into js/always-export-typedefshttps://github.com/microsoft/TypeScript/pull/23723/commits/6e29c5c6d07a5e70088a6c79911a3314823f0802
6e29c5chttps://github.com/microsoft/TypeScript/pull/23723/commits/6e29c5c6d07a5e70088a6c79911a3314823f0802
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
7cda045https://github.com/microsoft/TypeScript/commit/7cda045d527e49db6238fadc6275b07682c55985
Apr 30, 2018https://github.com/microsoft/TypeScript/pull/23723#event-1602509537
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
April 30, 2018 21:55https://github.com/microsoft/TypeScript/pull/23723#event-1602509635
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
May 1, 2018 https://github.com/microsoft/TypeScript/pull/23723#ref-issue-317690885
Create and add a guideline for typings webpack/webpack#7122 https://github.com/webpack/webpack/issues/7122
May 3, 2018 https://github.com/microsoft/TypeScript/pull/23723#ref-pullrequest-320106961
Fix find-all-refs for import("mod").Foo where Foo is a typedef #23881 https://github.com/microsoft/TypeScript/pull/23881
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jul 31, 2018https://github.com/microsoft/TypeScript/pull/23723#event-1763324079
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F23723
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
https://github.com/microsoft/TypeScript/pull/23723/files/539afc0bf023d4a338cff99ed3f6b8065f3a5b03
https://github.com/mhegazy
Mohamed Hegazy (mhegazy) https://github.com/mhegazy
https://github.com/microsoft/TypeScript/pull/23723/files/0f797a1e4e4680c8980ebdcd4a7be3916706dce4
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23723
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23723
https://github.com/sandersn
https://github.com/weswigham
https://github.com/mhegazy
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.