René's URL Explorer Experiment


Title: Allow exports assignments by sandersn · Pull Request #23319 · microsoft/TypeScript · GitHub

Open Graph Title: Allow exports assignments by sandersn · Pull Request #23319 · microsoft/TypeScript

X Title: Allow exports assignments by sandersn · Pull Request #23319 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Allow exports assignments by sandersn · Pull Request #23319 · microsoft/TypeScript

Open Graph Description: This PR just removes some bogus errors in the checker. The binding itself has already been fixed. Allow assignment to exports. The type of the rhs is not checked against the type of exports since ...

X Description: This PR just removes some bogus errors in the checker. The binding itself has already been fixed. Allow assignment to exports. The type of the rhs is not checked against the type of exports since ...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/23319

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:269bd62a-fc70-8f3b-d914-be93dc0153ba
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA272:1F2D:1E08C6D:2606845:6B0199A2
html-safe-nonce5d3307ceda25721545d0284a435aaf2e6d7d0e897f5641b2019c65a77988f6c4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMjcyOjFGMkQ6MUUwOEM2RDoyNjA2ODQ1OjZCMDE5OUEyIiwidmlzaXRvcl9pZCI6IjQ1MjgzMzUxMjc1MDc0NzQ4NTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8240823116db519bf84b8cdeb164c51b1b716971b6935e6714ff3a5113a413d3
hovercard-subject-tagpull_request:180733187
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/23319/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a724670f638221fd8de95239a2c5029cd65dd6b72346a6a0131724fc5bb87838/microsoft/TypeScript/pull/23319
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a724670f638221fd8de95239a2c5029cd65dd6b72346a6a0131724fc5bb87838/microsoft/TypeScript/pull/23319
og:image:altThis PR just removes some bogus errors in the checker. The binding itself has already been fixed. Allow assignment to exports. The type of the rhs is not checked against the type of exports since ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesandersn
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/23319#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F23319
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F23319
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/23319
Reloadhttps://github.com/microsoft/TypeScript/pull/23319
Reloadhttps://github.com/microsoft/TypeScript/pull/23319
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
js/allow-exports-property-assignmentshttps://github.com/microsoft/TypeScript/tree/js/allow-exports-property-assignments
Conversationhttps://github.com/microsoft/TypeScript/pull/23319
Commits1 (1)https://github.com/microsoft/TypeScript/pull/23319/commits
Checkshttps://github.com/microsoft/TypeScript/pull/23319/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/23319/files
Allow exports assignmentshttps://github.com/microsoft/TypeScript/pull/23319#top
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
js/allow-exports-property-assignmentshttps://github.com/microsoft/TypeScript/tree/js/allow-exports-property-assignments
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Apr 10, 2018https://github.com/microsoft/TypeScript/pull/23319#issue-313096487
#22459https://github.com/microsoft/TypeScript/issues/22459
#22436https://github.com/microsoft/TypeScript/issues/22436
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23319
https://github.com/sandersn
Allow exports assignmentshttps://github.com/microsoft/TypeScript/pull/23319/commits/05dc981ebfc7c86ff6c409d51639b2156bbc5f45
05dc981https://github.com/microsoft/TypeScript/pull/23319/commits/05dc981ebfc7c86ff6c409d51639b2156bbc5f45
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Wesley Wigham (weswigham)https://github.com/weswigham
April 10, 2018 21:30https://github.com/microsoft/TypeScript/pull/23319#event-1567228426
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Apr 11, 2018 https://github.com/microsoft/TypeScript/pull/23319#pullrequestreview-111061391
View reviewed changes https://github.com/microsoft/TypeScript/pull/23319/files/05dc981ebfc7c86ff6c409d51639b2156bbc5f45
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
9ceb113https://github.com/microsoft/TypeScript/commit/9ceb113ec50908803bacba430b7e0a0f063aa09a
Apr 11, 2018https://github.com/microsoft/TypeScript/pull/23319#event-1568622676
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
April 11, 2018 13:50https://github.com/microsoft/TypeScript/pull/23319#event-1568622803
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Apr 11, 2018 https://github.com/microsoft/TypeScript/pull/23319#ref-issue-226923086
checkJs too strict about module.exports assignment #15647 https://github.com/microsoft/TypeScript/issues/15647
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Apr 11, 2018 https://github.com/microsoft/TypeScript/pull/23319#ref-pullrequest-313116108
Improve user test tsconfig #23325 https://github.com/microsoft/TypeScript/pull/23325
Tobias Koppers (sokra)https://github.com/sokra
Apr 12, 2018 https://github.com/microsoft/TypeScript/pull/23319#ref-commit-9dafa97
https://github.com/sokra
TS now understands exports assignmentshttps://github.com/webpack/webpack/commit/9dafa97e5e63e7fdf22992ab160d6a84a2476cc6
9dafa97https://github.com/webpack/webpack/commit/9dafa97e5e63e7fdf22992ab160d6a84a2476cc6
microsoft/TypeScript#23319https://github.com/microsoft/TypeScript/pull/23319
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jul 25, 2018https://github.com/microsoft/TypeScript/pull/23319#event-1753831001
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F23319
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
https://github.com/microsoft/TypeScript/pull/23319/files/05dc981ebfc7c86ff6c409d51639b2156bbc5f45
https://github.com/mhegazy
Mohamed Hegazy (mhegazy) https://github.com/mhegazy
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23319
Javascript should support property assignments on exports, even when aliased https://github.com/microsoft/TypeScript/issues/22436
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/23319
https://github.com/sandersn
https://github.com/weswigham
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.