| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:269bd62a-fc70-8f3b-d914-be93dc0153ba |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A272:1F2D:1E08C6D:2606845:6B0199A2 |
| html-safe-nonce | 5d3307ceda25721545d0284a435aaf2e6d7d0e897f5641b2019c65a77988f6c4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMjcyOjFGMkQ6MUUwOEM2RDoyNjA2ODQ1OjZCMDE5OUEyIiwidmlzaXRvcl9pZCI6IjQ1MjgzMzUxMjc1MDc0NzQ4NTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 8240823116db519bf84b8cdeb164c51b1b716971b6935e6714ff3a5113a413d3 |
| hovercard-subject-tag | pull_request:180733187 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/23319/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a724670f638221fd8de95239a2c5029cd65dd6b72346a6a0131724fc5bb87838/microsoft/TypeScript/pull/23319 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a724670f638221fd8de95239a2c5029cd65dd6b72346a6a0131724fc5bb87838/microsoft/TypeScript/pull/23319 |
| og:image:alt | This PR just removes some bogus errors in the checker. The binding itself has already been fixed.
Allow assignment to exports.
The type of the rhs is not checked against the type of exports since ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sandersn |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/23319#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F23319 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F23319 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/23319 |
| Reload | https://github.com/microsoft/TypeScript/pull/23319 |
| Reload | https://github.com/microsoft/TypeScript/pull/23319 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests312 (312) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| master | https://github.com/microsoft/TypeScript/tree/master |
| js/allow-exports-property-assignments | https://github.com/microsoft/TypeScript/tree/js/allow-exports-property-assignments |
| Conversation | https://github.com/microsoft/TypeScript/pull/23319 |
| Commits1 (1) | https://github.com/microsoft/TypeScript/pull/23319/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/23319/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/23319/files |
| Allow exports assignments | https://github.com/microsoft/TypeScript/pull/23319#top |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| master | https://github.com/microsoft/TypeScript/tree/master |
| js/allow-exports-property-assignments | https://github.com/microsoft/TypeScript/tree/js/allow-exports-property-assignments |
|
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Apr 10, 2018 | https://github.com/microsoft/TypeScript/pull/23319#issue-313096487 |
| #22459 | https://github.com/microsoft/TypeScript/issues/22459 |
| #22436 | https://github.com/microsoft/TypeScript/issues/22436 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/23319 |
|
| https://github.com/sandersn |
| Allow exports assignments | https://github.com/microsoft/TypeScript/pull/23319/commits/05dc981ebfc7c86ff6c409d51639b2156bbc5f45 |
| 05dc981 | https://github.com/microsoft/TypeScript/pull/23319/commits/05dc981ebfc7c86ff6c409d51639b2156bbc5f45 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| Mohamed Hegazy (mhegazy) | https://github.com/mhegazy |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
| April 10, 2018 21:30 | https://github.com/microsoft/TypeScript/pull/23319#event-1567228426 |
| https://github.com/weswigham |
| Wesley Wigham (weswigham) | https://github.com/weswigham |
|
Apr 11, 2018
| https://github.com/microsoft/TypeScript/pull/23319#pullrequestreview-111061391 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/23319/files/05dc981ebfc7c86ff6c409d51639b2156bbc5f45 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| 9ceb113 | https://github.com/microsoft/TypeScript/commit/9ceb113ec50908803bacba430b7e0a0f063aa09a |
| Apr 11, 2018 | https://github.com/microsoft/TypeScript/pull/23319#event-1568622676 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
| April 11, 2018 13:50 | https://github.com/microsoft/TypeScript/pull/23319#event-1568622803 |
| https://github.com/mhegazy |
| Mohamed Hegazy (mhegazy) | https://github.com/mhegazy |
|
Apr 11, 2018
| https://github.com/microsoft/TypeScript/pull/23319#ref-issue-226923086 |
|
checkJs too strict about module.exports assignment
#15647
| https://github.com/microsoft/TypeScript/issues/15647 |
| https://github.com/sandersn |
| Nathan Shively-Sanders (sandersn) | https://github.com/sandersn |
|
Apr 11, 2018
| https://github.com/microsoft/TypeScript/pull/23319#ref-pullrequest-313116108 |
|
Improve user test tsconfig
#23325
| https://github.com/microsoft/TypeScript/pull/23325 |
| Tobias Koppers (sokra) | https://github.com/sokra |
|
Apr 12, 2018
| https://github.com/microsoft/TypeScript/pull/23319#ref-commit-9dafa97 |
|
| https://github.com/sokra |
| TS now understands exports assignments | https://github.com/webpack/webpack/commit/9dafa97e5e63e7fdf22992ab160d6a84a2476cc6 |
| 9dafa97 | https://github.com/webpack/webpack/commit/9dafa97e5e63e7fdf22992ab160d6a84a2476cc6 |
| microsoft/TypeScript#23319 | https://github.com/microsoft/TypeScript/pull/23319 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Jul 25, 2018 | https://github.com/microsoft/TypeScript/pull/23319#event-1753831001 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F23319 |
|
| https://github.com/weswigham |
|
Wesley Wigham (weswigham)
| https://github.com/weswigham |
|
| https://github.com/microsoft/TypeScript/pull/23319/files/05dc981ebfc7c86ff6c409d51639b2156bbc5f45 |
|
| https://github.com/mhegazy |
|
Mohamed Hegazy (mhegazy)
| https://github.com/mhegazy |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/23319 |
|
Javascript should support property assignments on exports, even when aliased
| https://github.com/microsoft/TypeScript/issues/22436 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/23319 |
|
| https://github.com/sandersn |
|
| https://github.com/weswigham |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |